Commit Graph

2739 Commits

Author SHA1 Message Date
TreeHugger Robot
aca883298a Merge "Add supportedAttributes param for spell checker." 2021-01-21 19:45:17 +00:00
Kohsuke Yatoh
036c61877a Merge "Add missing textservice OWNERS files." am: 0f4112a760 am: 49023f3cd8 am: 782d427971
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1554552

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ie00b4339b17b58e4041b506d23c8f7a984839481
2021-01-21 01:20:06 +00:00
Kohsuke Yatoh
0f4112a760 Merge "Add missing textservice OWNERS files." 2021-01-20 23:16:33 +00:00
Kohsuke Yatoh
93d47b0487 Add supportedAttributes param for spell checker.
Bug: 166304720
Test: atest CtsInputMethodTestCases:SpellCheckerTest
Change-Id: I22f4a59a0c8ccb43f799351062f9fabca42403cd
2021-01-20 20:06:12 +00:00
Kohsuke Yatoh
b1d2fe86f7 Add missing textservice OWNERS files.
Test: n/a
Change-Id: I56939ce3a22c72ac489e4d9248de9e0ce4ee9413
2021-01-20 18:53:11 +00:00
Chloris Kuo
dde50e8d10 Add NAS#onNotificationClicked API and TestAPI for cts test
Bug: 177032312
Test: atest NotificationListenerServiceTest
Test: atest NotificationManagerServiceTest
Change-Id: Ia11693c39c184a3c26c099acbc5dc6a3d5e8acd2
2021-01-19 12:20:34 -08:00
Hyunyoung Song
558c605944 Merge "Add OWNERS file to SearchUi related projects" am: 3e4b74520b am: 1f0eb2327a am: 3bbcad312a
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1552394

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I36d598aece29035d9d040eb2f03a9b9cdc723ff6
2021-01-15 22:17:13 +00:00
Hyunyoung Song
12d7faedf0 Add OWNERS file to SearchUi related projects
Test: not needed as this is a meta file change

Change-Id: I4900664d11374f2b82247a73445e0deea0e70cbc
2021-01-15 10:00:29 -08:00
Joanne Chung
d47c351b8d Merge "Initial layout of translation related APIs." 2021-01-12 16:00:23 +00:00
Adam He
2653f23d47 Initial layout of translation related APIs.
The initial translation related APIs. The APIs and the implementation
will be revised in the follow up changes. The service register will
on the next changes.

Bug: 173243538
Bug: 176208267
Test: manual verification (build)

Change-Id: Ib7b39e1b548bc6663a81482fa335632e8da18d6a
2021-01-12 21:08:05 +08:00
TreeHugger Robot
1d30d73d0e Merge "Catch the SecurityException in the APIs of SoundTriggerSession to avoid crashing." 2021-01-08 09:55:11 +00:00
Julia Reynolds
9bfd6c0f0a Merge "Add 'ongoing' filter type" 2021-01-08 03:14:52 +00:00
lpeter
3492b92b26 Catch the SecurityException in the APIs of SoundTriggerSession to avoid crashing.
Currently when switching the user, it will be possible to meet this
kind of issue due to timing factor that the API of SoundTriggerSession
was called by previous user and caused the exception "Caller is not
the current voice interaction service.". It seems that the flow between
switching user and voice interaction needs to be improved to avoid this
race condition issue, but the impact will be high.

It would be better to catch the exception and return the fail status
to caller instead of crashing as a short term solution.

Four approaches are considered below:
(1) Change state to STATE_INVALID
When AlwaysOnHotwordDetector is shutdown, the state will be set to
STATE_INVALID. Then all called methods from it will fail with an
IllegalStateException. This is a normal behavior that has been defined
in the javadoc. But the STATE_INVALID does not clearly indicate what
happended in the AlwaysOnHotwordDetector for this issue and what to do
next. So it is not the best approach to change the state to
STATE_INVALID directly.

(2) Use a new state to inform the caller (apply this)
Define a new state STATE_ERROR to indicate the unknown active
keyphrase availability due to an error.
public static final int STATE_ERROR = 3;

When the exception occurs, it will pass STATE_ERROR to the caller by
the callback API "onAvailabilityChanged(int status)".
Then all called methods from it should fail with an IllegalStateException
due to AlwaysOnHotwordDetector can not be used currently.
The caller should create a new instance after receiving this state.

In order to avoid unintended behavior in the application, it would be
better to use this approach when the target SDK version is greater
than R.

(3) Use onError() callback to inform the caller
Currently when some errors occurred during Recognition, the onError()
callback will be called. But it doesn't mean the caller should stop
to using the AlwaysOnHotwordDetector. It is different from what we
want that the caller should not use the AlwaysOnHotwordDetector and
should create a new instance. So it is not suitable to use the onError()
callback to inform the caller due to no error reason in the onError()
callback. The caller will not know what happened and what to do next.

(4) Create a new onError(int reason) callback to inform the caller
In this approach, it will need to create a new onError(int reason)
callback to inform the caller. It also needs to change the state of
AlwaysOnHotwordDetector, then all called methods from it should fail
with an IllegalStateException due to AlwaysOnHotwordDetector can not
be used currently. This approach is also fine, but it is very similar
to approach 2. Finaly we use the approach 2.

Bug: 148136382
Test: atest CtsVoiceInteractionTestCases
Test: atest CtsSoundTriggerTestCases
Change-Id: I4697a2e6e26d412cf5c985467c652d30586adbe7
2021-01-08 01:35:01 +00:00
Julia Reynolds
cd561fc63b Add 'ongoing' filter type
Test: atest
Bug: 173052211
Change-Id: I2d780d38fc86a11005450ea1f159b0067ff7f65d
2021-01-07 23:36:08 +00:00
TreeHugger Robot
677c97ddf8 Merge "Pass focused field's ViewNode information in the augmented autofill request" 2021-01-07 20:25:15 +00:00
Neil Fuller
762c026554 Merge "Add LocationTimeZoneProvider test infrastructure" 2021-01-06 23:03:48 +00:00
Feng Cao
41797aa777 Pass focused field's ViewNode information in the augmented autofill request
* Only regular view's viewnode info is produced. Virtual view is not
  support yet, for efficiency reasons.

Test: manual
Test: atest android.autofillservice.cts.inline
Test: atest android.autofillservice.cts.augmented
Bug: 141703532
Change-Id: Ib9aa75ebf8504d674513bd0e6528460ba9db2c34
2021-01-06 14:22:03 -08:00
Treehugger Robot
d0e3e80f51 Merge "Add an OWNERS file for location tz detection code" am: 205894f2af am: 95d9ae065e am: 716e202e57
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1541670

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ie0236ce8cbc5923c9ea460c050d0e64e8e4f2b3e
2021-01-06 20:18:28 +00:00
Neil Fuller
616df78f9e Add LocationTimeZoneProvider test infrastructure
Add test infrastructure for the location time zone manager.

This test command injection facility is a generalization of the
pre-existing SimulatedBinderProviderEvent and so replaces it with a
distinct send_provider_test_command.  This can be used to test the
ControllerImpl without using the real LocationTimeZoneProvider(s) (which
are disabled when the provider is set to simulation mode).

A command to a simulated secondary provider:

$ adb shell setprop persist.sys.geotz.secondary simulated
$ adb shell reboot
$ adb shell cmd location_time_zone_manager send_provider_test_command \
    secondary on-bind
$ adb shell cmd location_time_zone_manager send_provider_test_command \
    secondary success \
    "tz=string_array:Europe/London\&Europe/Paris"

See also the following for help:

$ adb shell cmd time_zone_detector
$ adb shell cmd location_time_zone_manager

Bug: 152746105
Test: See steps above
Change-Id: I7259778ad7af8f2937cb3b4b8751a02c149d2b21
2021-01-06 20:05:17 +00:00
Treehugger Robot
205894f2af Merge "Add an OWNERS file for location tz detection code" 2021-01-06 19:18:02 +00:00
Neil Fuller
26c036bb3a Add an OWNERS file for location tz detection code
Another OWNERS file for location tz detection code.

Test: treehugger only
Change-Id: Ic4f7031330a7bb8da343c8274cf385af49c68d0e
2021-01-06 16:17:11 +00:00
Tiger Huang
335d657422 Merge "Send display cutout to client via insetsChanged" 2021-01-06 06:52:31 +00:00
TreeHugger Robot
7b14bd6332 Merge "Add filtering to notifications sent to NLSes" 2021-01-05 22:13:46 +00:00
Julia Reynolds
51582aed15 Add filtering to notifications sent to NLSes
Test: atest
Bug: 173052211
Change-Id: Id1b3440ff375543b546f2a599b791a70e28d8bb8
2021-01-05 20:29:42 +00:00
Neil Fuller
ad4d5d365d Adjust time zone provider permissions
Modify ther permissions system around TimeZoneProviderService discovery.

Bug: 175718639
Test: Confirmed witholding the INSTALL_ permission led to a boot failure
Test: build / boot / treehugger
Change-Id: Id91fa7716e3ccc53cd2801aa4d7a469c01c990b6
2021-01-05 17:20:32 +00:00
Tiger Huang
ec1a69e87c Send display cutout to client via insetsChanged
Since the display cutout is a type of insets and the display cutout can
be obtained from WindowInsets, it makes sense that InsetsState has the
display cutout instance. In this way, we can send the display cutout to
client via W#insetsChanged instead of W#resized.

This can be a step to remove the class of ClientWindowFrames, and can
also be a step to make client compute its window frame locally.

Fix: 175858810
Bug: 161810301
Test: atest WindowAddRemovePerfTest ImeInsetsSourceConsumerTest
            InsetsControllerTest InsetsStateTest ViewRootImplTest
            WindowInsetsControllerTests ActivityRecordTests
            DisplayPolicyLayoutTests LaunchParamsControllerTests
            TaskSnapshotSurfaceTest WindowMetricsActivityTests
            WindowMetricsWindowContextTests WindowMetricsTest
            WindowFrameTests WindowStateTests WmDisplayCutoutTest
Change-Id: I9a930b1d2f7df3cea2b29629b767a4a5f31bca17
2021-01-05 22:22:38 +08:00
Nikita Dubrovsky
7d16988c5a Merge "When autofilling content, grant URI permissions to the target app" 2020-12-30 22:26:17 +00:00
Nikita Dubrovsky
981cde188f When autofilling content, grant URI permissions to the target app
Bug: 168341541
Test: atest CtsAutoFillServiceTestCases:DatasetTest
Test: Manually tested image suggestions when the target app doesn't have media store permissions
Change-Id: I42546c76e45ec404e8d8de3bf63ca094d8a494c6
2020-12-28 17:27:48 -08:00
Jeff Sharkey
0ff34e341c Merge "Add OWNERS file for attestation" am: ba2a123820 am: d9ba892bc7 am: 03a4d08fed
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1532899

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I382b5e2c8395ce3d42cd4f0d8dfb9835b38fe4c0
2020-12-22 06:47:43 +00:00
Jeff Sharkey
ba2a123820 Merge "Add OWNERS file for attestation" 2020-12-17 15:22:22 +00:00
lpeter
4fec923086 Add OWNERS file for attestation
Bug: 175767555
Test: build
Change-Id: I080973cae7a2b6c45e6bf03aef039cef34cdfb98
2020-12-17 14:47:32 +00:00
Automerger Merge Worker
bf0626bc36 Merge "Merge "Additional OWNERS coverage for storage." am: d111833fd3 am: c7077507d0" into rvc-qpr-dev-plus-aosp am: f11186b845
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1531982

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I472de486642f4fbc6bc37ba58cb88e196c5d7a39
2020-12-17 05:10:39 +00:00
Jeff Sharkey
9ac773a60b Additional OWNERS coverage for storage.
Bug: 174932174
Test: none
Change-Id: I265ebd077d27d0d52d97a2c3c4a7147368be2498
2020-12-16 14:47:45 -07:00
Biswarup Pal
685eca7077 Merge "Add freeCache API to ExternalStorageService" 2020-12-16 15:53:15 +00:00
Neil Fuller
815f169d11 Merge "Add System APIs for TimeZoneProvider" 2020-12-16 13:21:54 +00:00
Biswarup Pal
b23206602a Add freeCache API to ExternalStorageService
Call ExternalStorageService#freeCache from
PackageManagerService#freestorage via StorageManagerInternal
to free any cache held by ExternalStorageService under low storage
conditions.

Test: m
Bug: 170481432
Change-Id: Iaee2262705f4c99fb9e46875e321dcbbae841824
2020-12-16 09:11:15 +00:00
Neil Fuller
b94da68e10 Add System APIs for TimeZoneProvider
First step of moving LocationTimeZoneProvider from the
com.android.location.provider API surface to system API.

This copies / renames various APIs, generally dropping "Location" from
the name to try to generalize them. The
com/android/server/location/timezone classes have been updated
to use the new classes but the names have been left for now as they are
an internal detail and it's not clear which would be "location specific"
and which might be general.

Bug: 175633818
Test: build / treehugger
Change-Id: Ied2b43336ef80d2b4ed2eba8849ea1976145df8d
2020-12-15 23:19:30 +00:00
Hyunyoung Song
21e60a9d43 Add Initial SearchUIManager
Bug:162234997

Test: builds, locally ran cts tests

CTS tests: ag/13129468

[Meeting notes with Svet/Sunny/Winson] go/aaplus-search-api
[Design diagrams] go/aaplus-search-supl

Change-Id: I4589cd411e124dc9d7ea132a71651f6b9f9656ae
2020-12-15 18:54:43 +00:00
TreeHugger Robot
f010d5dea2 Merge "Add Assistant Triggered EventTime" 2020-12-14 17:00:13 +00:00
Treehugger Robot
431139218a Merge "Add missing IMF OWNERS" am: 4e3959e571 am: 30497d0911 am: 03ced7e52e
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1525813

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I5896f244b5d601ceec3da6d25cc2a1b633ff4f55
2020-12-12 02:54:04 +00:00
Adrian Roos
bb4c35d0d2 Add missing IMF OWNERS
Test: n/a
Change-Id: Ib1ec672f872a3b1faf65c3583e300f473bac8f0c
2020-12-11 17:02:19 +01:00
Johanna Ye
ea22f49eb3 Add Assistant Triggered EventTime
Test: ADT3 on adt3-userdebug, with RVIS as the default AssistService and
VoiceInteractionService reporting the intent extra.

12-09 17:16:19.826  8809  8809 I #AssistSession: TVTS_RVIS android.intent.extra.TIME: 926771
12-09 17:16:19.826  8809  8809 I #AssistSession: TVTS_RVIS invocation_time_ms: 926773
12-09 17:16:19.826  8809  8809 I #AssistSession: TVTS_RVIS ASSIST_INPUT_DEVICE_ID: 7
12-09 17:16:19.826  8809  8809 I #AssistSession: TVTS_RVIS invocation_phone_state: 5
12-09 17:16:19.840  8809  8809 I #AssistSession: [TVTS] Showing Voiceplate: 926792
12-09 17:16:19.932  8809  8832 I AudioSourceManager: [TVTS][Legacy] micOpen
12-09 17:16:20.162  8809  8856 I AudioSourceManager: [TVTS][Legacy] Read non-zero bytes

Bug: 129355484

Change-Id: I653deac41e105e04f56e03aec0fa80d8d7eb5b54
2020-12-09 19:09:41 +01:00
Jeff Sharkey
0ab7007631 resolve merge conflicts of 358f0d4fc8 to master
Bug: 174932174
Test: I solemnly swear I tested this conflict resolution.
Exempt-From-Owner-Approval: refactoring with team leads buy-in
Change-Id: I9262a08ffc1ccede8e519d0eed90ed2bfcf0232c
2020-12-08 11:01:05 -07:00
Jeff Sharkey
0ace970e19 Temporarily replace "android.com" accounts.
We're temporarily blocked on internal Gerrit tooling to support
relaxed OWNERS validation, so this change temporarily replaces all
"android.com" accounts with "google.com" equivalents.

Bug: 174932174,175111824
Exempt-From-Owner-Approval: refactoring with team leads buy-in
Change-Id: I114f2a40cee1b65e21250da7372e11c18cd73e25
2020-12-08 17:54:13 +00:00
Jeff Sharkey
c7c4a74a78 Improve OWNERS coverage across frameworks/base/. am: fab0ab3c9c
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1519383

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I0211462ecbcd9ad66f66af87e31cf12e1582fc65
2020-12-08 16:01:16 +00:00
Jeff Sharkey
fab0ab3c9c Improve OWNERS coverage across frameworks/base/.
As general background, OWNERS files expedite code reviews by helping
code authors quickly find relevant reviewers, and they also ensure
that stakeholders are involved in code changes in their areas.

Some teams under frameworks/base/ have been using OWNERS files
successfully for many years, and we're ready to expand them to cover
more areas.  Here's the historical coverage statistics for the last
two years of changes before these new OWNERS changes land:

-- 56% of changes are fully covered by OWNERS
-- 17% of changes are partially covered by OWNERS
-- 25% of changes have no OWNERS coverage

Working closely with team leads, we've now identified clear OWNERS on
a per-package basis, and we're using "include" directives whenever
possible to to simplify future maintenance.  With this extensive
effort, we've now improved our coverage as follows:

-- 98% of changes are fully covered by OWNERS
-- 1% of changes are partially covered by OWNERS
-- 1% of changes have no OWNERS coverage

This specific change is automatically generated by a script from
detailed ownership information confirmed by team leads.

Bug: 174932174
Test: manual
Exempt-From-Owner-Approval: refactoring with team leads buy-in
Merged-In: I9789c97c1de8e5d962b48c29c57d82fe83729eba
Change-Id: I9789c97c1de8e5d962b48c29c57d82fe83729eba
2020-12-08 08:36:27 -07:00
Xiangyu/Malcolm Chen
10ce9349ad Merge "Expose CarrierMessagingServiceWrapper as System API." 2020-12-04 23:03:12 +00:00
Jeff Sharkey
db4ae71beb Merge changes from topic "nov30"
* changes:
  Hand-migration to TypedXml interface.
  Mechanically apply TypedXml refaster template.
  Mechanical refactoring to new typed XML classes.
  Additional hand-migration to TypedXml interface.
  "Resolve" both human-readable and binary XML.
2020-12-04 21:32:44 +00:00
Malcolm Chen
80054bd6f7 Expose CarrierMessagingServiceWrapper as System API.
Also adding Executor when callback, according to API council's
feedback.

Bug: 172087216
Test: build
Change-Id: Iaff6c75c1f92840424deeffbc4504a3ecf9bc1ee
2020-12-04 11:52:50 -08:00
Julia Reynolds
4fddc79580 Allow listeners to know about lockscreen notifs
Specifically, whether user and device policy manager settings
means that a notification should be hidden or redacted on
the lockscreen

Test: cts verifier
Fixes: 173090853
Change-Id: Ic09a2b05a1acce5d3d63732861bdc69b274a1eba
2020-12-03 15:33:44 +00:00