Commit Graph

9620 Commits

Author SHA1 Message Date
Sudheer Shanka
dfc8b3ff8e Merge "Schedule external stats sync on battery level change with a delay" into pi-dev am: a750da1960
am: 0c3d9cefcb

Change-Id: I2961daf8ab38bed8f5d4fed804447b0ae2d66fa9
2018-04-26 20:46:41 -07:00
Sudheer Shanka
a750da1960 Merge "Schedule external stats sync on battery level change with a delay" into pi-dev 2018-04-27 03:20:38 +00:00
Sudheer Shanka
0719c6af44 Schedule external stats sync on battery level change with a delay
and fix locking in scheduleCpuStatsSyncDueToWakelockChange().

Bug: 74146897
Test: atest cts/hostsidetests/incident/src/com/android/server/cts/BatteryStatsValidationTest.java
Test: atest core/tests/coretests/src/com/android/internal/os/BatteryStatsTests.java
Change-Id: I2891dfb8a0aedf429232f45e26deab93c738506e
2018-04-26 15:43:40 -07:00
Nader Jawad
5dbc5aa22a Merge "Fixed issue where color attributes used for window background Activity themes would not be applied" 2018-04-26 22:04:30 +00:00
Nader Jawad
56c68bc296 Fixed issue where color attributes used for window background Activity
themes would not be applied

Updated windowBackground attribute in attrs.xml to take either a
reference or a color parameter. Updated PhoneWindow to consume the
drawable defined from the TypedArray. Added test to PhoneWindowTest to
handle verifying if a theme has a background color defined that it is
applied properly.

Fixes: 70268864
Test: Re-ran core tests on PhoneWindowTest with an updated test to
verify color literals are applied properly

Change-Id: I77083d5ee366ca0236633ac7039d2a5acf127fe7
2018-04-26 10:15:37 -07:00
Makoto Onuki
906bf6c91a Merge "Make "Want to start battery saver?" dialog better." 2018-04-25 23:23:05 +00:00
TreeHugger Robot
63b534768e Merge "Remove PendingIntent based soundTrigger" 2018-04-25 21:29:06 +00:00
Makoto Onuki
e8bbf95cdf Make "Want to start battery saver?" dialog better.
- Don't line-break in "Battery" (only in English)
- Add "Learn more" link.

Bug: 78261259

Test: Manual test with:
- adb shell dumpsys battery unplug
- adb shell settings delete secure low_power_warning_acknowledged
- Enable battery saver
- Make sure the link is clickable if a link is set.
- Make sure there's no "learn more" link if the link is not set in strings.xml

Cherry picked I83364f628dd596a4d50bf2aca4db7cbfe7cf4909 and manually resolved conflict.

Change-Id: Icf6d4e62d8cb3556561f992afc45aaea868bce0e
2018-04-25 13:55:48 -07:00
Abodunrinwa Toki
e71e44d3e3 Merge "Fix floating toolbar menu item spacing." into pi-dev am: abab4cbd25
am: cb9873dba9

Change-Id: I944026adbda22f4d9a3da665b482704b4aa7e9ba
2018-04-25 13:36:34 -07:00
TreeHugger Robot
abab4cbd25 Merge "Fix floating toolbar menu item spacing." into pi-dev 2018-04-25 20:13:37 +00:00
Makoto Onuki
778ce66697 DO NOT MERGE Make "Want to start battery saver?" dialog better.
- Don't line-break in "Battery" (only in English)
- Add "Learn more" link.

Bug: 78261259

Test: Manual test with:
- adb shell dumpsys battery unplug
- adb shell settings delete secure low_power_warning_acknowledged
- Enable battery saver
- Make sure the link is clickable if a link is set.
- Make sure there's no "learn more" link if the link is not set in strings.xml

Change-Id: I83364f628dd596a4d50bf2aca4db7cbfe7cf4909
2018-04-25 15:27:47 +00:00
Abodunrinwa Toki
49ec54250f Fix floating toolbar menu item spacing.
We mistakenly changed floating_toolbar_menu_button_side_padding in
I309c729eb842d9388066bfb43eb18f33dbfe10b8 where in fact what we
wanted to do was to just change the mIconTextSpacing.
This cl fixes that.

Change-Id: I1b940eb12d2948f8c167c3f37ed0eba105b9f5ce
Fixes: 74032743
Test: built, observed visual look
Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest
Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest
2018-04-25 15:46:54 +01:00
Yohei Yukawa
b1845f317c Deprecate private AsciiCapable protocol
The concept "AsciiCapable InputMethodSubtype" was initially introduced
as a private protocol based on a magic keyword "AsciiCapable"
specified in "imeSubtypeExtraValue" attribute in API level 15 [1],
then became a public API "isAsciiCapable" attribute in API 19 [2].

However, it turns out that there remains one place in InputMethodUtils
where the previous private protocol is still used.

With this CL, InputMethodUtils stop relying on the previous private
AsciiCapable.

 [1]: I1a83b227498073c47567f73566043c273809adc9
      c36905673a
 [2]: Ic3ace4b6e0432d56696bcbc0be336aec1dc744a5
      dc8abf6cee

Fix: 78537996
Test: make doc-comment-check-docs -j
Test: atest InputMethodPreferenceTest InputMethodUtilsTest
Change-Id: I56c0c19878657a41882c2d784e1ac96a52ab33f6
2018-04-24 18:36:23 -07:00
Rubin Xu
43a33477d9 Merge "Make password history hashing more secure" into pi-dev am: 66b6d1c3bc
am: 1e90f0135f

Change-Id: Ie67bb7caa2c1fec8c58d876171586ee88d16409f
2018-04-24 06:32:58 -07:00
TreeHugger Robot
66b6d1c3bc Merge "Make password history hashing more secure" into pi-dev 2018-04-24 13:06:57 +00:00
Selim Cinek
fe5e954e9e Merge changes from topic "notification_reply_action" into pi-dev am: 53790c1c8f
am: 0744f1d4b1

Change-Id: Ic0fdf693f31edc0402c43451610c051b2d8571cf
2018-04-24 02:37:39 -07:00
Kenny Guy
d79d5c9bd6 Merge "Add spinner for smart replies." into pi-dev am: 5f18904a00
am: 06c4122c74

Change-Id: I5a2d775500b0a43eea281592f2325add233e7de1
2018-04-24 02:11:49 -07:00
Selim Cinek
53790c1c8f Merge changes from topic "notification_reply_action" into pi-dev
* changes:
  Cleaned up the paddings of the messaging layout and smart replies
  Changed the size of the largeIcon
  Moved the disabling from alpha to manual color blending
  Updated the color of the reply button to be more neutral
  Updated the reply icon
  Disabled reply action when pending intents are cancelled
  Split the reply icon permanently from the right icon
2018-04-24 09:10:38 +00:00
TreeHugger Robot
5f18904a00 Merge "Add spinner for smart replies." into pi-dev 2018-04-24 08:51:56 +00:00
Selim Cinek
1c72fa0249 Cleaned up the paddings of the messaging layout and smart replies
Refactored the code such that the reply icon's inset was substracted
from the overall paddings to make all of them consistent. This
will also help in the future as we don't have to update those
paddings manually anymore.

Test: test all sorts of combinations with Notify
Change-Id: I8c6c9951bc73c88d95cb443c8e618c7adca7ebd3
Fixes: 78441535
2018-04-24 14:33:29 +08:00
TreeHugger Robot
3efd16607a Merge "Add @NonNull annotation to getDecorView()" 2018-04-24 04:19:19 +00:00
Fyodor Kupolov
e3d1fd3b79 Merge "Reset binder call stats along with batterystats" into pi-dev am: 46c2b1451c
am: 1494d2b825

Change-Id: Icf345379ab1716cd0398e7eca017ecbbe09f9517
2018-04-23 16:46:23 -07:00
TreeHugger Robot
46c2b1451c Merge "Reset binder call stats along with batterystats" into pi-dev 2018-04-23 23:05:31 +00:00
Sudheer Shanka
53370a7894 Merge "Rate limit battery external stats collection in takeUidSnapshot(s)." into pi-dev am: 6bc6e21be7
am: ec9e20a1d9

Change-Id: Ifbc3b63ce0173c7f066ed3f5a360c0cca53f1814
2018-04-23 15:08:39 -07:00
Sudheer Shanka
6bc6e21be7 Merge "Rate limit battery external stats collection in takeUidSnapshot(s)." into pi-dev 2018-04-23 21:34:57 +00:00
Fyodor Kupolov
8aa51245e9 Reset binder call stats along with batterystats
Test: dumpsys batterystats --reset && dumpsys binder_calls_stats
Bug: 75318418
Change-Id: Ibdbd95468bba876b1f91357b86f7a8d45af2daed
2018-04-23 14:21:20 -07:00
Sudheer Shanka
e56013aa31 Rate limit battery external stats collection in takeUidSnapshot(s).
Bug: 74146897
Test: atest cts/tests/tests/os/src/android/os/health/cts/SystemHealthManagerTest.java
Test: atest core/tests/coretests/src/com/android/internal/os/BatteryStatsTests.java
Change-Id: I2e01146718c3ce65d230308097622b958cb2897a
2018-04-23 11:38:36 -07:00
Fyodor Kupolov
b0ad3dd2c6 Merge "Enabled aggregated per-uid stats collection by default" into pi-dev am: 981d61ddf8
am: adb9a96b8e

Change-Id: I76eb5d2c94af5138232142ef603f7da6c088b2fa
2018-04-23 11:09:00 -07:00
Kenny Guy
a0f6de8ab2 Add spinner for smart replies.
Add a spinner to MessagingGroup that is enabled
when the user has clicked on a smart reply.

Bug: 73607490
Test: atest SystemUiTests

Change-Id: I4d892c19b5df2b443761819929a83f016967e217
2018-04-23 18:58:19 +01:00
TreeHugger Robot
981d61ddf8 Merge "Enabled aggregated per-uid stats collection by default" into pi-dev 2018-04-23 17:49:06 +00:00
Selim Cinek
384804b42d Split the reply icon permanently from the right icon
Previously these would overlap, but they are now completely
separate.

Test: ensure that all notification styles still work with the new affordance.
Change-Id: I16f5f863b4afac27494a4a7615631bca240ca532
Fixes: 72750728
2018-04-23 16:19:21 +08:00
Rubin Xu
f01e90789e Make password history hashing more secure
Instead of hashing the password directly which makes it possible to bruteforce
the password offline, hash the password together with the synthetic password.
This means without knowledge of the synthetic password, the hash itself is
useless.

As a consequence of this change, saving and checking historical password would
now also require the current device password to be provided. Checking password
history also takes more time due to the need to unwrap synthetic password, at
around 100-200ms.

Bug: 32826058
Test: manual
Change-Id: Icb65171b8c8b703d8f0aa3a8cb2bf7ad96c1332d
2018-04-21 09:46:23 +01:00
Fyodor Kupolov
3f3af617ae Enabled aggregated per-uid stats collection by default
Enabled collection of number of calls per-uid. It has relatively small
overhead. Memory impact is minimal and cpu overhead is also small -
250 ns vs 1500 ns with detailed tracking

Detailed tracking is disabled by default. Controlled by
persist.sys.binder_calls_detailed_tracking

Added commands to reset and enable/disable detailed stats:
dumpsys binder_calls_stats --reset
dumpsys binder_calls_stats --enable-detailed-tracking
dumpsys binder_calls_stats --disable-detailed-tracking

Test: manual
Bug: 75318418
Change-Id: I7c1280c025001b6d2b46e4a37bad841712b6da2f
2018-04-20 16:12:41 -07:00
Mihai Popa
a2d9c7430a Merge "No divider between floating toolbar item groups" into pi-dev am: cbfe423122
am: 33a030ccdf

Change-Id: I767a5453a141f23f794bed4ba00327e24d847515
2018-04-20 10:22:57 -07:00
TreeHugger Robot
cbfe423122 Merge "No divider between floating toolbar item groups" into pi-dev 2018-04-20 16:53:31 +00:00
Mihai Popa
66d41f87ea No divider between floating toolbar item groups
The CL removes the vertical divider that used to exist between adjacent
menu item groups in the floating toolbar, as well as the extra padding
between these, in order to adapt to the new UX requirements. The CL also
centers the text view inside a button, when there is no icon shown at
the left of the text view. This is only relevant when the minimum size
of the button is larger than the text measured width, and we want the
text to be centered inside the button in this case.

Bug: 74032743
Test: manual testing
Change-Id: I309c729eb842d9388066bfb43eb18f33dbfe10b8
2018-04-20 11:05:47 +00:00
Siarhei Vishniakou
c771e7e80d Add @NonNull annotation to getDecorView()
The function Window::getDecorView() cannot return null, because the view
is being constructed in the case where it actually is null. Therefore,
annotate the method with @NonNull.

Test: no functional change
Change-Id: I1a350e0af8f314f696bb1acde225633abb935a42
2018-04-19 11:43:29 -07:00
Makoto Onuki
c52be80cb7 Merge "Split provider / service dumpsys into platform and non-platform" into pi-dev am: dbdf5df96e
am: c7ed7f0074

Change-Id: I84fd648bf5b47690ab0082516a99c4bbd7be1914
2018-04-19 11:00:05 -07:00
Makoto Onuki
dbdf5df96e Merge "Split provider / service dumpsys into platform and non-platform" into pi-dev 2018-04-19 17:21:48 +00:00
TreeHugger Robot
448663576f Merge "Properly manage explore by touch helper state" 2018-04-19 02:08:27 +00:00
Phil Weaver
02872bb90b Properly manage explore by touch helper state
When a hover exit happens, update state if a virtual
view is being hovered over. Whether or not it has
accessibility focus is not relevant.

Bug: 78008262
Test: atest CtsAccessibilityServiceTestCase
Change-Id: I09038c3daefa766c9276d309c52e4737b2c413d6
2018-04-18 17:11:02 -07:00
TreeHugger Robot
a47c03960b Merge "Make getLanguageFromLocaleString private" 2018-04-18 19:01:05 +00:00
Dieter Hsu
0e14c74f09 Merge "Add rank & count event to notification clicks and dismisses" into pi-dev am: afc909d3ba
am: 64df7a46e0

Change-Id: Iaca38ea5698f750a53d1987929a36ae1de4f035a
2018-04-18 06:31:01 -07:00
Dieter Hsu
afc909d3ba Merge "Add rank & count event to notification clicks and dismisses" into pi-dev 2018-04-18 13:05:43 +00:00
Dieter Hsu
d39f0d52dc Add rank & count event to notification clicks and dismisses
For click/action click/dismiss, passing rank(0-based) and
count at the time of the actions to events.

Bug: 70724602
Test: runtest systemui-notification
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/notification
Change-Id: I07c440f84ccb745f744eb4e317881b72d2b41683
2018-04-18 03:28:48 +00:00
Julia Reynolds
3d0717898c Merge "Exclude system notifications from visual suppression" into pi-dev am: f9e4ccfe87
am: 8acacb7057

Change-Id: I7ad77aa40dce38bd56ea6b471ad88fa2f4d22747
2018-04-17 14:25:00 -07:00
Makoto Onuki
0b575a3cdf Split provider / service dumpsys into platform and non-platform
Also extend the timeout to 60 seconds.
- Because each provider / service dump may time out, the total time should relatively be large.

Bug: 78017892
Fix: 78017892

Test: Manual test with the following dumpsys commands:
dumpsys activity provider all
dumpsys activity provider all-platform
dumpsys activity provider all-non-platform
dumpsys activity provider com.android.providers.contacts/com.android.providers.contacts.VoicemailContentProvider
dumpsys activity provider com.android.providers.contacts/.VoicemailContentProvider
dumpsys activity provider contacts
dumpsys activity provider voicemail
dumpsys activity provider 4d45a78

dumpsys activity service all
dumpsys activity service all-platform
dumpsys activity service all-non-platform
dumpsys activity service bluetooth

Test: atest /android/pi-dev/frameworks/base/core/tests/coretests/src/com/android/internal/util/DumpTest.java
Test: atest /android/pi-dev/frameworks/base/core/tests/coretests/src/com/android/internal/util/ParseUtilsTest.java

Test: Manual test with "adb bugreport" with adding sleep(10s) to ProviderMap.dumpProvider()

Change-Id: I00bce0090b8dbb947d7f8b1e5d01bb8a70d84bd8
2018-04-17 10:41:40 -07:00
Julia Reynolds
aa96cf3460 Exclude system notifications from visual suppression
But silence them by saying them cannot bypass DND.

Test: atest SystemUITests
Bug: 77656914
Change-Id: I044696cfdcef0e4a14be21173949612480722236
2018-04-17 15:27:35 +00:00
Dmitry Dementyev
51806c9862 Merge "Remove implementation of deprecated RecoveryController methods." into pi-dev am: 5291268754
am: 88a9786359

Change-Id: I6ba172a7f56904ba603ed816d1a32f3357d4563f
2018-04-16 16:12:43 -07:00
TreeHugger Robot
5291268754 Merge "Remove implementation of deprecated RecoveryController methods." into pi-dev 2018-04-16 22:14:22 +00:00