Commit Graph

1221 Commits

Author SHA1 Message Date
Steve McKay
1e4e9850cf Add CREATOR class to Selection. am: 2fbb40eebd
am: 7b814c76bf

* commit '7b814c76bf32050ac10708122e6a93514a2773be':
  Add CREATOR class to Selection.
2016-02-22 21:27:31 +00:00
Steve McKay
6eb2b937b0 Merge "Move directory and roots support to own ui bots." into nyc-dev am: cddd034ca7
am: 45602c0251

* commit '45602c025185565d039b96984bef214c74a3cdd3':
  Move directory and roots support to own ui bots.
2016-02-22 21:25:12 +00:00
Steve McKay
7b814c76bf Add CREATOR class to Selection.
am: 2fbb40eebd

* commit '2fbb40eebd508b67e53f5a8590caf57a53cfb25d':
  Add CREATOR class to Selection.
2016-02-22 20:36:40 +00:00
Steve McKay
2fbb40eebd Add CREATOR class to Selection.
Bug: 27236334
Change-Id: I5f50cd63b850785194fec2db3eb68e40aa7af34f
2016-02-22 12:29:37 -08:00
Steve McKay
45602c0251 Merge "Move directory and roots support to own ui bots." into nyc-dev
am: cddd034ca7

* commit 'cddd034ca78fd92be132cb2336eb2bff04ac5ce8':
  Move directory and roots support to own ui bots.
2016-02-22 20:20:02 +00:00
Steve McKay
cddd034ca7 Merge "Move directory and roots support to own ui bots." into nyc-dev 2016-02-22 20:01:48 +00:00
Steve McKay
b9a20d10c9 Move directory and roots support to own ui bots.
Also...sorry, snowball, don't automatically open folders
    that are created in Files app. Only do this in DocumentsActivity.

Change-Id: I271655fd3566496eced4aaa7a44d5110233150a0
2016-02-22 11:50:34 -08:00
Felipe Leme
a77007a427 Merge "Improved OpenExternalDirectoryActivity so it returns right away when an app already has the requested permission." into nyc-dev am: c657f3d0ba
am: 305940d5cc

* commit '305940d5cc201043e0d8baf71a6a15a34a4fa6c8':
  Improved OpenExternalDirectoryActivity so it returns right away when an app already has the requested permission.
2016-02-22 19:50:12 +00:00
Felipe Leme
305940d5cc Merge "Improved OpenExternalDirectoryActivity so it returns right away when an app already has the requested permission." into nyc-dev
am: c657f3d0ba

* commit 'c657f3d0ba1f192c9819ffa79903588b605ef470':
  Improved OpenExternalDirectoryActivity so it returns right away when an app already has the requested permission.
2016-02-22 19:39:00 +00:00
Felipe Leme
c657f3d0ba Merge "Improved OpenExternalDirectoryActivity so it returns right away when an app already has the requested permission." into nyc-dev 2016-02-22 18:55:22 +00:00
Aga Wronska
c82e84a3b0 Merge "Directory fragment refactoring. First attempt to to refactor fragments handling, state and app lifecycle." into nyc-dev am: f0febdcf90
am: 21de65d5e4

* commit '21de65d5e47a00b2953a1bdf82d62e5cda00073d':
  Directory fragment refactoring. First attempt to to refactor fragments handling, state and app lifecycle.
2016-02-22 18:42:24 +00:00
Aga Wronska
21de65d5e4 Merge "Directory fragment refactoring. First attempt to to refactor fragments handling, state and app lifecycle." into nyc-dev
am: f0febdcf90

* commit 'f0febdcf90af31f8e5a0b86dc079108e99ebd514':
  Directory fragment refactoring. First attempt to to refactor fragments handling, state and app lifecycle.
2016-02-22 18:35:22 +00:00
Aga Wronska
f0febdcf90 Merge "Directory fragment refactoring. First attempt to to refactor fragments handling, state and app lifecycle." into nyc-dev 2016-02-22 18:28:42 +00:00
Aga Wronska
893390bd58 Directory fragment refactoring.
First attempt to to refactor fragments handling, state and app lifecycle.

The goal was to simplify code by using android built lifecycle
mechanism, eliminate bugs caused by multiple creation of the fragment,
see the performance impact and give some fundament for refactoring of
fragments and activities in the app.

Search view manager:
    * Remove curentSearch from state
    * Restore search from saved state (ex. after rotation)
    * Rename file  to give the better overview of its purpose

Directory fragment:
    * Store selection state in a bundle
    * Remove double creation of fragment
    * Use loaders to reload content when possible
    * Keep info about state inside the object
    * Refactor available types of fragment to be normal and recents
    * Make search type a mode possibly available in all types
    * Remove search being invoked from refresh method
    * Do search by reloading fragments content instead of recreation as
      an example

Other:
    * Fix window title maybe

Bug: 26968405, 27101786
Change-Id: I58f36cd0a3e3a6ec98996cd8aac16e10e425e1fe
2016-02-22 09:36:17 -08:00
Geoff Mendal
fdce862c95 Import translations. DO NOT MERGE
Change-Id: I5f452609d36a3b910e3fadab6f31913371da0f19
Auto-generated-cl: translation import
2016-02-22 07:11:59 -08:00
Geoff Mendal
19aa3d6bce Import translations. DO NOT MERGE
Change-Id: I9a26d5bc10393b366fc8e9945fb9e60a0a12b86e
Auto-generated-cl: translation import
2016-02-22 05:18:38 -08:00
Steve McKay
8bd2dba973 Merge "Undo generalization isDownloads > supportsChildren." into nyc-dev am: fdfd5b60fc
am: ac806ff14e

* commit 'ac806ff14ea7fdf5c9a4072e42e3e4e04eceb09b':
  Undo generalization isDownloads > supportsChildren.
2016-02-19 19:33:56 +00:00
Steve McKay
ac806ff14e Merge "Undo generalization isDownloads > supportsChildren." into nyc-dev
am: fdfd5b60fc

* commit 'fdfd5b60fc7b62d2a3af97af39abde8c5067eada':
  Undo generalization isDownloads > supportsChildren.
2016-02-19 19:26:19 +00:00
Steve McKay
fdfd5b60fc Merge "Undo generalization isDownloads > supportsChildren." into nyc-dev 2016-02-19 19:17:59 +00:00
Steve McKay
459725dbb9 Merge "Escape title of Operationdialog." into nyc-dev am: 04003d8936
am: 92c44fc846

* commit '92c44fc846d15ef3e944dc584a008de26fbc240f':
  Escape title of Operationdialog.
2016-02-19 02:57:21 +00:00
Steve McKay
92c44fc846 Merge "Escape title of Operationdialog." into nyc-dev
am: 04003d8936

* commit '04003d8936684d5bdb9ccbdca4149e113c62eb38':
  Escape title of Operationdialog.
2016-02-19 02:50:57 +00:00
Steve McKay
04003d8936 Merge "Escape title of Operationdialog." into nyc-dev 2016-02-19 02:36:23 +00:00
Ben Kwa
7f7aabe952 Merge "Renumber UMA constants." into nyc-dev am: 1374412d89
am: 96ef2831b1

* commit '96ef2831b1aad2e4706b0e77fe30bc435cd1000a':
  Renumber UMA constants.
2016-02-19 01:08:39 +00:00
Ben Kwa
96ef2831b1 Merge "Renumber UMA constants." into nyc-dev
am: 1374412d89

* commit '1374412d8948cbcb7b2a1069220eeffd6d3a1b98':
  Renumber UMA constants.
2016-02-19 01:01:16 +00:00
Ben Kwa
fafa161d81 Merge "Implement type-to-focus in the DirectoryFragment." into nyc-dev am: 7b300ff369
am: b78500093f

* commit 'b78500093f5ef7dbb09a52de09b15633695736fb':
  Implement type-to-focus in the DirectoryFragment.
2016-02-19 00:55:23 +00:00
Ben Kwa
1374412d89 Merge "Renumber UMA constants." into nyc-dev 2016-02-19 00:52:25 +00:00
Ben Kwa
a87e9f94d0 Renumber UMA constants.
Clearcut does not like negative or zero values for its histograms.

Also, consolidate all metrics constants in the Metrics.java file. In
cases where values are being obtained from elsewhere (e.g. State.action
constants), map those constants to constants defined in Metrics.java.
This will reduce occurrences of constants changes accidentally screwing
up metrics data.

BUG=26737132

Change-Id: Ia9fb88a49c3102afc2464d20653e2ee21cfc591f
2016-02-18 16:48:45 -08:00
Ben Kwa
b78500093f Merge "Implement type-to-focus in the DirectoryFragment." into nyc-dev
am: 7b300ff369

* commit '7b300ff36932a4815f1f85b9ea73ec9a373dee10':
  Implement type-to-focus in the DirectoryFragment.
2016-02-19 00:47:04 +00:00
Ben Kwa
7b300ff369 Merge "Implement type-to-focus in the DirectoryFragment." into nyc-dev 2016-02-19 00:39:27 +00:00
Steve McKay
a3471af5f9 Escape title of Operationdialog.
Security review feedback.

Bug: 27121721
Change-Id: Ibafa07aea7b2f77ca476e4f62bd5e4e556ba49c7
2016-02-18 16:09:48 -08:00
Steve McKay
008e948c3e Undo generalization isDownloads > supportsChildren.
Move root comparison logic into RootInfo.
Move shared string comparison code to Shared.

Change-Id: I3267b496a165ad3cae773783db0e79df2eb118e8
2016-02-18 15:59:52 -08:00
Steve McKay
7d673480e8 Merge "UX cleanups." into nyc-dev am: 7295bcbe42
am: 854694225c

* commit '854694225c4bbab59b2a78762129165bd311ff9e':
  UX cleanups.
2016-02-18 23:24:49 +00:00
Steve McKay
854694225c Merge "UX cleanups." into nyc-dev
am: 7295bcbe42

* commit '7295bcbe42a15742550fc8abcfb983a6274b86a6':
  UX cleanups.
2016-02-18 23:18:02 +00:00
Ben Kwa
cdaaedbd6c Merge "Implement backspace support." into nyc-dev am: b4cbd54ea9
am: 9caedd8ed7

* commit '9caedd8ed798d062068a4fc3db388cf0aec8be93':
  Implement backspace support.
2016-02-18 23:10:10 +00:00
Steve McKay
7295bcbe42 Merge "UX cleanups." into nyc-dev 2016-02-18 23:08:27 +00:00
Ben Kwa
9caedd8ed7 Merge "Implement backspace support." into nyc-dev
am: b4cbd54ea9

* commit 'b4cbd54ea94f3e2673cf7054cabc2247ca3a6ebf':
  Implement backspace support.
2016-02-18 23:02:50 +00:00
Ben Kwa
b4cbd54ea9 Merge "Implement backspace support." into nyc-dev 2016-02-18 22:57:18 +00:00
Ben Kwa
359bbebb6d Implement backspace support.
Pressing backspace pops the user up a directory level if they aren't at
the root directory of the current root.

BUG=27123794

Change-Id: I8f0a88a1194bf8f082d0b057a288a0c3da3068f6
2016-02-18 14:30:12 -08:00
Steve McKay
e2af078488 UX cleanups.
Visually separate directory background from sidebar.
Lower shadows so the "real" effect isn't so prominent.

Hitchhikders:
Consolidate bool values in config.xml files (were in dimens.xml).
Add missing supportsRecents & supportsSearch methods
    to RootInfo.
Rename RecentLoader to RecentsLoader so it doesn't defy
    searching for "Recents" string.
Move Downloads below the divider.

Change-Id: I06c76e26ec6df6541860a1448865c67ed953ed43
2016-02-18 22:21:03 +00:00
Steve McKay
6cb1472ea6 Merge "Fix CTS failure." into nyc-dev am: 0d198d3afc
am: 689fe4444f

* commit '689fe4444f49e52b8e8128845b4aeea0ee239e18':
  Fix CTS failure.
2016-02-18 21:18:44 +00:00
Steve McKay
689fe4444f Merge "Fix CTS failure." into nyc-dev
am: 0d198d3afc

* commit '0d198d3afc14897ecfcc4972ecd67bc0c2d6651b':
  Fix CTS failure.
2016-02-18 20:55:18 +00:00
Ben Kwa
a4acc90b0a Implement type-to-focus in the DirectoryFragment.
Add a helper to the FocusManager, to handle alphanumeric keystrokes.
- Build a search index mapping document titles to adapter positions, and
  keep it up-to-date.
- Intercept alphanumeric keystrokes and build up a search string from
  them.
- Use the search string and index to set focus in the directory listing.
- Highlight code is written, but not activated in the UI for now, to
  minimize surface area for potential breakages.  Revisit enabling
  highlights for O.

BUG=24988911

Change-Id: I148ff5583c655338d12bc06d6484a9ed7aa528ad
2016-02-18 12:04:35 -08:00
Steve McKay
b8397607ee Fix CTS failure.
Loosen the reigns on setPickTarget to accommodate no sub command mode.

Change-Id: Ia11c4194970c93fe86e98dfd0d23ed4fa1cea765
2016-02-18 11:59:26 -08:00
Steve McKay
edb90ee1f4 Merge "Don\'t show recents as copy/move destination." into nyc-dev am: 65001419cc
am: 50606de4f7

* commit '50606de4f72309c71ba38d4aca56184b195fff12':
  Don't show recents as copy/move destination.
2016-02-18 03:32:54 +00:00
Steve McKay
50606de4f7 Merge "Don\'t show recents as copy/move destination." into nyc-dev
am: 65001419cc

* commit '65001419ccf1c5c4391e2f6bf3b3ed1d13d40a9f':
  Don't show recents as copy/move destination.
2016-02-18 03:26:58 +00:00
Steve McKay
4a1ca86f47 Don't show recents as copy/move destination.
Revoke "SUPPORTS_CREATE" from the Recents faux-Root.
Don't allow copy to roots that don't support children.
Add friendly access methods to Root info for checking flags.
Only show spacer between roots sections when both non-empty.
Add docs explaining the "apps" section in roots.
Improve logic in the "canCopy" method.

Bug: 27232639
Change-Id: If78ee0ff73f0788de863345b560aecd41b23dfb9
2016-02-17 18:52:03 -08:00
Felipe Leme
560d23a28f Improved OpenExternalDirectoryActivity so it returns right away when an
app already has the requested permission.

BUG: 26742218

Change-Id: Ib441c17ed1462b19621f893dc2ee9d6d485518c9
2016-02-17 17:51:59 -08:00
Tomasz Mikolajewski
8acbb30515 Limit number of ClipData items for a quick viewer to 1000. am: 32a34d3379
am: 9ac2efa652

* commit '9ac2efa6523d621d308b8c51ddc705d96d608cc1':
  Limit number of ClipData items for a quick viewer to 1000.
2016-02-18 01:09:07 +00:00
Tomasz Mikolajewski
9ac2efa652 Limit number of ClipData items for a quick viewer to 1000.
am: 32a34d3379

* commit '32a34d337977618d95ab183f65627a4ff4b9a390':
  Limit number of ClipData items for a quick viewer to 1000.
2016-02-18 01:04:45 +00:00
Tomasz Mikolajewski
32a34d3379 Limit number of ClipData items for a quick viewer to 1000.
Bug: 20822219
Change-Id: I774be914ddeea0335dc646000a1d5c997ea73fd4
2016-02-18 00:54:26 +00:00