Commit Graph

12955 Commits

Author SHA1 Message Date
John Reck
2562753783 Merge "Revert SurfaceView back to Q's version" into qt-r1-dev
am: 2f8cae24b9

Change-Id: Iedb5910e225fd2584b6b4342dc7aed9b93747eb0
2019-06-19 16:07:02 -07:00
John Reck
5866a0c6ab Revert SurfaceView back to Q's version
Revert API behavior changes to SurfaceView, snapping
back to Q's version.

Bug: 133378280
Test: none
Change-Id: I3a47f9bfdfab2d16707f952a9af672551736e681
2019-06-19 11:39:20 -07:00
lumark
5df8aa8ee8 Merge "Make InputMethodSystemProperty#MULTI_CLIENT_IME_ENABLED testable." into qt-dev am: b7abebde5b
am: c0ecccca16

Change-Id: Iaf173a4f4f1ddd89421ab14f38c44639b1cc2726
2019-06-18 05:45:49 -07:00
lumark
c0ecccca16 Merge "Make InputMethodSystemProperty#MULTI_CLIENT_IME_ENABLED testable." into qt-dev
am: b7abebde5b

Change-Id: I7459ec72287ffa36bcc11e9cce87d9a4258705d5
2019-06-18 05:32:28 -07:00
TreeHugger Robot
b7abebde5b Merge "Make InputMethodSystemProperty#MULTI_CLIENT_IME_ENABLED testable." into qt-dev 2019-06-18 12:27:15 +00:00
lumark
ca442d5d9f Make InputMethodSystemProperty#MULTI_CLIENT_IME_ENABLED testable.
Annotates InputMethodSystemProperty#MULTI_CLIENT_IME_ENABLED as @TestApi
to let cts can verify if multi-client IME enabled.

Bug: 135217809
Test: build and passes
Change-Id: Id7b4dceb2dbfaf3d7ed1084957dd14b04cad0cdf
2019-06-17 16:09:42 +08:00
Tim Murray
4eca767f5e Merge "Revert "RootViewImpl: Fix measure size hint for WRAP_CONTENT windows"" into qt-dev am: 2ea2a58d97
am: 9adc27c042

Change-Id: I10074fc6efd0749da57189eb55f2b8e5e0507fc0
2019-06-14 13:37:00 -07:00
Tim Murray
9adc27c042 Merge "Revert "RootViewImpl: Fix measure size hint for WRAP_CONTENT windows"" into qt-dev
am: 2ea2a58d97

Change-Id: I89fe6d0159d74709578515329c0725fc75aa93bc
2019-06-14 13:24:06 -07:00
Tim Murray
a277618a1c Merge "Revert "RootViewImpl: Fix measure size hint for WRAP_CONTENT windows"" into qt-dev
am: 2ea2a58d97

Change-Id: I08d6b4a6f39bcc0c8982e51922f215ce729fa9c9
2019-06-14 13:24:01 -07:00
Tim Murray
2ea2a58d97 Merge "Revert "RootViewImpl: Fix measure size hint for WRAP_CONTENT windows"" into qt-dev 2019-06-14 19:50:20 +00:00
Tim Murray
4f6b8ec056 Revert "RootViewImpl: Fix measure size hint for WRAP_CONTENT windows"
This reverts commit c18c6da441.

Reason for revert: major memory increase

Change-Id: Iffb9cd14343cd678849e487bfa163b5f23608ffd
Test: presubmit
Bug: 134695730
2019-06-14 17:16:17 +00:00
Qasid Ahmad Sadiq
2e441f5581 Merge "AccessibilityNodeIdManager should hold onto weak references of Views." into qt-dev am: c0d808a274
am: 5e2254948d

Change-Id: I912df6a821035aadcdd47a749d4d8d7ff350e0a1
2019-06-10 22:32:49 -07:00
Qasid Ahmad Sadiq
5e2254948d Merge "AccessibilityNodeIdManager should hold onto weak references of Views." into qt-dev
am: c0d808a274

Change-Id: I44bfdb8beebafd5e1a8ea91da9f30a876b0ddf27
2019-06-10 22:27:47 -07:00
Qasid Ahmad Sadiq
0721d488ce Merge "AccessibilityNodeIdManager should hold onto weak references of Views." into qt-dev
am: c0d808a274

Change-Id: I7b64f0c078bccba4cd65c28ac09267b392dd8e18
2019-06-10 22:27:47 -07:00
Qasid Ahmad Sadiq
2e6efdefa6 AccessibilityNodeIdManager should hold onto weak references of Views.
... as opposed to strong references.
In case the calls between register and unregister aren't matched, we don't want to be leaking views.
I haven't seen any real eveidence of there being leaks, just a report. But this is preventative.

Created a "WeakSparseArray", which wraps SparseArray, and passes in a kind of WeakReference that has an id.
The references become unreachable, we use the id to remove the the entry from the SparseArray.

Test: Used the device for a bit with talkback on. CTSAccessibility*
Change-Id: I8d11727428f56fc06007232ae341d1409a11991f
Fix: 134506015
2019-06-10 19:47:34 -07:00
Feng Cao
a1a275e63c Merge "Only send text update for TextView after VIEW_ADDED is notified" into qt-r1-dev
am: 691fa971ec

Change-Id: I7cd136b96fa62c79557768ecd1f75243bb75c670
2019-06-08 11:06:53 -07:00
TreeHugger Robot
691fa971ec Merge "Only send text update for TextView after VIEW_ADDED is notified" into qt-r1-dev 2019-06-08 17:58:59 +00:00
Ady Abraham
8c219250c7 Merge "DisplayEventDispatcher: use eConfigChangedDispatch" into qt-r1-dev
am: 619946fdc4

Change-Id: I98ecea42a933ed20ddd7b085baa88c277e53e353
2019-06-07 18:36:52 -07:00
TreeHugger Robot
619946fdc4 Merge "DisplayEventDispatcher: use eConfigChangedDispatch" into qt-r1-dev 2019-06-08 01:29:23 +00:00
Feng Cao
9e4ca44e28 Only send text update for TextView after VIEW_ADDED is notified
Test: atest CtsContentCaptureServiceTestCases (sanity check)
Fixes: 134309443

Change-Id: Ia94194576db0a1679bbb2a9b76c84a871b965435
2019-06-08 00:56:43 +00:00
Ady Abraham
9c501aad4b DisplayEventDispatcher: use eConfigChangedDispatch
In order to get DISPLAY_EVENT_CONFIG_CHANGED, eConfigChangedDispatch needs
to be used when creating DisplayEventDispatcher.

Bug: 131688378
Test: adb shell /data/nativetest64/libsurfaceflinger_unittest/libsurfaceflinger_unittest
Test: trigger config change and observe logcat
Change-Id: I0de8037ee5b024b7d9729750f582be919087be41
2019-06-07 10:26:47 -07:00
Tony Mak
b671323eb0 Merge "Fix an issue that clicking on a smart action chip on keyguard ... failed to launch app resolver when there are more than one app handlers." into qt-dev am: 78a48f5512
am: 5db125ccb8

Change-Id: I87dc89d4f5e389fc7204cfe81166e2c174f9f5a5
2019-06-06 02:44:33 -07:00
Tony Mak
5db125ccb8 Merge "Fix an issue that clicking on a smart action chip on keyguard ... failed to launch app resolver when there are more than one app handlers." into qt-dev
am: 78a48f5512

Change-Id: Ibd5f497a614e21b7d70972c51a56c820a5eb7c8a
2019-06-06 02:39:34 -07:00
Tony Mak
01ac3d3a7b Merge "Fix an issue that clicking on a smart action chip on keyguard ... failed to launch app resolver when there are more than one app handlers." into qt-dev
am: 78a48f5512

Change-Id: Ic7dd0c9f952e905c8f42001276f3def6e1797b70
2019-06-06 02:39:33 -07:00
Tony Mak
82e60027f4 Fix an issue that clicking on a smart action chip on keyguard ...
failed to launch app resolver when there are more than one app handlers.

What happened:
1. TextClassifier constructs an implicit intent to fulfill a task
like opening a link, making a phone call, etc.
2. TextClassifier calls resolveActivity against the implicit intent to
resolve the intent. The resolve component name will be used to create
an explicit intent. In this case, the intent is resolved to the
app resolver activity.
3. wouldLaunchResolverActivity in SysUI returns false for an explicit
intent with component name android/ResolverActivity.
4. SysUI does not trigger the "start the activity after the keyguard
is gone" logic because wouldLaunchResolverActivity returns false.
5. When user clicks on the action on keyguard, ResolveActivity.onStop
is triggered because it is shown (and thus moved to the background)
under the keyguard. So, finish() is called in onStop, and thus the bug.

IMHO, wouldLaunchResolverActivity should not return false
for an explicit intent with component name android/ResolverActivity.
But since we are late at this point, the safest option is to not setting
component name when the intent is resolved to package "android". Note that
this is what we are doing for P, so it should be pretty safe.

Test: 1. Install two browsers. Send myself a link. Tap on the Open Link
chip on keyguard. App resolver is shown.
2. atest frameworks/base/core/tests/coretests/src/android/view/textclassifier/

BUG: 129220155

Change-Id: I6d4d67c2233a2fec950887ea274825bf1cbc1ae2
2019-06-05 12:52:22 +01:00
Adrian Roos
0fa0ddde1d Merge "RootViewImpl: Fix measure size hint for WRAP_CONTENT windows" into qt-dev am: 952bcb8ffe
am: 1fb1edbe8a

Change-Id: Ib7b4791de91bdcbdfd9cece9dd3166769b3766ce
2019-06-03 16:10:23 -07:00
Adrian Roos
1fb1edbe8a Merge "RootViewImpl: Fix measure size hint for WRAP_CONTENT windows" into qt-dev
am: 952bcb8ffe

Change-Id: Ia6e018776df9fcfcd3e0ce00b18341d1cbc7c8c6
2019-06-03 16:02:28 -07:00
Adrian Roos
09ed7c9762 Merge "RootViewImpl: Fix measure size hint for WRAP_CONTENT windows" into qt-dev
am: 952bcb8ffe

Change-Id: Id02b19a73bc5b19a67cd93ac394c8ec356602096
2019-06-03 16:02:26 -07:00
TreeHugger Robot
952bcb8ffe Merge "RootViewImpl: Fix measure size hint for WRAP_CONTENT windows" into qt-dev 2019-06-03 22:52:59 +00:00
Chavi Weingarten
96af8617b0 Merge "Only updateBoundsSurface when surface size has changed." into qt-dev
am: fd979ca3d2

Change-Id: I58a77f02333c717b32f3facc83fe4d684ecb3010
2019-06-03 10:10:29 -07:00
Riddle Hsu
9b7699939e Merge "Invoke setWindowStopped on the thread that created the view" into qt-dev
am: 3bc96f9113

Change-Id: I8a66a0d378b13e7c2f48edf4bff01ae2799e47d5
2019-06-03 10:06:18 -07:00
Chavi Weingarten
2e011e66b2 Merge "Only updateBoundsSurface when surface size has changed." into qt-dev am: fd979ca3d2
am: 71df88b5b0

Change-Id: I4aabdc78505d5da7e20ffa3ea6257aa7b5c30dac
2019-06-03 09:23:01 -07:00
Chavi Weingarten
71df88b5b0 Merge "Only updateBoundsSurface when surface size has changed." into qt-dev
am: fd979ca3d2

Change-Id: I4fc1da4bd8f3dd74f873a1955c8ef350e0d00c36
2019-06-03 09:18:02 -07:00
Chavi Weingarten
fd979ca3d2 Merge "Only updateBoundsSurface when surface size has changed." into qt-dev 2019-06-03 16:08:42 +00:00
Riddle Hsu
3dafb4e54b Merge "Invoke setWindowStopped on the thread that created the view" into qt-dev am: 3bc96f9113
am: 789d90fc0e

Change-Id: Id21b33aeb613341e6e5e8dae692f37f0a096522d
2019-06-03 03:25:19 -07:00
Riddle Hsu
789d90fc0e Merge "Invoke setWindowStopped on the thread that created the view" into qt-dev
am: 3bc96f9113

Change-Id: I8215c828fadc888d59b10ad85088b2edf17378df
2019-06-03 03:19:21 -07:00
TreeHugger Robot
3bc96f9113 Merge "Invoke setWindowStopped on the thread that created the view" into qt-dev 2019-06-03 10:13:18 +00:00
chaviw
c0a8c4edbd Only updateBoundsSurface when surface size has changed.
Currently, updateBoundsSurface was getting called when the surface
changed, not just when the size changed. This meant it could be calling
setWindowCrop and deferTransaction when no size had changed. If size
hadn't changed, there was a high possibility that no new frames would be
submitted by the client, causing the deferTransaction to wait forever.

Since the deferTransaction was still waiting, SurfaceFlinger would wake
up every vsync to check if it should call doTransaction for the deferred
transaction. This caused 60Hz composition even when frames were rendered
slower.

Fixes: 132110524
Test: SF doesn't compose 30fps app at 60Hz
Change-Id: Icf3a99b34c288575438bfcd05e9077ea7919b4ca
2019-06-01 00:12:09 +00:00
Adrian Roos
c18c6da441 RootViewImpl: Fix measure size hint for WRAP_CONTENT windows
Fixes an issue where we would measure WRAP_CONTENT windows inconsistently
in the measure passes before and after relayoutWindow.

Fixes: 119839070
Bug: 73813813
Change-Id: I376e416d648f31a0dedecd6a70b476c3bf82b8b0
Test: Install test case app from 119839070, verify dialog is correctly laid out.
2019-05-31 14:26:35 +02:00
Siarhei Vishniakou
38f3118f04 Merge "Close windows on ACTION_UP when touched outside" into qt-dev am: 89ebf3f674
am: 2cd6a8ae5f

Change-Id: I7c462accf98ddb500d221d20344441803ec87e3d
2019-05-29 15:06:26 -07:00
Siarhei Vishniakou
2cd6a8ae5f Merge "Close windows on ACTION_UP when touched outside" into qt-dev
am: 89ebf3f674

Change-Id: I50be8986f4ffef7024300a39a97a788a301487a5
2019-05-29 15:00:43 -07:00
Siarhei Vishniakou
d447030e71 Merge "Close windows on ACTION_UP when touched outside" into qt-dev
am: 89ebf3f674

Change-Id: I845e4979cb3e7cc32775b9ac8083ee0802d6a390
2019-05-29 15:00:30 -07:00
TreeHugger Robot
89ebf3f674 Merge "Close windows on ACTION_UP when touched outside" into qt-dev 2019-05-29 21:51:22 +00:00
Jackal Guo
71bb5aa048 Merge "A11y support for windows in a re-parented display" into qt-r1-dev
am: 6d7b49bead

Change-Id: Ib01e6faf2cfe84fd05de96beaede4bc3fd7b01ab
2019-05-23 20:05:57 -07:00
Jackal Guo
6d7b49bead Merge "A11y support for windows in a re-parented display" into qt-r1-dev 2019-05-24 01:02:17 +00:00
Abodunrinwa Toki
2764a9f1e3 Merge "Convert TextClassifierEvent to SelectionEvent for logging in the default TC." into qt-dev am: a578ecce46
am: aeb8a3b154

Change-Id: I6651ebe1b2c9bccf6a47362b7db5074f41b8ed90
2019-05-23 15:14:24 -07:00
Abodunrinwa Toki
b1007e962c Merge "Convert TextClassifierEvent to SelectionEvent for logging in the default TC." into qt-dev
am: a578ecce46

Change-Id: Ia6afb8f90784676091d70f81492d9b35721b6ca8
2019-05-23 14:47:38 -07:00
Abodunrinwa Toki
aeb8a3b154 Merge "Convert TextClassifierEvent to SelectionEvent for logging in the default TC." into qt-dev
am: a578ecce46

Change-Id: Icadad2e0afaa3355b260f95d011f0dd577115439
2019-05-23 12:55:31 -07:00
Abodunrinwa Toki
a578ecce46 Merge "Convert TextClassifierEvent to SelectionEvent for logging in the default TC." into qt-dev 2019-05-23 19:35:24 +00:00
Abodunrinwa Toki
5258633e2d Convert TextClassifierEvent to SelectionEvent
for logging in the default TC.

TCEvents for selection and links are not currently being written to
default TC logs. This changelist writes these events as SelEvents.

Bug: 131228248
Test: atest android.view.textclassifier.TextClassifierEventTest
Change-Id: I191f2f9281eab1b8a427ef21717fff283a304a22
2019-05-23 13:37:59 +01:00