Commit Graph

76882 Commits

Author SHA1 Message Date
Chet Haase
da9374211f Fix infinite loop problem in AnimationHandler
AnimationHandler.doAnimationFrame() iterates on a list that may be changed
during the course of the lopp, especially when Battery Saver is enabled, or
animators have zero duration, coupled with user code launching new animators
when old ones end.

The fix is to iterate through the old size of the list, and avoid processing
new animators in the current frame.

Bug: 37376806  Keyboard doesn't come up when battery saver is turned on on Android O
Test: manual
Change-Id: I40ca1d849e6f337779c23edbab22d80760c22f9b
2017-05-26 16:56:12 -07:00
TreeHugger Robot
afea5e8ca4 Merge "TRON: Smart selection events that don't change the selection." into oc-dev 2017-05-24 15:44:40 +00:00
Abodunrinwa Toki
e78ac52d8b TRON: Smart selection events that don't change the selection.
See Ia9081d92ae9aea50d863455be770eecd0c73be1a for multi-selection
counts.

Test: Manually checked logging happens as per go/tron-howto and verified
nothing is broken in related classes by running:
bit FrameworksCoreTests:android.widget.TextViewActivityTest
bit CtsWidgetTestCases:android.widget.cts.TextViewTest

Bug: 32572232
Change-Id: I4ceab136ab73a20c6bc56732f7606ed103fe64d3
2017-05-24 14:45:24 +01:00
Andrei Stingaceanu
98891dbb70 Merge "AutoSize TextView - correct pixel transformations" into oc-dev 2017-05-24 09:16:52 +00:00
Abodunrinwa Toki
d80e82f917 Merge "Make TextClassifier.getLinks(...) a default method." into oc-dev 2017-05-24 01:57:50 +00:00
TreeHugger Robot
6c6d37d416 Merge "Don't keep a reference to Service object" into oc-dev 2017-05-24 00:31:40 +00:00
TreeHugger Robot
eee1dd26fa Merge "Hide Autofill UI when non-savable id is gone." into oc-dev 2017-05-23 23:28:38 +00:00
Abodunrinwa Toki
9115eeb483 Make TextClassifier.getLinks(...) a default method.
Fixes: 37907518
Test: cts-tradefed run cts-dev -o -m CtsSignatureTestCases -t
android.signature.cts.SignatureTest

Change-Id: I876781eccb2574ea01b6b460e14afd4e970a01b4
2017-05-23 21:29:39 +01:00
Adam Lesinski
4fed971437 Resources: fix race with creating theme
Bug: 38353957
Test: none
Change-Id: Id78770b475b979635da6a4067db6269e3a1b04d6
2017-05-23 13:14:54 -07:00
Bryce Lee
367b880c02 Merge "Revert "Disallow starting activities without new task from non-activity context."" into oc-dev 2017-05-23 19:50:24 +00:00
Bryce Lee
25ae100cb0 Revert "Disallow starting activities without new task from non-activity context."
This reverts commit 8b49a5c0aa.

Change-Id: I7d2da4ac72ca578942b38fccf8b151f3a2ed081f
2017-05-23 19:46:59 +00:00
Felipe Leme
27e202208b Hide Autofill UI when non-savable id is gone.
AutofillManager keeps track of which views the AutofillServiec is interested to
save, so when these views are gone, the session is finished.

But when the AutofillService returns a dataset whose views it can not save,
the FillUi for these views are not hiding when the views are gone. This CL
fixes this issue by:

- Keeping track which non-savable views should be tracked.
- Pass the view (instead of it's id) when the UI on such views should be hid.

This CL also optimized some AIDL and internal calls by avoiding the creating of
unnecessary Lists.

Test: manual verification with Snapchat
Test: existing CtsAutoFillServiceTestCases pass
Test: new tests on MultipleFragmentLoginTest pass

Fixes: 38199452
Change-Id: I78fa357962dbc6667146d8e08cd6bacb63e0f337
2017-05-23 10:46:24 -07:00
Amith Yamasani
7592825084 Don't keep a reference to Service object
This is a potential fix for a global reference leak in the
system process by a JobService in an app.

Bug: 38467796
Test: manual
Change-Id: I8756c39ac77bead068c88fce750c4024f9ac1c03
2017-05-23 10:37:09 -07:00
TreeHugger Robot
6cfc8afa7a Merge "Fix window affecting SysUi visibility for once and all" into oc-dev 2017-05-23 16:58:42 +00:00
Rob Carr
d9bf5ecf51 Merge "SurfaceView: Wait to gather transparent region." into oc-dev 2017-05-23 16:31:02 +00:00
TreeHugger Robot
7c4998e614 Merge "Fix FloatingToolbar refresh on menu changes." into oc-dev 2017-05-23 16:01:37 +00:00
TreeHugger Robot
76ec0575bc Merge "Ensure FloatingActionMode has a non-null FloatingToolbar." into oc-dev 2017-05-23 15:57:49 +00:00
Jorim Jaggi
23cc9aa50a Fix window affecting SysUi visibility for once and all
This unforunately introduces another quasi-visibiltiy method but
I think this is the best solution, as the code is pretty clean.

Test: Navigate through, settings, make sure no flickering
Test: Launch music from notification
Test: Launch United app
Test: Go settings -> app -> settings repeadetly 100 times, make
sure light bar transition is always clean
Fixes: 38216281

Change-Id: I0b97334dea3bfef2966ad0c7dd8bbd9907f2574c
2017-05-23 16:59:58 +02:00
TreeHugger Robot
540cb28c5a Merge "Revert "Changed alert window notifications to use single channel"" into oc-dev 2017-05-23 03:32:43 +00:00
Robert Carr
3ca12be796 SurfaceView: Wait to gather transparent region.
With the introduction of surfaceRedrawNeededAsync we may
be asked to gather the transparent region ahead of the SurfaceView
having been drawn.

Bug: 38324871
Test: Launch Chrome Canary a lot! No Flickers.
Change-Id: I35f09a1bb8316895fa704b10c912e64a8920bd90
2017-05-23 02:53:11 +00:00
TreeHugger Robot
42c6529c1d Merge "SurfaceView: Don't destroy Surface while Stopped." into oc-dev 2017-05-23 02:32:17 +00:00
Wale Ogunwale
af38fd7b0f Revert "Changed alert window notifications to use single channel"
This reverts commit 8f7bebca36.

We now want multiple channels so the user can disable which ever ones they like.

Change-Id: I6015cd5f1e3f37a8a01e1db42b57a94087780304
Fixes: 38428796
Bug: 37422870
2017-05-23 01:43:59 +00:00
Sudheer Shanka
fdeb6b8ed3 Merge "Read cpu freq data only when needed." into oc-dev 2017-05-22 23:52:02 +00:00
Abodunrinwa Toki
46850fcaea Fix FloatingToolbar refresh on menu changes.
Also includes some minor code clean ups.

Fixes: 38465735
Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest
bit CtsWidgetTestCases:android.widget.cts.TextViewTest

Change-Id: Ie87cc256b77b3ec5732f49c000ce4845130fc91c
2017-05-22 23:56:03 +01:00
Jiaquan He
652e940ebd Do not relayout on default focus highlight.
Test: AdjacentListsWithAdjacentISVsInsideTest.testFocusedRectAndFocusHintWorkWithinListItemHorizontal
Bug: 38195445

Change-Id: I4ba61d1dd6b806bff5305986a086c436c3b05b12
2017-05-22 20:12:46 +00:00
Dianne Hackborn
ad6dde65ff Merge "Fix issue #38393543: Not allowed to start service Intent" into oc-dev 2017-05-22 20:03:33 +00:00
Bryce Lee
3ebe54b3e6 Merge "Disallow starting activities without new task from non-activity context." into oc-dev 2017-05-22 14:31:07 +00:00
Abodunrinwa Toki
17293cc8a2 Ensure FloatingActionMode has a non-null FloatingToolbar.
Test: none
Bug: 38472422
Change-Id: I8b1844e0cbbff6dedeb0a89536a4bc27535b56df
2017-05-22 14:16:04 +01:00
Phil Weaver
ed83139842 Merge "Revert "NumberPicker a11y (and a11y-inspired) fixes"" into oc-dev 2017-05-22 13:03:45 +00:00
Sudheer Shanka
671985f483 Read cpu freq data only when needed.
Bug: 34133340
Test: cts-tradefed run singleCommand cts-dev -m ctsIncidentHostTestCases -t \
      com.android.server.cts.BatteryStatsValidationTest

Change-Id: Ib235e166820b95b5cd0a496b6146ea353abdf844
2017-05-19 17:09:48 -07:00
Dianne Hackborn
3e6e3855ea Fix issue #38393543: Not allowed to start service Intent
Turns out there was another path in to the activity manager
to trigger a PendingIntent, which needs to be modified to
now also pass in the whitelist token of that pending intent.

Test: manual
Change-Id: I755ff87db1b782fa6974d404dcb490786053c5e0
2017-05-19 16:12:08 -07:00
Robert Carr
73678099f8 SurfaceView: Don't destroy Surface while Stopped.
We instead just want to leave it floating, and let
it's lifetime be controlled by the parent surface. This way it can
take part in animations. Normally the WindowManager handles this by
calling detachChildren but it seems sometimes stop arrives before
the window manager is even clued in. Rather than bringing ActivityManager
in to the detach children dance...this seemed more appropriate and very similar
to the behavior before SV->SurfaceControl port.

Bug: 37922210
Test: Manual from bug + Launch chrome a bunch
Change-Id: Iee4fb0078a6e8dfd4c7acdb0107f8edd3a995634
2017-05-19 15:21:58 -07:00
Evan Rosky
a2ee78aeb9 Merge "Missed a break statement. very sorry" into oc-dev 2017-05-19 20:25:54 +00:00
Keun-young Park
ff4cc4ebb5 Merge "Wait for keyguard draw before stopping boot animation" into oc-dev 2017-05-19 20:07:14 +00:00
Michael Wachenschwanz
61e2b15866 Merge "DO NOT MERGE Revert "WTF Logging for catching memory issue in Parcel"" into oc-dev 2017-05-19 18:27:15 +00:00
Adam Bookatz
1effe000b8 Merge "Cumulative wakelock time per uid" into oc-dev 2017-05-19 18:24:44 +00:00
Keun-young Park
4136d2d54b Wait for keyguard draw before stopping boot animation
- Add check for keyguard drawn before stopping boot animation.
  Otherwise blank screen can happen.
- Bind to keyguard service when sysui is launched to reduce waiting
  time later.
- Increase keyguard timeout to 5 secs if it is not boot completed.
  Otherwise (= normal screen on), keep the current 1 sec.
  This timeout can still lead into blank screen so use bigger timeout
  during boot-up to prevent such case.

bug: 37867510
Test: many reboots

Change-Id: Ibfdc42d295bb1d3f5b4ea316fe5aca9ab875e4be
2017-05-19 09:20:28 -07:00
Jorim Jaggi
906fe92759 Merge "Fix underdraw during resizing" into oc-dev 2017-05-19 15:42:51 +00:00
Jorim Jaggi
853d17d838 Fix underdraw during resizing
Since we hide the navigation bar background during resizing, we
need to fill it with the fallback background.

This was always an issue but somehow in OC we are displaying
garbage instead of black.

Test: Open Contacts/Dialer, resize, make sure no underdraw is
happening. Also test a couple of other apps.
Fixes: 36206155

Change-Id: I6b02060ef4acf36c2529d49063a61034f9261696
2017-05-19 14:53:55 +02:00
Jorim Jaggi
64900ad13c Merge "Take snapshot when screen is turning off" into oc-dev 2017-05-19 12:29:54 +00:00
TreeHugger Robot
01d5b3d2af Merge "Introduce early exit path for non resource path." into oc-dev 2017-05-18 23:30:24 +00:00
Jorim Jaggi
51304d7380 Take snapshot when screen is turning off
Since we can't take a snapshot when screen is turned off, we need
to snapshot before we are turning the screen off. For this, we
- Add a callback from DisplayPowerController to give policy a
chance to do something before display will be turned off.
- Implement this callback by taking snapshots of all visible
tasks.

Test: Inspect logs/traces about screen off blocking to make sure
callback is working correctly.
Test: Insert artificial 500ms delay in onScreenTurningOff and make
sure we are unblocking screen off when turning on screen in the
meantime.
Test: Open Maps, go to recents, open maps again, scroll to another
location, toggle power button, make sure the old location isn't
shown during unlock.

Change-Id: I489f31358f838d418f894f996495946084f136a4
Fixes: 37107783
2017-05-19 00:55:31 +02:00
Michael Wachenschwanz
138bebf4c1 DO NOT MERGE Revert "WTF Logging for catching memory issue in Parcel"
This reverts commit 101e38cbec.

Bug: 37298089
Change-Id: Ia468d50fd1e4ca2ffa6145967bf3c847ed1929b8
2017-05-18 22:09:18 +00:00
TreeHugger Robot
99e620ef32 Merge "In onDragEvent(), don't assume text is Spannable" into oc-dev 2017-05-18 19:21:51 +00:00
Evan Rosky
0892401a86 Missed a break statement. very sorry
Change-Id: Ifbc6c60a3fa2cf296a34836c890a10d50c0f14c1
2017-05-18 11:18:18 -07:00
Sudheer Shanka
aff7c3c71e Merge "More unit tests for classes needed in reading uid times per cpu freq." into oc-dev 2017-05-18 17:42:17 +00:00
Dianne Hackborn
e4f484915f Merge "Work on issue #36891897: Need to ensure foreground services..." into oc-dev 2017-05-18 17:35:15 +00:00
Phil Weaver
a998b5f869 Revert "NumberPicker a11y (and a11y-inspired) fixes"
This reverts commit 1d359a6d31.

Bug: 38301562
Change-Id: I7a04f3068a8ecb0de63efcb82205b41916138a89
2017-05-18 16:19:23 +00:00
Jeff Sharkey
f383c24749 Unbreak even more APK 26 apps running on "O" preview/beta builds.
Bug: 38391358
Test: builds
Change-Id: Ic48f9cb53da3ed8241e5d40d3096304ee4dfebd2
2017-05-17 17:53:38 -06:00
Roozbeh Pournader
74e7b26a10 In onDragEvent(), don't assume text is Spannable
Previously, onDragEvent() tried to set the anchor even if
the text was not Spannable. Now we check to make sure it is
Spannable before trying to set the selection.

Test: cts-tradefed run cts-dev --module CtsTextTestCases
Change-Id: I835bf3d6024bf3c85e1d248458829eef496ad93d
Fixes: 37261326
2017-05-17 15:04:45 -07:00