Commit Graph

8305 Commits

Author SHA1 Message Date
TreeHugger Robot
50afc5eb41 Merge "Avoid global transaction in magnifier" 2019-09-11 20:47:28 +00:00
Robert Carr
64660bedad Avoid global transaction in magnifier
It's not good to use the global transaction from the render thread
like this as the UI thread could also be using it from SurfaceView. Transaction
objects require external synchronization so we could be corrupting them.

Bug: 140070297
Test: Builds
Change-Id: I17b4c1417d45cc825fca380350c326ed6b3edcf6
2019-08-27 13:25:51 -07:00
Kevin Hufnagle
f9cea382c9 Merge "docs: Added content desc in ImageView example." into qt-dev am: eba5156095 am: f1e24288bb am: 37f493ca26
am: 9c463f3133

Change-Id: I79398cc80d534de3c321a4dc55965716c7a0158d
2019-08-26 19:17:13 -07:00
Kevin Hufnagle
9c463f3133 Merge "docs: Added content desc in ImageView example." into qt-dev am: eba5156095 am: f1e24288bb
am: 37f493ca26

Change-Id: Iec84b01b73fc9eceed77aa885811070fcc1e7f29
2019-08-26 17:15:07 -07:00
Kevin Hufnagle
37f493ca26 Merge "docs: Added content desc in ImageView example." into qt-dev am: eba5156095
am: f1e24288bb

Change-Id: I8f43342b0114655a9a4467d8247ae238261ef9e0
2019-08-26 16:06:10 -07:00
Kevin Hufnagle
f1e24288bb Merge "docs: Added content desc in ImageView example." into qt-dev
am: eba5156095

Change-Id: I440bf71cdf541a0048cf0655372553d391ab611c
2019-08-26 15:13:26 -07:00
TreeHugger Robot
2941abbc9b Merge "Revert "The source of subtree chagnes should be the viewParent"" 2019-08-24 10:41:25 +00:00
TreeHugger Robot
4b7b1af6b1 Merge "Make TextClock.refresh() a public API" 2019-08-24 06:06:55 +00:00
Qasid Sadiq
9a65d51435 Revert "The source of subtree chagnes should be the viewParent"
This reverts commit ed508280f9.

Reason for revert: Caused a performance regression: b/138853920

Change-Id: Ibc981ffca7aa0bf365eeea4d4e5e57259ce40f35
2019-08-23 19:52:41 +00:00
shawnlin
ec99810e5b Make TextClock.refresh() a public API
Starting from R, apps in /product are not allowed to use hidden API.
TextClock.refresh() is used in FloralClock which is in /product.

We need to make it a public API.

Bug: 132750099
Test: make
Change-Id: I20adbff79270ce9d13f3323386d3636c322012f1
2019-08-23 10:52:08 +08:00
Tony Mak
e9f236906d Merge "Hold a strong reference to the callback in TextClassifierService" into qt-qpr1-dev
am: 8247b5f5a6

Change-Id: I8591d0ac8025589679e9462e82c7bbcf4ea8ea63
2019-08-22 14:43:03 -07:00
Tony Mak
7ba3fd4546 Hold a strong reference to the callback in TextClassifierService
Issue:
TextClassifierService failed to invoke the callback to send the result back to client
occasionally because  the callback object may be GCed.
And thus smart selection failed occasionally, as the client doesn't get a response
back when it hits this issue. It won't fallback to local textclassifier due to the
timeout specified in TextView.

Cause:
We thought that ITextClassifierCallback is a "cross process" reference, and
so we only store a weak reference of it to avoid leak.
And it turns out that it is wrong. As soon as the weak ref gets GCed in
the service, that counts as dropping the callback. The service doesn't
know about any strong references the client has.

Bug: 138865849

Test: Try smart selection over 30 times, make sure smart action is shown
for every single time.

Merged-In: Ia9218cf67e8d67697a0fdff22c7918a55efc39ca

Change-Id: I4d89518dfff777ba5d999d9ba89d7f4cf7598e75
2019-08-22 14:19:23 +00:00
Tony Mak
cdc81e8aff Hold a strong reference to the callback in TextClassifierService
Issue:
TextClassifierService failed to invoke the callback to send the result back
to client occasionally because  the callback object may be GCed.
And thus smart selection failed occasionally, as the client doesn't get
a response back when it hits this issue. It won't fallback to local
textclassifier due to the timeout specified in TextView.

Cause:
We thought that ITextClassifierCallback is a "cross process" reference, and
so we only store a weak reference of it to avoid leak.
And it turns out that it is wrong. As soon as the weak ref gets GCed in
the service, that counts as dropping the callback. The service doesn't
know about any strong references the client has.

Bug: 138865849

Test: Try smart selection over 30 times, make sure smart action is shown
for every single time.

Change-Id: Ia9218cf67e8d67697a0fdff22c7918a55efc39ca
2019-08-22 15:17:09 +01:00
Kevin Hufnagle
b358694739 docs: Added content desc in ImageView example.
The example ImageView at the beginning of the class description now
includes a content description attribute. Also updated the links in
the first paragraph where code fonts aren't necessary.

Test: make ds-docs -j32

Bug: 138856073
Change-Id: I33a75dc31d68289d955979d2fe8afe2ae3d4770e
2019-08-14 18:29:55 -07:00
TreeHugger Robot
68599e8da1 Merge "ItemViews accessibility enabled state should also reflect view.isEnabled." 2019-08-13 00:02:34 +00:00
Qasid Ahmad Sadiq
8e5db4082d ItemViews accessibility enabled state should also reflect view.isEnabled.
Now it takes into account, the listView.enabled, layoutParams.enabled and the view.enabled.
This bug resulted in some disabled items to not be presented as disabled to the accessibility service.
Fix: 138560025
Test: CTS ABSListViewTest, ListViewTest, DocumentsUIGoogleTests:RenameDocumentUiTest.

Change-Id: I0493545fbfc46ec80631caf78b8851bddc498775
2019-08-09 22:55:35 -07:00
TreeHugger Robot
e1025e8228 Merge "Add max target sdk for ActivityGroup related APIs" 2019-08-08 10:03:37 +00:00
Qasid Sadiq
0dd1be75c3 Merge "The source of subtree chagnes should be the viewParent" 2019-08-07 18:46:51 +00:00
Adrian Roos
a417290040 Merge "GestureNav: Fix AbsSeekBar thumb exclusion" into qt-r1-dev am: 92f61f0323 am: 9546c97709
am: 47ede3f54a

Change-Id: I579e89818e0ab7bbf787141d8dcefebc228ff5c3
2019-08-07 10:29:39 -07:00
Adrian Roos
9546c97709 Merge "GestureNav: Fix AbsSeekBar thumb exclusion" into qt-r1-dev
am: 92f61f0323

Change-Id: Ib0fd305bbf70a33c4d66808a3e3ffca8376c07ad
2019-08-07 09:56:51 -07:00
Adrian Roos
7c7898e74f GestureNav: Fix AbsSeekBar thumb exclusion
Fix two issues that caused the exclusion for SeekBar thumbs to be to small and offset
from the thumb:

Account for padding and thumb offset; the thumb drawable is drawn with an offset
from the View's Canvas; the same offset must be applied when udpating the exclusion
rects.

The thumb is typically much smaller than the drag zone; the thumb rect alone doesn't
provide an appropriately large exclusion for reliably hitting it, so it is enlarged
to the height of the seek bar (up to 48dp).

Bug: 138992366
Test: manual, show exclusion zones with: adb shell setprop debug.pointerlocation.showexclusion 150 && adb shell settings put system pointer_location 1
Test: atest android.widget.AbsSeekBarTest
Change-Id: I2b670c6f3f33451bdccdfd3d75a75e90260257ff
2019-08-07 15:09:26 +02:00
Yinglei Wang
165f56a092 Merge "add directional accessibility page actions to StackView" 2019-08-01 17:41:19 +00:00
Charles Chen
5c0943dbb0 Add max target sdk for ActivityGroup related APIs
Test: build and presubmit
Bug: 137825207
Change-Id: Ie3125743b46e785bf3f5655518e5634da2f578b0
2019-08-01 10:51:22 +08:00
yingleiw
7b2e888fd8 add directional accessibility page actions to StackView
StackView has ITEMS_SLIDE_UP mode and ITEMS_SLIDE_DOWN mode. In
ITEMS_SLIDE_UP mode, scroll forward is slide up and all pages go up
(page down action), scroll backward is slide down and all pages go down
(page up action). In ITEMS_SLIDE_DOWN mode, it is the opposite.
A video in ITEMS_SLIDE_UP MODE is here:
https://drive.google.com/file/d/1m5awAP7ja8tqSaSvNM_oDoVbaUeCa3l6/view?usp=sharing

Test: Tested with twisted talkback that in ITEMS_SLIDE_DOWN mode, page
down action is equivalent to scroll backward, and page up is equivalent
to scroll forward.
Bug: 136277517

Change-Id: I52b2af231781fa04cec5815db2e573a9014e434b
2019-07-31 13:59:42 -07:00
TreeHugger Robot
a6a28fd28f Merge "Deprecate TabHost and TabWidget" 2019-07-31 06:32:32 +00:00
Adam He
2eaec69928 Merge "Implement AssistStructure.ViewNode.getHintIdEntry()." 2019-07-30 21:32:27 +00:00
Charles Chen
28a0e47963 Deprecate TabHost and TabWidget
Since the core implementation of TabHost is LocalActivityManager, which
was deprecated for several years. It does not make sense to maintain
TabHost and TabWidget.

Test: flash and build
Bug: 137825207
Change-Id: Ifb62dbe68c8ada8499dd5336a189c803f2ae3dc1
2019-07-30 17:31:11 +08:00
Yinglei Wang
c526ef72ac Merge "add directional scroll for accessibility action in NumberPicker" 2019-07-27 00:32:43 +00:00
Robert Chou
ea1edcd99b Merge "Resolve NumberPicker display abnormal issue." am: 434e4fdfdb am: 17c0df4aa4 am: b7d3ffef37 am: cc0eaa051d
am: 6cab0b641f

Change-Id: Ife074b005bc16a2b0c1b9c2bd804420ef6442458
2019-07-25 21:24:13 -07:00
Robert Chou
cc0eaa051d Merge "Resolve NumberPicker display abnormal issue." am: 434e4fdfdb am: 17c0df4aa4
am: b7d3ffef37

Change-Id: Ieef8f0cce3dff1fb0c92dea3700e6a7723805399
2019-07-25 20:50:29 -07:00
Robert Chou
b7d3ffef37 Merge "Resolve NumberPicker display abnormal issue." am: 434e4fdfdb
am: 17c0df4aa4

Change-Id: Idd61b68dc773114fe09fcd7f8aebd1043c1a838d
2019-07-25 20:40:29 -07:00
Robert Chou
17c0df4aa4 Merge "Resolve NumberPicker display abnormal issue."
am: 434e4fdfdb

Change-Id: I1d5711167309ce1cb65ddf24bdd8e6392d83bd40
2019-07-25 20:30:37 -07:00
yingleiw
929f612c06 add directional scroll for accessibility action in NumberPicker
Test: Twisted talkback code to perform scroll down when scroll forward
is called. Verfied that scroll down is successfully performed in the
framework code and the number picker behaves correctly. Also verifed the
scroll up/down actions are correctly added to AccessibilityNodeInfo.
Bug: 136277517
Change-Id: I540d2ed3bf4e6b733668853182bd38faa8545997
2019-07-24 15:56:20 -07:00
Mingyan Liu
6234cd9c1a Resolve NumberPicker display abnormal issue.
Bugid: https://partnerissuetracker.corp.google.com/u/0/issues/138241751
Change-Id: Id5971e59d30506b0be2c5347a1e2dd4bb8371eaa
2019-07-24 07:53:38 +00:00
TreeHugger Robot
2857fdab3d Merge "Start saving attribute data for ViewAnimator." 2019-07-23 22:03:09 +00:00
Aurimas Liutikas
fae3445860 Start saving attribute data for ViewAnimator.
Bug: 137892645
Test: atest CtsWidgetTestCases:WidgetAttributeTest
Change-Id: I9e9696b8d5c6bdb6508cca2f08f0607b99ae9803
2019-07-22 16:15:18 -07:00
Kevin Hufnagle
07b2351189 Merge "docs: Fixed link in setCurrentTab() description" into qt-dev am: 2839f24e64 am: 21083088e9
am: 655931d20f

Change-Id: I87418f118f8e1383ac86806dc85a0e799eaf3aad
2019-07-22 15:54:30 -07:00
Kevin Hufnagle
655931d20f Merge "docs: Fixed link in setCurrentTab() description" into qt-dev am: 2839f24e64
am: 21083088e9

Change-Id: I257f23f7a7a463d53f187fe36e4ce4208d2aa9eb
2019-07-22 15:37:02 -07:00
Kevin Hufnagle
21083088e9 Merge "docs: Fixed link in setCurrentTab() description" into qt-dev
am: 2839f24e64

Change-Id: I4d888ec589953a02238520de0594d751fda3e6d0
2019-07-22 15:23:56 -07:00
Kevin Hufnagle
3eac945cb6 Merge "docs: Fixed link in setCurrentTab() description" into qt-dev
am: 2839f24e64

Change-Id: Ie058fa4312e0ee5e411ee0d0a2f0e49c5362c7c2
2019-07-22 15:23:56 -07:00
Kevin Hufnagle
2839f24e64 Merge "docs: Fixed link in setCurrentTab() description" into qt-dev 2019-07-22 22:01:49 +00:00
Nick Cook
bd5effc8d8 Merge "docs: Fix broken link." into qt-dev am: 2aec022fd2 am: 3fd9f9aaf9
am: 9a2dbf3c80

Change-Id: I099a1dad5b0910693a7836abe2c517903d2c2bb6
2019-07-22 11:02:14 -07:00
Nick Cook
9a2dbf3c80 Merge "docs: Fix broken link." into qt-dev am: 2aec022fd2
am: 3fd9f9aaf9

Change-Id: Id88ae5b1c60c07643b004a633fc0c7459aeba49c
2019-07-22 10:53:26 -07:00
Nick Cook
3fd9f9aaf9 Merge "docs: Fix broken link." into qt-dev
am: 2aec022fd2

Change-Id: I7a3c62f0259757be3921b2c8f6b8a2e3d6aa0bd7
2019-07-22 10:44:42 -07:00
Nick Cook
82252f17d3 Merge "docs: Fix broken link." into qt-dev
am: 2aec022fd2

Change-Id: I52cd7a41c34a1f44b427029c651c29912b36da93
2019-07-22 10:43:27 -07:00
Nick Cook
2aec022fd2 Merge "docs: Fix broken link." into qt-dev 2019-07-22 17:24:07 +00:00
Adam He
d55b16e73e Implement AssistStructure.ViewNode.getHintIdEntry().
Bug: 135134274
Test: atest CtsAutoFillServiceTestCases
Test: atest android.contentcaptureservice.cts.unit.ViewNodeTest
Change-Id: I7154cf97a5236ad975bd774c29b30e055cfca8bd
2019-07-19 15:33:51 -07:00
Nick Cook
7c0d47657f Merge "docs: Fix broken link." into qt-dev am: a2fe3be17d am: d0a4a594c5
am: fc53f95cf8

Change-Id: I659a3025b7aaa177c71a1ecc1f8adec6168c1588
2019-07-19 10:33:36 -07:00
Nick Cook
fc53f95cf8 Merge "docs: Fix broken link." into qt-dev am: a2fe3be17d
am: d0a4a594c5

Change-Id: I7b51ae46bbe26d888f9cb541244c2024c3833698
2019-07-19 10:23:35 -07:00
Nick Cook
4190144c27 Merge "docs: Fix broken link." into qt-dev
am: a2fe3be17d

Change-Id: I99943186126549eb9ce1269e619792e619c84bab
2019-07-19 10:16:48 -07:00