Commit Graph

27906 Commits

Author SHA1 Message Date
TreeHugger Robot
73b2a34e8d Merge "Update strings for bubbles" into rvc-dev 2020-03-19 22:48:02 +00:00
TreeHugger Robot
6d0bd16d08 Merge "URI parsing permission for SystemUI" into rvc-dev 2020-03-19 22:40:42 +00:00
TreeHugger Robot
31ddf754dc Merge "Deflake NotificationEntryManagerInflationTest" into rvc-dev 2020-03-19 21:47:41 +00:00
Hall Liu
2227afaacb Merge "Rename NotificationChannel#setBlockableSystem" into rvc-dev 2020-03-19 21:06:53 +00:00
Ben Lin
97d3a6554d Merge "Make PipTaskOrganizer protected." into rvc-dev 2020-03-19 20:57:27 +00:00
Fabian Kozynski
eae6bb56e4 Merge "Add warnings for leaked receivers in tests" into rvc-dev 2020-03-19 20:51:40 +00:00
Lyn Han
e566b36db9 URI parsing permission for SystemUI
Fixes: 151021631
Test: manual -> promote people bubble from overflow, chathead icon shows
Change-Id: Ib3a3f944f16908a01a24ed765f78ccbc270ea288
2020-03-19 20:36:12 +00:00
Mady Mellor
71869175cd Update strings for bubbles
- Adds some user education strings that aren't used yet, that'll
  be fixed in a follow up
- Removes some strings that aren't ever used

Test: treehugger
Bug: 151965589
Change-Id: I31a4dcb518b37505ed07fc2d454ddfec7598fb01
2020-03-19 13:19:02 -07:00
Beth Thibodeau
c285c18e66 Merge "Add long press menu to remove media player" into rvc-dev 2020-03-19 19:31:51 +00:00
Ben Lin
2dfaaebfe9 Merge "PIP: Add mouse hover/exit menu show support." into rvc-dev 2020-03-19 18:36:02 +00:00
Kevin Han
a6d5bb4750 Deflake NotificationEntryManagerInflationTest
Deflake NotificationEntryManagerInflationTest by moving back
to the countdown latch approach and providing our own executor
to AsyncInflationTask.

It was infeasible to depend on the exact number of main thread messages
as other main thread messages from other tests could interfere. Thus.
we move back to the countdown latch for when NotificationEntryManager
finishes inflation. This makes us dependent on the listener API for
determining when inflation is finished, but it's unlikely we can do
better unless we can inject an executor into RowInflaterTask.

In addition, using AsyncTask's SERIAL_EXECUTOR on hwasan builds seemed
to be much slower than normal. This lead to other tests' AysncTask
work delaying the work in this test and leading to the timeout
happening before inflation finished. By providing a test executor
instead and synchronously controlling its execution, we avoid this
issue.

Bug: 150618180
Test: atest --iterations 100 NotificationEntryManagerInflationTest
Test: atest SystemUITests
Test: A forrest run coming soon!
Change-Id: I87c6e2d216c8f26aaf340d311f618c9dccaba8af
2020-03-19 11:27:57 -07:00
Beth Thibodeau
8ebf6ad928 Add long press menu to remove media player
Screenshots: https://drive.google.com/drive/folders/1oaE6oFqShIhmcnG6P7CJFhgVenFgYNgm?usp=sharing

Fixes: 150742919
Test: manual
Change-Id: I36b61c62443bfee3ce6f13cccea9564460563918
2020-03-19 17:26:43 +00:00
Will Brockman
c92f717dee Merge "Fix UIEvent ID collision." into rvc-dev 2020-03-19 17:25:50 +00:00
Will Brockman
aaeccfbe56 Fix UIEvent ID collision.
An accidental ID collision in volume dialog logging had
RINGER_MODE_NORMAL and ZEN_MODE_OFF both on ID 156.  Move both to new
IDs (334, 335).

Fixes: 151632114
Test: atest SystemUITests
Change-Id: Ic24fd3ac30721c93eae9f0b164c8a2a7d3aee118
2020-03-19 16:40:36 +00:00
Steve Elliott
a7aededa7d Merge "Populate conversation notifs from shortcut info" into rvc-dev 2020-03-19 15:18:33 +00:00
Mark Chien
fc526fb6ba Merge "Replace type with TetheringRequest in startTethering usage" into rvc-dev 2020-03-19 14:54:41 +00:00
TreeHugger Robot
6b70283f4e Merge "Controls UI - Persist subtitles" into rvc-dev 2020-03-19 14:35:54 +00:00
TreeHugger Robot
0e56c85768 Merge "Renamed DisplayInfo to TelephonyDisplayInfo" into rvc-dev 2020-03-19 14:29:24 +00:00
Fabian Kozynski
8116816493 Add warnings for leaked receivers in tests
This CL adds a way to track BroadcastReceivers that are leaking in test
cases that use SysuiTestCase (all of SystemUITests). Every receiver that
is registered with Context is recorded and those that are not
unregistered are logged as a Warning. After each test, receivers are
unregistered so they don't polute following tests.

Additionally, if a BroadcastDispatcher is instantiated, a Fake is
provided that will also track leaked receivers and log them as Info (as
BroadcastDispatcher will only keep WeakReferences).

This is a separate tracker done directly in SysuiTestableContext instead
of using LeakCheckedTest or a LeakChecker as that is usually pretty
stringent (it will fail the test).

Test: SystemUITests
Bug: 151614195
Change-Id: I11afb49ce3bbc51d98fa069ba4074c852d07bcce
2020-03-19 09:35:07 -04:00
markchien
ff3b10030f Replace type with TetheringRequest in startTethering usage
startTethering with type is deprecated way and may not be exposed in
TetheringManager. The usage should be replaced by startTethering with
TetheringRequest.

Bug: 151918384
Test: m, atest
Change-Id: I9c26db3639857a8909be1888046fc942b8a51182
2020-03-19 13:09:47 +00:00
Ben Lin
11e808a472 Make PipTaskOrganizer protected.
This allows other parties to directly interact with PipTaskOrganizer.

Bug: 147361175
Test: None yet
Change-Id: I0047f1cad5f55ddc4bd35ed892bb10ad4ded0fe2
2020-03-18 18:50:53 -07:00
Matt Pietal
85878269e6 Controls UI - Persist subtitles
It is less than ideal to see subtitles popping in. Persist and restore them.

Bug: 150876640
Test: atest ControlsControllerImplTest AllModelTest ControlsBindingControllerImplTest ControlsFavoritePersistenceWrapperTest
Change-Id: I449ac020ccdd03f8c42b0a29eef21764514470a0
2020-03-18 18:55:31 -04:00
TreeHugger Robot
7a38263f94 Merge "Reinflate all headers when locale changes" into rvc-dev 2020-03-18 22:31:30 +00:00
TreeHugger Robot
653604d01b Merge "Controls UI - Suggested controls" into rvc-dev 2020-03-18 22:28:19 +00:00
Ben Lin
34b6fbf7e6 PIP: Add mouse hover/exit menu show support.
This adds the ability to show/hide menu based on hover enter/exit
events.

This also changes the InputConsumer so that it's now attached to the
pinned RootTask (Stack)'s SurfaceControl, so that the PipMenuActivity
appearing will not cause a new HOVER_EXIT + HOVER_ENTER pair event.

Bug: 144184591
Test: atest PipTests
Hover in/out of PIP activity, see menu show/hide.

Change-Id: I79536eb52cd234a82cbb7cb3004e31ada3ca0433
2020-03-18 15:14:01 -07:00
Jack Yu
ac3ca33567 Renamed DisplayInfo to TelephonyDisplayInfo
To reduce ambiguity with android.view.DisplayInfo.

Test: Telephony sanity tests + unit tests
Bug: 151101989
Change-Id: Ic507b6bf082ca5510ff6d1dcde501f5be9ef074f
2020-03-18 15:11:31 -07:00
TreeHugger Robot
7695663db7 Merge "Add NPE check in CameraTransitionCallback" into rvc-dev 2020-03-18 21:06:13 +00:00
Steve Elliott
59e23ebaf7 Reinflate all headers when locale changes
Fixes: 151267685
Test: manual, visual
Change-Id: I19da84fd4d8daec45b7393a0eb94c24f6f956065
2020-03-18 16:26:53 -04:00
Matt Pietal
6126644083 Controls UI - Suggested controls
When no controls have been loaded, and a preferred package has been
set, bind to the preferred service and ask it for suggested controls
to seed the stored favorites.

Bug: 151817620
Test: atest StatefulControlSubscriberTest ControlsBindingControllerImplTest ControlsControllerImplTest ControlsProviderLifecycleManagerTest ServiceWrapperTest

Change-Id: I1e51b8998b8379f08c2b995b7cbe23d1037bd840
2020-03-18 14:19:28 -04:00
Steve Elliott
46bb2a10a2 Populate conversation notifs from shortcut info
Fixes: 151330577
Test: manual
Change-Id: Ib7b7037155fc1891935fcbe89ced9f1639378ba0
2020-03-18 13:23:51 -04:00
Bill Lin
173f30edef Add NPE check in CameraTransitionCallback
CameraManager.AvailabilityCallback will notifyCameraInactive()
at initial stage, and cause NPE when mCutoutViews is NULL

Initialize mCutoutView at early stage

Bug: 151706640
Test: manual boot device
Test atest SystemUITests

Change-Id: I2008342d15bb589f85bb99fcc35ede96ef9678bd
2020-03-18 16:42:54 +08:00
Shawn Lin
841f253cb1 Merge "Fixed wrong QS padding" into rvc-dev 2020-03-18 05:28:43 +00:00
Mark Chien
099628bfe6 Merge "Remove no-op TetheringEventCallback default function" into rvc-dev 2020-03-18 00:36:17 +00:00
Lucas Dupin
517fffaa67 Merge "Do not allow division by 0" into rvc-dev 2020-03-18 00:31:05 +00:00
Beverly Tai
6a68d3d8a0 Merge "onDestroy, remove messages+callbacks on handler" into rvc-dev 2020-03-18 00:19:26 +00:00
Beverly Tai
97bec1d928 Merge "Add HeadsUpCoordinator to new notif pipeline" into rvc-dev 2020-03-18 00:12:45 +00:00
Beth Thibodeau
2b97e346d6 Merge "Fixing stray NPEs" into rvc-dev 2020-03-18 00:09:16 +00:00
Lucas Dupin
9e20024b94 Do not allow division by 0
Test: make
Bug: 151128233
Change-Id: Id1a50ae18a2cd014093a17701f6b62070a62e5ff
2020-03-17 15:28:43 -07:00
Selim Cinek
3d2ecec838 Merge changes I7993fde3,Ia804fc9b into rvc-dev
* changes:
  Fixed the double tap behavior on the expand button
  Forced the expand button to be double tappable on the lock screen
2020-03-17 21:42:02 +00:00
Beth Thibodeau
a51c3140b8 Fixing stray NPEs
Fixes: 151539645
- no session activity

Fixes: 151054103
- no contentIntent

Fixes: 151566982
- no handler for mSeamless

Test: manual, existing tests pass
Change-Id: I543ac440d8185eeaaab7c8d937db30b10b56bc00
2020-03-17 17:39:38 -04:00
Beverly
2520ac32e0 Add HeadsUpCoordinator to new notif pipeline
Fixes: 150797570
Test: atest HeadsUpCoordinatorTest PreparationCoordinatorTest
Change-Id: I42aa9008deb930a3b647a81428c1911171a1fe10
2020-03-17 16:30:40 -04:00
Ben Lin
fed10a3084 Merge "Reland: Track current resized bounds for resized PIP." into rvc-dev 2020-03-17 18:20:11 +00:00
Evan Laird
25f8496e7c Merge "Plugging in a new ViewHierarchyManager to the new pipeline" into rvc-dev 2020-03-17 17:17:48 +00:00
Evan Laird
9a9a6191e1 Plugging in a new ViewHierarchyManager to the new pipeline
NewNotifPipeline spits out a 2d list of notifications with new/improved
filtering, sorting, and grouping. This CL is an effort to plug that new
hotness into the NSSL, and make it testable hopefully.

Bug: 112656837
Test: not yet
Change-Id: I0ad159295cc9825f8ebbe219b4823dde82ef4621
2020-03-17 16:20:57 +00:00
John Li
bc67fc79cb Merge "Provide QSFactory" into rvc-dev 2020-03-17 15:34:01 +00:00
markchien
14628e4926 Remove no-op TetheringEventCallback default function
From API guideline: for platform code and libraries targeting Java 8 or
later, should prefer interfaces in cases where the default implementation
is stateless. Remove no-op default funnction call in
HotspotControllerImpl, then change TetheringEventCallback from abstruct
class to interface with default methods.

Bug: 151243337
Test: m, atest
Change-Id: I694f9110cffb7be8e4fd99bf6ac29e8a47131326
2020-03-17 23:02:50 +08:00
Miranda Kephart
031f0212f1 Merge "Fix crash when taking screenshots from overview" into rvc-dev 2020-03-17 14:25:43 +00:00
Josh Tsuji
7b0f95621f Merge "Surprisingly you can translate to Float.MIN_VALUE - stackPos.y, but you should not." into rvc-dev 2020-03-17 14:14:05 +00:00
Beverly
8947d75873 onDestroy, remove messages+callbacks on handler
Messages in the the KeyguardUpdateMonitor handler were still being
called after a test was finished, causing an assertMainThread exception
while running tests sometimes, so we would see flaky tests.

Test: atest SystemUITests
Fixes: 150592614
Change-Id: Ibd25e09948711054a4ef144cb54eaacfe566eeca
2020-03-17 09:04:12 -04:00
John Li
4e3dddce35 Provide QSFactory
Bug: 145892579
Test: atest SystemUITests:CustomTileTest SystemUITests:QSTileHostTest
Change-Id: I3b676e6fc2ec3f3b779c13b7dc8214569cc427e5
Merged-In: I3b676e6fc2ec3f3b779c13b7dc8214569cc427e5
(cherry picked from commit 6fa10209d7)
2020-03-17 08:12:51 +00:00