Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
828,940 Commits 3 Branches 0 Tags
d84de83dcd0eaecf4e3862a1945c83d42760a193
Commit Graph

9464 Commits

Author SHA1 Message Date
TreeHugger Robot
c7ab586fa3 Merge "Use event source for the UI visibility" 2022-08-26 10:53:19 +00:00
Seigo Nonaka
8630c53160 Use event source for the UI visibility 
Bug: 240383641
Test: atest TextViewMouseInteractionTest
Change-Id: Iefc5c27a05c716b06678266582a89c275a3a74f2
 2022-08-26 13:24:06 +09:00
Daniel Norman
47d8fe5c9f Merge changes from topic "reland-a11y-adp" 
* changes:
  Tweak behavior of isAccessibilityDataPrivate() to reduce CPU usage.
  Revert "Revert "Limit off-label accessibility access using a new..."
 2022-08-25 23:25:12 +00:00
Riley Jones
1c04b58273 Merge "Giving RatingBar a default custom StateDescription for more descriptive TTS output." 2022-08-24 20:12:36 +00:00
Alex Stetson
eca458e0fe Merge "Fixed divider rendering in RTL languages" into tm-qpr-dev am: 2cd24931e3 am: 4ce48b4d83 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19295691

Change-Id: Ib550629875d9f2de86d5e0797148c9f73c1a23a6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-24 19:54:45 +00:00
Alex Stetson
4ce48b4d83 Merge "Fixed divider rendering in RTL languages" into tm-qpr-dev am: 2cd24931e3 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19295691

Change-Id: Ie1a410591ed21da53d32cb59a9c6c8427922f728
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-24 19:40:20 +00:00
Alex Stetson
2cd24931e3 Merge "Fixed divider rendering in RTL languages" into tm-qpr-dev 2022-08-24 19:32:59 +00:00
Jon Eckenrode
32cd0a63d4 Merge "Docs: Touch-up of parameter descriptions and tags for consistency." 2022-08-24 18:04:56 +00:00
Zeyin Wu
dabec9ef59 Merge "Add accessibility expand/collapse action to node info" 2022-08-23 21:21:53 +00:00
Daniel Norman
60bb7c9bca Revert "Revert "Limit off-label accessibility access using a new..." 
Revert submission 19637776-revert-19246592-accessibility-tool-only-VJOPAMQMLT

Reason for revert: Relanding with fix
Reverted Changes:
I701b811fd:Revert "Limit off-label accessibility access using...
I85c58736b:Revert "CTS tests for the accessibilityDataPrivate...

Change-Id: Idfb12294c4ba75dfba8abd90985dea548d29042a
 2022-08-23 20:40:08 +00:00
joneckenrode
66504044ed Docs: Touch-up of parameter descriptions and tags for consistency. 
Staged:

https://android.devsite.corp.google.com/reference/android/widget/TextView

https://android.devsite.corp.google.com/reference/android/graphics/text/LineBreakConfig

https://android.devsite.corp.google.com/reference/android/graphics/text/LineBreakConfig.Builder

Test: Built API docs
Change-Id: I68d5228b2f952876c81f8590ccf69d68733f2741
 2022-08-23 17:48:53 +00:00
Zeyin Wu
1d59f48e7c Add accessibility expand/collapse action to node info 
Bug: 213940323
Test: ran atest android.widget.cts.ExpandableListViewTest and manually verified through talkback tests.
Change-Id: I8e9523781edd0dfd76c422da219beccf1a39a298
 2022-08-22 18:00:09 +00:00
Riley Jones
9e99f1cfd0 Giving RatingBar a default custom StateDescription 
for more descriptive TTS output.

Test: CTS tests included in topic
Bug: 149794211
Change-Id: I67945f7025ad29b3d11a33fd1ecec4b231966be5
 2022-08-17 01:34:09 +00:00
Daniel Norman
1e924c4709 Merge "Revert "Limit off-label accessibility access using a new property."" 2022-08-16 23:17:30 +00:00
Jon Eckenrode
0004b75dbf Merge "docs: Edited API documentation related to line-break and line-break word styles." 2022-08-16 21:48:11 +00:00
Daniel Norman
ff3c059c29 Revert "Limit off-label accessibility access using a new property." 
Revert submission 19246592-accessibility-tool-only

Reason for revert: Jank regression b/242267091
Reverted Changes:
I0685e6dd4:CTS tests for the accessibilityDataPrivate propert...
I1c02af88c:Limit off-label accessibility access using a new p...

Change-Id: I701b811fd4fb2634872a759134356736a7e8b7dd
 2022-08-16 16:13:28 +00:00
TreeHugger Robot
7e56ce1098 Merge "Hide text UIs for mouse interaction" 2022-08-15 03:23:19 +00:00
joneckenrode
f81fbd3eb0 docs: Edited API documentation related to line-break and line-break word styles. 
Staged to:

https://android.devsite.corp.google.com/reference/android/graphics/text/LineBreakConfig

https://android.devsite.corp.google.com/reference/android/graphics/text/LineBreakConfig.Builder

https://android.devsite.corp.google.com/reference/android/widget/TextView

https://android.devsite.corp.google.com/reference/android/R.attr

https://android.devsite.corp.google.com/reference/kotlin/android/R.attr

Test: Built API docs
Change-Id: I06fdf27ba94d806753a1dcc99873dff24cdae626
 2022-08-12 17:58:25 +00:00
Riley Jones
c1a8a2a99d Merge "Changed textView's addExtraDataToAccessibilityNodeInfo() to avoid Out of Bounds errors when Location Length exceeds Text Length. Specified the accessibilityService CTS tests to run for core presubmit." 2022-08-12 09:29:43 +00:00
Treehugger Robot
6efd2c943e Merge "Update OWNERS for RemoteViews related files." am: 00545d0fd6 am: ea4b4e5a83 am: 4e5571fd30 am: 82812dd066 am: bef30a8056 
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2180621

Change-Id: Ibd33288397d9f4d88854ecd44ef7e60d5582d2b7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-11 18:48:27 +00:00
Treehugger Robot
bef30a8056 Merge "Update OWNERS for RemoteViews related files." am: 00545d0fd6 am: ea4b4e5a83 am: 4e5571fd30 am: 82812dd066 
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2180621

Change-Id: I0ade83d702a47dd3ec12d08a01d5104e80085070
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-11 18:24:35 +00:00
Treehugger Robot
ea4b4e5a83 Merge "Update OWNERS for RemoteViews related files." am: 00545d0fd6 
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2180621

Change-Id: I4beccbf68d0b3b841b2e629be2a5f2662fe90f42
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-11 17:07:04 +00:00
Daniel Norman
f003dd10b2 Merge "Limit off-label accessibility access using a new property." 2022-08-11 17:04:57 +00:00
Riley Jones
9b471535ca Changed textView's addExtraDataToAccessibilityNodeInfo() to avoid Out of Bounds errors when Location Length exceeds Text Length. 
Specified the accessibilityService CTS tests to run for core presubmit.

Test: Should fix broken tests in AccessibilityTextActionTest
Bug: 241784682

Change-Id: I9b5fd1b2850b26815dea73080ad21aeb3d177bfe
 2022-08-11 09:59:53 +00:00
Mihir Patel
9064a4ef80 Merge "Reporting the Autofill IDs and Positions of active views in list view" into tm-qpr-dev am: 25192d7d0c am: f333fa0c93 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19054708

Change-Id: I2cbfe0cea3466bf0da1119ee9de1e52152ce6694
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-10 18:07:43 +00:00
Mihir Patel
f333fa0c93 Merge "Reporting the Autofill IDs and Positions of active views in list view" into tm-qpr-dev am: 25192d7d0c 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19054708

Change-Id: I6b8ffade431d057334147ae9cd5386afbad13cbc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-10 17:41:15 +00:00
Mihir Patel
25192d7d0c Merge "Reporting the Autofill IDs and Positions of active views in list view" into tm-qpr-dev 2022-08-10 16:35:13 +00:00
TreeHugger Robot
40d744aa6f Merge "RemoteViews: fix BitmapCache after immutable Bitmap switch" into tm-qpr-dev am: fe195e6f74 am: 9c1576da1c 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19450080

Change-Id: I493e5541d80c063cc9fc713b6817357bef3875d8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-10 04:54:41 +00:00
TreeHugger Robot
9c1576da1c Merge "RemoteViews: fix BitmapCache after immutable Bitmap switch" into tm-qpr-dev am: fe195e6f74 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19450080

Change-Id: I7ea562c9433a85dcad6cb3241954140dcb8905b2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-10 04:34:20 +00:00
TreeHugger Robot
fe195e6f74 Merge "RemoteViews: fix BitmapCache after immutable Bitmap switch" into tm-qpr-dev 2022-08-10 04:13:07 +00:00
Pinyao Ting
8767364abf Update OWNERS for RemoteViews related files. 
Change-Id: I50719c5d5b19f0d5fd542a94726221b165020860
 2022-08-09 23:40:35 +00:00
Mihir Patel
a6e0f74c90 Reporting the Autofill IDs and Positions of active views in list view 
Test: atest CtsContentCaptureServiceTestCases, observed events reported only once on scroll and stop as well as on fling
Bug: 211899037
Change-Id: Id67fcc360bf63fcab1d9f345c31d2bf7b9a173d6
 2022-08-09 15:37:50 -07:00
Sunny Goyal
45bdf7a065 Merge "Wrapping various apply parameters into a separate class" into tm-qpr-dev am: b4b3a8bdeb am: b4b25e4f9e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19531583

Change-Id: Ic6e6eda7ce96c0df0da665af0e32f75610981d08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-08 16:56:53 +00:00
Sunny Goyal
b4b25e4f9e Merge "Wrapping various apply parameters into a separate class" into tm-qpr-dev am: b4b3a8bdeb 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19531583

Change-Id: I1c24d06db68910c8a99028eca57b233c7e6c5b0d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-08 16:39:36 +00:00
Sunny Goyal
6224d07127 Wrapping various apply parameters into a separate class 
> This would allow us to easily extect the options
> Also passing the executor for async inflation. This will allow
  containing adapters to also be async if the parent View is using
  async inflation

Bug: 202766048
Test: Presubmit
Change-Id: I60a9b5db5f9b5f8d6e56521ee00de4be30decce6
 2022-08-05 14:53:00 -07:00
Alex Stetson
0ee3b273a0 Fixed divider rendering in RTL languages 
In horizontal layouts, when elements are rendered from LTR, the
definition of "before" and "after" gets flipped, causing the divider
spacing to be allocated to the wrong locations. By flipping the check in
RTL layouts, the dividers can be placed correctly.

Additionally, it is necessary to add divider measurements to all layout
width measurements to allow for dividers in right gravity to layout
properly.

Bug: 208927871
Test: atest android.widget.cts.LinearLayoutTest
Change-Id: If6e917873571484a6fb1dfc28b356289e2cc1ffa
 2022-08-03 16:03:29 -07:00
Haoyu Zhang
ad2359e69b Merge "Introduce Layout#fillCharacterBounds" 2022-08-02 21:25:01 +00:00
Daniel Norman
54eee1bc76 Limit off-label accessibility access using a new property. 
Bug: 238390816
Test: atest AccessibilityEndToEndTest
Change-Id: I1c02af88c4b23aa61a2444f4b83c9f5972b31e17
 2022-08-02 11:01:20 -07:00
Haoyu Zhang
e7422024fe Introduce Layout#fillCharacterBounds 
Introduce Layout#fillCharacterBounds to compute character bounds faster.
This change makes TextView#populateCharacter 5 times faster.

After:
        populateCharacterBounds[mTextLength (100))]_min (ns): 52361
        populateCharacterBounds[mTextLength (300))]_min (ns): 148941
        populateCharacterBounds[mTextLength (1,000))]_min (ns): 463237
        populateCharacterBounds[mTextLength (3,000))]_min (ns): 1388081
        populateCharacterBounds[mTextLength (10,000))]_min (ns): 1165867

Before:
        populateCharacterBounds[mTextLength (100))]_min (ns): 204065
        populateCharacterBounds[mTextLength (300))]_min (ns): 653159
        populateCharacterBounds[mTextLength (1,000))]_min (ns): 2184327
        populateCharacterBounds[mTextLength (3,000))]_min (ns): 6770318
        populateCharacterBounds[mTextLength (10,000))]_min (ns): 22777530

Bug: 233922052
Test: atest android.text.TextViewPopulateCharacterBoundsTest
Test: atest android.text.TextViewCursorAnchorInfoPerfTest
Change-Id: I68a47cf3099b89e0a10604b7706fa7a3dea66d32
 2022-08-02 09:39:12 -07:00
TreeHugger Robot
ad5f5557f1 Merge "Stop cursor from blinking when not visible" 2022-08-01 21:24:45 +00:00
Seigo Nonaka
ea5bbfeeb0 Hide text UIs for mouse interaction 
Floating toolbar, magnifier and tear drop selection handles are
designed for finger touch input. For the mouse UX, these UI will
not be good. So hiding them if the TextView/EditText has interacted
with mouse device.

Bug: 240383641
Test: atest TextViewMouseInteractionTest
Change-Id: I66f169ee3f2b77e3a066aecb07170e82248c2cde
 2022-08-01 10:19:01 +09:00
Tim Murray
c930727226 RemoteViews: fix BitmapCache after immutable Bitmap switch 
Test: widgets appear correctly
Bug: 237256275

Change-Id: I864ac1ba8ac771c326dc215ae4e712ceb0b6057b
 2022-07-27 17:45:14 +00:00
Yi-an Chen
c48f21a557 Merge "Add PbA branding to clipboard" into tm-qpr-dev am: 2b04393a1d am: 89e8a943d8 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19152769

Change-Id: I9c0a86d4eaab28baccceeef713cde9141d71d492
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-07-25 16:45:09 +00:00
Yi-an Chen
89e8a943d8 Merge "Add PbA branding to clipboard" into tm-qpr-dev am: 2b04393a1d 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19152769

Change-Id: I5e965626328b0d60f67ff43094f38e28304287c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-07-25 16:25:47 +00:00
Yi-an Chen
2b04393a1d Merge "Add PbA branding to clipboard" into tm-qpr-dev 2022-07-25 16:08:26 +00:00
Steven Terrell
941de7ed8f Stop cursor from blinking when not visible 
Cursor continues to blink in a text field even when the text field is
not currently visible. This change checks the visibility of the window
that houses the text field in addition to checking if the view is in
focus.

Bug: 228354442

Test: Added logging to the shouldBlink() method ran following steps:
     1: open contacts app
     2: tap add new contact, tap in an edit field
     3: move back to home screen
     4: lock screen, then unlock screen
     5: observed logs written out to logcat console when app not
        visible.
     after change logs no longer printed to console, cursor still blinks
     correctly after app is re-opened or when new field becomes in
     focus.
Test: CtsWidgetTestCases:EditTextTest#
        testCursorNotBlinkingOnNewActivity_WithoutFocus()
	testCursorBlinkingOnNewActivity_WithFocus()
	testSuspendAndResumeBlinkingCursor()
Change-Id: Iad4396e5f7fd810344c711320d65c57ea25eda70
 2022-07-21 16:31:34 +00:00
Sean McQuillan
cd4d5991b2 Merge "Don't crash after unsetting char[] in TextView" into tm-qpr-dev am: 469768f559 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19340644

Change-Id: Id975fe1ef50e8bab6a0ac851eab071b3f246c2ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-07-20 16:22:58 +00:00
Yi-an Chen
edfc44079c Add PbA branding to clipboard 
Bug: 213357911

Test: Manually on Raven
Change-Id: If9944393fe64c7f94a5be139a538833d91ae98fe
 2022-07-19 13:52:13 -07:00
Sean McQuillan
81cde0b584 Don't crash after unsetting char[] in TextView 
TextView.setText(char[]) is from API 1 and follows a running with
scissors API style of not copying the passed array.

To avoid a leak, in TextView.setText(String), the char[] would be nulled
out. However, an internal object could have been read using .getText()
prior to this second setText would immmediatly become a
CharSequence that crashed when you called any methods on it.

After this change, the CharWrapper will stay valid if had been
previously retrieved. The general shape of the API will be maintained.

Fixes: b/227218386
Test: atest android.widget.TextViewTest
Relnote: "Calling TextView.getText() after calling TextView.setText(char[])
will now return a valid CharSequence. The char[] pointed to by this char
sequnece may still be mutated by future calls to setText(char[]), but it
will no longer allow a (char[]) null to be set, which lead to crashes
when reading CharSequence returned from getText on TextView."

Merged-In: I35a2a76d58ec1946dace2f615cacf6a6085efdeb

Change-Id: I35a2a76d58ec1946dace2f615cacf6a6085efdeb
(cherry picked from commit 166c7217f4)
 2022-07-19 20:38:10 +00:00
Sean McQuillan
782e063d25 Mark nullability for TextView.setText(char[]) 
Add @NonNull to TextView.setText(@NonNull char[], ...)

This has always thrown a NPE since API 1.

Bug: b/227218386
Test: atest android.widget.TextViewTest
Relnote: "TextView.setText(@NonNull char[], ...) added nullability
annotation."

Change-Id: I212bb5b73d00185f83adb5e74d4acd07a1410ca8
 2022-07-12 15:18:47 -07:00