Commit Graph

5134 Commits

Author SHA1 Message Date
Sudheer Shanka
4344e7c721 Merge "Don't use linked mediastore uris in DownloadProvider operations." into qt-dev 2019-05-22 02:20:08 +00:00
Ivan Chiang
d580b03f3f Merge "Fix thumbnail's orienation issue" into qt-dev 2019-05-22 02:10:52 +00:00
Sudheer Shanka
1b817f65db Don't use linked mediastore uris in DownloadProvider operations.
When MediaProvider db gets recreated, all the media content ids
get renumbered. It's possible that when DownloadProvider is
trying to delete an entry, it is holding onto a invalid mediastore
uri. So, don't use linked mediastore uris in DownloadProvider
operations. Also, revoke any prior uri grants of media content from
DownloadStorageProvider.

Bug: 132087334
Test: manual
Test: atest DownloadProviderTests
Test: atest cts/tests/app/src/android/app/cts/DownloadManagerTest.java
Test: atest cts/tests/app/DownloadManagerLegacyTest/src/android/app/cts/DownloadManagerLegacyTest.java
Test: atest cts/tests/app/DownloadManagerApi28Test/src/android/app/cts/DownloadManagerApi28Test.java
Test: atest cts/hostsidetests/appsecurity/src/android/appsecurity/cts/AppSecurityTests.java
Change-Id: I4885f5a0ae0b3ab660426605a8a43b8c1d66a4c7
2019-05-21 10:21:43 -07:00
Shafik Nassar
c605c7b185 Merge "Documentation: Add trailing '/' to MediaColumns.RELATIVE_PATH" into qt-dev 2019-05-21 15:27:37 +00:00
TreeHugger Robot
a491cc4cd0 Merge "Add Aware Lock Settings" into qt-dev 2019-05-21 09:03:15 +00:00
shafik
a9a63575db Documentation: Add trailing '/' to MediaColumns.RELATIVE_PATH
Fix javadoc for MediaStore.MediaColumns.RELATIVE_PATH

Test: atest MediaProviderTest
Fixes: 132631113
Change-Id: I6f379b2d304a43198513341adcc3bafa2f00b0c1
2019-05-20 14:26:37 +00:00
Ivan Chiang
8214d58d2c Fix thumbnail's orienation issue
- If we do full file decoding, we should not handle orientation by
  ourselves.
- If we decode the thumbnail from ExifInterface.getThumbnailBytes()
  or MediaMetadataRetriever, we should handle the orientation.

Change-Id: I632b0b0ed41710401192dfb12f407eaf74c480ba
Fix: 130446058
Test: manual
2019-05-20 19:38:42 +08:00
Jeff Sharkey
b66f4f4bad Aggresive performance optimizations.
Now that we have LocalCallingIdentity, we can start caching it in
very narrow cases.  We must be careful to not cache too long, since
any changes to granted permissions for the UID mean we need to
re-evaluate any cached answers.

The best middle-ground for this in the Q release is to use an active
camera session as a proxy for when we should create a cache object
and then later invalidate it.  (It's very unlikely that a user
changes permissions while actively using the camera, and this is
a strong signal that the caller is sensitive to performance.)

Many other sprinkled optimizations to avoid extra binder calls into
the OS, such as aggressively caching VolumeInfo related details.

Track IDs that are owned by each LocalCallingIdentity, to speed up
all future security checks.

Dispatch all change notifications asynchronously, and delay them by
several seconds while the camera is being actively used, to give
more important foreground work a fighting chance.  Invalidate
thumbnails asynchronously.

Optimizations to ModernMediaScanner where it's safe to skip the
"reconcile" and "clean" steps when we're focused on a single file
that we successfully scanned.

Local tests show this CL improves performance of a test app that
takes 100 rapid shots by 45%.  (All the collective optimizations
done so far this week add up to a 70% improvement.)

Bug: 130758409
Test: atest --test-mapping packages/providers/MediaProvider
Exempt-From-Owner-Approval: trivial manifest change
Change-Id: I38cc826af47d41219ef44eae6fbd293caa0c01d5
2019-05-18 05:48:21 +00:00
Sudheer Shanka
75fb684e00 Merge "Revoke prior uri grants when MediaProvider db gets recreated." into qt-dev 2019-05-16 01:27:38 +00:00
Sudheer Shanka
7a66be2a13 Revoke prior uri grants when MediaProvider db gets recreated.
Bug: 132084545
Test: manual
Test: atest --test-mapping packages/providers/MediaProvider
Change-Id: Ibf2f2357d712a212f25b3bd005572ac74fe524fd
2019-05-15 16:37:06 -07:00
Edgar Wang
4870e4b034 Add Aware Lock Settings
Bug: 132106801
Test: rebuild & manual
Change-Id: I9c0efdd195b367b0744685e5d001ff4e23b55408
2019-05-15 19:14:43 +08:00
Jeff Sharkey
a356f1989c Legacy insertImage() should use IS_PENDING.
Also stream known file directly into place instead of doing a lossy
and expensive transcode.

Bug: 131710636
Test: atest --test-mapping packages/providers/MediaProvider
Change-Id: Icbfe4f79725c705a1197296f1fd4518c0179a9c1
2019-05-11 21:07:50 -06:00
Aran Ink
0cde819fc6 Merge "Add secure setting for Global Actions Panel debug mode." into qt-dev 2019-05-10 15:30:10 +00:00
Aran Ink
93dd25cfe7 Add secure setting for Global Actions Panel debug mode.
Changes grid-based power menu logic to use new debug setting.

Bug: 123397865
Bug: 127644235

Test: Automated tests pass. Manual testing turning off/on debug setting.
Change-Id: Ic95188bd10a433f5c58f0f37a098a872e65d8150
2019-05-09 14:42:14 -04:00
TreeHugger Robot
f992bb99b2 Merge "Apply content capture settings to all users." into qt-dev 2019-05-09 18:27:37 +00:00
Kevin Chyn
c03c8909e5 Merge "Added face education setting" into qt-dev 2019-05-08 23:55:22 +00:00
joshmccloskey
421e2691f3 Added face education setting
Test: It builds
Bug: 131774352
Change-Id: I23cc05838052da7d40223a519bbf99895d165f86
2019-05-08 14:26:31 -07:00
Aran Ink
c8cb13a537 Merge "Add secure settings for Global Actions Panel." into qt-dev 2019-05-08 18:56:26 +00:00
Christine Franks
1da3d01b5e Merge "Validate vendor display color modes" into qt-dev 2019-05-08 17:38:21 +00:00
Aaron Heuckroth
00ff1180b2 Add secure settings for Global Actions Panel.
Test: Automated tests pass.
Fixes: 131751030

Change-Id: I969a56ecc0b9310ed32cd5bd5d8ad0c2499ae63b
2019-05-07 14:59:28 -04:00
Yasmin Molazadeh
04e3a27c12 Merge "Update the contract docummentation regarding UnsupportedOperationException." into qt-dev 2019-05-07 13:07:37 +00:00
Tim Murray
d06c6d2932 Revert "Add optional reasons why permissions were denied"
This reverts commit 3623f3219e.

Reason for revert: 40% startup perf regression

Test: revert
Bug 132129453
Exempt-From-Owner-Approval: critical revert

Change-Id: I19dc33e6a71c9254b4096154f4089c059fe408dd
2019-05-07 07:10:30 +00:00
Christine Franks
c5f0d146db Validate vendor display color modes
Bug: 128607042
Test: atest FrameworksServicesTests:ColorDisplayServiceTest

Change-Id: I78dca7eeb9d4855007b5616b444b2b715860bed1
2019-05-06 12:26:08 -07:00
TreeHugger Robot
dd82c4513b Merge "Add optional reasons why permissions were denied" into qt-dev 2019-05-06 06:21:23 +00:00
Philip P. Moltmann
3623f3219e Add optional reasons why permissions were denied
Currently only for the ContextImpl.enforcePermission code paths and only
when 'secure debug_package_permission_check' is set.

This feature is disabled on user-builds.

Test: Enabled permission checking for my app and
      - checked runtime permision denial
      - permission denial because app is instant
Bug: 111075456
Change-Id: Ib85777db69ee490608e9dac32a3b97971c0ba215
2019-05-05 21:05:13 -07:00
Adam He
27ea41d2fc Apply content capture settings to all users.
Bug: 131748579
Test: manual verification
Change-Id: I35c39120e2a16587ff9b8137149decc94b044577
2019-05-03 16:54:49 -07:00
Salvador Martinez
49d35968e6 Merge "Prevent dark mode backup from applying in before setup" into qt-dev 2019-05-03 18:31:08 +00:00
Yasmin
f50730e3b2 Update the contract docummentation regarding UnsupportedOperationException.
Test: atest ManagedProfileTest#testCrossProfileCalendar
      atest CalendarProvider2Test
Bug: 130284827
Change-Id: I9e98efae6bc7229b995506a542940663c3fbae8f
2019-05-03 16:09:40 +00:00
Salvador Martinez
c500b2741e Prevent dark mode backup from applying in before setup
This CL makes it so that UIModeManager will not allow dark mode
to be changed prior to initial setup wizard being completed.
Additionally, it makes it so that when UIModeManager starts it
will try to start in light mode prior to setup wizard completing
regardless of what the backed up value is. We also register for
an observer if when we start UIModeManager we notice that setup
wizard has not run and defer updating dark mode to the true value
until we see that setup wizard completes.

Test: Manual
Bug: 119666724
Change-Id: Ie9cf36c8483d9cdd9e7aadd3aae4cc0ef15e8d45
2019-05-02 17:59:17 -07:00
Abodunrinwa Toki
0634af3875 Lazy-load textclassifier settings.
Re-enables reading settings from device_config.
See: I6b7ab56e4015448ee068deb49e7f6fa133fea53c
Updates tests.
Updates documentation.

Bug: 129934185
Test: atest android.view.textclassifier
Test: (Performance) Test: frameworks/base/apct-tests/perftests/textclassifier/run.sh
      Compare performance results with ConfigParser.ENABLE_DEVICE_CONFIG
      set to true vs false. Trivial regression recorded i.e. 1.03x.
Test: (Manual) Change flags and see them reflected. e.g.
      adb shell cmd device_config put textclassifier system_textclassifier_enabled false
      Verify that app no longer uses the OEM TCS but the AOSP TC.
Change-Id: I4c6ff781c97fc2e3d3da55dc49123fa1d759670a
2019-05-02 12:55:58 +01:00
TreeHugger Robot
b037feb130 Merge "Fix can't create thumbnail and wrong orientation issue" into qt-dev 2019-05-02 05:01:15 +00:00
TreeHugger Robot
8189440785 Merge "Elevate standby bucket on first foreground service start" into qt-dev 2019-05-02 01:55:12 +00:00
Kweku Adams
4e774a37db Creating separate flags for Time/QuotaControllers.
TimeController and QuotaController flags don't have to be changed
atomically with other JobScheduler constants, so it's best to have them
be separate. I think it's best to have the QuotaController constant
change be atomic, which is why the flag is set up as a key/value pair.

Bug: 120793892
Test: atest android.provider.SettingsBackupTest
Test: atest com.android.server.job.controllers.ConnectivityControllerTest
Test: atest com.android.server.job.controllers.QuotaControllerTest
Test: atest com.android.server.job.controllers.StateControllerTest
Test: atest com.android.server.job.controllers.TimeControllerTest
Test: atest CtsJobSchedulerTestCases
Change-Id: I5bf20c37ea87a58bbcf4326f8e81cd6bea0a7c08
2019-04-30 19:14:03 -07:00
Xiangyu/Malcolm Chen
1342fcd9f8 Merge "Defining intent actions for enabling MMS setting." into qt-dev 2019-04-30 23:05:25 +00:00
Anna Wasewicz
3eb46249bd Merge "Add DeviceConfig flag for ContentSuggestionsService. Test: presubmit Bug: 123289833" into qt-dev 2019-04-30 18:15:09 +00:00
Soonil Nagarkar
c67cc12148 Correct visibility for LOCATION_MODE_ON
As per API feedback in b/126727563, move LOCATION_MODE_ON to SystemApi
instead of deprecated. This is safe as this constant is not used
anywhere yet.

Test: manual
Bug: 126727563
Change-Id: Iddbea546d1585cb8677c4adb97e465d5ac7a76a4
Merged-In: Iddbea546d1585cb8677c4adb97e465d5ac7a76a4
(cherry picked from commit 7449108978)
2019-04-30 01:06:46 +00:00
Anna Wasewicz
3ecea55725 Add DeviceConfig flag for ContentSuggestionsService.
Test: presubmit
Bug: 123289833

Change-Id: I016a7585bc03e25bd494b9e3bd3080416d67ee50
2019-04-29 16:16:22 -07:00
Ivan Chiang
6da7b0adcc Fix can't create thumbnail and wrong orientation issue
- When MediaMetadataRetriever can't create the thumbnail of some
  HEIF files, attempt decoding it from ExifInterface.

- ImageDecoder can't create the thumbnail with getThumbnailBytes
  from ExifInterface in some cases. It will occur DecodeException:
  Failed to create image decoder with message 'unimplemented'Input
  contained an error. Attempt to decoding the full image in these
  cases.

- Use orientation from ExifInterface to transform the thumbnail to
  right orientation.

Test: manual
Test: atest ThumbnailUtilsTest
Bug: 130775874
Fix: 130446058
Change-Id: Icd0726ec49fe85651150736199c3caa184fa1a3f
2019-04-29 21:18:57 +08:00
Julia Reynolds
5b655c3915 Add setting for silent notifs on lockscreen
Test: atest
Bug: 128445911
Change-Id: If07b593aa0588f494691c7399e471a142fb585c6
2019-04-25 10:05:15 -04:00
Sudheer Shanka
cbfe50d70c Merge "Update behavior of some DownloadManager APIs." into qt-dev 2019-04-25 00:51:59 +00:00
TreeHugger Robot
c84e33b3f1 Merge "Remove Settings constants for NetworkStack" into qt-dev 2019-04-24 11:46:25 +00:00
Sudheer Shanka
25f1c6ebeb Update behavior of some DownloadManager APIs.
-- Update behavior of DownloadManager.setDestinationUri(),
   DownloadManager.setDestinationInExternalPublicDir() and
   DownloadManager.addCompletedDownload() based on the latest
   storage re-design. Essentially, going forward these APIs
   will only allow downloading files into package owned dirs
   or the top-level Download dir.
-- Allow some system components to specify
   MediaColumns.OWNER_PACKAGE_NAME when inserting items into
   MediaProvider.
-- Don't copy DownloadManager.COLUMN_TITLE to MediaProvider.
   DownloadProvider and MediaProvider have different constraints
   around "title" and there isn't really a need to keep these
   in sync.
-- Sanity check file download paths hinted by apps.
-- Remove sandbox related logic in DownloadProvider.

Bug: 120879208
Bug: 128630262
Bug: 130797842

Test: manual
Test: atest DownloadProviderTests
Test: atest cts/tests/app/src/android/app/cts/DownloadManagerTest.java
Test: atest cts/tests/app/DownloadManagerLegacyTest/src/android/app/cts/DownloadManagerLegacyTest.java
Test: atest cts/tests/app/DownloadManagerApi28Test/src/android/app/cts/DownloadManagerApi28Test.java
Test: atest cts/tests/tests/provider/src/android/provider/cts/MediaStore*

Change-Id: If48bc9ecf9ed94412c6c62ce4e5e6a55fff9b789
2019-04-23 18:55:51 -07:00
Santos Cordon
623526b4b3 Add delay to power-button power-off after gesture wakeup.
Adds a small delay to avoid turning off the device if the user
hits the power button right after the device wakes up via a gesture.

Bug: 126560003
Test: Manual
Change-Id: I3116ce98f244e5660573d5fa764a77083aee7fc5
2019-04-23 11:55:29 +01:00
Chiachang Wang
4dd1b47b0b Remove Settings constants for NetworkStack
The definitions reference of these constants are moved from
Settings to DeviceConfig. These definitions are @hide and the
usage in the Settings are removed. Thus, remove the definitions
from API level.

Bug: 123167629
Test: make system-api-stubs-docs-update-current-api \
      test-api-stubs-docs-update-current-api
Test: atest NetworkStackTests
Change-Id: I28c4bf2c0b72e154cea91d11007a9497c7f21570
2019-04-23 09:32:14 +08:00
Steve Elliott
2c570c179a Merge "Power key behavior tweaks." into qt-dev 2019-04-19 23:02:08 +00:00
Salvador Martinez
d6aa4d3e8e Merge "Make Settings and SysUI estimates use same data class" into qt-dev 2019-04-19 22:00:27 +00:00
Lei Yu
622d628fa8 Merge "Add DeviceConfig namespace for settings ui" into qt-dev 2019-04-19 19:44:53 +00:00
Salvador Martinez
580098fe44 Make Settings and SysUI estimates use same data class
This moves everything over to using a shared data class
for Estimates in SettingsLib which will facilitate a cl
that will help ensure greater consistency across
surfaces where battery estimates are shown.

Test: Tests pass
Bug: 124030091
Change-Id: I0b7f1f3a806255ff4804a00e6d90a7846c484484
2019-04-19 17:35:20 +00:00
Dan Sandler
b458f4eee8 Power key behavior tweaks.
- Added a new value for config_longPressOnPowerBehavior:
    "5" means "launch assist intent"
  - Added global settings for power key longpress and "very
    long press" (3.5 sec), allowing these functions to be
    tweaked at runtime by privileged code

Bug: 130415373
Test: adb shell settings put global power_long_press 5
      # ^ set longpress to assist
      adb shell settings put global power_very_long_press 1
      # ^ set vlongpress to globalactions (so you can still
      # power off the device)
Test: atest frameworks/base/core/tests/coretests
Change-Id: Ic611b2850dc98fddd7662d32b0a60ca1e8231efb
2019-04-19 16:46:44 +00:00
Malcolm Chen
68d3173108 Defining intent actions for enabling MMS setting.
Bug: 130222866
Test: manual
Change-Id: I6d0310c8b08195a3e9e155e7d9647566fc3fe5ca
2019-04-18 16:51:24 -07:00