This was a regression introduced in ag/17913997 because
I missed that the legacy code included the ternary
`? 0 : 1` to convert from boolean to int value in this
(not-type-safe, see b/231577676) API call.
Bug: 231491021
Bug: 231577676
Test: compile/presubmit. This doesn't prove that the fix
works (we must just not have coverage, or we would've
caught the regression the first time) but it does validate
the syntax and confirm that there are no other unintended
changes (stray keystrokes...). The fix is trivial; this CL
simply restores the exact behavior pre- ag/17913997.
Change-Id: I706dee50e074da3ca40cde5b83abfd076a271959
* changes:
If something is suppressed from the notification list don't bubble it
Tell NoMan to update the auto-expand flag
Allow SysUI to update BubbleMetadata#FLAG_AUTO_EXPAND_BUBBLE
Includes general information as well as the system and app actions (or
media actions if there are no app actions)
Bug: 204173025
Bug: 199490119
Test: manual - check notification content from aosp notification listener
Change-Id: I6a15e443ad8f1fa17bd76e52c002909faa1c44db
The PositionUpdateListener sometimes gets called after the
FrameDrawingCallback, because there is no ordering guarantee between
these two callbacks. This causes the BlurRegions sent to SF to
not have up-to-date positions. For example, an empty Rect gets sent
as the blur region bounds, because the position update hasn't arrived
when the surface transaction is sent. When the position update arrives
it set the correct bounds, but it requires another draw to happen so
that the correct position is picked up.
This CL fixes this issue by saving the blur regions that were last sent
to SF in FrameDrawingCallback and sending another transaction when the
position update arrives. That transaction is merged into the previous
one for the same frame, so the final transaction sent to SF has correct
values.
The CL also moves the FrameDrawingCallback registering logic entirely in
the BlurAggregator in the first onPreDraw. This cleans up VRI
Bug: 197239228
Test: atest --iterations 100 BlurTest#testBackgroundblurSimple
Test: atest BlurAggregatorTest
Change-Id: Ia122df40fdf2aa124299461c2e2597b61fa92699
We currently close the IME by having the target application forward KEYCODE_BACK to the IME process through InputMethodManager#dispatchInputEvent and having the IME handle the keycode in InputMethodService#onKeyDown. When apps opt in to OnBackInvokedDispatcher API, we will not dispatch KEYCODE_BACK to apps anymore. Thus we need to migrate IME to the new API for it to close on back invocation.
This implementation forwards OnBackInvokedCallbacks from the IME process
to the app process. This is necessary because all callbacks need to
exist in the app process for them to be considered by hardware back keys. While back gestures go through WM to resolve callbacks from the focused window, hw keys are directly sent to the focused window's ViewRootImpl, bypassing server side back nav logic.
Bug: 228358882
Test: atest CtsInputMethodTestCases:KeyboardVisibilityControlTest
Test: atest CtsInputMethodTestCases:InputMethodServiceTest
Test: atest CtsInputMethodTestCases
Change-Id: Ie207b63b11a56c9b2173f26b734a27b13ebccc60
Will do further reductions later with a slower rollout.
Bug: 224816815
Test: atest ChooserActivityTest
Change-Id: I9c00137d73febca8f8576e579e55157aa1bd05fe
Also add a default onStopTrackingTouch() method in the
SeekBarVolumizer.Callback to let Settings inject the jank monitor.
Bug: 230285829
Test: make build
Change-Id: I9f5f511183f62caf809d7326766549b87d226b0b
Modernize the tabs in Sharesheet/Resolver to match All Apps.
Much of this is copied from the tabs implementation in All Apps.
Remove divider line below tabs (no longer needed).
More XML, less code.
Bug: 188589041
Test: Manual in light and dark themes
Test: atest ResolverActivityTest
Test: atest ChooserActivityTest
Change-Id: Ib23a1927d416d32714dd8c890dd412c73f9e573c
This flag should only really be applied to a notification bubble
one time. Once the bubble has auto-expanded (or if it was posted and
unable to auto-expand at that time due to something like DND), the
flag should be removed so we don't auto-expand it again.
We have a method that allows us to modify some specific flags on
BubbleMetadata. This CL updates that method to be more general and
work with any of the BubbleMetadata flags.
Bug: 226316876
Test: atest NotificationManagerServiceTest
Change-Id: Ib9653ed304f13ac88f489146d503f4de4fa29421
As noted in the linked bug, in certain scenarios IC established callback
is not always called. As a fix, we make sure we don't return early when
MSG_BIND callback is received from IME
Fix: 228105257
Bug: 217971553
Test: atest StylusHandwritingTest#testHandwritingEndToEnd
Change-Id: I780327003f7145c4f9b9df4dc5243227d7e67d92
