Commit Graph

6274 Commits

Author SHA1 Message Date
Alan Viverette
a019841dd1 Merge "Add consistent @NonNull annotations for drawable callbacks" into nyc-dev am: 79936ddda4
am: a3710fbd27

* commit 'a3710fbd2780fe6decd11d2bc259f0c3b6e28f71':
  Add consistent @NonNull annotations for drawable callbacks
2016-03-11 18:59:49 +00:00
Alan Viverette
79936ddda4 Merge "Add consistent @NonNull annotations for drawable callbacks" into nyc-dev 2016-03-11 18:42:43 +00:00
Alan Viverette
146dbea111 Merge "Add temporary logging to SimpleMonthView" into nyc-dev am: d969cc6856
am: 9f4f4f3962

* commit '9f4f4f39623322776d94b9636ee1e8a16265e89c':
  Add temporary logging to SimpleMonthView
2016-03-11 15:14:36 +00:00
Alan Viverette
f6d87ec193 Add consistent @NonNull annotations for drawable callbacks
Bug: 27599515
Change-Id: I33fdc5392302403bfff9cc74a8226173ec962af6
2016-03-11 10:09:14 -05:00
Alan Viverette
d969cc6856 Merge "Add temporary logging to SimpleMonthView" into nyc-dev 2016-03-11 15:08:25 +00:00
Keisuke Kuroyanagi
2b8c98187b Merge "Fix: Context menu can contain obsolete suggestions." into nyc-dev am: 13d66d8456
am: f6c1149985

* commit 'f6c1149985b6dff5c17af1d8b4eb7a0da3257456':
  Fix: Context menu can contain obsolete suggestions.
2016-03-11 11:35:03 +00:00
Keisuke Kuroyanagi
182f5fec53 Fix: Context menu can contain obsolete suggestions.
When there are not enough number of suggestions, previously used
suggestions was continue to be used. This fixes it and simplifies code
by always allocating SuggestionInfo array.

Bug: 27602619
Change-Id: I9378315b8c810f126f65fade96ce9f6ff5271957
2016-03-11 10:08:11 +00:00
Keisuke Kuroyanagi
7ee08071ee Merge "Reset mWordIteratorWithText when SpellChecker locale is changed." into nyc-dev am: 01ef02d785
am: 5b47ae745f

* commit '5b47ae745fd0e2e3ad176912b18701974274e074':
  Reset mWordIteratorWithText when SpellChecker locale is changed.
2016-03-11 05:51:22 +00:00
Keisuke Kuroyanagi
01ef02d785 Merge "Reset mWordIteratorWithText when SpellChecker locale is changed." into nyc-dev 2016-03-11 05:43:19 +00:00
Raph Levien
9593c1334e Merge "Invalidate TextView on change of elegantTextHeight" into nyc-dev am: a4750fd71d
am: 8c8e942b50

* commit '8c8e942b50de7e3a765e339b30adbe2d43443874':
  Invalidate TextView on change of elegantTextHeight
2016-03-11 01:37:35 +00:00
Raph Levien
a4750fd71d Merge "Invalidate TextView on change of elegantTextHeight" into nyc-dev 2016-03-11 01:26:52 +00:00
Raph Levien
25ff8a53a3 Invalidate TextView on change of elegantTextHeight
Previously we were setting the paint but not invalidating, so it
could show stale content.

Bug: 27572149
Change-Id: I668667ec5b95a96e31a58cff0f8bbbb9958e470c
2016-03-09 13:30:55 -08:00
Alan Viverette
799c311d83 Merge "Clean up SimpleMonthView formatters" into nyc-dev am: 366e137c0e
am: 60adb4d264

* commit '60adb4d264fd4be3277a5b80d8021aa1b4d79107':
  Clean up SimpleMonthView formatters
2016-03-09 18:51:00 +00:00
Alan Viverette
da7cc2d2ae Add temporary logging to SimpleMonthView
We can remove this once we figure out why the dates are messed up.

Bug: 27310206
Change-Id: I34fff5251124cc0867955255189ed323dc7170c1
2016-03-09 13:41:58 -05:00
Alan Viverette
366e137c0e Merge "Clean up SimpleMonthView formatters" into nyc-dev 2016-03-09 18:40:47 +00:00
Keisuke Kuroyanagi
5f35184834 Merge "Make drag&drop be atomic for undo/redo." into nyc-dev am: 12298bb64c
am: 195c688756

* commit '195c6887564ab3fba8716b01d083f87de9c2e945':
  Make drag&drop be atomic for undo/redo.
2016-03-09 07:20:17 +00:00
Keisuke Kuroyanagi
e0ac5ac6f0 Reset mWordIteratorWithText when SpellChecker locale is changed.
Bug: 27537808
Change-Id: Ic55b543456cc859673b4c17cc5bf6e4b6da21e13
2016-03-09 15:33:30 +09:00
Keisuke Kuroyanagi
fae4578311 Make drag&drop be atomic for undo/redo.
For undo/redo, drag&drop is recorded as a 2 operations, paste and
delete. This CL makes drag&drop be atomic operation to be properly
undoed/redoed.

Bug: 27268820
Change-Id: Ia38d663f046c2c65f348985934f5cfa054b0437e
2016-03-09 06:07:01 +00:00
Keisuke Kuroyanagi
d52e4a28e8 Fix: Selection is not correctly used for SuggestionsPopup. am: 713be06f7a
am: f0772438c6

* commit 'f0772438c64f46f612c5dfc8737bb929ebc4f224':
  Fix: Selection is not correctly used for SuggestionsPopup.
2016-03-08 08:40:52 +00:00
Keisuke Kuroyanagi
713be06f7a Fix: Selection is not correctly used for SuggestionsPopup.
This happens because suggestions are gathered based on the
selection after setting the cursor position to the middle
of the user selected range, which means 0-width selection
at that position. As a result, SuggestionsPopup was not
shown when any suggestion spans don't overlap middle point
of the selection.

Bug: 20709442
Change-Id: I3e1cb570f451b4ab14cf36f7da23dc2bd22f4ac8
2016-03-08 08:32:28 +00:00
Keisuke Kuroyanagi
2ef67b0614 Merge "Call View#setHasTransientState in TextView#spanChange." into nyc-dev am: 40fd5fac48
am: 6bb63dc339

* commit '6bb63dc3396795e0e895460339874acfc3824912':
  Call View#setHasTransientState in TextView#spanChange.
2016-03-08 07:37:40 +00:00
Keisuke Kuroyanagi
40fd5fac48 Merge "Call View#setHasTransientState in TextView#spanChange." into nyc-dev 2016-03-08 07:28:34 +00:00
Keisuke Kuroyanagi
af4caa6006 Call View#setHasTransientState in TextView#spanChange.
setHasTransientState(true) and setHasTransientState(false) have to
be coupled, but they were not always coupled in TextView. e.g. when
we fire PROCESS_TEXT intent.
With this CL, TextView calls setHasTransientState() always when
selection is created or cleared to make sure 2 setHasTransientState
calls are always coupled.

Bug: 27409041
Change-Id: Ib454b0fbbc2c2f8d19818f154f415c4a5d7e2d7e
2016-03-08 04:58:46 +00:00
Yohei Yukawa
93cda9a0e9 Merge "Ensure PopupDecorView is not IME-focusable during exit transition." into nyc-dev am: 64177e51e4
am: b5069e05e0

* commit 'b5069e05e04ea34631b366fcd99519974f71fdbf':
  Ensure PopupDecorView is not IME-focusable during exit transition.
2016-03-07 19:33:53 +00:00
Yohei Yukawa
64177e51e4 Merge "Ensure PopupDecorView is not IME-focusable during exit transition." into nyc-dev 2016-03-07 17:47:48 +00:00
Yohei Yukawa
dbd299de2a Ensure PopupDecorView is not IME-focusable during exit transition.
Currently PopupDecorView temporarily gets FLAG_NOT_FOCUSABLE bit during
exit transition.  When doing this we it is important that PopupDecorView
does not have FLAG_ALT_FOCUSABLE_IM bit, because having both
FLAG_NOT_FOCUSABLE and FLAG_ALT_FOCUSABLE_IM means that PopupDecorView
is IME-focusable.

To prevent IMEs from flickering, this CL ensures that PopupDecorView is
not IME-focusable during exit transition.

Bug: 27396330
Change-Id: I0cc81791b826f7d4257f0b6085c028c796fd9536
2016-03-06 22:27:40 -08:00
Keisuke Kuroyanagi
3558cbad42 Merge "Try to find equivalent SuggestionsSpan when it has been updated." into nyc-dev am: 15ae7c1328
am: a1fd59019e

* commit 'a1fd59019e89903b6bcd9b67fe24fc19a75e1d37':
  Try to find equivalent SuggestionsSpan when it has been updated.
2016-03-07 02:55:46 +00:00
Keisuke Kuroyanagi
15ae7c1328 Merge "Try to find equivalent SuggestionsSpan when it has been updated." into nyc-dev 2016-03-07 02:48:17 +00:00
Adam Powell
6b0487558b Merge "Stop ProgressBar animations when not visible" into nyc-dev am: 92e84089c4
am: 24e592a5e3

* commit '24e592a5e3a9e85cf1412f8555054c2e9911e484':
  Stop ProgressBar animations when not visible
2016-03-04 19:39:15 +00:00
Adam Powell
92e84089c4 Merge "Stop ProgressBar animations when not visible" into nyc-dev 2016-03-04 19:27:17 +00:00
Alan Viverette
e264f9503b Clean up SimpleMonthView formatters
Only generates the month and day of week labels when necessary, rather
than every time the headers are drawn.

Change-Id: Ia20042753cba08bc6b29d4defb312617a2691016
2016-03-04 13:18:48 -05:00
Adam Powell
c1bba9b9f8 Stop ProgressBar animations when not visible
Propagate setVisible calls to current drawable. Take window visibility
into account when determining drawable visibility.

Bug 27461595

Change-Id: Ia1de1d1686f26c2cf27630c5bde70f23c2c332bd
2016-03-04 10:15:35 -08:00
The Android Automerger
1ccd57a91c Merge commit '22e01d5611d14cc04055b8abcbd1e8c114a0853c' 2016-03-04 01:05:11 +00:00
Keisuke Kuroyanagi
bd4b217a28 Merge "Refresh action mode always when selection is modified." into nyc-dev 2016-03-04 00:53:59 +00:00
Keisuke Kuroyanagi
c1cd17f918 Merge "Supress SuggestionPopup for original field." into nyc-dev 2016-03-03 23:34:51 +00:00
Seigo Nonaka
1e99420e74 Merge "Fix unexpected ellipsize for long suggestion text." into nyc-dev am: 71208d6f7b
am: e40ab5d564

* commit 'e40ab5d564168bd7e0c5e24b12b4b3b05c650663':
  Fix unexpected ellipsize for long suggestion text.
2016-03-03 21:26:46 +00:00
Seigo Nonaka
71208d6f7b Merge "Fix unexpected ellipsize for long suggestion text." into nyc-dev 2016-03-03 20:20:45 +00:00
Siyamed Sinir
981250bf50 Merge "TextView should fade edges according to text." into nyc-dev am: 1ca7c80844
am: 7919b1f7e5

* commit '7919b1f7e54347929594716e5f358e11fd673d17':
  TextView should fade edges according to text.
2016-03-03 19:01:47 +00:00
Siyamed Sinir
24d606a74a Merge "Update EditText.setEllipsize JavaDoc" into nyc-dev am: 15dfbdd0ea
am: ea87a00927

* commit 'ea87a009271a15af0010f2ac86857ea9efc46dc3':
  Update EditText.setEllipsize JavaDoc
2016-03-03 18:52:18 +00:00
Siyamed Sinir
1ca7c80844 Merge "TextView should fade edges according to text." into nyc-dev 2016-03-03 18:43:23 +00:00
Siyamed Sinir
192d3bdaaf Update EditText.setEllipsize JavaDoc
Update EditText.setEllipsize JavaDoc to describe that MARQUEE is not
supported by EditText.

Bug: 26219977
Change-Id: Ibe709f3470a749c0fbb672c8ec33f0835c5d90ec
2016-03-02 14:11:56 -08:00
Yigit Boyar
786f71ef01 Merge "Check if item is selectable before calling on click" into nyc-dev am: 5ae74b7fa6
am: 82036dbe65

* commit '82036dbe6569c807500836d624e1187ed0bb2449':
  Check if item is selectable before calling on click
2016-03-02 06:20:29 +00:00
Alan Viverette
26daa2c7f6 Merge "Use Holo date/time picker layouts on very small screens" into nyc-dev am: 90ed1eca3e
am: 80e6a6a696

* commit '80e6a6a6964c64073fc51b5b5655092132cdaaeb':
  Use Holo date/time picker layouts on very small screens
2016-03-02 06:00:43 +00:00
Yigit Boyar
5ae74b7fa6 Merge "Check if item is selectable before calling on click" into nyc-dev 2016-03-02 00:36:50 +00:00
Yigit Boyar
418d0cf5c9 Check if item is selectable before calling on click
This CL fixes a bug in ListView where it might call onClick on an
un-clickable if a new touch arrives before up timeout.

We could actually consider making child position non-changable
but that will change behavior. This seems safer approach.

Bug: 27198796
Change-Id: I7b15d04efa19d1d760a294bd027f3da3aaa3a445
2016-03-01 16:09:58 -08:00
Alan Viverette
90ed1eca3e Merge "Use Holo date/time picker layouts on very small screens" into nyc-dev 2016-03-01 23:13:43 +00:00
Alan Viverette
6b3f85f87e Use Holo date/time picker layouts on very small screens
If the screen is smaller than "small" then use the Holo picker layouts.
Unifies the SavedState between delegates so that we can seamlessly
transition between them during configuration changes. Pushes the
DatePickerSpinnerDelegate up to the same level as the calendar delegate.

Bug: 27239893
Change-Id: Ida4dc2748d38bd766ae93d12aef15e963921939c
2016-03-01 16:48:04 -05:00
Andreas Gampe
23f4594523 Merge "Frameworks/base: Refactor TextView initialization" into nyc-dev am: 4f655de3de
am: 0f6f34b4eb

* commit '0f6f34b4ebd0c0b300a57a8e5cc86c95a70458b4':
  Frameworks/base: Refactor TextView initialization
2016-03-01 20:02:51 +00:00
Andreas Gampe
4f655de3de Merge "Frameworks/base: Refactor TextView initialization" into nyc-dev 2016-03-01 18:38:09 +00:00
Seigo Nonaka
f47976e7b4 Fix unexpected ellipsize for long suggestion text.
Unexpected ellipsize issue happens after
Ic8445022634e9130f9462e02bfb08d4877396ba3. By setting match_parent to
ListView, the ListView does not expand to fit the suggestion item.

Thus, explicitly setting the ListView width instead of setting
match_parent or wrap_content.

I manually verified this CL does not revive Issue 27341560 or
unexpected ellipsize for shorter text.

Bug: 27341560
Change-Id: I69b258687b4bf5510d9b2c3e690c88106bf893f5
2016-03-01 17:24:07 +00:00