Commit Graph

2200 Commits

Author SHA1 Message Date
Gilles Debunne
ea1c7f3c51 Merge "Bug 5248215: Even though I turned off the Spelling correction, it still shows up" 2011-09-26 10:38:58 -07:00
Adam Powell
53f56c4f51 Fix bug 5358705 - Request no full-screen mode of the IME when a
SearchView is expanded in an action bar

This is a case where we always know there will be room on screen for
the user to meaningfully use the UI in the absence of full-screen
extract mode. Save the old state and restore it when we go in and out
of expanded action bar mode.

Change-Id: I4ae2c5df4f581c6824e6a1f7ff8d97fd86d8e260
2011-09-25 13:50:57 -07:00
Svetoslav Ganov
83a559e78f Merge "Scroll accessibility events should not populate text." 2011-09-23 13:26:18 -07:00
Gilles Debunne
186aaf9735 Bug 5248215: Even though I turned off the Spelling correction, it still shows up
Bug 5313754: SpellCheckSession is released when the window loses focus.

When an EditText is initialized with text, a new spell check is initiated
and previous spell check spans are removed.
Requires a new flag to prevent this from happening when the window focus
change comes from the suggestion popup window being shown.

Also fixes bug 5329588: handle spell check language change.

This change has been reverted. This amended change defers the creation
of the SpellChecker, so that it is only created for editable TextView.

Patch 3: Bug 5332065, the spell check session is closed in onDetachedFromWindow, which is
called when the window is destroyed (like on rotation), which was not the case with
onWindowFocusChanged.

Patch 5: Fixed life cycle. A view can be created and never attached to the hierarchy. As
a result, the spellCheck session would not be closed. Moved spell check to onAttach and
perform a spell check when text is changed by setText only if the view has previously
been attached (and the spellChecker has been created).

Change-Id: Ic2cfbfc0d3f23c589dd9e37f02e4afc1d625615d
2011-09-23 10:16:01 -07:00
Svetoslav Ganov
b84b94e1a0 Scroll accessibility events should not populate text.
Scroll events are used to report position change and should not
contain the text content of the view that fires them because it
is usiually a containter for many other views and the text will
be long and not informative for accessibility purposes. Also
such evens are fired relatively frequently. If a client wants
to fetch some textual content for a scroll event he can use
the interrogation APIs.

bug:5352059

Change-Id: I43e02aca895c8ab16ba82ebe1cee3aea8ce7711a
2011-09-22 19:55:47 -07:00
Svetoslav Ganov
1ac6b1e221 Merge "ActivityChooserView not showing "Show all" properly if the default target button not shown." 2011-09-22 19:08:26 -07:00
Svetoslav Ganov
f632eaa9d6 ActivityChooserView not showing "Show all" properly if the default target button not shown.
If the default target button is hidden all activities are shown in the list from
which to choose. In this case due to off by one error the list was not showing the
option to expand it if the activities are one more than the initially shown.

bug:5358475

Change-Id: I8c3db37dab008637d78330f8de830cec92720264
2011-09-22 16:09:46 -07:00
Adam Powell
823f074a73 Fix bug 5300621 - Share menu disappears in gallery
ActionProviders (or action views) unfortunately had no way to report
that they had opened a sub-UI that would affect menu visibility
listeners used to hide action bars when not in use. This caused the
Gallery UI to hide its action bar when the share popup was open.

Add hidden API (to be made public later) to ActionProvider that can be
used to inform the menu system that a sub UI has opened or
closed. Account for this in menu visibility callbacks. Fix
ShareActionProvider to use this when its popup windows open and close.

Fix a regression where submenus were not properly reporting visibility
changes.

Change-Id: Ia6f45fb463ad106105c40d01f141c2e5c8b96f78
2011-09-21 17:21:47 -07:00
Gilles Debunne
a80599f5be Revert "Bug 5248215: Even though I turned off the Spelling correction, it still shows up"
This reverts commit 6e405f84b8.

Change-Id: I9593273d414aee1f9817f84b462cf45360ff19e3
2011-09-21 10:58:03 -07:00
Chih-Chung Chang
d1396fbc64 Fix 5229466: don't consume pointer events outside the window
Change-Id: Ifa3d1d5edd81346e6ca80e113f80914ee2c47055
2011-09-21 15:56:26 +08:00
Gilles Debunne
576b6bb2f9 Merge "Bug 5248215: Even though I turned off the Spelling correction, it still shows up" 2011-09-20 18:02:45 -07:00
Svetoslav Ganov
4877b85aea Merge "ActivityChooserView not showing highest ranked target if default action not shown." 2011-09-20 17:41:59 -07:00
Svetoslav Ganov
efab4e7f59 ActivityChooserView not showing highest ranked target if default action not shown.
The view was not showing the highest ranked activity if the default action
button was not shown (happens if no history is present).

bug:5224159

Change-Id: I66536513e14496568ea2034467bd29ea4bc93cdb
2011-09-20 15:13:35 -07:00
Svetoslav Ganov
d37848af08 TextView not adding text to accessibility events.
Reversed conditional.

bug:5342756

Change-Id: Ia2a523af6f7b12e27275e6095ea1b137768ea14c
2011-09-20 14:03:59 -07:00
Justin Ho
f2ff20e05b Merge "Tuning Overscroller's scroll curve Softer end + rounder curve with less contrast Bug: 5200575" 2011-09-19 18:06:13 -07:00
Justin Ho
a181bb4b8c Tuning Overscroller's scroll curve
Softer end + rounder curve with less contrast
Bug: 5200575

Change-Id: Icff6ba3cf7ae052c80b2e80e2d2b07085fcb40ce
2011-09-19 17:52:06 -07:00
Gilles Debunne
6e405f84b8 Bug 5248215: Even though I turned off the Spelling correction, it still shows up
Bug 5313754: SpellCheckSession is released when the window loses focus.

When an EditText is initialized with text, a new spell check is initiated
and previous spell check spans are removed.
Requires a new flag to prevent this from happening when the window focus
change comes from the suggestion popup window being shown.

Also fixes bug 5329588: handle spell check language change.

Change-Id: I113229dbe06863d34c1369d05d067292894f73f1
2011-09-19 10:57:22 -07:00
Dianne Hackborn
bc82385706 Fix issue #5260129: Suggestion strip in Talk app not showing all the time
Change-Id: Ibac6138f3b3b0c3850a30d2c432495aa57b7f3f1
2011-09-19 10:41:43 -07:00
Philip Milne
a93909792c Merge "Fix for http://b/issue?id=5297155" 2011-09-19 10:18:36 -07:00
Adam Powell
cbff417962 Fix bug 5143751 - cts errors in android.app.cts.AlertDialog_BuilderTest
Change-Id: Ic532785d2c52bf65c3884665ffc53aabdf3253b9
2011-09-18 17:49:27 -07:00
Adam Powell
8ee6d7c20e Fix bug 5333962 - Problems with no action bar/overlay action mode
Change the standalone action mode window for overlay mode to be of
TYPE_APPLICATION. (This also fixes a bug where overflow menus would
not work properly on these types of action mode bars.)

Set exitFadeDuration on btn_cab_done_holo_* drawables.

Remove no-window-focus override selector states for selectable item
backgrounds to allow proper touch feedback on windows that do not have
focus but that the user can interact with.

Change-Id: Ib504866238708150d21e6183ff7b695869c05d3e
2011-09-18 15:34:00 -07:00
Philip Milne
f6679c88d1 Fix for http://b/issue?id=5297155
. Make GridLayout dynamic (see below)
. Change access modifiers from private to package private
  (to remove access$XX methods generated by compiler)
. Make private internal classes final (+10% perf)
. Update javadoc and add limitations section
. Improve error diagnostics

The bug above highlights the fact that GridLayout is a static
rather than dynamic layout - i.e. that the structure of the
grid could not be changed once it had been set up. This fix changes
GridLayout to a dynamic layout in which changes to its orientation,
rowCount and columnCount properties may be effected between layout
operations.

This change does not require a change to GridLayout's public API.

Change-Id: If5643574422dcfd3a557ce4db2bb19498dc6ecd8
2011-09-18 13:10:54 -07:00
Jeff Brown
92061b70be am 79aa4030: Merge "Can\'t stop the fling! Bug: 5335420" into ics-factoryrom
* commit '79aa40302b643ee6c6227ee354a1b1378e721568':
  Can't stop the fling! Bug: 5335420
2011-09-16 23:30:52 -07:00
Jeff Brown
b0c71eb9f5 Can't stop the fling!
Bug: 5335420

Fixed a bug in VelocityTracker where the output velocity was
not being set to zero when not available.

Added a condition to ensure that the velocity is at least
the minimum fling velocity before continuing.  If not, then
the user is trying to stop the fling and scroll more precisely.

Change-Id: I36634b0c3f7a9a09cf20c33f71d41163a8e33eed
2011-09-16 21:43:58 -07:00
Romain Guy
f18c8ddd0f Clarify documentation of AdapterView.OnItemSelectedListener
Bug #5331587

Change-Id: Ic3d6aca573639d6cae3abb45bfe821f5fd31f1bc
2011-09-16 16:16:36 -07:00
Adam Powell
1451f1821d Merge "Update docs for RelativeLayout to better explain its interpretation of gravity." 2011-09-15 15:02:55 -07:00
Gilles Debunne
a0383f7212 Merge "Bug 5319091: Completions delayed in AutoComplete in landscape" 2011-09-15 14:51:35 -07:00
Adam Powell
1fec24e0ff Update docs for RelativeLayout to better explain its interpretation of
gravity.

Change-Id: Ie52dc23458c73dfb7fdbf929b802f968ef905557
2011-09-15 14:49:19 -07:00
Svetoslav Ganov
98c8b52b0a Merge "TextView should report in an AccessibilityNodeInfo's text its hint if the View text is empty." 2011-09-15 13:11:44 -07:00
Svetoslav Ganov
4c94936511 Merge "CalendarView diregarding XML attributes." 2011-09-15 13:11:08 -07:00
Gilles Debunne
0fd7e087eb Merge "Bug 5299484: Recipient address in to field is doubled when entering in landscape mode" 2011-09-15 12:43:51 -07:00
Svetoslav Ganov
ab5a4057e7 TextView should report in an AccessibilityNodeInfo's text its hint if the View text is empty.
1. TextView was reporting only its text as the text of the emmited AccessibilityNodeInfo
   not using the hint if the text is empty which is inconsistent with the handling of
   accessibility events.

2. TextView was using the contentDescription in AccessibilityEvents if its
   text and hint are empyty. However, the content description is reported as
   a separate event property and it is incorrect to report it as the text.

bug:5129138

Change-Id: I1c9270459cb07650a0ec5181cc4a01993dde3b5c
2011-09-15 11:30:06 -07:00
Svetoslav Ganov
f1189e9a46 CalendarView diregarding XML attributes.
1. CalendarView was disregarding XMl attributes.

2. CalendarView was trying to set the current date
   to today without checking where today is between
   min and max date.

bug:5116456

Change-Id: Ie5a81826a3cd028f42e18a7985461fa283839171
2011-09-15 11:26:08 -07:00
Gilles Debunne
d513e9746f Bug 5319091: Completions delayed in AutoComplete in landscape
The filtering is an async process. We need to re-update completion
when it is finished.

Changed loogic to mimic the way it was done in GB.

Change-Id: If49048d786b3b9529da55c7247e7ef5f3d0fc8b5
2011-09-15 11:03:56 -07:00
Dianne Hackborn
df82905cf3 Merge "Update the public APIs for finding views by text to optionally use content description." 2011-09-14 22:33:54 -07:00
Svetoslav Ganov
ea515aeafa Update the public APIs for finding views by text to optionally use content description.
1. Added flags to the search method to specify whether to match text or
   content description or both.

2. Added test case for the seach by content description.

3. Updated the code in AccessibilityManager service to reflect the latest
   changes there so test automation service works - this is the fake
   service used for UI automation.

Change-Id: I14a6779a920ff0430e78947ea5aaf876c2e66076
2011-09-14 19:40:33 -07:00
Svetoslav Ganov
de16e00f6d Merge "TimePicker CTS test failing." 2011-09-14 19:07:23 -07:00
Svetoslav Ganov
11c9132818 TimePicker CTS test failing.
TimePicker code for setting the IME options was not taking into
account the old style of the UI where the AmPm spinner can be
null.

bug:5318844

Change-Id: I58b1781ef95398d11ecf0ca5bb49817cbba97b54
2011-09-14 18:35:48 -07:00
Gilles Debunne
688df79243 Bug 5299484: Recipient address in to field is doubled when entering in landscape mode
A tap on a completion in the keyboard calls onCommitCompletion, which in turn calls
performCompletion because of the DropDownItemClickListener.

As a result, the text is replaced twice. Removing the first text replacement.

Change-Id: I4974d23c68ab25ca0ad0cda5abf25f30129b28ee
2011-09-14 15:52:07 -07:00
Adam Powell
149cecdc78 Merge "Bug 5151927 - Monkeys should not play with detached lists." 2011-09-14 14:54:23 -07:00
Adam Powell
a2b986e72c Bug 5151927 - Monkeys should not play with detached lists.
Don't process ListView key events while detached from a window.

Change-Id: Ibf85e081887d47834a467f9fd2cb6a1e39b4857e
2011-09-14 14:21:33 -07:00
Gilles Debunne
bd4016e9c8 Bug 5295607: IOOB problems in Suggestions
The start and end of the suggestion span were cached, where as
they should be retrieved when the user clicks since text may have
changed in the meantime.

Change-Id: Iab47f9969d538d8213a8c5b76b4b7ace8dc9428e
2011-09-14 10:10:49 -07:00
Adam Powell
5c3a77c0ff Un-force fading edges in ListPopupWindows.
Change-Id: Iefb1f64b1f8927fd3c29a8d448a1517afac1ffe1
2011-09-13 21:43:29 -07:00
Adam Powell
1e83b3e6ab Fix bug 5312352 - ListView modal multi-select mode bugs
When the provided callback returned false for creating the mode, the
item was still getting checked and the bar was flickering. Don't do
that.

Change-Id: I384962742edeac0c43aec6f7898bd50dab064738
2011-09-13 18:13:31 -07:00
Fabrice Di Meglio
d309a0434a Merge "Fix bug #5282141 ScrollView overscroll should not generate invalidations when not needed (ANR textview redraws constantly when touched)" 2011-09-13 15:35:06 -07:00
Fabrice Di Meglio
e9dbef85d3 Fix bug #5282141 ScrollView overscroll should not generate invalidations when not needed (ANR textview redraws constantly when touched)
- check if the overscroll range is not 0
- check if we are in the correct overscroll mode
- also udpate HorizontalScrollView the same way

Change-Id: I0bb37f9813a5871eb856914786db5c06de59e4d3
2011-09-13 13:47:20 -07:00
Adam Powell
ac126be503 Merge "Fix bug 5226097 - App compatibility issues around new ListView fixes" 2011-09-13 13:40:07 -07:00
Adam Powell
247a0f0a16 Fix bug 5226097 - App compatibility issues around new ListView fixes
Only dispatch change events when headers/footers change if we have an
adapter.

Change-Id: Ic5d68ea214196771d76f6a88186aaf5f8ed4c4cf
2011-09-13 13:11:29 -07:00
Gilles Debunne
18b4311922 Merge "Bug 5281947: add to dictionnary option promoted in suggestions." 2011-09-13 12:38:03 -07:00
Jeff Sharkey
883adec771 Merge "Handle data changed during FlingRunnable." 2011-09-12 18:28:15 -07:00