Commit Graph

994 Commits

Author SHA1 Message Date
Felipe Leme
f9a9bbf430 Merge "Use initial value on save when value didn't change." into oc-dev am: 2e723982d5
am: 08365011a2

Change-Id: I38b2e8096b7fe43a294afe400af093b49616335d
2017-06-07 00:57:16 +00:00
Felipe Leme
2e723982d5 Merge "Use initial value on save when value didn't change." into oc-dev 2017-06-07 00:25:11 +00:00
Felipe Leme
e8f6808079 Use initial value on save when value didn't change.
Otherwise, it will fail to call onSaveRequest() in scenarios where the service
required a field that was pre-populated for the app. For example, when the
service requires both a username and password, the app pre-populates the
username, and the user fills the password.

Test: new LoginActivityTest.testSaveOnlyTwoRequiredFieldsOnePrefilled() pass
Test: existing CtsAutoFillServiceTestCases pass

Bug: 62270740

Change-Id: Idbb11a8c2dab6741c18549c55dfdb71b483c2447
2017-06-06 13:49:42 -07:00
Jeff Sharkey
ec68b46bc8 Merge "Annotate @SystemApi with required permissions." into oc-dev am: c1406978a4
am: 7a2e4a8486

Change-Id: Ib629e25dbf047c110feaf03e4ff744b5c6df9aeb
2017-06-06 15:48:24 +00:00
Jeff Sharkey
d86b8fea43 Annotate @SystemApi with required permissions.
Most @SystemApi methods should be protected with system (or higher)
permissions, so annotate common methods with @RequiresPermission to
make automatic verification easier.

Verification is really only relevant when calling into system
services (where permissions checking can happen on the other side of
a Binder call), so annotate managers with the new @SystemService
annotation, which is now automatically documented.

This is purely a docs change; no logic changes are being made.

Test: make -j32 update-api && make -j32 offline-sdk-docs
Bug: 62263906
Change-Id: I2554227202d84465676aa4ab0dd336b5c45fc651
2017-06-05 13:27:11 -06:00
Chris Wren
5a406e996c Merge "add channel and group tags to the notificaiton logs" into oc-dev am: 76e76a5c26
am: 6b88afda65

Change-Id: I840c89e34b00cf505e50897bc7ba433f37a67dff
2017-06-02 22:51:15 +00:00
Chris Wren
b39217972e add channel and group tags to the notificaiton logs
Change-Id: Icf029e42fca46262c9d9f8ff63f26de098f888bf
Fixes: 37714086
Test: runtest systemui-notification
2017-06-02 16:19:13 -04:00
Winson Chung
a9861756b5 Merge "Prevent showing voice session when it is already queued to be hidden." into oc-dev am: c672cb5ed9
am: 6d9ea8ec97

Change-Id: I9c0768835c6932c3ec4c55a26fdd63b0d5e6bac5
2017-06-02 16:25:07 +00:00
Winson Chung
fc3ec4c5e6 Prevent showing voice session when it is already queued to be hidden.
- It is possible for the session to be requested to be hidden before it
  gets the message to be shown and completes showing. This leads to an
  inconsistency where the voice interaction service implementation will be
  in a different state than the system for the session. Instead, we can
  cancel any pending show messages, and also clean up the pending show
  callback list immediately when the session is hidden.
- Also fixing up some error message codes when starting the assistant
  activity.

Bug: 38379130
Test: android.server.cts.ActivityManagerAssistantStackTests
Test: CtsVoiceInteractionTestCases
Test: CtsAlarmClockTestCases
Change-Id: I0d0e9c024367a47bda82d6a29ca89e18b7d69527
2017-06-01 22:58:01 +00:00
Adrian Roos
7374d3a4bc Credential FRP: Add implementation
- Adds a facility to store a credential handle that survives factory reset
- Adds a method to KeyguardManager for verifying the stored credential for SetupWizard
- Dark launches persisting the primary user's credential as the FRP credential (behind a default-off flag)

Future work:
- Use a separate GK handle / synthetic password for the FRP credential
- Enroll the FRP credential in verifyCredential for the upgrade case

Bug: 36814845
Test: runtest -x core/tests/coretests/src/com/android/internal/widget/LockPatternUtilsTest.java && runtest -x services/tests/servicestests/src/com/android/server/LockSettingsStorageTests.java && runtest -x services/tests/servicestests/src/com/android/server/SyntheticPasswordTests.java
Change-Id: Ia739408c5ecb169e5f09670cd9ceaa7febc2b1cc
2017-05-30 19:14:01 -07:00
Jeff Davidson
91c3d07fd9 Implement remaining core eUICC APIs.
Includes:

-getDefaultDownloadableSubscriptionList, which returns a list of
default subscriptions available for the device.
-getEuiccInfo, which returns an EuiccInfo object containing
non-sensitive information about the eUICC device.
-deleteSubscription, to delete a subscription.
-switchToSubscription, to switch to (or away from) a subscription.
-updateSubscriptionNickname, to update the nickname of a subscription
which is saved to the eUICC.
-eraseSubscriptions, to factory reset the eUICC.
-Settings.Global#DEFAULT_SM_DP_PLUS, a default SM-DP+ server which is
used to query for default subscriptions in
getDefaultDownloadableSubscriptionList.

These APIs follow the template of the APIs which have already been
implemented.

This completes the baseline implementation as designed; any additional
APIs or tweaks to the APIs will be tracked as separate bugs.

Fixes: 33075886
Test: Build/boot
Change-Id: I8057757c874f94e0c816af1ca071d656c8f145b9
2017-05-14 10:57:00 -07:00
Jeff Davidson
d02731ffff Define APIs for listing embedded subscriptions.
Two new APIs will list all embedded subscriptions along with any
active ones. One API requires the ability to read phone state and
returns all subscriptions. The other requires no special permissions
but will only return those subscriptions which the caller may manage
according to their metadata.

A list result from the LPA includes whether the current eUICC is
removable. If true, subscriptions in the list are considered
transient and always removed upon the next list update (i.e. SIM card
state change) unless that update includes the subscription. Otherwise,
they will be retained across future list operations for which the
current eUICC is removable. This allows callers to retain knowledge
about available embedded subscriptions on an inactive but still
accessible eUICC, as long as that eUICC is permanent.

The LPA may request a refresh of the list at any time; this is
intended to be used of the list or metadata is updated through a
non-API operation, e.g. a server-initiated metadata update. For
operations driven through a platform API, the list will be refreshed
automatically.

Bug: 33075886
Test: TreeHugger
Change-Id: I1887cbca835c304b9eb285fd972c7c8eaffa6e1d
2017-05-14 10:55:40 -07:00
Felipe Leme
321a829b4b Merge "Removed deprecated APIs." into oc-dev am: 4b91fe8699
am: 3eee11cb4d

Change-Id: I39859572bfd0b8e34d02ad96147364e0f4ce2ee5
2017-05-12 20:41:35 +00:00
Felipe Leme
73fedacfeb Removed deprecated APIs.
Test: CtsAutoFillServiceTestCases pass
Test: manual verification with existing service

Bug: 37563972

Change-Id: Ibea2810f9230f06e59d2d81e4ba853de54987956
2017-05-12 10:32:45 -07:00
Philip P. Moltmann
eb013ab31d Merge "Speed up structure update before OnFillRequest" into oc-dev am: 6ab00addb1
am: fc89e4fab1

Change-Id: Ie0b0674a5c415858ae0c3332761682597a0f78af
2017-05-11 09:38:50 +00:00
Ruben Brunk
cc9089817d Merge "Fix VR component enforcement for "2D in 3D" apps." into oc-dev am: 4d73fd5765
am: dbe6a24331

Change-Id: I7de9452a95aebf7a658d9d0552426146d1bf8e73
2017-05-11 04:51:09 +00:00
TreeHugger Robot
6ab00addb1 Merge "Speed up structure update before OnFillRequest" into oc-dev 2017-05-11 03:22:22 +00:00
Philip P. Moltmann
22567d3415 Speed up structure update before OnFillRequest
We now
- cache AutofillId -> ViewNode
- look for all AutofillIds at the same time (instead of one by one)

Bug: 37997043
Test: CtsAutoFillServiceTestCases
Change-Id: I094468ad885eed0cc506b4b62ff09c4af48570ff
2017-05-10 17:29:04 -07:00
Ruben Brunk
4d73fd5765 Merge "Fix VR component enforcement for "2D in 3D" apps." into oc-dev 2017-05-10 18:19:06 +00:00
Svetoslav Ganov
2b3385ab9d Merge "Allow null fill values to support authentication case" into oc-dev am: 90bcc1c8bc
am: 0e4f1bab09

Change-Id: I4f95cb012fd5d8b96c2beb097aa3b09c8c557b74
2017-05-10 06:43:26 +00:00
Svetoslav Ganov
a9379d0b44 Allow null fill values to support authentication case
If a dataset needs to be authenticated the fill service
may not have the values but needs to tell the system for
which fields to show the fill UI. We now allow passing
a null value to mean the view is a part of the dataset
semantically but its value should remain unchanged.

If a dataset has no values, i.e. the related autofill ids
are mapped to null, we cannot properly filter. In this case
we always match such items regardless what the user typed.

While at this improved accessibility support for filtering
to announce when the number of items being filtered changes.

Also while at this allowed a dataset authentication to return
a response which replaces the current response and refreshes
the UI. Matching datasets with null values to any text plus
allowing a response to be returned from a dataset auth enables
the use case where there is always "Import" item at the
end of the list which when clicked can show arbitrarily more
data entries associated to other apps.

Another change is that we now provide the client state
bundle on both request and dataset auth.

Finally, this change gets rid of dataset waiting auth and
response waiting auth concepts since the reference to the
response and the dataset is piped with the auth request.

Fixed a bug where the width of the autofill UI was not
properly measured by going over all items in the adapter.
Now we measure enough height to fit the first three and the
width id the width of the widest item in the adapter.

Test: Added LoginActivityTest#testDatasetAuthTwoFieldsReplaceResponse
      Added LoginActivityTest#testDatasetAuthTwoFieldsNoValues
      Added LiginActivityTest#filterTextNullValuesAlwaysMatched
      All autofill CTS tests pass

bug:37724701
bug:37424539

Change-Id: Ic19e5d7cbdbb7d110c9e7da0ad60b540cbf1aecf
2017-05-09 17:40:28 -07:00
Jeff Sharkey
d75ff5f2e8 Merge "Fix broken SystemApi docs." into oc-dev am: bbc764e83a
am: 43c327b4f2

Change-Id: Ic2e3b8ea13551e211a3f643de63900c9921eb931
2017-05-09 23:46:03 +00:00
Jeff Sharkey
bbc764e83a Merge "Fix broken SystemApi docs." into oc-dev 2017-05-09 22:56:23 +00:00
Jeff Sharkey
412aa37fea Fix broken SystemApi docs.
These broken docs were causing the docs build to completely fail.

Test: make -j32 online-system-api-sdk-docs
Bug: 38164929
Change-Id: I7f5fd4922e20e1a42af953f86f3c652655bc9192
2017-05-09 11:57:10 -06:00
TreeHugger Robot
764b7370ad Merge "Add API for querying if a given keyphrase/locale is supported for AOHD." 2017-05-09 03:41:15 +00:00
Chris Thornton
bf8288ce34 Add API for querying if a given keyphrase/locale is supported for AOHD.
Test: Use test VoiceInteraction app to verify function behaves as
expected, and no longer crashes in the framework if you try to use a
AOHD with a null KeyphraseEnrollmentMetaData object.

Change-Id: I12923b8ebf37e6de9be336b4397c24679c86fff8
2017-05-08 15:31:58 -07:00
Felipe Leme
64775de93d Merge "Fixed scenario where an authentication response has no dataset." into oc-dev am: 1c38d29482
am: 98333b84a2

Change-Id: I166b085c41d06c104080b8489a7111f527a12081
2017-05-08 19:40:53 +00:00
TreeHugger Robot
1c38d29482 Merge "Fixed scenario where an authentication response has no dataset." into oc-dev 2017-05-08 19:20:16 +00:00
Daniel Nicoara
57c32d93f6 Merge "Remove controller connection API" into oc-dev am: daefe1dcc7
am: 41950bc2c6

Change-Id: I48855908fe4fc4c284bc84b0d99bae5a82099c5d
2017-05-08 16:48:21 +00:00
TreeHugger Robot
daefe1dcc7 Merge "Remove controller connection API" into oc-dev 2017-05-08 16:30:37 +00:00
Svet Ganov
fd75ecb21f Merge "Add call super" into oc-dev am: a41a968f10
am: c13d648d4b

Change-Id: I93f57d5bfeaad9c94f6b7460734125cc259624b0
2017-05-06 23:05:12 +00:00
Svet Ganov
ecfa58a113 Add call super
Test: manual

bug:37775067

Change-Id: I50a50f1fbdb7e9c087c72ad0be3b767aeab9572a
2017-05-06 14:06:49 -07:00
Felipe Leme
8fd0575327 Fixed scenario where an authentication response has no dataset.
Also use getUiForShowing() on all relevant places, and added missing
SaveDataType value.

Test: LoginActivityTest.testFillResponseAuthServiceHasNoData()
Test: manual verification

Fixes: 37711385
Fixes: 38009452

Change-Id: Id69c831f96fb9ac35d1f2d86cfd41e76428c776e
2017-05-05 17:17:07 -07:00
Ruben Brunk
666505ec35 Fix VR component enforcement for "2D in 3D" apps.
Bug: 38004624

Test: Launch 2D in 3D application, check that null is delivered
VrListenerService#onCurrentVrActivityChanged.

Change-Id: I8ecb3d2fd4fa686ec43509852f4bc5f7d11d665c
2017-05-04 16:54:46 -07:00
Daniel Nicoara
1336a806f9 Remove controller connection API
No longer need the proxy since VR Window Manager is in VrCore.

Bug: 36506799, 37542947
Test: Compiled and ran in VR on device.
Change-Id: Id5b5f34a1ad2b6da263527463d63777d40f18085
2017-05-04 16:42:34 -04:00
Karthik Ravi Shankar
60df13e750 Merge "Rename CompatibilityDisplay to Vr2dDisplay" into oc-dev am: 1d01f9cf67
am: c4d7248cdd

Change-Id: I8714be5933827c015f1446d5231f5c1f704b53c3
2017-05-04 05:29:12 +00:00
Karthik Ravi Shankar
2b9aaedf63 Rename CompatibilityDisplay to Vr2dDisplay
CompatibilityDisplay used for displaying 2D activities in Vr world. This
is confusing in more than one way. To clarify what it really means,
rename it to Vr2dDisplay.

Changes in this CL -

- /s/CompatibilityDisplay/Vr2dDisplay
- /s/Compatibility/Vr2d - in CompatibilityDisplay context.

Bug: 37851944
Test: cts/hostsidetests/services/activityandwindowmanager/util/run-test
CtsServicesHostTestCases android.server.cts.ActivityManagerDisplayTests
passes on Marlin.

Change-Id: I0a442302fa9d0f48bbd0c01a7766b94369e04386
Signed-off-by: Karthik Ravi Shankar <karthikrs@google.com>
2017-05-03 22:16:02 -07:00
Felipe Leme
e82ea39a51 Merge "Removed deprecated setAuthentication() method that didn't take ids." into oc-dev am: 136a48e36a
am: 68eecb37d8

Change-Id: If40b81d68913a162f77581b09932647846c992c1
2017-05-02 01:11:25 +00:00
TreeHugger Robot
136a48e36a Merge "Removed deprecated setAuthentication() method that didn't take ids." into oc-dev 2017-05-02 00:53:34 +00:00
Jeff Sharkey
a03c9d1640 Merge "Updates based on API council guidance." into oc-dev am: 3ba7117164
am: e13d60764c

Change-Id: Ib0a727b11cc24c20d10adf9df85df100f603a87f
2017-05-01 18:52:23 +00:00
Felipe Leme
c2430f3c4d Removed deprecated setAuthentication() method that didn't take ids.
Such method would cause the AutofillUi to show on all fields, now it only
shows in the fields the service is interested on.

This doesn't solve FillResponse auth on multiple partition, but that will
come soon...

Bug: 37424539
Test: removed hack from testFillResponseAuthJustOneField()
Test: CtsAutoFillServiceTestCases pass

Change-Id: Id97dddfb9fc1630cd6bac96b9bae9d4a2986dd6d
2017-05-01 11:21:54 -07:00
Jeff Sharkey
000ce80505 Updates based on API council guidance.
Test: builds, boots
Change-Id: I223faf55c1e1b4d81d11b4c8b2d93ccd131c969b
Fixes: 37775662
Fixes: 37748635
Fixes: 37673408
Fixes: 37672564
Fixes: 37672218
Fixes: 37638323
Fixes: 37637423
2017-04-29 13:14:17 -06:00
Jeff Sharkey
25fdc90020 Merge "Respond to API council feedback." into oc-dev am: d275dc83be
am: 858fd1bf47

Change-Id: Ie58915ab6882725ac030a024a09b719f7f9db249
2017-04-28 23:15:55 +00:00
Jeff Sharkey
1a74942fbf Respond to API council feedback.
Test: builds
Bug: 37752002
Change-Id: I7ae1699c4c5e1a098d16465c41fb41510478b678
2017-04-28 14:24:03 -06:00
Felipe Leme
02adf09e5b Merge "Improved Autofill logging." into oc-dev am: 2d5c0d89e5
am: eb9a99c3d4

Change-Id: Iefa99c2578934ba959d075e5b620d9cc81df668c
2017-04-28 16:02:56 +00:00
Julia Reynolds
226ae10c66 Merge "Documentation updates" into oc-dev am: b8d4a94867
am: 9b4511c643

Change-Id: Ib8d4c116d548b55f395e977ab76bc1f85d9791ba
2017-04-28 14:01:53 +00:00
Felipe Leme
9f9ee25515 Improved Autofill logging.
- Removed ui.Helper.
- Replaced DEBUG and VERBOSE constants by sDebug and sVerbose.
- Added a shell command to dynamically set the constants.
- Removed obsoleted log statements.
- Changed log-level of some log entries.
- Removed unused methods.

Fixes: 36141126

Test: CtsAutoFillServiceTestCases pass
Test: manual verification

Change-Id: Ic08ee9a2adc10e63f49bbcc7ed126455462dc9c1
2017-04-28 06:56:23 -07:00
Julia Reynolds
b8d4a94867 Merge "Documentation updates" into oc-dev 2017-04-28 13:44:10 +00:00
Felipe Leme
ee15506088 Merge "Refactored Autofill to move starting flag out of Session." into oc-dev am: b63d261f9c
am: f966d48f66

Change-Id: I2d7d5a8eb571ceb093f26d3f9805917b201167f7
2017-04-28 09:41:57 +00:00
Felipe Leme
0aa4c5065d Refactored Autofill to move starting flag out of Session.
Otherwise, all onFillRequest() calls in the same partition would use
the same flags.

Fixes: 37675138
Test: existing CtsAutoFillServiceTestCases pass
Test: CtsAssistTestCases pass
Test: PartitionedActivityTest.testAutofill4ParitionsMixManualAndAuto() pass

Change-Id: I03c8a036637bae534904d4f41265e451088cf940
2017-04-27 23:38:14 -07:00