Commit Graph

107 Commits

Author SHA1 Message Date
Bjorn Bringert
50145bc883 ACTV: getWindowVisibility() instead of private attach count
When debugging a problem with the search dialog drop-down
sometimes not showing up, I saw that the mAttachCount variable
in AutoCompleteTextView could get a negative value because
onDetachedFromWindow() was called multiple times. This lead to
the drop-down not being displayed on filtering.

Instead of the private attach count in ACTV, this change
uses View.getWindowVisibility().
2009-06-11 12:30:48 +01:00
Jack Veenstra
53175148c9 Add support for custom tab views in TabHost and TabWidget.
This change adds the ability to specify an arbitrary view for a tab
indicator.  It also adds support for specifying a drawable to use as
the divider between tab views.
2009-06-10 11:38:02 -07:00
Android (Google) Code Review
a32b5f3252 Merge change 2411 into donut
* changes:
  Manual merge from cupcake_dcm. Need to be reviewed by enf.
2009-06-10 08:01:20 -07:00
Romain Guy
0e1ca5749a Add support for gestures in Home.
Adds a new animation style for the gestures pad, and de-normalize
the scores in the recognition engine.
2009-06-09 22:58:46 -07:00
Romain Guy
f642aa2a44 Removes gestures from ListView. 2009-06-08 23:24:18 -07:00
Romain Guy
0a20264db8 Do not automatically enable gestures in list based on filtering/fastscroll status. Enable gestures in Contacts for now. 2009-06-08 14:47:01 -07:00
Android (Google) Code Review
4e0b13c9a9 Merge change 3348 into donut
* changes:
  Fix AlphabetIndexer.getSectionForPosition()
2009-06-05 14:53:00 -07:00
Phil Dubach
1b111bb6e2 Fix AlphabetIndexer.getSectionForPosition()
This did not properly set the cursor position before reading, which
resulted in wrong return values or exceptions in the cursor.
2009-06-05 12:27:59 -07:00
Romain Guy
834f0391b5 Fixes #1899273.
When a "ghost" stroke was showing, events would be intercepted in ListView. This patch modifies the logic used to detect when to still events: either the current stroke is a gesture, or the previous stroke was a gesture.
2009-06-05 11:24:09 -07:00
Android (Google) Code Review
ad8a510fcc Merge change 3227 into donut
* changes:
  Fix int to string mapping of exported properties. The value generated by the mapping in a @ViewDebug.ExportedProperty annotation was always overriden by the resolveId attribute.
2009-06-04 15:12:06 -07:00
Romain Guy
a1f3e4aef1 Fix int to string mapping of exported properties. The value generated by the
mapping in a @ViewDebug.ExportedProperty annotation was always overriden by
the resolveId attribute.
2009-06-04 15:10:46 -07:00
Android (Google) Code Review
b640da8fcb Merge change 3204 into donut
* changes:
  Avoid touching all adapter items when building accessibility event.
2009-06-04 14:12:02 -07:00
Amith Yamasani
d296fafab5 Avoid touching all adapter items when building accessibility event.
Only check for enabled items if the list is less than 15 items.
2009-06-04 14:00:20 -07:00
Romain Guy
f993ad5b89 Fixes #1882836.
Prevents the gestures window from leaking. This change does exactly what was
done for the filter popup window: the popup is dismissed in onSaveInstanceState()
as it is the only place that is executed early enough to avoid the dreaded
window leak error.
2009-06-04 13:26:52 -07:00
Android (Google) Code Review
fa30c0eed3 Merge change 2548 into donut
* changes:
  Fix a bug in AppSecurityPermissions where it wouldn't display permissions used by an app if it uses a shared user id. Remove the else clause and always get the list of requested permissions first before adding the permissions obtained via the shared user id. Also change an if condition and comments for better readability
2009-06-01 10:21:05 -07:00
Android (Google) Code Review
10d273bb69 Merge change 2591 into donut
* changes:
  Check if the ownerView is still attached to window in refreshPositionVariables.
2009-06-01 09:55:44 -07:00
Android (Google) Code Review
f422dc495a Merge change 2566 into donut
* changes:
  Fix javadoc typos. No code changes.
2009-05-29 15:07:45 -07:00
Romain Guy
0a63716ed0 Modify the base gestures API to use streams instead of files. Adds new wrappers to easily load/save gestures from files, resources, etc. Do the same for the letters recognizer. 2009-05-29 14:43:54 -07:00
Android (Google) Code Review
d1353cc4f1 Merge change 2731 into donut
* changes:
  Fixes #1873537.
2009-05-29 13:43:57 -07:00
Romain Guy
c51ef9702d Fixes #1873537.
Only update the popup window when it is shown. This avoids throwing an NPE in PopupWindow.
A PopupWindow is only aware of its content view after being shown.
2009-05-29 12:05:11 -07:00
Romain Guy
e32edc614e Fixes #1884152. This change improves how the opaque property is handled with respect to dividers.
If the list is opaque and its background is not, then we want to fill a solid rect where the dividers should be when they are skipped for non-selectable items. When the list is opaque and the background is also opaque, there is no need to draw something in lieu of the dividers since the background will do it for us.
2009-05-29 10:33:36 -07:00
Romain Guy
b0ded43d38 Uninstalls the gestures overlay when the letters recognizer cannot be loaded instead of simply dismissing the popup. This is cleaner and reuses the setGestures() method. 2009-05-27 21:37:14 -07:00
Owen Lin
470681e0ff Check if the ownerView is still attached to window in
refreshPositionVariables.
2009-05-27 17:56:17 -07:00
Jack Veenstra
982be3be05 Fix javadoc typos. No code changes.
Also reformatted a comment that was too long.
2009-05-27 15:07:59 -07:00
Suchi Amalapurapu
c7b14e9207 Fix a bug in AppSecurityPermissions where it wouldn't display permissions used by an app if it uses a shared user id.
Remove the else clause and always get the list of requested permissions first before adding the permissions obtained via
the shared user id.
Also change an if condition and comments for better readability
2009-05-27 14:14:09 -07:00
Marco Nelissen
8ae3f61902 Fix another crash in Gestures, this one caused by the data file
having the wrong version. I made the loader print a message to
the log for this, and made the calling code disable gestures
for the listview instead of crashing.
2009-05-27 10:03:44 -07:00
Marco Nelissen
fea57edf0d Fix crash in GestureOverlayView 2009-05-26 14:20:35 -07:00
Daisuke Miyakawa
c1d2748d44 Manual merge from cupcake_dcm. Need to be reviewed by enf. 2009-05-25 17:37:41 +09:00
Romain Guy
82f3495b14 Cleanup Gestures API and make it easier to use in 3rd party apps. Also fix the events processing in the gestures overlay mechanism. Give better control of the various properties of the overlay through XML attributes. 2009-05-24 23:45:03 -07:00
Romain Guy
a02903fbee Fixes NPE in ListViews with non-selectable items. This was caused by a weird initialization issue in ListView and AbsListView: a private final field instanciated in the declaration in ListView was used in AbsListView<init> via an overriden method and that field was somehow null at this time. This fix moves the instanciation at a later point. 2009-05-23 13:26:46 -07:00
Romain Guy
b6888167d3 Fixes #1872506. Prevents NPE in ListView. When the opaque property changes at runtime, it is possible to end up in a situation in which the divider's Paint instance has not been instanciated. This change simples uses a final Paint that is guaranteed to not be null. 2009-05-22 14:09:29 -07:00
Romain Guy
d6a463a9f2 Add a new API to ListView: setGestures(int). This allows developers to enable gestures to jump inside the list or filter it. This change also introduces a new XML attribute to control this API. It also adds the ability to theme the GestureOverlayView from the gestures library. Finally, this adds a new VERSION header to the binary format used to store the letters for the recognizer. 2009-05-22 01:59:59 -07:00
Romain Guy
7444e147a8 Fixes external http://code.google.com/p/android/issues/detail?id=2732. ExpandableListView is wrongly assuming that the saved state if of the correct type. A similar bug fix was made in TextView.onRestoreInstanceState() a while ago. This fix simply ensures that the state received is of the right type. 2009-05-21 12:54:16 -07:00
Romain Guy
a6cd4e03e6 Fix NPE at boot. 2009-05-20 15:09:21 -07:00
Romain Guy
3c77d39ee8 Fixes #1866819.\nTextView sets the bounds of its compound drawables to contain only the width and the height of the drawables. This causes View.invalidateDrawable() to invalidate the compound drawables at location (0, 0) within the view, thus invalidating the wrong part of the View. This prevents animation from running correctly when using animated drawable. This change overrides invalidateDrawable() in TextView to take into account the real position of the compound drawable. 2009-05-20 11:26:50 -07:00
Romain Guy
48540eb853 TextView was not setting the callback on its compound drawables, thus preventing them from refreshing the view when updating their internal state. This would for instance prevent animated drawables from actually animating. Quite infuriating. 2009-05-19 16:44:57 -07:00
Android (Google) Code Review
9d16d2072b Merge change 1916 into donut
* changes:
  Revise the ImageButton class description to include information about XML <selector> drawables, for managing button state.
2009-05-18 17:03:24 -07:00
Daisuke Miyakawa
841ddefcb5 Hand merge from cupcake_dcm to donut, part 2.
Modify Contacts-related java files and update vCard importer code to the latest.
2009-05-19 08:26:32 +09:00
Scott Main
84971ae010 Revise the ImageButton class description to include information
about XML <selector> drawables, for managing button state.
2009-05-18 16:05:52 -07:00
Romain Guy
8f1344f5e7 Fixes #1855461, #1857290 and #1857365. Certain scrollbar styles make an opaque view not be opaque. ListView and View now account for this when indicating whether they are opaque or not. 2009-05-15 16:15:04 -07:00
svetoslavganov
75986cf9bc Accessibility feature - framework changes (replacing 698, 699, 700, 701 and merging with the latest Donut) 2009-05-14 23:47:05 -07:00
Android (Google) Code Review
14ad07f604 Merge change 1708 into donut
* changes:
  Fixes #1853550. Prevent NPE when calling the PopupWindow() and PopupWindow(int, int) constructors. Instead, throw an IllegalStateException when trying to show a popup with no content view.
2009-05-14 16:42:46 -07:00
Romain Guy
448ecf5a94 Fixes #1853550. Prevent NPE when calling the PopupWindow() and PopupWindow(int, int) constructors. Instead, throw an IllegalStateException when trying to show a popup with no content view. 2009-05-14 16:03:42 -07:00
Marco Nelissen
9ea923174c Rearrange some code so it makes more sense. Thanks, findbugs. 2009-05-14 15:11:23 -07:00
Romain Guy
13922e0303 Fixes #1836075. Adds consistency checks for the View hierarchy. To enable them, you need a debug build and ViewDebug.sConsistencyCheckEnabled set to true in debug.prop. This change also lets you easily enable drawing and layout profiling in ViewRoot by setting ViewRoot.sProfileDrawing, ViewRoot.sProfileLayout and ViewRoot.sShowFps in debug.prop with a debug build. 2009-05-13 15:42:23 -07:00
Android (Google) Code Review
da33d0d139 Merge change 1424 into donut
* changes:
  Fixes 1844680. Interrupted scrolling could lead to rendering artifacts. The ListView was invalidating itself in opaque mode but before the drawing could happen, it was getting rid of its scrolling cache, thus becoming translucent again.
2009-05-12 11:13:04 -07:00
Romain Guy
83b2107c4d Fixes #1846038. DrawableContainer was wrongly returning its opacity by ignoring the visibility of the currently selected layer. This change simply reports a TRANSPARENT opacity if there is no currently selected layer of if the selected layer is not visible. Otherwise it reports the opacity computed by the state class. 2009-05-12 10:54:51 -07:00
Romain Guy
6dfed24158 Fixes 1844680. Interrupted scrolling could lead to rendering artifacts. The ListView was invalidating itself in opaque mode but before the drawing could happen, it was getting rid of its scrolling cache, thus becoming translucent again. 2009-05-11 18:25:05 -07:00
Romain Guy
2d6afea681 Fix the build 2009-05-11 15:19:21 -07:00
Android (Google) Code Review
a2ea1d3765 Merge change 1371 into donut
* changes:
  Fixes #1596240. Optimize invalidate/draw passes by marking opaque views and avoiding drawing them. Whenever a View requests an invalidate its parent check whether the view is opaque or not. When the view is not opaque, the framework behaves as it used to. However, when a view is opaque, the parent marks itself as being dirty because of an opaque view. Its parent then does the same, and so on. When the framework then starts drawing the views, it does not draw views marked as dirty opaque. If a view is dirty opaque and receives an invalidate request from a non-opaque view, it then clears the dirty opaque flag and behaves as before.
2009-05-11 14:04:23 -07:00