Commit Graph

429 Commits

Author SHA1 Message Date
Mady Mellor
104be2e019 If the menu hasn't been created yet don't do things with it
Test: runtest systemui
Fixes: 62594598
Change-Id: I1050e2b2bf1ece960d19ad13cb6a9bf71512db57
(cherry picked from commit 0b3f004acb)
2017-06-28 15:34:36 +00:00
Shishir Agrawal
ecbb1f60f0 Supress roaming indications during a carrier network change.
Change-Id: Ib39d229b67374c4ca30c3a2c8c3b0050106733cd
Fixes: 62795179
Test: NetworkControllerSignalTest
2017-06-27 17:37:14 +00:00
Lucas Dupin
ddbaf84ac6 Fix notification contrast with transparent bg
Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/StatusBarIconViewTest.java
Change-Id: I2f0595408be61acb8267bb7449486ee46f7aad19
Fixes: 62937149
2017-06-23 09:39:11 -07:00
TreeHugger Robot
d0550a9b6c Merge "Ensure icon contrast on the shelf" into oc-dev 2017-06-22 17:25:17 +00:00
Jason Monk
b46a3c9634 Fix ConcurrentModificationException from LocationController
Test: runtest systemui
Change-Id: I0b7db7344217b3b7ad91f315100d1873e8167baf
Fixes: 62859544
2017-06-22 09:32:07 -04:00
Lucas Dupin
83519da8b6 Ensure icon contrast on the shelf
Change-Id: Ie9251ae4bdb4b590ce93c7f2f092476d5f895b5a
Fixes: 62591326
Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/StatusBarIconViewTest.java
2017-06-21 13:53:45 -07:00
Selim Cinek
d246bed148 Retrying the remoteview application on the ui thread
Because of various reasons, the async inflation could spuriously
fail, leading to dropped notifications.
We're now retrying them on the UI thread before we fail completely.

Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/notification/NotificationInflaterTest.java
Bug: 38190555
Change-Id: I13feaeaad925b72798a22194add16528c9438412
2017-06-20 18:42:48 +00:00
Siarhei Vishniakou
6ad0e39f33 Revive DeadZone
Override dispatchTouchEvent for the root FrameLayout
of NavigationBar to process ACTION_OUTSIDE MotionEvents
and dispatch directly to DeadZone to keep track of the
most recent outside tap.
Clarified documentation of ACTION_OUTSIDE behaviour.

Bug: 37552674
Test: open IME, tap any key, then quickly tap on top half
of the home button. The home button tap is ignored
and device does not go to homescreen.

Change-Id: Icb5cf6c76959f3514b8b94c09e38cc5434f31b23
2017-06-19 14:06:21 -07:00
TreeHugger Robot
04298759fe Merge "add a log for peek to shade expansion" into oc-dev 2017-06-15 16:20:15 +00:00
Chris Wren
621933fd7b add a log for peek to shade expansion
Move the note_load counter into the manager, replacing
the redundant and useless notification_load counter.

Update the StatusBarTest to allow for hander side-effects.

Test: runtest systemui
Change-Id: I2551c51cc0f4627995abe4401eafc2e5adb3a8fa
Fixes: 27698560
2017-06-15 09:18:58 -04:00
Jason Monk
2a0b423cd4 Merge "Fix footer not being hidden in detail panels" into oc-dev 2017-06-14 13:37:34 +00:00
Jason Monk
b4ec0b90dc Fix footer not being hidden in detail panels
Was causing incorrect accessibility focus

Test: manual
Change-Id: Id487286eb9fa931b73349b0b0dfe772566c10e6d
Fixes: 62568126
2017-06-13 21:16:15 +00:00
Jason Monk
9ef03b463c Fix sysui depending on slow bt calls
Move calls to a background thread and cache the results to avoid
slowing down sysui when there are too many bluetooth devices.

Test: runtest systemui
Change-Id: Ica10e86ca6b2783c30ed9de68f1a91dc5cfdf068
Fixes: 38118549
2017-06-13 12:49:55 -04:00
TreeHugger Robot
4f30aa2be8 Merge "Removed test from presubmit." into oc-dev 2017-06-09 23:17:18 +00:00
Lucas Dupin
f26517d466 Removed test from presubmit.
testOnNotification_stillWorksAfterOneFailedProxCheck needs to
be ignored on presubmit runs. It fails on Tree Hugger but
runs locally.

Test: runtest systemui
Change-Id: Id4e1107528715c7e0b6ce7c69e2da7fa837e79a2
2017-06-09 14:10:33 -07:00
Selim Cinek
dc66506f0a Merge "Fixed an issue where the notification could stay userlocked" into oc-dev 2017-06-09 04:25:42 +00:00
Selim Cinek
f8c4add851 Fixed an issue where the notification could stay userlocked
When collapsing the shade while draging down (using fingerprint)
notifications would stay userlocked and would appear in a small
height instead of their regular size.

Test:  runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarWindowViewTest.java
Change-Id: Ibd97a6ce063bc2fcd76f11e010e781a61bd76b5f
Fixes: 36469584
2017-06-08 09:56:42 -07:00
Jason Monk
a5b457b3bf Merge "Move QS cell indicator back into mobile data tile" into oc-dev 2017-06-08 16:35:26 +00:00
Selim Cinek
b18f65a168 Merge "Fixed a bug where the navigation notification would flicker" into oc-dev 2017-06-08 14:07:23 +00:00
Selim Cinek
131f1a4bc4 Fixed a bug where the navigation notification would flicker
Change-Id: Id68ba339407287d67d8db888515389e79e09ece3
Fixes: 62339936
Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/NotificationCustomViewWrapperTest.java
2017-06-07 18:04:57 -07:00
Selim Cinek
a7c69637f8 Fixed an issue where the icons had the wrong color
The color of the icons was taken from the ambient view
and wasn't updated when dark changed.

Change-Id: I472e76ff9d4d92500faae5517f10bdeb2658936d
Fixes: 62423352
Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
2017-06-07 15:52:30 -07:00
Jason Monk
01df36f37f Move QS cell indicator back into mobile data tile
Remove it from the header and drop it back in its old location.

This reverts commit 10b4c8a4ab.

Test: runtest systemui
Fixes: 62331189
Change-Id: I087589c256894e0972656619e665b6a16536ce6c
2017-06-07 15:00:23 -04:00
TreeHugger Robot
d5ece513ec Merge "Fix crash in test" into oc-dev 2017-06-07 04:12:50 +00:00
Jorim Jaggi
fd3b1a1b76 Fix crash in test
Test: runtest systemui
Change-Id: I841b6ed21fb101e7873b218521c480c904f361f8
Fixes: 62389344
2017-06-06 17:04:19 -07:00
TreeHugger Robot
285ad4ce66 Merge "Fix icon tint on notification shelf" into oc-dev 2017-06-05 23:29:49 +00:00
Dan Sandler
008cea772a Hide redundant foreground service notifications.
If an app with a foreground service has (at least one)
FLAG_FOREGROUND notification shown to the user, we allow
that to satisfy the requirement that the user be informed
about such things. But if the fg notification or its channel
is blocked by the user, we show the NOTE_FOREGROUND_SERVICES
notification (a/k/a Dianne's Dungeon) provided to us by the
activity manager.

Note that if even one of the foreground processes for the
current user is missing its disclosure notification, the
user will see the whole dungeon.

Bug: 36891897
Test: runtest -x frameworks/base/packages/SystemUI/tests/src/com/android/systemui/ForegroundServiceControllerTest.java
Change-Id: I4f5d96f80b7c1901faadb56661a42d26f746aa88
2017-06-05 11:18:59 -04:00
TreeHugger Robot
227e65d818 Merge "Add checks against incorrect context use in sysui tests" into oc-dev 2017-06-01 19:43:49 +00:00
Jason Monk
893f0bdcb7 Add checks against incorrect context use in sysui tests
Fix incorrect usages found by this check.

Test: runtest systemui
Bug: 62251903
Change-Id: I45a762f96838e617833c1cbe003e583087bb8176
2017-06-01 11:21:14 -04:00
Jason Monk
fcd97ce795 Fix crash from non-default sims in QS
Test: runtest systemui
Change-Id: Icdb063589258a6b4bd94634cc9f41f788a7d2299
Fixes: 62209034
2017-06-01 11:00:00 -04:00
Lucas Dupin
b6ed63b567 Fix icon tint on notification shelf
Public layout icon color wasn't being propagated correctly.

Change-Id: I6396e8dc5a9a18f614afd0e184c99c6d799151cb
Fixes: 38371661
Test: runtest -x tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
2017-05-31 09:55:12 -07:00
Lucas Dupin
6ea2787920 Fix header not set on initialization
Header not being set was causing min priority
groups to skip expansion animation.

Bug: 38436027
Test: runtest -x frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/stack/NotificationChildrenContainerTest.java
Change-Id: I34307a7e5ecfe7e30d5bf97880b17fedb0d84378
2017-05-30 16:46:23 -07:00
TreeHugger Robot
e3f2f29cde Merge "Fix crash from concurrent modification" into oc-dev 2017-05-30 21:50:08 +00:00
Jason Monk
f66d377a68 Fix crash from concurrent modification
Change zen callbacks to allow for concurrent modification.

Test: runtest systemui
Change-Id: I8233353f617c4537104be2ec7be13247ed7f6ae0
Fixes: 38449656
2017-05-30 14:45:17 -04:00
Jason Monk
d2638591d9 Merge "Make QS signal indicator act like a QS signal indicator" into oc-dev 2017-05-30 17:01:04 +00:00
Julia Reynolds
30203159f9 Suppress HUNs according to group alert behavior
Test: runtest systemui, systemui-notification
Change-Id: I9f987bc0ba22f2d48b02585fd722880bb5c2a9b5
Fixes: 62126386
2017-05-26 20:35:07 +00:00
Jason Monk
1ec5d85a41 Merge "Make volume dialog pick up on theme changes" into oc-dev 2017-05-26 19:03:46 +00:00
Jason Monk
10b4c8a4ab Make QS signal indicator act like a QS signal indicator
It had the behavior of the status bar before, so switch it over to
QS behavior but keep status bar icons for the appearance. Ditch
the old QS data icons because we no longer need them.

Test: runtest systemui
Change-Id: I1356bbc19c4874ae467e192b9129136ebd0a37c8
Fixes: 62128809
2017-05-26 13:52:59 -04:00
Jason Monk
a29528979c Make volume dialog pick up on theme changes
Test: change theme, view volume
Change-Id: I3f5b6ea7fd949e72624458a13b6c953629fcd1b5
Fixes: 38408033
2017-05-26 12:58:07 -04:00
Julia Reynolds
3a2ac3e11b Merge "Allow some system notifications to be blocked." into oc-dev 2017-05-26 14:39:30 +00:00
Selim Cinek
3d5fd7a959 Merge "Fixed memory leak with the inflater" into oc-dev 2017-05-25 22:54:12 +00:00
Julia Reynolds
f732159cf8 Allow some system notifications to be blocked.
- Happens at a channel level, and system services have to opt in

Bug: 38428796
Test: runtest systemui-notification, manual
Change-Id: I5592b4e32c177844583aee25379390199eef0a58
2017-05-25 20:42:59 +00:00
Selim Cinek
67ff248168 Fixed memory leak with the inflater
Because min priority children could be removed from
their parents after the removal, a new inflation task
would be started, leading to the view being instantly
readded again. This lead to memory leaks.

It also fixes a bug where the inflation would not inflate
enough views that could lead to crashes / wrong layouts.

Finally there was a indexing error when handling removal
of group summaries.

Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/notification/NotificationInflaterTest.java
Change-Id: Iac242946bd30060967ee7877560d40e63f39f996
Fixes: 62067645
2017-05-25 12:41:03 -07:00
Jason Monk
25a52b65b2 Add test to verify all sysui tests extend the right stuff
And then make it pass.

Test: runtest systemui
Fixes: 38500852
Change-Id: I377164219e4a4f4d1a99f11ef06da03c2b527eb0
2017-05-25 15:18:06 -04:00
Selim Cinek
e736807efd Merge "Fixed an issue where groups could stay userlocked" into oc-dev 2017-05-25 03:29:14 +00:00
Selim Cinek
91f41cea2e Fixed an issue where groups could stay userlocked
It also fixes an issue where the reinflation wasn't
working properly.

Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
Merged-In: If359256a3ac0c574260b5ff5af3fc2042e1dce9a
Change-Id: If359256a3ac0c574260b5ff5af3fc2042e1dce9a
Fixes: 36469584
2017-05-24 21:00:19 +00:00
Geoffrey Pitsch
70950def80 Change Ignores to FlakyTest so we can check if they're fixed
Test: runtest systemui
Bug: 38500852
Change-Id: I84fd8178086dbd4e35c72e7ef2780248a00791e8
2017-05-23 17:13:38 -04:00
Geoffrey Pitsch
351a321371 Ignore a bunch of systemui tests until flakes are found
Test: runtest systemui
Bug: 38500852
Change-Id: I54f0e868bd9432758ff21a344631b6888bc83a4b
2017-05-23 09:12:49 -04:00
Jorim Jaggi
e549a8d621 Optimize latency when unlocking phone
Latency when unlocking the phone regressed a bit for two reasons:
- For lockscreen -> app we now have to create a full starting
window containing the snapshot, while previously this was just
showing a surface.
- For lockscreen -> home, we can't use the saved surface anymore
because currently we don't support snapshotting translucent
activities. However, in the long term, we want home screen to be
more involved into transitions anyways, so we'll have to wait for
the first frame draw anyways.

However, crystal ball trainee developer Jorim added some
artificial latency in this transition 3 years ago, because he knew
that it is going to be an issue at some point so we have some
headroom to improve! Genius! On a more serious note, it was because
he didn't understand how to read systraces with binders involved (to
be fair, there was also no binder tracing).

Now, we can completely fix the introduces latencies above by
removing this latency of 100ms, and we are 30-70ms better than
before! However, this requires a lot of discipline in SystemUI.
Currently, the callback to dismiss Keyguard takes around 30ms. By
moving all non-essential binder calls of the main thread or to the
next frame, we bring this down to 5ms, such that window animation
and Keyguard animation starts about at the same time.

Test: Take systrace, unlock phone...profit!

Fixes: 38294347
Change-Id: I481fe4ecf358ed09f7142dd9e7ecd290b53c500c
Merged-In: I3ea672bc2eca47221bc6c9f3d7c56b6899df207d
2017-05-17 23:47:15 +00:00
TreeHugger Robot
1ab1da3f25 Merge "Fix number of channels in inline notification settings" into oc-dev 2017-05-15 14:18:22 +00:00
TreeHugger Robot
8902bbe4e3 Merge changes I7b5504d0,I10c263dc into oc-dev
* changes:
  Get rid of a lot of binder calls
  Fix recents entry delay
2017-05-13 12:57:23 +00:00