Commit Graph

10975 Commits

Author SHA1 Message Date
Wale Ogunwale
b32fecd6e0 Merge "Added 'dumpsys activity lastanr'" into oc-dev 2017-06-10 15:58:14 +00:00
Wale Ogunwale
f1285916c3 Added 'dumpsys activity lastanr'
Allows for dumping the activity state during the last anr. This will
also be included in collected bug reports.

Bug: 38121026
Test: Cause an anr to occur and run 'adb shell dumpsys activity lastanr'
Change-Id: I1e4200f9e5cc16bfab98e5af31fc599cdd54cd11
2017-06-09 17:17:07 -07:00
George Mount
e5e246ce5c Merge "Add target sdk check for behavior change." into oc-dev 2017-06-09 23:41:47 +00:00
George Mount
d1cfbc506b Add target sdk check for behavior change.
Bug 62188967

A previous change stopped animations on fragment Views before
being removed. This change in behavior caused other problems,
so the behavior must be placed behind a target SDK check.

Test: ran fragment tests, validated on app
Change-Id: I098e9b0f1472d9838abeacba3baaa7581f7a82ad
2017-06-08 14:18:31 -07:00
Felipe Leme
9be8c96918 Merge "Overall improvement on Autofill javadocs for autofillable APIs." into oc-dev 2017-06-08 05:21:08 +00:00
Julia Reynolds
6e96251d92 Merge "Revert "Change default for group alert behavior"" into oc-dev 2017-06-07 20:12:28 +00:00
Julia Reynolds
2f431e264d Revert "Change default for group alert behavior"
This reverts commit 8f7828ebe7.

Mutes sound on legacy apps that use their summaries to make sound

Change-Id: I635b1428ee247c0b7753f58343637e64da1c981d

Fixes: 62387153
2017-06-07 14:16:05 +00:00
Felipe Leme
2f6fc72efc Overall improvement on Autofill javadocs for autofillable APIs.
Bug: 37567048
Test: ran 'm -j doc-comment-check-docs' and checked resulting HTML

Change-Id: I7eaf0a521c3777baf0dc0002ae814990fd96a14c
2017-06-06 14:33:56 -07:00
TreeHugger Robot
42abe82bbb Merge "Fix #62350081 - annotate permission requirements" into oc-dev 2017-06-06 20:18:21 +00:00
Christopher Tate
8d3079f641 Fix #62350081 - annotate permission requirements
The Alarm Manager APIs that allow callers to ascribe wakelock time
to other apps are gated on the UPDATE_DEVICE_STATS permission.
Document this with the appropriate annotation.

Test: N/A
Change-Id: Idf5548089fb7d2235139ae8ba7bf58e7f455eb33
2017-06-05 18:30:05 -07:00
Jeff Sharkey
bfc4fcde9f Give Doclava our manifest; more permission docs.
We've seen some @SystemApi methods protected with non-system
permissions, so give Doclava the platform AndroidManifest.xml so it
can parse the actual permission protection levels to look for APIs
that are letting in non-system apps.

Also document more @SystemApi permissions.

This is purely a docs change; no logic changes are being made.

Test: make -j32 update-api
Bug: 62263906
Change-Id: Ie0f0a5fb0033817bcc95060f2183a52ae4ae7b06
2017-06-05 17:38:19 -06:00
Jeff Sharkey
d86b8fea43 Annotate @SystemApi with required permissions.
Most @SystemApi methods should be protected with system (or higher)
permissions, so annotate common methods with @RequiresPermission to
make automatic verification easier.

Verification is really only relevant when calling into system
services (where permissions checking can happen on the other side of
a Binder call), so annotate managers with the new @SystemService
annotation, which is now automatically documented.

This is purely a docs change; no logic changes are being made.

Test: make -j32 update-api && make -j32 offline-sdk-docs
Bug: 62263906
Change-Id: I2554227202d84465676aa4ab0dd336b5c45fc651
2017-06-05 13:27:11 -06:00
TreeHugger Robot
c3504d4f33 Merge "Workaround to ensure that PIP activities have a visible shadow." into oc-dev 2017-06-03 20:41:18 +00:00
Winson Chung
4d8681ff6a Workaround to ensure that PIP activities have a visible shadow.
- When the window for the activity enters PIP, update the outline provider
  to override the alpha of the shadow (to be opaque) to ensure that is is
  visible.  Only applies to the task root activity.

Bug: 36741700
Test: Launch YT, ensure that there is a shadow when after it enters PIP
Test: go/wm-smoke
Test: android.server.cts.ActivityManagerPinnedStackTests

Change-Id: If089dae84e4916d3d0e7bbeb316215b46e522e05
2017-06-02 16:02:50 -07:00
Winson Chung
f229ae5523 Handling cases with a null bitmap.
- This can happen either if an app creates an ActivityOptions without a
  thumbnail, or if the call to create a hardware bitmap fails for any
  reason. Just ignore the thumbnail for the transition in this case.

Bug: 62296016
Test: Have not been able to reproduce, but this is just a logical change
Change-Id: I30776b651df1f42118fe1d317fa4817261a6e977
2017-06-02 14:34:52 -07:00
Winson Chung
c672cb5ed9 Merge "Prevent showing voice session when it is already queued to be hidden." into oc-dev 2017-06-02 16:04:52 +00:00
Winson Chung
fc3ec4c5e6 Prevent showing voice session when it is already queued to be hidden.
- It is possible for the session to be requested to be hidden before it
  gets the message to be shown and completes showing. This leads to an
  inconsistency where the voice interaction service implementation will be
  in a different state than the system for the session. Instead, we can
  cancel any pending show messages, and also clean up the pending show
  callback list immediately when the session is hidden.
- Also fixing up some error message codes when starting the assistant
  activity.

Bug: 38379130
Test: android.server.cts.ActivityManagerAssistantStackTests
Test: CtsVoiceInteractionTestCases
Test: CtsAlarmClockTestCases
Change-Id: I0d0e9c024367a47bda82d6a29ca89e18b7d69527
2017-06-01 22:58:01 +00:00
TreeHugger Robot
87c727a169 Merge "Fix TimePickerDialog positive button clicks." into oc-dev 2017-06-01 08:02:51 +00:00
Aurimas Liutikas
553303fac1 Fix TimePickerDialog positive button clicks.
With my TimePickerDialog change to support keyboard based input I
accidentally broke TimePickerDialog#onClick as it was no longer being
called, instead it was calling TimeSetListener directly. This CL changes
the logic back to use onClick again.

Bug: 36042834
Test: Locally tested FitBit app.
Change-Id: I47d5563c99cc46eaaf2b1d4a96483d6825fc5805
2017-05-31 15:10:25 -07:00
Erik Wolsheimer
9be3a06082 Support multi-window on low-memory watches.
On watches, multi-window is used to present essential system UI, and thus it
must be supported regardless of device memory characteristics.

Bug: 37482466
Test: Manually, on a watch
Change-Id: I7929a090b7fd46de019d237ce771c82a6d7fd3f3
2017-05-31 15:00:45 -07:00
TreeHugger Robot
faba1835b4 Merge "Change default for group alert behavior" into oc-dev 2017-05-31 19:43:10 +00:00
TreeHugger Robot
21999d2895 Merge "Always post AutofillManager operations in the UI thread." into oc-dev 2017-05-31 18:49:38 +00:00
Winson Chung
4e73123c52 Merge changes from topic 'hw_bitmap' into oc-dev
* changes:
  DO NOT MERGE Updating AnimationSpec and related internal APIs to use GraphicBuffer.
  Update code to draw into hardware bitmaps.
2017-05-31 18:46:59 +00:00
Julia Reynolds
8f7828ebe7 Change default for group alert behavior
To alert for children but not the summary.

Bug: 62027641
Test: cts
Change-Id: Ie7978514be45be6b13c2ea3bd7ff898db352a1ed
2017-05-31 17:58:08 +00:00
Winson Chung
aa7fa01353 DO NOT MERGE Updating AnimationSpec and related internal APIs to use GraphicBuffer.
- This reduces the copy of the hardware bitmap when it is
  parceled/unparceled.

Bug: 38507414
Bug: 62021436
Test: Launch Overview to/from app, ensure that the header bar shows
Test: go/wm-smoke

Change-Id: I85a9a59a0a3699d1642158061d10fddef34393c3
Signed-off-by: Winson Chung <winsonc@google.com>
2017-05-31 16:23:24 +00:00
TreeHugger Robot
69bf3ea86d Merge "Fix Error Prone ArrayEquals/ArrayHashCode bugs" into oc-dev 2017-05-31 15:37:48 +00:00
Jeff Sharkey
ddff807b76 Consistent "low storage" behavior.
When answering the question "how much space is free", use the same
logic for Settings UI and StorageManager.getAllocatableBytes().  That
is, the reported free space is usable bytes plus any cached data the
system is willing to delete automatically.

This does *not* include any reserved cache space, since we don't want
abusive apps to penalize other well-behaved apps that are storing
their data in cache locations.  Callers freeing cached data need to
now explicitly request defiance of the reserved cache space.  (Most
callers are already doing this by using FLAG_ALLOCATE_AGGRESSIVE.)

Rewrite the core logic of DeviceStorageMonitorService to understand
this new "reserved" cache space, and to be easier to understand.  It
also now handles cached data on adopted storage volumes, which had
been ignored until now.  Also fix bug where we had skipped "low"
broadcasts when the device skipped directly from/to "full" state.

Bug: 38008706
Test: cts-tradefed run commandAndExit cts-dev -m CtsJobSchedulerTestCases -t android.jobscheduler.cts.StorageConstraintTest
Test: cts-tradefed run commandAndExit cts-dev -m CtsAppSecurityHostTestCases -t android.appsecurity.cts.StorageHostTest
Change-Id: Icbdcf3b52775f7ada1ceaeff2f96094c8d8052f9
2017-05-30 22:17:23 -06:00
Felipe Leme
9876a6fba9 Always post AutofillManager operations in the UI thread.
Test: existing CtsAutoFillServiceTestCases pass
Fixes: 62194407

Change-Id: If878b2befc03706c000b3f31b60904072b2225f4
2017-05-30 19:54:43 -07:00
Dianne Hackborn
1399d3abf5 Merge "Work on issue #62095840: NPE in JobParamteres in the background" into oc-dev 2017-05-30 20:21:17 +00:00
Dianne Hackborn
ccc63ec80f Work on issue #62095840: NPE in JobParamteres in the background
Crash early if an app calls jobFinished() with null params.

Test: manual

Change-Id: Icc2cf241edaad00bc5bd49d07a431627bbd76524
2017-05-30 11:04:53 -07:00
Julia Reynolds
8bc45cb78f Merge "Suppress HUNs according to group alert behavior" into oc-dev 2017-05-30 16:43:39 +00:00
Paul Duffin
c67663cbc8 Fix Error Prone ArrayEquals/ArrayHashCode bugs
This will change behavior so it could break tests but
if it does it is because they relied on broken behavior.

Someone on the frameworks team will need to verify the
correctness of these changes and fix any knock on effects.

See the following for a description of the bugs:
* http://errorprone.info/bugpattern/ArrayEquals
* http://errorprone.info/bugpattern/ArrayHashCode

Fixed automatically by Error Prone apart from manual
changes to fix up the formatting (Error Prone expects
google-java-format) and to change Object.deepEquals to
Arrays.equals for consistency with Arrays.hashCode.

Test: make checkbuild
Change-Id: I1528b795b77a4f1e0c4e7e66ad4f924b7a7606f6
2017-05-30 10:53:52 +01:00
Julia Reynolds
745c15477b Properly read vibration setting on boot.
Test: runtest systemui-notification
Change-Id: I400bc3df441524abe4973d4d6bccc7ef30a2e1c7
Fixes: 37865035
2017-05-26 20:35:16 +00:00
Julia Reynolds
30203159f9 Suppress HUNs according to group alert behavior
Test: runtest systemui, systemui-notification
Change-Id: I9f987bc0ba22f2d48b02585fd722880bb5c2a9b5
Fixes: 62126386
2017-05-26 20:35:07 +00:00
Adam Lesinski
24c18af14a Merge "Add ResourceId validation helper method" into oc-dev 2017-05-26 18:45:28 +00:00
TreeHugger Robot
25ae29dfd5 Merge "Removed deprecated setAutofill() method for virtual children." into oc-dev 2017-05-26 15:08:20 +00:00
Julia Reynolds
3a2ac3e11b Merge "Allow some system notifications to be blocked." into oc-dev 2017-05-26 14:39:30 +00:00
TreeHugger Robot
8d902a9e28 Merge "Remove the old version of setAffiliationIds" into oc-dev 2017-05-26 13:00:40 +00:00
Julia Reynolds
f732159cf8 Allow some system notifications to be blocked.
- Happens at a channel level, and system services have to opt in

Bug: 38428796
Test: runtest systemui-notification, manual
Change-Id: I5592b4e32c177844583aee25379390199eef0a58
2017-05-25 20:42:59 +00:00
Felipe Leme
5f3dbb30fc Removed deprecated setAutofill() method for virtual children.
Test: CtsAutoFillServiceTestCases pass

Bug: 37563972

Change-Id: Icbffb89d86ee65831b7c78effd2522ac7891e1be
2017-05-25 11:51:50 -07:00
Adam Lesinski
9553fb3240 Add ResourceId validation helper method
An invalid, 'null' resource ID is defined as 0. Apps often use -1.

Add a helper method that makes checking valid IDs easy and more
centralized.

Eventually make it public API.

Bug: 38393777
Test: manual
Change-Id: I969ec4a45e86bdab3d7f57d357d475b77c7f8a78
2017-05-24 15:39:23 -07:00
Sergey Vasilinets
ce8a4b89c8 Merge "Correctly save retained fragments in the backstack" into oc-dev 2017-05-24 21:05:38 +00:00
TreeHugger Robot
6c6d37d416 Merge "Don't keep a reference to Service object" into oc-dev 2017-05-24 00:31:40 +00:00
TreeHugger Robot
eee1dd26fa Merge "Hide Autofill UI when non-savable id is gone." into oc-dev 2017-05-23 23:28:38 +00:00
sergeyv
be6f50424a Correctly save retained fragments in the backstack
Test: FragmentLifecycleTest#retainedFragmentsInBackstack
bug:62027280
Change-Id: I4ba20c5138f957107422c46d67095c7c8db2c608
2017-05-23 15:24:37 -07:00
Bryce Lee
367b880c02 Merge "Revert "Disallow starting activities without new task from non-activity context."" into oc-dev 2017-05-23 19:50:24 +00:00
Bryce Lee
25ae100cb0 Revert "Disallow starting activities without new task from non-activity context."
This reverts commit 8b49a5c0aa.

Change-Id: I7d2da4ac72ca578942b38fccf8b151f3a2ed081f
2017-05-23 19:46:59 +00:00
Felipe Leme
27e202208b Hide Autofill UI when non-savable id is gone.
AutofillManager keeps track of which views the AutofillServiec is interested to
save, so when these views are gone, the session is finished.

But when the AutofillService returns a dataset whose views it can not save,
the FillUi for these views are not hiding when the views are gone. This CL
fixes this issue by:

- Keeping track which non-savable views should be tracked.
- Pass the view (instead of it's id) when the UI on such views should be hid.

This CL also optimized some AIDL and internal calls by avoiding the creating of
unnecessary Lists.

Test: manual verification with Snapchat
Test: existing CtsAutoFillServiceTestCases pass
Test: new tests on MultipleFragmentLoginTest pass

Fixes: 38199452
Change-Id: I78fa357962dbc6667146d8e08cd6bacb63e0f337
2017-05-23 10:46:24 -07:00
Amith Yamasani
7592825084 Don't keep a reference to Service object
This is a potential fix for a global reference leak in the
system process by a JobService in an app.

Bug: 38467796
Test: manual
Change-Id: I8756c39ac77bead068c88fce750c4024f9ac1c03
2017-05-23 10:37:09 -07:00
Dianne Hackborn
ad6dde65ff Merge "Fix issue #38393543: Not allowed to start service Intent" into oc-dev 2017-05-22 20:03:33 +00:00