Enable tests ot be in presubmit, postsubmit or marked as flaky
Do not require flicker DSL changes
Bug: 162923992
Test: atest FlickerTests WMShellFlickerTests
Change-Id: I74fdadaf5f6f08d96973683682297200eec6658d
1) Integrate companion object inheritance and the default test runner
2) Move launch activity to setup: avoid noise of splash screen
3) Move setRotate() to setup: avoid noise of system windows
(LetterBox, NavBar, StatusBar...) visibility changes
4) Reducing test time of each test case: remove redundant transition
5) Remve redundant val for readibility
6) Remove navBarLayerIsAlwaysVisible assertion from split test
the rotation flow of enter split screen :
Overview(land) -> enter split(portrait) -> split mode(land)
7) Partially enable ROTATION_90 tests
8) Bypass visibleLayersShownMoreThanOneConsecutiveEntry assertion
for flaky reasons(Splash Screen, LetterBox, BackGestureSurface)
Test: atest WMShellFlickerTests
Bug: 176134495
Bug: 178685668
Bug: 178447631
Change-Id: I1d6153b987e5913a5d9a1fa5b72b9341b40db6fc
The postsubmit tests run using ATP instead.
Bug: 162923992
Test: check the flicker tests dashboard
Change-Id: I5a408a4d241125d97701a59a3852ca894bcf4cc4
Improve flicker memory consumption with the following:
- Use a static factory for better compatibility with JUnit4 ParameterizedRunner
- Ensure `cleanUp` is always called, even when an exception occurs
Bug: 178572522
Test: atest FlickerTests WMShellFlickerTests
Change-Id: Id9e539c0e8bce350f94811cab58a726e47aac525
This assertion is ~30% flaky at the moment
Bug: 162923992
Test: atest FlickerTests
Change-Id: I4abe2869a83ee6de910bd78f41ea0bbe802908f1
(cherry picked from commit 8982df5d9a)
The tests are stable in postsubmit, so they can be moved to presubmit
Bug: 175027130
Test: atest FlickerTests
Change-Id: Ic2e084d92ec2d1db6f87126493440b3be3efd6ba
The tests are stable in postsubmit, so they can be moved to presubmit
Bug: 174658929
Test: atest FlickerTests
Change-Id: Id912152ecc693ed267a10d2d9e8fffa333f6792c
The tests are stable in postsubmit, so they can be moved to presubmit
Bug: 174635878
Test: atest FlickerTests
Change-Id: I5775f1ab4962fb3ffea3cff6db7cce8c0ec0c28d
Use media projection instead of the shell command for screen recording.
Test: atest FlickerTests
Bug: 177077842
Change-Id: I9ac7351bf04004b5512316232637fd5cc2dd5fcc
Runner now prints each assertion individually to aid debugging.
Bug: 162923992
Test: atest FlickerTests WMShellFlickerTests
Change-Id: I1c9a49ec3c283e5e034f0223573fca3ccafaf64c
On flame the IME is using the whole UI and the test app is not visible, when the phone is in landscape mode.
Make the flicker tests compatible with this change.
Bug: 176799414
Test: atest FlickerTests
Change-Id: I52f18e4b6c1dc48758b833fbf4e11e80853effc2
The visible region calculation in the surface flinger doesn't consider that a layer with rounded corners can fully occlude another. Use the same behavior in flicker and winscope.
Bug: 174541970
Test: atest FlickerTests
Change-Id: Ia18f49495d911e17c6493eb5344beb02a4a190e7
Updating split screen tests:
- Adding the assertions visibleWindowsShownMoreThanOneConsecutiveEntry and visibleLayersShownMoreThanOneConsecutiveEntry for all the split screen tests (the layer one is disabled as we need ag/13051160 to ignore one layer).
- Replacing some assertions for other that check more things (i.e. replacing the dockedStackDividerIsVisible assertion for dockedStackDividerBecomesVisible).
- Adding some new assertions to the current tests in order to check for more things.
Adding new WM and layer assertions to Flicker tests to avoid repeating code:
- appWindowBecomesVisible
- layerBecomesVisible
- layerBecomesInvisible
Adding new layer assertions to WM shell to avoid repeating code:
- dockedStackDividerBecomesVisible
- dockedStackDividerBecomesInvisible
Test: atest WMShellFlickerTests
Bug: b/171049797
Change-Id: I2bbb23a1cf92df16ee6292e5da4644936a6d99e5
Updating ReOpenImeWindowTest & OpenAppFromOverviewTest transition to wait for fullscreen app instead of hasWindow as this last one was not completely correct.
Adding the assertions for the test ReOpenImeWindowTest.
Adding also some missing assertions to OpenImeWindowTest.
Moving some tests from CommonAssertions launch file to flicker common assertions so that other tests, besides the lunch ones, can use them:
- wallpaperWindowBecomesInvisible
- appLayerReplacesWallpaperLayer
Adding new IME assertions:
- imeWindowBecomesVisible
- imeAppWindowBecomesVisible
Renaming assertion windowAlwaysVisible to appWindowAlwaysVisibleOnTop to be more clear on what it does.
Test: atest FlickerTests
Bug: b/175197807
Change-Id: I157962d53f1254a04c9abef7c6ad2bd1392b1728
Updating all IME tests with new assertions (visibleLayersShownMoreThanOneConsecutiveTime and visibleWindowsShownMoreThanOneConsecutiveEntry). For the visibleWindowsShownMoreThanOneConsecutiveEntry, adding a new param to it to ignore some windows as the InputMethod window should be ignored as it only shows one time. Same behaviour for visibleLayersShownMoreThanOneConsecutiveEntry.
Also enabling some assertions that were disabled that seems to work.
Test: atest FlickerTests
Bug: b/171049649
Change-Id: I15a6e4934dfc64fd9449d4ff15ce7b1ab881f324
Bug: 174932174
Test: I solemnly swear I tested this conflict resolution.
Exempt-From-Owner-Approval: refactoring with team leads buy-in
Change-Id: I9262a08ffc1ccede8e519d0eed90ed2bfcf0232c
As general background, OWNERS files expedite code reviews by helping
code authors quickly find relevant reviewers, and they also ensure
that stakeholders are involved in code changes in their areas.
Some teams under frameworks/base/ have been using OWNERS files
successfully for many years, and we're ready to expand them to cover
more areas. Here's the historical coverage statistics for the last
two years of changes before these new OWNERS changes land:
-- 56% of changes are fully covered by OWNERS
-- 17% of changes are partially covered by OWNERS
-- 25% of changes have no OWNERS coverage
Working closely with team leads, we've now identified clear OWNERS on
a per-package basis, and we're using "include" directives whenever
possible to to simplify future maintenance. With this extensive
effort, we've now improved our coverage as follows:
-- 98% of changes are fully covered by OWNERS
-- 1% of changes are partially covered by OWNERS
-- 1% of changes have no OWNERS coverage
This specific change is automatically generated by a script that
identifies relevant "include" directives.
Bug: 174932174
Test: manual
Exempt-From-Owner-Approval: refactoring with team leads buy-in
Merged-In: I3480ddf2fe7ba3dfb922b459d4da01fa17a2c813
Change-Id: I3480ddf2fe7ba3dfb922b459d4da01fa17a2c813
Disabling the test ReOpenImeWindowTest as it's crashing the tests on crosshatch and making all postsubmit tests fail.
Test: atest FlickerTests
Bug: b/175027130
Change-Id: I4ff2e059a4afeef1ba74cfbccb4173dd72fca84b
To detect flickers the test should execute multiple times the transition instead of a single one.
Bug: 173688145
Test: atest FlickerTests:ChangeAppRotationTest
Change-Id: I5d28750e2a667c19c0f9263bda8566c6fd818e39
Adding the FlakyTest annotation to the test OpenAppFromOverviewTest as it's crashing on crosshatch.
Test: atest FlickerTests
Bug: b/174658929
Change-Id: I72d689acae51a02c6e6d03e0b7dc4636b9c3d891
Tradefed FilePullerLogCollector can no longer access the internal app directory (e.g. /storage/emulated/0/Android/data/com.android.server.wm.flicker/files).
This makes it unable to pull trace files, when a test fails. This CL makes flicker tests store their data on /sdcard/flicker which can be accessed by the Tradefed FilePullerLogCollector
Bug: 171026227
Test: atest FlickerTests
Change-Id: Ibed6b621b068b0668d93b39838c0959441527295
Marking the two close tests (CloseAppHomeButtonTest and CloseAppBackButtonTest) as flaky as they are crashing when running, and they are blocking post submit runs.
Test: atest FlickerTests
Bug: b/174635878
Change-Id: Ia63d255b60fc48bd7b05d372868ab27b1d0cbef1
The test OpenAppColdTest has been flaky for the past weeks. The assertion visibleLayersShownMoreThanOneConsecutiveEntry is the one we are disabling because of bug b/174541970.
Test: atest FlickerTests
Bug: b/174541970
Change-Id: I4403704c9440283fab44725dc3a445ea16eca138
This reverts commit 2195e8b951.
Reason for revert: Potential culprit for Bug 174223861 - verifying through Forrest before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
Bug: b/174223861
Change-Id: I7b7c53c1fccc05efe2424daafc54cfc18cc754bd
Moving all tests of Pip and SplitScreen from FlickerTests lib to WMShell.
Test: atest WMShellFlickerTests FlickerTests
Change-Id: I5e915f38beb8c1fef44cf18d955caf1e3cc77b30
Adding the Presubmit tag to the CloseAppBackButtonTest and the CloseAppHomeButtonTest so that it runs on presubmit.
Test: atest CloseAppBackButtonTest CloseAppHomeButtonTest
Change-Id: Iae797b11719793e00b6cc299da18e2a68aa052bc
Integrate forceStop() in exit() that PIP window could really
exit after each round of test
Bug: 173567664
Test: atest com.android.wm.shell.flicker
Test: atest com.android.server.wm.flicker.Flicker
Change-Id: I8aaa4f590344f8fb1e6e731ed865f21f63892bb2
Add a new test (only the transition at the moment) that reopens an IME app with focused IME from recents apps and it will check (once we add the assertions) that the IME is still showing.
Test: atest FlickerTests:ReOpenImeWindowTest
Bug: b/171049722
Change-Id: I43f89bb26b6abcaba4b984b0955034bdf41b2977
Adding all the assertions for the CloseAppHomeButtonTest. This includes WM assertions (the common ones for all test + one that the launcher replaces the app window and another that the wallpaper window becomes visible) and layers assertions (the common ones + one for the wallpaper layer replacing the app layer).
Test: atest FlickerTests:CloseAppHomeButtonTest
Bug: b/171049778
Change-Id: I179a39914c71049002c987f5543dfa26ea6225f3
Adding all the assertions for the CloseAppBackButtonTest. This includes WM assertions (the common ones for all test + one that the launcher replaces the app window and another that the wallpaper window becomes visible) and layers assertions (the common ones + one for the wallpaper layer replacing the app layer).
Also adding new assertions in CommonAssertions files (wallpaperLayerReplacesAppLayer, wallpaperWindowBecomesVisible and launcherReplacesAppWindowAsTopWindow).
Test: atest FlickerTests:CloseAppBackButtonTest
Bug: b/171049647
Change-Id: I992edfe372b677d723dda09a0af8fdf9f6213c73
Add a new test CloseAppHomeButtonTest that closes an app by pressing the back button (adding only the transition for now).
Test: atest FlickerTests:CloseAppHomeButtonTest
Bug: b/171049647
Change-Id: I4e234da55dfb893cb4581ba0eed9966f10763414
