Commit Graph

11038 Commits

Author SHA1 Message Date
TreeHugger Robot
efcd6e1ceb Merge "Fix confusing Log.e message in SpellCheckerSession" into pi-dev 2018-03-21 03:25:49 +00:00
Yohei Yukawa
0cf7b31012 Fix confusing Log.e message in SpellCheckerSession
With this CL, calling SpellCheckerSession#close() multiple times will
no longer show the following error message in logcat, which was quite
confusing.

  E SpellCheckerSession: ignoring processOrEnqueueTask due to
    unexpected mState=TASK_CLOSE scp.mWhat=TASK_CLOSE

Note that with a recent CL [1], we now more often see the above
message.  A typical scenario is:

  1. App creates SpellCheckerSession x.
  2. App calls x.close().
  3. x is garbage-collected. ART calls x.finalize(), which internally
     calls x.close() again.

 [1]: I4e00c3a2cec93d1dacff20546e481fe757279661
      9b64367193

Bug: 72974646
Fix: 72974646
Test: Made sure that no error message in question with a test app
      that calls SpellCheckerSession#close() multiple times then
      trigger SpellCheckerSession#finalize().
Change-Id: Ie9690860e6d0406dc6746cd03c28f693e65c1dde
2018-03-21 01:15:02 +00:00
TreeHugger Robot
d0661a081d Merge "Distinguish between createSurface error codes." into pi-dev 2018-03-21 00:40:19 +00:00
Andrii Kulian
982973934d Merge "Don't set override display info for ActivityView" into pi-dev 2018-03-20 22:01:27 +00:00
Andrii Kulian
f0379de259 Don't set override display info for ActivityView
ActivityView content should never be letter- or pillar-boxed
and it doesn't have overscan areas, so we can skip setting
display override info for a virtual display that backs it.

Bug: 72220802
Test: Manually resize with ActivityView demo app
Change-Id: I211449eaea50ec5d3214d63e7eb93a1d2ed2c0fd
2018-03-20 19:43:34 +00:00
TreeHugger Robot
036a2409fc Merge "Dispatching display list recreations also to transient views" into pi-dev 2018-03-19 21:09:31 +00:00
TreeHugger Robot
89b182890c Merge "SurfaceView: Expose hook for subclass to position child surfaces." into pi-dev 2018-03-19 20:32:35 +00:00
Tracy Zhou
017f44be88 Merge "Move default pip position to right above the shelf." into pi-dev 2018-03-19 20:15:14 +00:00
TreeHugger Robot
e24c95fac5 Merge "Fixed isVisibleToUserForAutofill() again." into pi-dev 2018-03-19 19:57:14 +00:00
Felipe Leme
a946d88011 Merge "Fixed AutofillManager.isAutofillUiShowing()" into pi-dev 2018-03-19 18:27:20 +00:00
Felipe Leme
cb2e83da36 Fixed AutofillManager.isAutofillUiShowing()
It was using & instead of &&

Test: not really
Bug: 75652829
Bug: 74527545

Change-Id: Ib8ca79ba6ec35d2fc97f042db2152b03d334ce30
2018-03-19 11:26:23 -07:00
Tracy Zhou
43513086d2 Move default pip position to right above the shelf.
This change takes care of the flow from WindowManagerService to
PinnedStackController, all the way to PipTouchHandler. It also
introduces a WindowManager hook that allows Launcher to pass in
shelf visibility and height. A separate change is made to send
signals from Launcher to SysUI. (ag/3724896)

Bug: 73961893
Change-Id: I2ff54e78bc2dc35c806b902464048b051a4d6394
Test: atest CtsActivityManagerDeviceTestCases:ActivityManagerPinnedStackTests
2018-03-19 17:41:08 +00:00
Felipe Leme
7008e70234 Fixed isVisibleToUserForAutofill() again.
This method should return false when the accessibility provider does not have
an accessibility info for a node. Otherwise, the Save UI is not triggered on
compat mode.

Bug: 75017711
Test: manual verification

Change-Id: Ic1759520a43b4333aef9f8f0e1d93f8d378b131c
2018-03-19 09:55:39 -07:00
John Reck
564284759f Don't use IPC in isolateProcess
Fixes: 74395652
Test: hwuiunit passes in 'shell stop' state (pseudo-isolated process),
      manually checked non-isolated processes still have working vsync
      via systrace of RT animations demo

Change-Id: I630ea011dc7eb2efa265b25673d3304b3b2510d3
2018-03-16 17:34:02 -07:00
Robert Carr
27a800afac SurfaceView: Expose hook for subclass to position child surfaces.
To position child surfaces of a SurfaceView in sync with the main view root
we need to expose the frame number and RT callback. This is of course not API
but we plan to use it with app controlled transitions, for manipulating window
surfaces within a view hierarchy.

Bug: 70341013
Test: Builds
Change-Id: Ibb3645461fac36bda8ab163867fcb2087cadee37
2018-03-16 15:15:17 -07:00
Dake Gu
21935e0c6f Merge "autofill: ViewRootImpl.dispatchKeyFromIme() should not be dropped" into pi-dev 2018-03-16 17:32:25 +00:00
Adrian Roos
e90248c00e Merge "DisplayCutout: Add corner cutout overlay" into pi-dev 2018-03-16 13:01:00 +00:00
Selim Cinek
d6a51b1137 Dispatching display list recreations also to transient views
Change-Id: If40eb8dec82f8b50bd3fa8abdb376db20a1f742a
Fixes: 75033268
2018-03-15 17:11:38 -07:00
Makoto Onuki
70d24a0b1f Merge "Fix deadlock regarding screen-capture-disabled" into pi-dev 2018-03-15 21:01:49 +00:00
Adrian Roos
b8b10f807c DisplayCutout: Add corner cutout overlay
Bug: 74982138
Test: mmm packages/overlays/DisplayCutoutEmulationCornerOverlay/
Change-Id: I06258f417b4ce3b1cc65e046fb18bc856de896c9
2018-03-15 20:09:46 +00:00
Seigo Nonaka
83143d005b Remove mtOffset from drawTextRun
Bug: 72998298
Test: atest CtsWidgetTestCases:EditTextTest
    CtsWidgetTestCases:TextViewFadingEdgeTest
    FrameworksCoreTests:TextViewFallbackLineSpacingTest
    FrameworksCoreTests:TextViewTest FrameworksCoreTests:TypefaceTest
    CtsGraphicsTestCases:TypefaceTest CtsWidgetTestCases:TextViewTest
    CtsTextTestCases FrameworksCoreTests:android.text
    CtsWidgetTestCases:TextViewPrecomputedTextTest

Change-Id: Ia886c1ce9f7387559d7fe00b34ce03378d56ecec
2018-03-15 04:09:19 +00:00
Robert Carr
b0f39361b5 Distinguish between createSurface error codes.
Thusly preventing killing applications in the case of
a missing parent.

Bug: 73664284
Test: Manual. go/wm-smoke.
Change-Id: Iafcd578765fa8fcf603c3f5a6a546e6986f297e8
2018-03-14 17:48:40 -07:00
Jorim Jaggi
c175631670 Merge "Add ability to filter remote animation adapter by activity type" into pi-dev 2018-03-14 21:55:07 +00:00
Makoto Onuki
04ef44761d Fix deadlock regarding screen-capture-disabled
- Introduced DevicePolicyCache, which stores a copy of device policies
that can be accessed with any lock held.

- Removed "wm screen-capture". According to code search, it's not being used,
and this command wasn't really working as intended, since DPM can always
override the manually set value.

Bug: 74277398
Test: atest /android/pi-dev/cts/hostsidetests/devicepolicy/src/com/android/cts/devicepolicy/MixedDeviceOwnerTest.java#testScreenCaptureDisabled,testScreenCaptureDisabled_assist ; \
Test: atest /android/pi-dev/cts/hostsidetests/devicepolicy/src/com/android/cts/devicepolicy/MixedProfileOwnerTest.java#testScreenCaptureDisabled,testScreenCaptureDisabled_assist ; \
Test: atest /android/pi-dev/cts/hostsidetests/devicepolicy/src/com/android/cts/devicepolicy/MixedManagedProfileOwnerTest.java#testScreenCaptureDisabled,testScreenCaptureDisabled_assist
Change-Id: I1968d1c32145a715d0343f25cb9d58939514b597
2018-03-14 12:21:54 -07:00
Jorim Jaggi
77be157a9e Add ability to filter remote animation adapter by activity type
Such that Launcher can choose not to use the remote animation
for assistant.

Test: Open assistant, close it
Test: go/wm-smoke

Bug: 72702760
Change-Id: Ib97cb5dd076afe5535e4e7951f423ccf9e78e720
2018-03-14 17:12:45 +01:00
TreeHugger Robot
d854d917ec Merge "Allow controlling SystemUI flags during RecentsAnimation" into pi-dev 2018-03-14 16:00:49 +00:00
Jorim Jaggi
50bf59ca0d Allow controlling SystemUI flags during RecentsAnimation
Such that the bars can flip from light/dark depending on animation
progress.

Test: go/wm-smoke
Test: Swipe up from light bar app
Test: WindowStateTests
Bug: 73498721
Change-Id: Ie4b99c75840474a01225720fcd7372191f035a3e
2018-03-14 15:11:52 +01:00
Dake Gu
d9dbd27370 autofill: ViewRootImpl.dispatchKeyFromIme() should not be dropped
ag/3628400 bypass unhandled keyevent from autofill to app window,
that solves the issue of using physical keyboard. But we still have
issue When user uses touch screen with IME.

There are two ways that IME interacts with app:
1. IME directly replaces text of TextView. (Sample app login screen)
2. IME calls ViewRootImpl.dispatchKeyFromIme. (Sample app credit card
   screen)

In the second case, because we gave focus to autofill window,
ViewRootImpl will drop the event.

The fix checks if autofill window is showing fillui it should not
drop event. And dispatchKeyFromAutofill can use the same check, no
longer need FLAG_FROM_AUTOFILL.

Bug: 74527545
Test: Manually check with login and credit card example, using IME
touchscreen and "adb shell input keyevent". I am not able to write
cts test without a fake IME

Change-Id: I698423d83ee8f9151d03a39b49e85416f7d6b615
2018-03-13 14:58:38 -07:00
TreeHugger Robot
a56e4bbad0 Merge "Fixed flags when button that trigger autofill is clicked." into pi-dev 2018-03-13 18:45:47 +00:00
Jorim Jaggi
f75d161dd8 Improve animation dump/logging
Bug: 74220420
Test: go/wm-smoke
Test: adb shell dumpsys window during animation
Change-Id: Ib8bddb4f38ad4fe7a80315d3bfdac0a80aea4cc8
2018-03-13 14:06:08 +01:00
TreeHugger Robot
5d92e72482 Merge "DisplayCutout: Support more than one cutout" into pi-dev 2018-03-12 22:45:34 +00:00
Felipe Leme
ef9225e061 Fixed flags when button that trigger autofill is clicked.
Test: atest CtsAutoFillServiceTestCases:SimpleSaveActivityTest#testExplicitySaveButton
Test: manual observation
Fixes: 72937886

Change-Id: Iad8ee6ff6540b07137c8e90c7bb6e77a9fe27a7c
2018-03-12 15:03:55 -07:00
Abodunrinwa Toki
ad52f4b97c TextClassifierService.onSelectionEvent
Bug: 74466564
Bug: 67609167
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Test: bit FrameworksCoreTests:android.view.textclassifier.logging.SelectionEventTest
Merged-In: Ib5af1ec80a38432d1201fbc913acdc3597d6ba82
Change-Id: Ib5af1ec80a38432d1201fbc913acdc3597d6ba82
2018-03-12 19:32:51 +00:00
Adrian Roos
6a4fa0ec18 DisplayCutout: Support more than one cutout
Also makes API more restrictive. Also moves window manager specific
logic out of the framework. Also fixes SystemUI such that it can properly
deal with more than one cutout.

Bug: 74195186
Test: atest DisplayCutoutTest WmDisplayCutoutTest DisplayContentTests WindowFrameTests
Change-Id: Ib7b89e119ce2d3961687579bb81eadce1159a600
2018-03-12 17:26:01 +00:00
Abodunrinwa Toki
9554dd94ec Merge "Merge textclassifier/logging/ into textclassifier/" into pi-dev 2018-03-12 15:16:53 +00:00
TreeHugger Robot
4b306e5e23 Merge "Revert "Revert "Remove a compat hack SurfaceView#setWindowType()""" into pi-dev 2018-03-12 09:45:42 +00:00
Abodunrinwa Toki
f1d939910f Merge textclassifier/logging/ into textclassifier/
This is based on feedback on Ib5af1ec80a38432d1201fbc913acdc3597d6ba82

Bug: 74466564
Bug: 67609167
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest
Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest
Test: bit CtsViewTestCases:android.view.textclassifier.cts.TextClassificationManagerTest
Test: bit CtsViewTestCases:android.view.textclassifier.cts.LoggerTest
Merged-In: Ic8d58acb2bbd63cedcac4aa16940b4ac852aadc8
Change-Id: Ic8d58acb2bbd63cedcac4aa16940b4ac852aadc8
2018-03-10 13:13:14 +00:00
TreeHugger Robot
fe700fc694 Merge "Adding isNotInRecents to RemoteAnimationTarget" into pi-dev 2018-03-10 01:11:27 +00:00
Vadim Tryshev
593e9567fd Adding isNotInRecents to RemoteAnimationTarget
For animations required by Recents, we calculate whether the task is
going to be presented in Recents UI.

Bug: 70789568
Test: Manual: swipe a normal app to Recents; swipe an app with a
      half-screen assistant on top of it to Recents.

Change-Id: I1ec9c36865dd4f57e843ae58811f90f3096365a5
2018-03-09 14:00:32 -08:00
Tarandeep Singh
9219b31067 Revert "Revert "Remove a compat hack SurfaceView#setWindowType()""
This reverts commit 9309c19513.

Reason for revert: We can now remove the deprecated method. Compat hack
is no longer required for keyboards.
Fixes: 62054282
Test: Manually flashed and verified keyboard apps work.

Change-Id: Iae0c82b6fd3fd5930e9eea3216fab76925839e4d
2018-03-09 19:34:51 +00:00
Peiyong Lin
c481d0a43c Merge "Add lockHardwareWideColorGamutCanvas." into pi-dev 2018-03-09 18:19:52 +00:00
Jorim Jaggi
3a78ec6ae4 Merge changes I46e93397,Ie0a157a9 into pi-dev
* changes:
  Also set calling pid when registering for next activity start
  Revert "Revert "Elevate remote/recents animation priority""
2018-03-09 12:05:01 +00:00
Tarandeep Singh
eda9f31218 Remove debug metadata isVrOnly from InputMethodInfo
Change-Id: I1e5ae572ab0f8d53b1b8c4ae1e787aff294c82e0
Fixes: 68948291
Test: Manually built and tested. No changes expected for non-dev apps
2018-03-09 00:15:59 +00:00
Peiyong Lin
d8b6871740 Add lockHardwareWideColorGamutCanvas.
This patch adds a hidden API to return a hardware canvas with wide color gamut
support. The hardware canvas returned from BaseSurfaceHolder.lockHardwareCanvas
doesn't support wide color gamut, this patch makes sure that a wide color gamut
canvas context is created when calling lockHardwareCanvas.

Verified this approach works by building ImageWallpaper to use this API.
Without this API an 8 bit logo P3 doesn't show the logo, with this API the logo
is shown correctly. See b/74116826 for more info.

BUG: 74116826
Test: Build ImageWallpaper using this API with an 8 bit P3 image
Change-Id: Id20343fabcd7f0873d79ce72a235ea9b7c1f3e77
2018-03-08 23:43:35 +00:00
Jordan Liu
805a5ecedb Merge "Support ENVELOPE (EVENT DOWNLOAD - User activity) command" into pi-dev 2018-03-08 19:49:47 +00:00
Jorim Jaggi
bc2aabe845 Revert "Revert "Elevate remote/recents animation priority""
This reverts commit a8b48ab733.

Original issue has been fixed in follow up CL.

Bug: 73555925
Change-Id: Ie0a157a91c3c66df52370adad7b188f59c4749ea
2018-03-08 18:04:21 +01:00
TreeHugger Robot
7b894b3fcd Merge "Show app ops guts when tap app ops icons" into pi-dev 2018-03-08 04:00:37 +00:00
Phil Weaver
fc0c8d9b63 Merge "Fix accessibility action parceling" into pi-dev 2018-03-08 01:49:43 +00:00
Julia Reynolds
b586745d86 Show app ops guts when tap app ops icons
Test: runtest systemui
Bug: 64085448
Change-Id: Ia51044f77311ab705ffb9dd1ae204d0131316396
2018-03-08 01:45:09 +00:00
TreeHugger Robot
a08a8569bf Merge "Fix NPE if app context is null" into pi-dev 2018-03-08 00:15:22 +00:00