Commit Graph

3992 Commits

Author SHA1 Message Date
Mateusz Cicheński
0b6bf0f229 Merge "Make PiP round corners when entering from split screen." into tm-dev 2022-04-08 19:39:26 +00:00
Tony Huang
9074b73ec7 Merge "Remove getSfInstance usage from ViewRootImpl" into tm-dev 2022-04-08 06:41:24 +00:00
Robert Horvath
85c6db27a4 Merge "Change PiP stash scoring to distance moved" into tm-dev 2022-04-08 06:39:14 +00:00
Mateusz Cicheński
c158371dfb Make PiP round corners when entering from split screen.
Bug: 213597585
Test: http://recall/-/b4c7RdloJffWblJ6lo9xVu/YN4EY16KVcTYcRcK5IFZr

Change-Id: I810a040db387d8b1a7c8e11c3a27ba53c0920996
2022-04-08 02:03:46 +00:00
Dave Mankoff
22149274f9 Merge "Remove FileDescriptor from systemui.Dumpable." into tm-dev 2022-04-07 20:19:05 +00:00
Jason Chang
118e6bacdb Merge "Fix One-handed mode tutorial broken on large screen device" into tm-dev 2022-04-07 18:10:11 +00:00
Robert Horvath
2d69b6d442 Merge "Consider all TV PiP stashing directions" into tm-dev 2022-04-07 13:42:21 +00:00
Tony Huang
a825a5c0d9 Remove getSfInstance usage from ViewRootImpl
The getSfInstance usage on ViewRootImpl is target to reduce jank
when moving split divider, but legacy split is going to be depracated
and it didn't used on new split too so we can remove whole related
codes safely.

Bug: 222696368
Test: build pass
Change-Id: Icf9b543bdd1d4bee54efb3be852722f247d1bd47
2022-04-07 18:15:27 +08:00
Tony Huang
19a4ebfacc Merge "Implement center aligned parallax resizng effect" into tm-dev 2022-04-07 05:24:20 +00:00
Shan Huang
f608b18317 Merge "Split predictive back bitmask flags into a few boolean flags." into tm-dev 2022-04-07 00:24:47 +00:00
Mateusz Cicheński
9e7f234b10 Merge "Move PiP when it occludes a keep clear area with naive algorithm." into tm-dev 2022-04-06 20:41:53 +00:00
Dave Mankoff
96985e5212 Remove FileDescriptor from systemui.Dumpable.
This is the first step in moving over to the new public
android.util.Dumpable api.

Bug: 217567642
Test: m SystemUI
Merged-In: Ibaebcfb2c6c5326d0c45b8c72d868c76655d89a0
Change-Id: Ibaebcfb2c6c5326d0c45b8c72d868c76655d89a0
2022-04-05 20:48:27 +00:00
Mady Mellor
ab6aaa765b Merge "Bubble flicker test: Ensure the notification shade is opened" into tm-dev 2022-04-05 16:19:38 +00:00
Pablo Gamito
e2a041cf92 Merge "Update component ids from Winscope to Flicker" am: d41316339d am: 1016b2d3c2 am: b9a97d8d9b
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2055046

Change-Id: If7f4442f602e60ca1a5322e02484cace47ce89a3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-05 15:19:51 +00:00
Pablo Gamito
1016b2d3c2 Merge "Update component ids from Winscope to Flicker" am: d41316339d
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2055046

Change-Id: Id635b8ae570d38e9a935edf30537eb027c7be794
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-05 14:33:00 +00:00
Pablo Gamito
e1dbfe84d4 Merge "Promote and demote flicker tests" into tm-dev 2022-04-05 10:00:29 +00:00
Galia Peycheva
49f5f057b6 Merge "Add edu text to TV PiP" into tm-dev 2022-04-05 06:01:26 +00:00
Galia Peycheva
b26603d090 Merge "Add Tv Pip rounded corners tray" into tm-dev 2022-04-05 05:59:14 +00:00
Pablo Gamito
85c38bd427 Update component ids from Winscope to Flicker
Test: N/A
Change-Id: I5bc614c406535b0f282cb9d948e426e879d3a069
2022-04-04 22:31:02 +00:00
Pablo Gamito
ac56c3acc2 Promote and demote flicker tests
Test: atest FlickerTests WMShellFlickerTests -- --module-arg FlickerTests:include-annotation:android.platform.test.annotations.Presubmit --module-arg FlickerTests:exclude-annotation:android.platform.test.annotations.Postsubmit --module-arg FlickerTests:exclude-annotation:androidx.test.filters.FlakyTest
Change-Id: I10699aed8cd4cfb7e053b32b5a526aa5ce78c584
2022-04-04 21:12:43 +00:00
Tiger Huang
da5263ebd2 Merge "Let TaskSnapshotWindow compute its window frame" into tm-dev 2022-04-04 18:51:59 +00:00
Galia Peycheva
c24734e830 Add edu text to TV PiP
The edu text is added to the bottom of the TvPipMenuView, below the
pip content. This also makes the front and back pip menu surfaces
change size while the edu text is showing. It is shown for 10 seconds
and after that it is hidden by sliding upwards. This repositions the
PiP window so that it is placed properly (centered in case of expanded
pip).

This change introduces temporary decor insets - this is for the edu
text. Temporary decor insets don't interfere with the keep-clear area
algorithm - they will not cause the pip to move if they intersect with
a keep-clear area. They are only taken into account when calculating
the anchor bounds. Permanent decor insets are also taken into account
when calculating intersecting keep-clear areas

Bug: 219884907
Test: manual - start pip and check that the edu text is displayed and
      goes away after 10 seconds
Change-Id: Ie27c633c517903a4bf0b1544626bd00b621c19d4
2022-04-04 14:33:07 +02:00
Galia Peycheva
d2d5e68312 Add Tv Pip rounded corners tray
This CL adds a permanent grey border around the pip surface, which
has rounded corners, and a backing surface, with the same color as the
border. This way the pip surface is sandwiched between the two pip menu
surfaces

Bug: 219883374
Test: m && open app in expanded pip && move pip to opposite edge
    && start dream && wake up dream && toggle expanded pip
Change-Id: Idf22ca22044e7e5e3ca6b39326e3afb76e3ee43c
2022-04-04 14:32:32 +02:00
Mateusz Cicheński
f96f01f76e Move PiP when it occludes a keep clear area with naive algorithm.
This does not adjust the position of PiP after user manipulation,
i.e. PiP can occlude keep clear areas if user drags it on top of them.

Video of the behavior: http://recall/-/g8x7ZkgdfbqscttAA9wzl9/gDH7SgnC3nVLM0FBfWq8iU
Bug: 183746978
Test: manually on device, atest PipKeepClearAlgorithmTest
Change-Id: I3cbc46170df84954f40ff1484aa53ca374f9ce18
2022-04-01 20:59:26 +00:00
Gaurav Bhola
be5abebe9f Merge "Add the insets visibilities requested by the focussed window in topFocussedWindowChanged() api." into tm-dev 2022-04-01 19:57:58 +00:00
Mady Mellor
d1f18027e7 Bubble flicker test: Ensure the notification shade is opened
This test depends on finding the text in the notification. In some
cases the notification might not be visible due to whatever else is
going on on the device.

This change adds a swipe that (based on local testing...) will trigger
the shade to expand while on lockscreen and allow all notification
text to be read / found by UiAutomator.

Update the text in the notification to use "BubbleChat" everywhere
so that it can be reliably found (when the notification is collapsed
or expanded it shows text a little differently & it auto expands
when the shade is expanded and it's the top notification).

Test: atest LaunchBubbleFromLockScreen --iterations 20
    - Ideally get the "app updates are ready" notif by checking for
      updates in settings, when you have this on screen the test
      would fail 100% consistently.
Bug: 205288792
Change-Id: Ib01923f35c531fb15230d640237e2c395ee1904d
2022-04-01 17:54:52 +00:00
TreeHugger Robot
c5866bede0 Merge "Re-deprecate animation backgroundColor API" into tm-dev 2022-04-01 11:48:52 +00:00
Tony Huang
084bdd9ecf Implement center aligned parallax resizng effect
Follow new UI design mock, make resizng smaller side for new
center aligned parallax effect.

Bug: 220985951
Test: manual
Test: pass existing tests
Change-Id: Ia42ad64e9b956ce6f9daa7ea2ccb0d42ac26a322
2022-04-01 19:39:20 +08:00
Tony Huang
86aff45356 Merge "Reduce flicker when resize animation" into tm-dev 2022-04-01 10:10:06 +00:00
Vadim Caen
87a1c2dd46 Merge "Ensure no animation is run except for HOME" into tm-dev 2022-04-01 09:23:26 +00:00
Nick Chameyev
a830367d97 Merge "Migrate unfold animation to Shell transitions [Part 1]" into tm-dev 2022-04-01 09:13:09 +00:00
Pablo Gamito
2b770a7e86 Re-deprecate animation backgroundColor API
It's prefered to keep the API deprecated since the API was previously
deprecated and made a noop. Undeprecating it would lead to inconsistent
behavior across android versions. With the API not working on some
versions which can easily look like a bug from a developer's
perspective.

Instead we create a new API for the animation background effect refering
to an animation backdrop instead of a background. This also required
updating other API references of background in this context to backdrop.

Bug: 226122431
Test: atest CtsWindowManagerDeviceTestCases:ActivityTransitionTests

Merged-In: I4493d22a33606d639d498b6dc0f6f1bfa3d7f135
Change-Id: I4493d22a33606d639d498b6dc0f6f1bfa3d7f135
2022-03-31 23:27:01 +00:00
Hongwei Wang
901e20fdf0 Merge "Do not set shadow when leaving PiP mode" into tm-dev 2022-03-31 23:19:32 +00:00
Hongwei Wang
b1ffb7953c Do not set shadow when leaving PiP mode
Regression from ag/17456722 that setting the shadow radius when leaving
away from PiP would result in screen dimming.

Change to apply shadow radius when entering / moving / resizing PiP only

Bug: 227607130
Test: follow the reproduce steps in bug
Change-Id: Ie4d4dba94a1c66da52825798df60ebf3f971aa32
2022-03-31 18:47:52 +00:00
Tiger Huang
d8aa7f7882 Let TaskSnapshotWindow compute its window frame
When LOCAL_LAYOUT is enabled, TaskSnapshotWindow computes its window
frame on its own.

Bug: 161810301
Test: presubmit
Change-Id: I9e5bf9d5c93055017d303515ea1d1b0048776ebd
2022-03-31 23:28:30 +08:00
Vadim Caen
ff898c6407 Ensure no animation is run except for HOME
... and directly reset the animation state for other cases.

Fixes: 222769294
Test: BackAnimationControllerTest#verifyAnimationFinishes
Change-Id: If04885065076ef7e3c15f5cce2c1d040bd92b494
2022-03-31 15:27:23 +02:00
Nick Chameyev
3f12009a16 Migrate unfold animation to Shell transitions [Part 1]
Adds a trigger to DisplayContent that creates
unfold transition before applying the display size
and marks it as ready when the sizes are applied.

Adds a placeholder animation for fullscreen tasks.

Bug: 204925795
Test: enable shell transitions, open an app, unfold =>
 check that app surface is animated
Change-Id: Ia88178a7c7849a99c17b4d18117a05b2a0fb8b7f
2022-03-31 10:38:56 +00:00
Tony Huang
cfeb154a1b Reduce flicker when resize animation
When resize split, split decor use fade in animation but bottom
larger than bounds area is black, it will make color change from
black to decor background color and it just like flicker.

To avoid this, we should add back using of am#setSplitScreenResizing
which could make black backgound to color similar to app content
background. And it should also reduce flicker while snap divider to
dismiss split.

Bug: 220985951
Bug: 221178408
Test: manual
Test: pass existing tests
Change-Id: I961a4d3ab4f3552fd5ace4b3a6742afa980f073c
2022-03-31 14:47:44 +08:00
Jerry Chang
c3cd94f727 Merge "Make sure to release split layout when returning to home" into tm-dev 2022-03-31 00:37:38 +00:00
Hongwei Wang
b68626be54 Merge "Deprecate getSfInstance usage in PiP component" into tm-dev 2022-03-31 00:12:04 +00:00
Wei Sheng Shih
91da83b715 Merge "Use WeakReference for the TaskSnapshotWindow in inner Window." into tm-dev 2022-03-30 23:59:22 +00:00
Mady Mellor
8649b5088a Merge "Use KeyguardStateController to listen for unlocked shade state" into tm-dev 2022-03-30 23:03:18 +00:00
Hongwei Wang
b2a5b198cd Merge "Handle PiP shadow radius in WMShell" into tm-dev 2022-03-30 22:23:51 +00:00
Hongwei Wang
74092d1e49 Deprecate getSfInstance usage in PiP component
- Deprecated also the custom animation handler in PhysicsAnimator
- Ensures the transactions within PiP have VsyncId being set

Bug: 222697646
Test: verify PiP functionalities still work
Change-Id: Ib9a9bab2ffdc11b887271f4a05ee9953865db8b1
2022-03-30 12:50:54 -07:00
Gaurav Bhola
3b42bacd29 Add the insets visibilities requested by the focussed window in
topFocussedWindowChanged() api.

- This is helpful when DisplaySystemBarsController needs to show/hide
  the bars depending on what the window has requested.

Bug: 224883596
Test: atest DisplayInsetsControllerTest
Change-Id: If00231b96153c9c7830fd948003e00a93c8294cd
2022-03-30 17:14:47 +00:00
Jason Chang
6bf4115606 Fix One-handed mode tutorial broken on large screen device
Change the check statement for Portrait and Landscape, then
only allow Portrait can trigger One-handed mode.

Bug: 223486060

Test: manual
Test: atest WMShellUnitTests
Change-Id: If740164d287dbddadd7cae7b6e7fe17b7bede717
2022-03-31 00:35:12 +08:00
Nataniel Borges
a8acc4954d Merge "Wait for correct surface to disappear on transition" into tm-dev 2022-03-30 15:57:43 +00:00
Shan Huang
342dccd988 Merge "Fix back taking multiple swipes." into tm-dev 2022-03-30 15:00:45 +00:00
Jerry Chang
b3d0379faa Make sure to release split layout when returning to home
When returning to home from recent apps, the splitting tasks were
already hidden while performing the recent transition, so dismiss split
screen directly without requesting dismiss transition. Also reorder to
make sure it collects all clean-up operations before finishing the
transition.

Fix: 226682648
Bug: 206487881
Test: verify with the repro steps of the bug
Change-Id: I05e7ae6fa26631203d652ccb532fb57f532794d7
2022-03-30 06:52:18 +00:00
Mady Mellor
bd04e7d58f Use KeyguardStateController to listen for unlocked shade state
Using keyguard state controller allows us to check the occlusion
state and hide / show based on that as well.

Test: manual - have screensaver turn on and ensure bubbles are hidden
Test: atest BubblesTest NewNotifPipelineBubblesTest
Bug: 223913857
Change-Id: I29992ed76c7cdd4e99b4920849c143f6520f9c42
2022-03-30 00:24:40 +00:00