Commit Graph

839 Commits

Author SHA1 Message Date
Steve McKay
dd27444fa8 Make advanced storage option sticky...
...when used from one of the picker modes.

Bug: 29454465
Change-Id: I5f7db04a51023b59121289afd300a13ea071146d
2016-06-20 11:57:19 -07:00
Steve McKay
56d950c5e6 Include cause when reporting errors.
Bug: 29191892
Change-Id: I5f904da3a8564ec68ca634c28e3eda7f496a5c1c
2016-06-16 10:41:50 -07:00
Felipe Leme
24cc2cea74 Fixed check for visible volume.
Previously it was checked if the volume was visible to user, but
transient volumes (such as USB drives) are not marked as such.

Fixes: 29174953
Change-Id: I5dbcc42c5b31c6856e01f73815d73482822785d9
2016-06-10 12:10:16 -07:00
Felipe Leme
60f8f72cd4 Fixed check for volume name.
There are scenarios - like when an SD Card is adopted as internal
storage - where the getBestVolumeDescription() returns null, in which
case we should use the StorageVolume description instead (or a default
value if such description is also null)>

Change-Id: Ia11c3f4069dfbe252c568210ee60b5d8c384d863
Fixes: 29198046
2016-06-10 11:07:35 -07:00
Ben Lin
de862e1cc8 Merge "Adding docsui prefix to access metric tags." into nyc-dev 2016-06-06 18:04:12 +00:00
Steve McKay
3c6d499858 Don't assert on uris with stack.
This is legal arrangement when viewing Archives.
Bug: 28923366

Change-Id: I75a26edc8dac865f536a7c5bcdef1ba00b0883f0
(cherry picked from commit a379fad3b9)
2016-05-31 20:32:55 +00:00
Ben Lin
1a3b676441 Adding docsui prefix to access metric tags.
Bug: 28934495
Change-Id: I44291b887e8aa9f4412ee1e7e1826ea68ffb40b9
2016-05-26 16:19:21 -07:00
Garfield, Tan
01958b11ef Fix an assertion to avoid crash on deletions in Recent root.
Bug: 28917333
Change-Id: I758c01898a6bb45cbf4975a1e7223efddd17a448
2016-05-26 16:06:04 -07:00
Steve McKay
78951ad998 Fix RTL issue in delete dialog.
Bug:28772371
Change-Id: Ia5d3e074ac40b73f21cc83f507735d0918799966
2016-05-19 11:21:41 -07:00
TreeHugger Robot
fec0d188c1 Merge "Don't show new-window item in Downloads per Gabe." into nyc-dev 2016-05-13 17:26:46 +00:00
Ben Lin
f2413b79c6 Merge "Removed duplicate call to Metric log, and using private logging method." into nyc-dev 2016-05-11 17:36:26 +00:00
Steve McKay
f570c771f2 Don't show new-window item in Downloads per Gabe.
Also, fix regression...don't show "internal storage" option in Downloads.
All other modes, fix inconsistencies in presentation of
internal-storage/new-windows commands by eliminating launch mode inference.
Update VolumeInfo and MTP provider to send correct launch mode extra.

Bug: 28691735,28695347
Change-Id: Ic480925f4c8f1beee4da104a2259c1ce5f28a6a1
2016-05-10 16:25:58 -07:00
TreeHugger Robot
522a437786 Merge "Don't persist selection after restore." into nyc-dev 2016-05-06 22:11:14 +00:00
Ben Lin
ae00a14ae3 Removed duplicate call to Metric log, and using private logging method.
Bug: 28554140
Change-Id: I071c50ef5b51de65e71b85453cf83acae5ad6af7
2016-05-06 12:32:15 -07:00
Steve McKay
99544dd0f4 Don't persist selection after restore.
Bug: 28469988
Change-Id: I1fec774d8ebdec13b33262d7fe8e17fccd84b657
2016-05-06 12:27:49 -07:00
Steve McKay
5acf1ac2ab Fix regression, show internal storage option...
...for non "Downloads" scenarios like "Copy to".
Bug: 28552420

Change-Id: If317e3f575a40cac69628c1b6eecfc6be1dfcbce
2016-05-05 14:38:55 -07:00
TreeHugger Robot
94e3b80d5b Merge "Finish selection mode after copyto and share..." into nyc-dev 2016-05-04 20:58:39 +00:00
Steve McKay
3fff306827 Merge "Disable share when dirs selected." into nyc-dev 2016-05-04 16:46:30 +00:00
Steve McKay
080efafe1f Finish selection mode after copyto and share...
actions are picked by user.
Bug: 27601508

Change-Id: I32cbc8e8eb4abba4161309327d5ce730610193ad
2016-05-03 17:48:22 -07:00
Steve McKay
9efd34e00c Disable share when dirs selected.
Pass a SelectionDetails object instead of a pile of booleans into updateActionMenu.
Normalized "is feature X enabled" naming.
Normalized menu fiddling in FilesTuner.

Bug: 28467604
Change-Id: Ic88fab78adf02f794ef0c0550443a3c075e7bab6
2016-05-03 15:57:27 -07:00
Vladislav Kaznacheev
067d6fadd9 Collect mime type data correctly for all URIs added to ClipData
Bug: 28452937
Change-Id: I883ae2d22e09000137fa484ef66d5070855cd0ed
2016-05-03 15:53:45 -07:00
Ben Lin
2360aa33db Merge "Safe check so we don't move cursor beyond possible pos scope." into nyc-dev 2016-04-27 20:33:52 +00:00
TreeHugger Robot
e597323939 Merge "Terminate DocumentsUI opened for the specific root." into nyc-dev 2016-04-27 01:18:44 +00:00
Tomasz Mikolajewski
b56bc29657 Merge "Exclude virtual files from ACTION_SEND." into nyc-dev 2016-04-27 01:11:04 +00:00
Tomasz Mikolajewski
52036c743c Merge "Fix index computation for quick viewing." into nyc-dev 2016-04-27 00:30:46 +00:00
Daichi Hirono
99900a0e58 Terminate DocumentsUI opened for the specific root.
If USB is opened in DocumentsUI from storage settings and format it from
context menu, a user expects it goes back to storage settings after
formatting the storage.  However, previous we show Downloads as a result
of redirect from the previous USB storage.

The CL changes the logic for callback so that it finishes the activity
if DocumentsUI is opened for the specific root and the root was removed
while a user stays at the root.

Fixes: 28246076
Change-Id: I5548152fc27fd13bd9b75b3083bcfbdd9f93509e
2016-04-26 16:52:44 +09:00
Tomasz Mikolajewski
f61b0b8440 Revert "Precompute cursor indexes in DocumentsUI and improve perf by 2.7%."
This reverts commit 2e4e14789e.

Bug: 28371571
Change-Id: I7aad5eb483c17cccb3485eb22effb677e1ba2160
2016-04-26 11:13:50 +09:00
Tomasz Mikolajewski
f0a56721ae Exclude virtual files from ACTION_SEND.
Bug: 28312221
Change-Id: Ic137ac5e6140cd9e56dc772ada31bb53e451e5f8
2016-04-25 10:21:30 +09:00
Tomasz Mikolajewski
6be540666a Fix index computation for quick viewing.
Bug: 28305994
Change-Id: I8c7abc83bd5ca6f01533a4a7ed0bb995c00833af
2016-04-25 10:00:56 +09:00
Ben Lin
71c7565093 Safe check so we don't move cursor beyond possible pos scope.
Bug: 28278372
Change-Id: I7c66b5229ae3a6a1b99bdf0f02bf1f0b8a1c79b2
2016-04-22 16:13:08 -07:00
Garfield Tan
a5dd3f3240 Merge "Disable view recycling to avoid passing wrong type of view to Item.bindView()." into nyc-dev 2016-04-22 22:47:38 +00:00
Garfield, Tan
360a1964a7 DO NOT MERGE: Disable drag n' drop in DocumentsActivity.
Bug: 28318396
Change-Id: If27bc093b873af5395f69d9139d3fd96e50c0a7b
2016-04-21 16:34:37 -07:00
Garfield, Tan
9eb8818059 Disable view recycling to avoid passing wrong type of view to
Item.bindView().

Bug: 28298672

Change-Id: I1f7442ea3c6287da40b3e5fde25b16c2f2a7b685
2016-04-21 14:09:28 -07:00
Tomasz Mikolajewski
69e3618f07 Merge "Do not make files in zip disabled in ACTION_VIEW." into nyc-dev 2016-04-21 03:17:03 +00:00
Steve McKay
d8c2459b50 Merge "Only show OPEN button as needed." into nyc-dev 2016-04-20 14:25:07 +00:00
Tomasz Mikolajewski
1037af38a4 Do not make files in zip disabled in ACTION_VIEW.
Intent.ACTION_VIEW is only used for browsing ZIP files from Downloads.
FragmentTuner should ignore the MIME type from the MIME type filter.

This CL removes the MIME type filtering logic from FilesTuner, as
I believe FilesActivity is never used for picking items, so there should
be no need to mark any files as disabled.

Bug: 28267117
Change-Id: Iba92f82aca60154674a4bea3265b0f1a3ae296dc
2016-04-20 16:50:25 +09:00
Tomasz Mikolajewski
0fb51357af Merge changes I5e500724,I40cfb12c into nyc-dev
* changes:
  Restrict selection to 1000 items in DocumentsUI.
  Cancel band selection on directory change.
2016-04-20 03:57:28 +00:00
Steve McKay
00c9815d94 Merge "Handle null uris in content changed events." into nyc-dev 2016-04-19 17:10:25 +00:00
Tomasz Mikolajewski
76572d6f19 Restrict selection to 1000 items in DocumentsUI.
Bug: 27208679
Change-Id: I5e500724a3fb9af5b8f59e0c959523da5066b1fd
2016-04-19 08:51:46 +00:00
Tomasz Mikolajewski
4759c9f03f Cancel band selection on directory change.
This is a workaround for N. Ideally we should keep the band selection,
as directory may change very often, eg. during loading, or downloading
a file (every second).

Bug: 27224277
Change-Id: I40cfb12c4f7928c4e0d6e675e91ba30ab3a6ab52
2016-04-19 17:51:05 +09:00
Steve McKay
757fa1b684 Handle null uris in content changed events.
Bug: 28244958
Change-Id: Id3a7adb0ab4a751cfcf6ed3fee4cc6337ce512bb
2016-04-18 17:36:17 -07:00
Felipe Leme
8478bf468e Added extra validation for invalid paths.
In normal circumstances, StorageVolume can only be obtained through
StorageManager and hence it will contain a valid path internally. But
the path could be invalid in at least 2 occations:

- App maliciously changed it using reflection.
- Mounted volume was ejected.

This change improves OpenExternalDirectoryActivity so it returns a
RESULT_CANCELED upon receiveving an invalid path.

BUG: 27962875

Change-Id: Ide43968babaa37961c7b704bd289f44eac952e94
2016-04-18 14:55:15 -07:00
Steve McKay
64bf86503b Only show OPEN button as needed.
Bug: 28182686
Change-Id: I61152015ae5e7b92eead7f42a546ca6055dd426a
2016-04-18 12:22:28 -07:00
TreeHugger Robot
793f859123 Merge "Fallback to Recents when Downloads is not available." into nyc-dev 2016-04-15 23:30:41 +00:00
Steve McKay
8f6387021b Handle delete failure notifications correctly.
Case was omitted in dialog, resulting in UnsupportedOperationException.
Remove a redundant flag check.

Bug: 28204292
Change-Id: I313d61c72596d4a127f61d557af7300f50d26bf0
2016-04-15 11:02:36 -07:00
Tomasz Mikolajewski
30616fcd21 Fallback to Recents when Downloads is not available.
Bug: 28182647
Change-Id: I0ece028f7980c7e55ca64d5aa34e98bdb4d08176
2016-04-15 14:06:09 +09:00
Ben Lin
3a1ae58286 Merge "Disable auto-drawer opening if intent is creating doc on empty dir." into nyc-dev 2016-04-15 00:03:00 +00:00
Steve McKay
f90db0890d Merge "Deal gracefully with empty srcs." into nyc-dev 2016-04-14 19:00:49 +00:00
Steve McKay
cb6903deac Merge "Guard against null clipdata objects." into nyc-dev 2016-04-14 18:44:24 +00:00
Steve McKay
55625a675f Deal gracefully with empty srcs.
Bug: 28184194, 28173827
Change-Id: I6794b147a7e3d3aba73600a87d565bfffe4a4b93
2016-04-14 10:34:08 -07:00