Commit Graph

2279 Commits

Author SHA1 Message Date
satok
e6fee18d16 Merge "Invalidate SuggestionSpan with FLAG_AUTO_CORRECTION when it's removed." into ics-mr0 2011-10-14 11:15:05 -07:00
Joe Fernandez
471fa9d10b Merge "docs: add developer guide cross-references, Project ACRE, Round 2" into ics-mr0 2011-10-14 10:52:33 -07:00
Joe Fernandez
558459fe85 docs: add developer guide cross-references, Project ACRE, Round 2
Change-Id: I39a534ae3a2a34b4dabc333a09961012ef911d3e
2011-10-14 10:18:33 -07:00
satok
75e126f2df Invalidate SuggestionSpan with FLAG_AUTO_CORRECTION when it's removed.
Bug: 5460262

Change-Id: I4ca71020a6d4b7057f60ca99944c479775cca8b7
2011-10-15 01:24:44 +09:00
Adam Powell
2c5b8cc71b Fix bug 5455676 - seek bars without thumbs
Change-Id: I9a4257b91a89cceeca7d5acf9358a8254446c784
2011-10-13 11:44:38 -07:00
Fabrice Di Meglio
9f51384720 Fix bug #5446966 Changing Gravity on a TextView does not change how the text is aligned
- this was a regression introduced when dealing with getLayoutAlignment()

Change-Id: I9571a7976789b768c7cb41560d88b35d67ae3895
2011-10-12 11:43:27 -07:00
Adam Powell
af5280cc71 Fix bug 5173029 - make fast scroller aware of scrolling containers
When a ListView with a FastScroller is located in a scrolling
container, defer the start of the drag operation for a short time or
until a touch slop is crossed. This allows these lists to be placed in
containers like ViewPagers without immediately stealing touch events.

Change-Id: I9b10b6993b24113c5e95c485bf57206747c73a84
2011-10-11 19:06:13 -07:00
Adam Powell
aa4f5c95c3 Fix bug 5434403 - invalidation problem with seek bars at edges
Explicitly invalidate the seek bar thumb area when we change drawable
states for touch down. This prevents the thumb from only being
half-invalidated at the edges since it extends into the view's padding
region.

Change-Id: Icc4e608aca044b2d05f3a9378eced839c03947e6
2011-10-11 15:38:30 -07:00
Svetoslav Ganov
a72a80632b Merge "DO NOT MERGE AdapterView does not set setCurrentItemIndex in accessibility event." into ics-mr0 2011-10-11 13:54:28 -07:00
Svetoslav Ganov
eb0c52e491 DO NOT MERGE AdapterView does not set setCurrentItemIndex in accessibility event.
Cherry picking since branching caught us in the middle of review.

bug:5439637

Change-Id: I67d080abb4c14cad88b952e2f91d65e181b2029b
2011-10-11 11:58:13 -07:00
Svetoslav Ganov
98348517fd DO NOT MERGE AdapterView#isScrollableForAccessibility does not handle null adapter.
Cherry picking since branching caught us in the middle of review.

1. If an AdapterView has no adapter and the view tries to fire an
   accessibility event we get a null pointer exception.

bug:5439321

Change-Id: Ia3d7a5ad852ef42422d10d8a62c4d3af6792313b
2011-10-11 11:54:22 -07:00
Gilles Debunne
f656030a86 Bug 5437846: Crash in SpellChecker
The cached mText field from TextView is not constant overtime.
It is especially changed whne the first character of text is added.
Retrieve the actual current value everytime we use it.

Change-Id: Ie297a3292106879621e54a22e5d03444d442ec96
2011-10-10 15:04:54 -07:00
Gilles Debunne
59ba2b2fab Merge "Bug 5250788: LatinIME slows down as amount of Text increases" 2011-10-10 10:54:51 -07:00
Dianne Hackborn
43ee0ab877 Fix issue #5433910: RTE while adding an account from settings
Make the new marshalling/unmarshalling code for the long sparse
array of ints always consistent.

And sane.

Change-Id: Ifbfbe6e56f59e469acb66257c504b1168d6566fa
2011-10-09 14:11:05 -07:00
Gilles Debunne
287d6c6e12 Bug 5250788: LatinIME slows down as amount of Text increases
Removed unnecessary CharSequenceIterator and made the WordIterator
work on String instead of CharSequence

Submit words to the spell checker by batches.

Refactored WordIterator to make it intrinsically local.

Change-Id: Ie9e30691985a130fa55cd052005ddb22a21761cb
2011-10-07 13:27:52 -07:00
Adam Powell
e0f2515b44 Merge "Fix bug 5399568 - ListView check states inconsistent after data set change" 2011-10-07 11:16:51 -07:00
Adam Powell
14c080497e Fix bug 5399568 - ListView check states inconsistent after data set change
ListView tracks check states in two ways, by position and by ID if an
adapter reports stable IDs. After a data set change there was no
guarantee that the position checked mapping was consistent.

Fix up the position mapping from the ID mapping after a data set
change. In the future this should happen by asking the adapter where a
given ID is now located, but this will require new API and not all
adapters in the wild will implement it. For now make a best guess by
searching in a limited window around the item's last known position.

Change-Id: I70ba89eb103c438b0410c3c6d066acc3918459f9
2011-10-06 19:55:42 -07:00
Svetoslav Ganov
7853c579fa Merge "Fixing errors in position information of scrollable views reported for accessibility." 2011-10-06 15:13:06 -07:00
Svetoslav Ganov
d9ee72fddb Fixing errors in position information of scrollable views reported for accessibility.
1. ScrollView/HorizontalScroll view were reporting only the scroll X and Y but
   failed to convey the max scroll along X and Y so the position can be determined.

2. WebView was not reporting correctly its scroll position for accessibility.

3. Some descendants of AdapterView were reporting incorrect position information.

4. Updated the accessibility docs with some details about the scroll information.

5. Cleaned up duplicated code.

bug:5412132
bug:5412265

Change-Id: I165e73ecde027dad811425b9f395a3f758c923ba
2011-10-06 14:42:58 -07:00
Luca Zanolin
535698c57d Remove the mic from the keyboard in SearchView
Bug: 5357750
Change-Id: I20c87a25e95222772c6b5154d09dd681b966fd9a
2011-10-06 13:36:15 +01:00
Fabrice Di Meglio
764041d213 Fixbug #5387832 [UI/Visual] Address of the website is not displayed properly(second line of the address is partly shown)
- make VERY_WIDE bigger ... 64 times actually

Change-Id: I1a177ef5821d9341abb77ea69a50e05a5bfc97b5
2011-10-05 16:28:18 -07:00
Fabrice Di Meglio
e921572bda Merge "Revert "Fix bug #5387832 [UI/Visual] Address of the website is not displayed properly(second line of the address is partly shown)"" 2011-10-04 17:24:37 -07:00
Fabrice Di Meglio
ad0b051b13 Revert "Fix bug #5387832 [UI/Visual] Address of the website is not displayed properly(second line of the address is partly shown)"
This reverts commit a130e5f59d
2011-10-04 17:21:26 -07:00
Gilles Debunne
8c60235b55 Merge "5402566: Copy/cut icons do not appear if the text is Japanese only" 2011-10-04 10:51:13 -07:00
Gilles Debunne
a13a322e09 Merge "Optimisations and bugs in SpellChecker" 2011-10-04 10:50:54 -07:00
Gilles Debunne
8f3105ff9b 5402566: Copy/cut icons do not appear if the text is Japanese only
When the word iterator return an empty range, select an arbitrary
character so that cut/copy icons are available.

Change-Id: I16e5a3c7f10886db967d870706da7f2d690af013
2011-10-03 18:34:28 -07:00
Svetoslav Ganov
2588a07730 Merge "The logic for not populating text to some accessibility events is scattered." 2011-10-03 18:33:32 -07:00
Svetoslav Ganov
0058f724eb Merge "Accessibility services cannot obtain the source of an event coming from a root namespace descendant." 2011-10-03 17:43:39 -07:00
Gilles Debunne
e1fc4f6c3c Optimisations and bugs in SpellChecker
A bug was introduced in a recent refactoring: correct words didn't have their
SpellCheckSpan removed, leaving a lot of useless spans.

SPAN_EXCLUSIVE_EXCLUSIVE should never have a 0-length. With Japanese characters
wordStart could be equal to wordEnd when parsing the text: skip these.

Using toString().substring(...) instead of subSequence(...).toString() which
is more efficient.

Change-Id: I670870a34565939b676400091f4852152a7f7124
2011-10-03 17:03:57 -07:00
Svetoslav Ganov
2cdedffcfa Accessibility services cannot obtain the source of an event coming from a root namespace descendant.
1. The user can touch the screen at an arbitrary location potentially crossing the root namespace
   bounday which will send an accessibility event to accessibility services and they should be able
   to obtain the event source. Also accessibility ids are guaranteed to be unique in the window.
   Added a package scoped findViewByAccessibilityId method that dives into nested root namespaces.

2. Added accessibility support to the AnalogClock.

bug:5405934

Change-Id: I84edcb554bae41aafcbbc2723c5e62c1ef8a6ddf
2011-10-03 15:07:44 -07:00
Adam Powell
d2b58940f7 Don't obtain attributes for the whole theme when looking for selection
mode drawables.

Change-Id: I82d327e8fcf67baa557245982b2b5ba76ffa9fec
2011-10-03 13:42:41 -07:00
Gilles Debunne
f00b4decc3 Merge "Bug 5327547: re-check word after it (may) have been added to user dictionary." 2011-10-03 12:58:52 -07:00
Gilles Debunne
6771c7fdbe Merge "Bug 5384674: When only one suggestion is returned, it is displayed twice" 2011-10-03 12:58:42 -07:00
Gilles Debunne
d3871c53cf Merge "New underline color for the Voice recognized suggestions" 2011-10-03 12:58:34 -07:00
Svetoslav Ganov
70853772bd Adding accessibility support to the share UI.
Added content description to the overflow button and default
action target as well as content description for the popup
list with share targets.

bug:5398787

Change-Id: Iea1e9d85893899f7d161986cb958595083c79b93
2011-10-03 11:16:40 -07:00
Svetoslav Ganov
82e236d72a The logic for not populating text to some accessibility events is scattered.
1. Some accessibility evenents should not and were not dispatched for
   text population but there was no centralized location for enforcing
   this - rather the system was firing them in a specific way or there
   were conditions in a few places enforcing that. Now this is centralized
   and clean.

2. Updated the documentation with some new event types the were lacking.

3. Explicitly stated in the documentaition which events are dispatched to
   the sub-tree of the source for text populatation.

bug:5394527

Change-Id: I86e383807d777019ac98b970c7d9d02a2f7afac6
2011-09-30 19:55:27 -07:00
Gilles Debunne
845d9c7f7e Bug 5327547: re-check word after it (may) have been added to user dictionary.
Change-Id: Id4f32477c3368a140883dd34c97578aab46b04db
2011-09-30 11:24:53 -07:00
Gilles Debunne
176cd0d3b4 Bug 5384674: When only one suggestion is returned, it is displayed twice
Two separate issues here:
- The results of the spell checker may be identical to the one set by the IME. Since
we merge the spans, the entries are duplicated. Filter spell checker results to avoid
these duplicates.

- When the text is saved on rotation, the spans are saved and restored. Since we start
a new spell check when the window is attached, it also doubles the size.

Change-Id: I21e1a5ae1b264bc97f44d762e4589bf520c6c19c
2011-09-30 11:19:02 -07:00
Gilles Debunne
eba3d92341 Merge "Bug 5384675: Color in add to dictionary" 2011-09-30 10:58:30 -07:00
Gilles Debunne
9fb46925d3 Merge "Bug 5384535: Underline for typo even if there are no suggestions" 2011-09-30 10:58:10 -07:00
Gilles Debunne
5b92a451c0 Merge "Bug 5254884: suggestions are no logner copied in the clipboard" 2011-09-30 10:58:01 -07:00
Gilles Debunne
67ed574cdb Merge "Bug 5250788: EditText gets slower has the entered text gets longer" 2011-09-30 10:57:51 -07:00
Gilles Debunne
c2deadc9f3 New underline color for the Voice recognized suggestions
Change-Id: Icb863942e7c11caca7384deca5c59866d4668256
2011-09-30 10:43:43 -07:00
satok
594cb47654 Merge "Use user's settings for the spell check language instead of the system locale" 2011-09-30 01:52:40 -07:00
satok
70deff4c10 Use user's settings for the spell check language instead of the system locale
Bug: 5390462
Change-Id: Ia2a3981cb93f451646debe5ee6b037313825cf9f
2011-09-30 17:49:40 +09:00
Luca Zanolin
af43add388 Merge "The x and y position of the pop-up where not calculated correctly when the text view had internal scrolling." 2011-09-30 01:01:35 -07:00
Svetoslav Ganov
2783b4fa43 Merge "ActivityChooserView shows "see all" improperly." 2011-09-29 17:54:22 -07:00
Fabrice Di Meglio
46c78b4de1 Merge "Fix bug #5387832 [UI/Visual] Address of the website is not displayed properly(second line of the address is partly shown)" 2011-09-29 17:53:09 -07:00
Svetoslav Ganov
1c07e22c36 ActivityChooserView shows "see all" improperly.
1. The cooser was presenting the "Show all" option if the number
   of available activities was more than the initial max count of activities
   to be shown. Since the show all option is added to the drop down
   the latter becomes effectively one longer than the initial max activity
   count which may make the drop down taller than client expectats. Also
   this leads to the case where if the activities are one more than the
   initial activity count pressing the show all button will just replace
   the show all item with the activity that did not fit - this is somehow
   annoying to the user.

bug:5379282

Change-Id: I2693214cb0b66edb2a3bdffc01ed29139341111c
2011-09-29 16:51:04 -07:00
Philip Milne
a15cb2cda7 Merge "Fix for 5393156" 2011-09-29 15:01:27 -07:00