The teardown() function should only be called from the native
thread when WebCore is happy for us to release the media player.
When we lose audio focus, simply stop playback. Also be careful
not to check the playing state of the MediaPlayer if we are in
the error state.
Bug: 5461143
Change-Id: Iba03bdad5c39b104b3071129430d7ef2177e9358
Make clear that the charset specified in the mediatype portion of a data URL
overrides that specified in the HTML or XML document itself.
Bug: 5418915
Change-Id: Iff7305b6ac9e656d0fb7ed1b2ffe6fd0e21be49b
In overview mode, text wrap is done at reading level scale. If user
changes double-tap zoom in overview mode, reflow text at the new scale.
In any other mode, a double-tap will take user to overview mode, at
which point, the text will be reflowed at the updated reading level
scale.
Bug: 5312461
Change-Id: I29be34a32246019101a9a875e1758e22b5af2bd3
Currently we get the host and port from Chromium as a std::string, convert to a
jbyte array to pass over JNI, then convert to String. It's simpler to convert
directly to jstring and to pass that over JNI.
Requires https://android-git.corp.google.com/g/141234
in external/webkit.
Bug: 5442710
Change-Id: I5480471a841c24481ef09d836a8b0c778251b119
Bug: 5267547
set no suggestions for WebTextView when spellcheck attribute is
false
depends on CL: https://android-git.corp.google.com/g/#/c/141326/2
Change-Id: I4ad476270607e9d600567bbb4d9fd321893707b1
This is used to notify the host application that an SSL error occurred while
loading a resource, but the WebView but chose to proceed anyway based on a
decision retained from a previous response to onReceivedSslError().
Bug: 5403366
Change-Id: I51a25b93d7824b7eb7b6d5a961cba948e37c85db
1. ScrollView/HorizontalScroll view were reporting only the scroll X and Y but
failed to convey the max scroll along X and Y so the position can be determined.
2. WebView was not reporting correctly its scroll position for accessibility.
3. Some descendants of AdapterView were reporting incorrect position information.
4. Updated the accessibility docs with some details about the scroll information.
5. Cleaned up duplicated code.
bug:5412132
bug:5412265
Change-Id: I165e73ecde027dad811425b9f395a3f758c923ba
These warnings appear occasionally and this will help track them down.
Also removes an unused method.
Bug: 5421676
Change-Id: I5ba3f146449623e3457aafc91fd2e7edc367a9d9
We need to set the size of the text used in the autocomplete
drop down in pixels, as we do when setting the size of the
EditText itself.
Bug: 5420125
Change-Id: Ife6d8c108c57106ffaa8706fa9e4e537a73a1733
Bug: 5403763
Prevent rapidly switching between a null adapter and a valid
adapter by only clearing if the node pointer changes or the text view
is no longer autocompletable.
Change-Id: Ie594396db807b5ad5e1a5a0e68ec0c7677364aaf
We should only re-use a cached 'allow' decision if the decision ...
- is for the same host
- is for an error which is at least as severe as the current error
Bug: 5409251
Change-Id: Id8516f58c8d23de44e80539ffeaf945be3d2914a
- Fix a comment in BrowserFrame.certificate()
- Simplify SslCertLookupTable by not storing 'deny' decisions.
We only need to store 'allow' decisions, as we don't re-use 'deny' decisions.
No change in behaviour.
Bug: 5409251
Change-Id: I447cd1966fbb6c2dea8088b2e4c4e2de22405cb9
- Use assert rather than junit.framework.Assert
- Add some comments
- There's no need for checkSslPrefTable() to call handleSslErrorResponse() as
we'll never update the table. Instead call
LoadListener.handleSslErrorResponse() directly.
No functional change.
Bug: 5409251
Change-Id: I0c6cdae43fa966f86f4a6c43b74c2f2a01f60319
https://android-git.corp.google.com/g/#/c/133348 changed BrowserFrame to
construct the SslError using only the host. This was done so that we match on
just the host component of the URL when re-using previous decisions in case of
an SSL error. It also means that the browser displays only the host when it
shows the SSL error dialog.
This change fixes BrowserFrame to pass the full URL to SslError. We modify
SslCertLookupTable to keep the existing behaviour regarding matching on only the
host component. There's no need to change Browser to continue displaying only
the host as I think this change was an unintentional side-effect.
Also remove dead code-path in BrowserFrame.reportSslCertError(). This
method is used only with the Chromium HTTP stack. This code was added
in https://android-git.corp.google.com/g/#/c/121023.
No functional change.
Bug: 5410252
Change-Id: Ief2dbf4558095fb6fa7ab0caac7d37fa4f640b66
Directly update the layers transform and position.
This makes updates faster and less dependent on other webkit work.
bug:5218173
Change-Id: I5f784ef64eda1be3cee406aa23702e5378c8de9e
bug: 5385775
Check mWebViewCore has been destroyed
Remove mWebTextView from WebView when WebView is destroyed
Clear WebTextView's handler when it is removed from WebView
Change-Id: I9c62292d693109e692c341e3e4dba3e04af81fe4
Multiple focusable windows cause undesired behavior around selection
modes. TextView isn't sure how to behave when it loses window focus
with regard to selection handles and action modes need to be focusable
for WebView find on page since it uses an EditText as a custom view.
For now:
* Use a layered window decor for overlay action mode when there is no
action bar requested. This eliminates an extra window and avoids the
issue described for full-screen UIs.
* Disable WebView's find-on-page mode when the action mode's UI will
not be focusable. This only affects WebViews in floating windows.
Also remove the "Text Selection" title for WebView's selection mode at
UX's request, as it is inconsistent with TextView's selection mode and
the string does not fit on phones in portrait even on wide
devices. This now uses the same mechanism used in TextView to decide
whether to use title text.
Change-Id: I80caeecea9b47728cf26bb0a388153ca0bdeafe1
