Commit Graph

15 Commits

Author SHA1 Message Date
Aaron Liu
cfcd42a273 [Bouncer] Add initial text for bouncer.
Add intiial text for pin, password, and pattern screens in onResume.

Bug: 228047010
Test: Manual on Device.
Change-Id: I1718816508342c601b8bdabb144ec77d46c94755
2022-06-06 08:57:44 -07:00
Aaron Liu
0859177c73 Merge "Revert "Bouncer: Add title for each auth screen."" into tm-dev 2022-03-10 18:32:26 +00:00
Aaron Liu
7657fa90b5 Revert "Bouncer: Add title for each auth screen."
This reverts commit 22941ed02d.

Reason for revert: title is shown when viewcontroller onPause is called. We might want to set the title in a more specific place

Change-Id: I9a1618aa1961f5a2a37de92cb5ecc87bebcbbdeb
2022-03-10 03:23:22 +00:00
Aaron Liu
778aa79fc7 Bouncer: Add error animation for buttons
Adds an animation for buttons when there is an incorrect entry.

Bug: 222541046
Test: Test on device
Change-Id: I4ac82e0b623d567f697b5bc62c082ae0d9561871
2022-03-08 17:27:43 +00:00
Aaron Liu
22941ed02d Bouncer: Add title for each auth screen.
On reset state in the view controller, set the security message to be
the default text. It seems like this copy already exists.

Bug: b/218833792
Test: Manual test on multiple devices
Change-Id: I5d704255622864a8593ce1b31747a36ec95224bb
2022-03-04 22:07:44 +00:00
Dave Mankoff
db4ee91dce Revert^2 "Add Controller for Emergency Button."
f23acf33ff

Change-Id: Id555c35af9a5ed2570504cd6b4e3ca3b5892c340
2021-03-23 10:48:27 -04:00
Dave Mankoff
03c717447d Add continuous falsing to keyguard.
With this change, taps outside of the bouncer inputs increase the
FalsingManager's belief that erroneous taps are happening. If the
belief becomes strong enough, the bouncer will be retracted.

Special attention is given to ensure that actual password inputs
are not recorded by the falsing manager. Valid button and pattern
inputs do not have their motion events recorded, but do _decrease_
the FalsingManager's belief in pocket dialing. Thus, a few bad taps
mixed with good taps will not retract the bouncer.

Test: atest SystemUITests && manual
Bug: 172655679
Change-Id: Iac8d2a2f41764f3c1cccb66b9d332c489cabca77
2021-03-10 16:42:23 -05:00
Dave Mankoff
8d0f3a0c3c Incorporate Bayes into Falsing.
This uses the HistoryTracker on pin-based input to determine if a
tap outside of an intended region is a false touch, retracting the
pin input if we believe pocket dialing is occuring.

To do this, the cl properly integrates the HistoryTracker into
falsing, at least for single taps.

Most importantly, HistoryTracker#falsingBelief now return 0.5 when
it is unsure if a tap is false or not, and tends towards 0 when it
believes it's valid and 1 when it believes it's false.
HistoryTracker#falsingConfidence remains unchanged.

Test: atest SystemUITests && manual
Bug: 172655679
Change-Id: Ie771b1bf8ac564af7ffb68e190772fff5c562e89
2021-03-10 16:42:23 -05:00
Alec Mouri
f23acf33ff Revert "Add Controller for Emergency Button."
Revert submission 13536242-b179775696-depenency-get-keyguard

Reason for revert: Candidate reversion for broken tests: b/180440298
Reverted Changes:
I6d0271692:Add ViewController to CarrierText.
I4d9a4a21f:Add Controller for Emergency Button.
I4c76d99f9:Remove Dependency.get from KeyguardSliceTextView.
I730593fcf:Add injection to ClockProvider.
Ifbb93e624:Remove Dependency.get from KeyguardStatusView.
I237215456:Remove final calls to Dependency.get from keyguard...

Change-Id: I7b46dbad24050cfe6a363131549169602fda1f13
2021-02-18 11:39:15 -05:00
Dave Mankoff
f8cb6b2458 Add Controller for Emergency Button.
This removes all the calls to Dependency.get from EmergencyButton.

Bug: 179775696
Test: atest SystemUITests && manual
Change-Id: I4d9a4a21fe8a8a0306b110a2fbaaa3ea91507d05
2021-02-16 12:28:55 -05:00
Dave Mankoff
7860852d3b Connect FalsingManager to HistoryTracker.
With this change, the analysis of gestures actually gets added to our
HistoryTracker. Prior to this, HistoryTracker was only ever being
exercised in tests.

The one trick that this addresses is that invalid single-taps can't
immediately be added to the HistoryTracker, as they may become
_valid_ double taps. We don't want double taps to be penalized.

Bug: 172655679
Test: atest SystemUITests
Change-Id: I2e5ece6af82eb20f053b6b17298dcd9002236e39
2021-01-05 15:57:54 -05:00
Dave Mankoff
8848abd1b5 Add ability to ignore gestures in FalsingManager
This gives other parts of the system the ability to temporarily
override the falsing manager, telling it to ignore a given gesture.

The intent is to give other parts of the system a chance to include
their own falsing information (such as whether a button was tapped or
not), giving the FalsingManager more context about what is going on.

As of right now, their is no way to feedback this context-aware
falsing information back to the FalsingManager. An API for this is
still being explored.

Bug: 172655679
Test: atest SystemUITests && manual
Change-Id: I87ee94a2386622ebff7580346325ae07e3bb5f5d
2021-01-05 15:55:22 -05:00
Dave Mankoff
dc01930044 Revert^2 "7/N controllers for remaining Keyguard Password ..."
Revert submission 12656261-revert-12585643-b166448040-keyguard-message-area-NUUJOVRYJS

This also fixes the original issue introduced in this CL.
KeyguardAbsKeyInputViewController#reset would call mView#resetState
instead of its own internal resetState method. However, all the logic
from the various resetState methods had been moved from the views to
their controllers. Simply calling resetState direclty resolves the
issue (line 105 of KeyguardAbsKeyInputViewController).

Reason for revert: Fixing http://b/169231892 and http://b/169145796
Reverted Changes:
I7683b2234:Revert "4/N Setup Controller fo KeyguardSecurityCo...
I5cbe04c0c:Revert "5/N Add KeyguardSecurityViewFlipperControl...
I11dff38ad:Revert "6/N Add Controller for KeyguardPatternView...
I55c250121:Revert "7/N controllers for remaining Keyguard Pas...
Ie84234cb8:Revert "8/N Remove View Injection from KeyguardMes...
Ic62f199a5:Revert "9/N Clean Up Keyguard Class Structure"

Change-Id: Ie3669e0c9a23ffd4443ced0fb08ec754f1df55db
Fixes: 169145796
2020-09-24 11:04:51 -04:00
Dave Mankoff
bdc667325a Revert "7/N controllers for remaining Keyguard Password Views."
Revert submission 12585643-b166448040-keyguard-message-area

Reason for revert: http://b/169081305 & http://b/169020145
Reverted Changes:
I6fa05012c:4/N Setup Controller fo KeyguardSecurityContainer....
Iecf265744:5/N Add KeyguardSecurityViewFlipperController.
I90ab99b2f:6/N Add Controller for KeyguardPatternView
I4b74eddd1:7/N controllers for remaining Keyguard Password Vi...
I805286374:8/N Remove View Injection from KeyguardMessageArea...
I362755980:9/N Clean Up Keyguard Class Structure

Change-Id: I55c250121c2e234a41b30f2d647c44f6cb631028
Fixes: 169081305
Fixes: 169020145
2020-09-22 13:25:57 +00:00
Dave Mankoff
1d569867a4 7/N controllers for remaining Keyguard Password Views.
No real functionality changes (hopefully). Just moving
objects into controllers.

Test: manual
Bug: 166448040
Change-Id: I4b74eddd18d29dd8966caa32c5960ff8be2e6f43
2020-09-16 16:24:56 -04:00