Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
835,084 Commits 3 Branches 0 Tags
bd2df678ff59cc03ee6fbdcbc805fa3f3b1467c8
Commit Graph

9498 Commits

Author SHA1 Message Date
Steven Terrell
da54b2835e Merge changes from topic "cursor-bg-blink-cp" into tm-qpr-dev am: 131fb1ff89 am: b2eba6b95d 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19955684

Change-Id: I61543684ba63c8a2aa9ee5c9e1b6f9df92d5d2a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-17 12:16:58 +00:00
Steven Terrell
b2eba6b95d Merge changes from topic "cursor-bg-blink-cp" into tm-qpr-dev am: 131fb1ff89 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19955684

Change-Id: I896302084978f6f22cc52167f981d62feaedc31a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-16 03:15:41 +00:00
Steven Terrell
e23d904d4a Stop cursor from blinking when not visible am: 4ec6dfc389 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19758504

Change-Id: Id4fd25b59737a3095366280de62ab484bda75193
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-09-16 03:15:20 +00:00
Steven Terrell
131fb1ff89 Merge changes from topic "cursor-bg-blink-cp" into tm-qpr-dev 
* changes:
  Add Ability to Check if Cursor is Blinking
  Stop cursor from blinking when not visible
 2022-09-16 02:46:30 +00:00
TreeHugger Robot
085455fd72 Merge "Fix: EditText returns wrong CursorAnchorInfo matrix" 2022-09-16 00:39:48 +00:00
Steven Terrell
d2acc476d0 Add Ability to Check if Cursor is Blinking 
adds a method for returning whether the cursor is blinking based on the
current value of the mCancelled property in the Blink class.  This
method is only inteded to be used for testing purposes.

Bug: 228354442
Test: manual, method is called in CtsWidgetTestCases:EditTextTest#
      testSuspendAndResumeBlinkingCursor,
      testCursorBlinkingOnNewActivity_WithFocus,
      testCursorNotBlinkingOnNewActivity_WithoutFocus
Change-Id: I02849f6e105cbfe7af78dfb34ffbf1ebbb4a82ae
 2022-09-15 22:42:43 +00:00
Haoyu Zhang
85dfb5e356 Fix: EditText returns wrong CursorAnchorInfo matrix 
Bug: 245025737
Test: tested manually
Change-Id: Ia8b0b25582cc89b5729cebc27426f54bc3d8007d
 2022-09-15 08:06:09 -07:00
TreeHugger Robot
268f971575 Merge "Cancel selection animation when new selection arrives" 2022-09-13 12:56:07 +00:00
Zeyin Wu
8d937f340a Merge "Send AccessibilityEvent.CONTENT_CHANGE_TYPE_INVALID when TextView set errors" 2022-09-12 16:45:38 +00:00
Seigo Nonaka
8a147ba6dc Merge "Implement Ctrl+B/I/U shorcut" 2022-09-09 04:19:47 +00:00
Zeyin Wu
7f8a4a2ff3 Send AccessibilityEvent.CONTENT_CHANGE_TYPE_INVALID when TextView set 
errors

Bug: 230141621
Test: atest android.widget.cts.TextViewTest & verified on talkback_tests
Change-Id: I35f60820a5f366f186ff500cbbc77f45c278660d
 2022-09-08 19:52:12 +00:00
Seigo Nonaka
9a13cec9a1 Cancel selection animation when new selection arrives 
The onAnimationEnd callback will set the selection but there is a race
condition that the new selection may arrive during animation.
The later selection should be honored, so cancel the ongoing animation
before starting new selection.

Bug: 244273440
Test: Manually done on the Pixel 5 with wireless mouse
Change-Id: I977f6cc9244e571caddfe0d79e10ee1c6c8a413d
 2022-09-08 18:03:04 +09:00
Seigo Nonaka
66260c6045 Implement Ctrl+B/I/U shorcut 
These shortcut works as follows:

- If the selected region is empty, do nothing.
- If the selected region has at least one character that is not styled,
  e.g. bold, apply bold style.
- If the selected region is fully styled, e.g. bold, remove bold style
  from the region.

The default TextView/EditText supports styled editing, but it is used
commonly as plain text fields, e.g. email address in the form, etc.
So, not to style the text in such places, disable styled shortcut by
 default and let developers to enable it when necessary.

Bug: 240628246
Test: TextViewStyleShortcutTest
Change-Id: Id0f1cd85eb198553a852c5c2b628f5d03a2741e1
 2022-09-08 13:41:42 +09:00
Haoyu Zhang
7cf6d0618c Merge "Checking TextOperationUser when initialize stylus handwriting" 2022-09-02 09:05:15 +00:00
TreeHugger Robot
25f2a588fa Merge "Assign redo action to Ctrl+Y shortcut" 2022-09-02 07:05:16 +00:00
Seigo Nonaka
96bedec89c Assign redo action to Ctrl+Y shortcut 
Bug: 244262525
Test: atest TextViewKeyboardShortcutTest
Change-Id: I43021b42f8f080990600e9fa84ae6dc40ebae148
 2022-09-02 14:27:00 +09:00
TreeHugger Robot
d7a11eca6f Merge "Provide gesture result" 2022-09-02 02:20:16 +00:00
Haoyu Zhang
3f655af0b3 Checking TextOperationUser when initialize stylus handwriting 
Bug: 237418160
Fix: 244475514
Test: atest HandwritingInitiatorTest
Change-Id: I6c87d034d5bef28383db70f587bdd0ee2db77a79
 2022-09-01 18:44:19 -07:00
Haoyu Zhang
49bd302a80 Merge "Introduce visible line bounds to CursorAnchorInfo" 2022-09-01 18:56:12 +00:00
Justin Ghan
19bf9c65a1 Provide gesture result 
Bug: 240435922
Test: atest android.widget.cts.TextViewHandwritingGestureTest
Change-Id: I33590176445ee4cf697499688a06fda24bf0cbcf
 2022-09-01 10:09:28 -07:00
Haoyu Zhang
4976e19609 Introduce visible line bounds to CursorAnchorInfo 
Add visible line bounds to CursorAnchorInfo for IME to improve
scribe rich gesture recognization accuracy.

Bug: 215533103
Bug: 239843501
Test: manually tested
Change-Id: I7039b75388ae34d24feb38d18d8da9a91df89504
 2022-09-01 05:07:37 -07:00
Justin Ghan
496de1565d TextView report supported handwriting gestures 
Bug: 244355876
Test: atest android.widget.cts.TextViewHandwritingGestureTest
Change-Id: Ie0263f4732a329089be171fbb24d7473c667ceb5
 2022-08-31 08:43:14 -07:00
Seigo Nonaka
ce46186c15 Merge "Move mLastInputSource member to TextView from Editor" 2022-08-30 01:59:22 +00:00
Alan Viverette
411af7b504 Merge "Fixed the reference to the compat version of the widget. Revised the class description." into tm-dev am: 96d92cfeda am: 86fec4c5ad am: 1e6efa818e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19748654

Change-Id: I1722a5c7993ac4d6a09d2b1736df83a66f2cc8ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-29 15:46:03 +00:00
Alan Viverette
1e6efa818e Merge "Fixed the reference to the compat version of the widget. Revised the class description." into tm-dev am: 96d92cfeda am: 86fec4c5ad 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19748654

Change-Id: I295cfcd5d4070eefef89c9dc16b38e7aaec13199
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-29 15:21:09 +00:00
Seigo Nonaka
d68f864369 Move mLastInputSource member to TextView from Editor 
The ActionMode could be initiated from LinkMovementMethod
which can be handled without Editor instance. So, moving
mLastInputSource member from Editor to TextView.

Test: TextViewIntegrationTest TextViewMouseInteractionTest
Bug: 243922672
Change-Id: I05679f8dbd30fd69e11ed4e315b5b309647ecafb
 2022-08-29 12:19:07 +09:00
Justin Ghan
3ebab3f7c2 TextView implementation of insert gesture 
Bug: 240435922
Test: atest android.widget.cts.TextViewHandwritingGestureTest
Change-Id: I3c7eb06925081bd5e699999c69437ef8bb929741
 2022-08-26 23:19:28 -07:00
Justin Ghan
8b5d4bd91e TextView implementation of select and delete gestures 
Bug: 240435922
Test: atest android.text.LayoutGetRangeForRectTest
Test: atest android.widget.cts.TextViewHandwritingGestureTest
Change-Id: I6ceaa4555b82f1c2650d2db3bf39674641d53b8f
 2022-08-26 23:18:00 -07:00
Steven Terrell
4ec6dfc389 Stop cursor from blinking when not visible 
Cursor continues to blink in a text field even when the text field is
not currently visible. This change checks the visibility of the window
that houses the text field in addition to checking if the view is in
focus.

Bug: 228354442

Test: Added logging to the shouldBlink() method ran following steps:
     1: open contacts app
     2: tap add new contact, tap in an edit field
     3: move back to home screen
     4: lock screen, then unlock screen
     5: observed logs written out to logcat console when app not
        visible.
     after change logs no longer printed to console, cursor still blinks
     correctly after app is re-opened or when new field becomes in
     focus.
Test: CtsWidgetTestCases:EditTextTest#
        testCursorNotBlinkingOnNewActivity_WithoutFocus()
	testCursorBlinkingOnNewActivity_WithFocus()
	testSuspendAndResumeBlinkingCursor()
Change-Id: Iad4396e5f7fd810344c711320d65c57ea25eda70
Merged-In: Iad4396e5f7fd810344c711320d65c57ea25eda70
 2022-08-26 20:31:56 +00:00
TreeHugger Robot
c7ab586fa3 Merge "Use event source for the UI visibility" 2022-08-26 10:53:19 +00:00
Seigo Nonaka
8630c53160 Use event source for the UI visibility 
Bug: 240383641
Test: atest TextViewMouseInteractionTest
Change-Id: Iefc5c27a05c716b06678266582a89c275a3a74f2
 2022-08-26 13:24:06 +09:00
Daniel Norman
47d8fe5c9f Merge changes from topic "reland-a11y-adp" 
* changes:
  Tweak behavior of isAccessibilityDataPrivate() to reduce CPU usage.
  Revert "Revert "Limit off-label accessibility access using a new..."
 2022-08-25 23:25:12 +00:00
joneckenrode
6dbcd1f835 Fixed the reference to the compat version of the widget. Revised the class description. 
Cherry-picked from CL 19211934 merged on master. See https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/19211934.

Test: Built API documentation
Change-Id: If74178eba609346eb7cf9e462bdb3edf40db4d81
 2022-08-25 23:18:47 +00:00
Jon Eckenrode
02516202f1 Merge "docs: Edited API documentation related to line-break and line-break word styles." into tm-dev am: 1914a2f78e am: 0e9d7be16e am: 638d45938c 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19669167

Change-Id: I309ce5c008792c52c581dcc19b77e63b05f55aef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-25 19:42:07 +00:00
Jon Eckenrode
638d45938c Merge "docs: Edited API documentation related to line-break and line-break word styles." into tm-dev am: 1914a2f78e am: 0e9d7be16e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19669167

Change-Id: I8c7e51969b81ec6f66c6009567d9805debe48ecc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-25 19:24:31 +00:00
Riley Jones
1c04b58273 Merge "Giving RatingBar a default custom StateDescription for more descriptive TTS output." 2022-08-24 20:12:36 +00:00
Alex Stetson
eca458e0fe Merge "Fixed divider rendering in RTL languages" into tm-qpr-dev am: 2cd24931e3 am: 4ce48b4d83 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19295691

Change-Id: Ib550629875d9f2de86d5e0797148c9f73c1a23a6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-24 19:54:45 +00:00
Alex Stetson
4ce48b4d83 Merge "Fixed divider rendering in RTL languages" into tm-qpr-dev am: 2cd24931e3 
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19295691

Change-Id: Ie1a410591ed21da53d32cb59a9c6c8427922f728
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-08-24 19:40:20 +00:00
Alex Stetson
2cd24931e3 Merge "Fixed divider rendering in RTL languages" into tm-qpr-dev 2022-08-24 19:32:59 +00:00
Jon Eckenrode
32cd0a63d4 Merge "Docs: Touch-up of parameter descriptions and tags for consistency." 2022-08-24 18:04:56 +00:00
Zeyin Wu
dabec9ef59 Merge "Add accessibility expand/collapse action to node info" 2022-08-23 21:21:53 +00:00
joneckenrode
bf5d4d5190 docs: Edited API documentation related to line-break and line-break word styles. 
Files patched from CL 19608033, https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/19608033.
Could not cherry-pick CL because LineBreakConfig.java on master contains Android U code.

Staged to:

https://android.devsite.corp.google.com/reference/android/widget/TextView

https://android.devsite.corp.google.com/reference/android/R.attr

https://android.devsite.corp.google.com/reference/kotlin/android/R.attr

Test: Built API docs
Change-Id: Ie322096ee2cc0ab3e24bb7d2ff8c398e8861726f
 2022-08-23 20:55:59 +00:00
Daniel Norman
60bb7c9bca Revert "Revert "Limit off-label accessibility access using a new..." 
Revert submission 19637776-revert-19246592-accessibility-tool-only-VJOPAMQMLT

Reason for revert: Relanding with fix
Reverted Changes:
I701b811fd:Revert "Limit off-label accessibility access using...
I85c58736b:Revert "CTS tests for the accessibilityDataPrivate...

Change-Id: Idfb12294c4ba75dfba8abd90985dea548d29042a
 2022-08-23 20:40:08 +00:00
joneckenrode
66504044ed Docs: Touch-up of parameter descriptions and tags for consistency. 
Staged:

https://android.devsite.corp.google.com/reference/android/widget/TextView

https://android.devsite.corp.google.com/reference/android/graphics/text/LineBreakConfig

https://android.devsite.corp.google.com/reference/android/graphics/text/LineBreakConfig.Builder

Test: Built API docs
Change-Id: I68d5228b2f952876c81f8590ccf69d68733f2741
 2022-08-23 17:48:53 +00:00
Zeyin Wu
1d59f48e7c Add accessibility expand/collapse action to node info 
Bug: 213940323
Test: ran atest android.widget.cts.ExpandableListViewTest and manually verified through talkback tests.
Change-Id: I8e9523781edd0dfd76c422da219beccf1a39a298
 2022-08-22 18:00:09 +00:00
Riley Jones
9e99f1cfd0 Giving RatingBar a default custom StateDescription 
for more descriptive TTS output.

Test: CTS tests included in topic
Bug: 149794211
Change-Id: I67945f7025ad29b3d11a33fd1ecec4b231966be5
 2022-08-17 01:34:09 +00:00
Daniel Norman
1e924c4709 Merge "Revert "Limit off-label accessibility access using a new property."" 2022-08-16 23:17:30 +00:00
Jon Eckenrode
0004b75dbf Merge "docs: Edited API documentation related to line-break and line-break word styles." 2022-08-16 21:48:11 +00:00
Daniel Norman
ff3c059c29 Revert "Limit off-label accessibility access using a new property." 
Revert submission 19246592-accessibility-tool-only

Reason for revert: Jank regression b/242267091
Reverted Changes:
I0685e6dd4:CTS tests for the accessibilityDataPrivate propert...
I1c02af88c:Limit off-label accessibility access using a new p...

Change-Id: I701b811fd4fb2634872a759134356736a7e8b7dd
 2022-08-16 16:13:28 +00:00
TreeHugger Robot
7e56ce1098 Merge "Hide text UIs for mouse interaction" 2022-08-15 03:23:19 +00:00