Commit Graph

324 Commits

Author SHA1 Message Date
Pablo Gamito
93a3db084b Update Flaky annotation
We will now only support the  annotation for flaky flicker tests so we need to update all tests that still use the  to use that.

Bug: 233876784

Test: atest FlickerTests
Change-Id: Ib693a64c1367c17b4644247dd51c6c2c15de15e6
2022-06-07 19:20:21 +00:00
Mateusz Cicheński
e86b8edc91 Merge "Add a flicker test for entering PiP via navigation to Home" into tm-qpr-dev 2022-06-02 20:40:28 +00:00
Mateusz Cicheński
25cfccaaa0 Add a flicker test for entering PiP via navigation to Home
Bug: 216577639
Test: atest WMShellFlickerTests:EnterPipOnUserLeaveHintTest

Change-Id: I59448191a22c31e4591346de58695ff653e3687f
2022-06-01 17:27:20 +00:00
Chilun Huang
31b85ddad7 Modify app expected position base on the drag behavior change
Because ag/18529596 change the drop position, the test need to modify
the expected position of the app.

Bug: 232878493
Test: atest EnterSplitScreenByDragFromAllApps
Change-Id: Ib4823a899aa42ab2c0b23f9e654cbf13becb02bd
2022-05-28 02:24:33 +08:00
Chilun Huang
6384389786 Add assertions for layers become visible
Add more assertions for layers become visible.

Bug: 232878493
Test: atest EnterSplitScreenByDragFromAllApps

Change-Id: Ida948525b618b800915813cf2927523600e23724
2022-05-25 15:07:28 +08:00
TreeHugger Robot
611e9ca2fa Merge "Create flicker tests for split screen" into tm-qpr-dev 2022-05-19 03:50:07 +00:00
Ben Lin
8f049afdf4 Merge "Apply PiP Params if there was a deferred info." into tm-dev am: 26b096d288 am: 2bbd40e21b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18380631

Change-Id: I260e95b48c681eb89929b05421286f5cdd8f66fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-18 22:48:20 +00:00
Chilun Huang
97db297984 Create flicker tests for split screen
Create the base split screen flicker test and the CUJ of entering split
by dragging from all apps.

Bug: 231399426
Bug: 232878493
Test: atest EnterSplitScreenByDragFromAllApps
Change-Id: Ic684474457f5da28554ff801f3e03d585e8db9fb
2022-05-18 17:22:52 +00:00
Ben Lin
efd8255419 Apply PiP Params if there was a deferred info.
If there was a deferred info, that means PiP params was saved but not
applied earlier. Force apply it.

Bug: 232104080
Test: Double tap on YouTube after exiting earlier Map PiP, aspect ratio
is correct

Change-Id: I52e9f38d4a923fdfee06e7ff37eb61a599caba04
2022-05-13 14:35:26 -07:00
Tony Huang
aea80e8de7 Remove App pairs related codes and files
Bug: 199236198
Test: build pass
Test: pass existing tests
Ignore-AOSP-First: remove whole folder
Change-Id: Iebd8803f53f1106d1b2df306ac239ad8c3765802
2022-05-09 13:59:17 +08:00
Tony Huang
103f4a9673 Clean up the legacy split screen (9/n)
This should be final clean patch, remove legacy split screen
package and its windowing modes

Bug: 199236198
Test: build pass
Test: pass existing tests
Ignore-AOSP-First: remove whole package
Change-Id: Ib2af42834938032bf525b8c16b1046b4c898b8d5
2022-05-09 13:59:13 +08:00
Tracy Zhou
ace8b6862a Merge "Rename navigationBarHeight to navigationBarFrameHeight" into tm-dev am: cf134e04c8 am: 9e3f03991d
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18203341

Change-Id: Iaf46e2850ff4ede488df7d3520c8c25766245697
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-07 07:08:21 +00:00
Tracy Zhou
6cfc16157c Rename navigationBarHeight to navigationBarFrameHeight
This is used for surfaces

Bug: 200310506
Test: presubmit tests (since there is no behavior change)
Change-Id: I8c17777d14c1e8445ea426d9154580731b10632d
2022-05-06 19:47:58 +00:00
Jerry Chang
cec18f583a Merge "Skip running app pair flicker tests since it's deprecated" into tm-dev am: 535fbd5b46 am: 694a6ff910
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17990062

Change-Id: I7d7fce94cc5c24e428e17eb70231049528617a11
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-29 21:09:41 +00:00
Evan Rosky
692e5f7dd5 Merge "Unmark ExitPipViaIntent flaky for shell-transitions" into tm-qpr-dev 2022-04-28 16:51:15 +00:00
Evan Rosky
97dca04490 Merge "Unmark flakiness for PipKeyboardTestShellTransit" into tm-qpr-dev 2022-04-27 22:23:55 +00:00
Jerry Chang
37f8c719fe Skip running app pair flicker tests since it's deprecated
Remove app-pair flicker tests from presubmit and mark them with @Ignore
since app-pair is not currently used but kept in codebase for backup.

Fix: 223076688
Fix: 226869067
Fix: 214190843
Fix: 200778092
Fix: 200777653
Test: atest WMShellFlickerTests
Change-Id: I328d87f87bf9c5f01d86474b850d7d3056aa3ed9
2022-04-27 18:01:38 +00:00
Evan Rosky
09f9f98e9b Merge "Use end-bounds for pip-animations that start in the end state" into tm-qpr-dev 2022-04-27 17:01:47 +00:00
Evan Rosky
9e49d65eb7 Unmark flakiness for PipKeyboardTestShellTransit
This doesn't appear to be flaky anymore (see dashboard), so
unmarking flaky.

Unfortunately, it looks like non-shell-transit is still marked
flaky, so we can't "unify" the test suite yet.

Bug: 227313015
Test: atest WMShellFlickerTests:PipKeyboardTestShellTransit
Change-Id: I501fab0aa9316a56b944452b66708e4e8c831700
2022-04-26 10:59:05 -07:00
Evan Rosky
da1359f12f Unmark ExitPipViaIntent flaky for shell-transitions
statusBarlayerRotatesScales is still flaky for legacy, so I split
those up.

Bug: 227006499
Test: atest WMShellFlickerTests:ExitPipViaIntentTest
Change-Id: I3129303f854e9fae743421d8bb94fbba0422665f
2022-04-25 16:12:40 -07:00
Evan Rosky
95eb1049e9 Use end-bounds for pip-animations that start in the end state
PIP animations usually animate from start to end bounds. However,
there are some animations where the whole animation is in the
end bounds (specifically fade-in). So, make sure to sync the
pip bounds-state to the end-bounds when doing one of these
animations.

Bug: 227214914
Test: atest WMShellFlickerTests:PipRotationTest
Change-Id: I85d5afdcd6b72a82628bf157781dd446a297846a
2022-04-25 10:47:36 -07:00
Nataniel Borges
fd9e7d529f Disable failing PIP expand assertion
The PIP layer shrinks for 1 frame while expanding (flaky)

Bug: 197726610
Test: atest WMShellFlickerTests
Change-Id: Ibc27fe345722223f6dd29277f5d70abff8ab5a89
2022-04-21 11:41:57 +02:00
Pablo Gamito
521dfd5acf Remove references to old FaaS test rule
Test: atest FlickerTests
Change-Id: Iabab1c67166933be74244abcb8e9d883ce2e8dad
2022-04-13 09:38:26 +00:00
Mady Mellor
ab6aaa765b Merge "Bubble flicker test: Ensure the notification shade is opened" into tm-dev 2022-04-05 16:19:38 +00:00
Pablo Gamito
ac56c3acc2 Promote and demote flicker tests
Test: atest FlickerTests WMShellFlickerTests -- --module-arg FlickerTests:include-annotation:android.platform.test.annotations.Presubmit --module-arg FlickerTests:exclude-annotation:android.platform.test.annotations.Postsubmit --module-arg FlickerTests:exclude-annotation:androidx.test.filters.FlakyTest
Change-Id: I10699aed8cd4cfb7e053b32b5a526aa5ce78c584
2022-04-04 21:12:43 +00:00
Mady Mellor
d1f18027e7 Bubble flicker test: Ensure the notification shade is opened
This test depends on finding the text in the notification. In some
cases the notification might not be visible due to whatever else is
going on on the device.

This change adds a swipe that (based on local testing...) will trigger
the shade to expand while on lockscreen and allow all notification
text to be read / found by UiAutomator.

Update the text in the notification to use "BubbleChat" everywhere
so that it can be reliably found (when the notification is collapsed
or expanded it shows text a little differently & it auto expands
when the shade is expanded and it's the top notification).

Test: atest LaunchBubbleFromLockScreen --iterations 20
    - Ideally get the "app updates are ready" notif by checking for
      updates in settings, when you have this on screen the test
      would fail 100% consistently.
Bug: 205288792
Change-Id: Ib01923f35c531fb15230d640237e2c395ee1904d
2022-04-01 17:54:52 +00:00
Nataniel Borges
a8acc4954d Merge "Wait for correct surface to disappear on transition" into tm-dev 2022-03-30 15:57:43 +00:00
Nataniel Borges
786e62ef54 Enable passing shell transition tests
- App close: with home / with back
- Launch app: cold / warm / from overview
- Bubbles: expand / launch / dismiss

Bug: 214452854
Bug: 213852103
Bug: 219690120
Bug: 217777115
Bug: 205288792
Fixes: 219693385
Fixes: 219688533
Fixes: 218604389
Test: atest FlickerTests:com.android.server.wm.flicker.close
Change-Id: Ib9b290baac911d42fdc8ac87755fd8df98fdb272
2022-03-29 16:46:15 +00:00
Nataniel Borges
9b6e35749e Wait for correct surface to disappear on transition
Waiting for the wrong surface makes the transition crash

Fixes: 227308870
Test: atest ExitPipViaExpandButtonClickTest
Change-Id: I3be2da3c344301586cc61201b962ffce3937e77d
2022-03-29 13:40:34 +00:00
Nataniel Borges
e08000c02d Merge "Allow LaunchBubble app to be launcher from launcher" into tm-dev 2022-03-23 17:47:26 +00:00
Pablo Gamito
633398fe8c Merge "Promote stable flicker tests" into tm-dev 2022-03-10 18:30:39 +00:00
Pablo Gamito
19caa1d7d8 Promote stable flicker tests
Change-Id: Ibdb17efe85a8a6cb8da16d96c1658720f53bd671
2022-03-10 11:28:41 +00:00
Evan Rosky
cf3d0a65a4 move shell_transit sysprop to persist.wm
This way we can use a context that systemui can set via flipper

Bug: 219067621
Test: manual
Change-Id: I29d1c39a1733e4d5f19f7f025e8a2cf2ca4f6d5a
2022-03-02 17:04:32 -08:00
Nataniel Borges
78019cb9db Allow LaunchBubble app to be launcher from launcher
Test: install all and check launcher
Change-Id: Ib544248a34bc6fd925b343bff819216cdec15f30
2022-02-24 16:27:25 +01:00
Nataniel Borges
e74d47839a Fix wait condition for SetRequestedOrientationWhilePinnedTest
The setup waited for a ROTATION_0, but this test starts at ROTATION_90

Bug: 219773854
Bug: 220977327
Test: atest WMShellFlickerTests:SetRequestedOrientationWhilePinnedTest
Change-Id: Ib2bde1f66f248adbe69acf5c344322e32b364eb2
2022-02-24 11:24:20 +01:00
Chris Li
1e9ff8eea6 Merge "Fix SetRequestedOrientationWhilePinnedTest with Shell transition" into tm-dev 2022-02-24 00:59:34 +00:00
Chris Li
7404ff1182 Fix SetRequestedOrientationWhilePinnedTest with Shell transition
When the windowing mode is changed during fixed rotation, we don't want
to animate to the fixed rotation anymore, because the fixed rotation
will be cancelled later.

Bug: 214324061
Test: atest WMShellFlickerTests:SetRequestedOrientationWhilePinnedTest
Change-Id: I24b5389ec2b6ea28ce3ba7abf38fbd269566edf3
2022-02-23 14:50:01 +08:00
Nataniel Borges
798fe83b4b Crash test when wait condition not met
This makes triaging issues unrelated to the test (e.g., transition crash) easier since all failing assertions are clustered with the same stack trace

Bug: 219773854
Test: atest FlickerTests WMShellFlickerTests
Change-Id: I65bb1b5e87997c856ce080b24d549ba1c978955a
Merged-In: I65bb1b5e87997c856ce080b24d549ba1c978955a
2022-02-22 14:23:34 +00:00
Chris Li
02c59f009b Fix ExitPipWithDismissButtonTest#focusDoesNotChange
The transition is to click on the pip menu, then click on the dismiss
button. This will cause the focus change.

Fix: 215869110
Fix: 216306753
Test: atest WMShellFlickerTests:ExitPipWithDismissButtonTest
Change-Id: I50dab84f588c3bedaa7d65c02144054d4eefdcd5
2022-02-21 05:29:51 +00:00
Pablo Gamito
3d6d75b455 Merge changes Icf637f09,Ibae3c102,I9758fc10,Ic4a53d96
* changes:
  Extract out rotationLayerAppearsAndVanishes assertions
  Demote flaky transitions
  Update FlakyTest annotation to correct package
  Remove redundant tests
2022-02-17 11:20:22 +00:00
TreeHugger Robot
8dc59320da Merge "Disable async trace" 2022-02-17 10:40:02 +00:00
Pablo Gamito
9e9c069e2d Demote flaky transitions
Test: NA
Change-Id: Ibae3c102a953aeb4bbf69b76cf83b540457fb3e9
2022-02-16 17:19:07 +01:00
Pablo Gamito
904c875e23 Update FlakyTest annotation to correct package
Test: atest FlickerTests
Change-Id: I9758fc103e8f35b964883c0aea8c970bb4f3f0c1
2022-02-16 17:18:47 +01:00
Nataniel Borges
669a1a74c9 Disable async trace
Using compressed trace files speeds up trace collection and the benefits of using async trace fetch become negligible.

To simplify the code, remove the functionality

Bug: 209843622
Test: atest FlickerTests WMShellFlickerTests
Change-Id: Id21d58af5393eb7f364b353db619c55a5a5b616c
2022-02-16 07:14:59 +01:00
TreeHugger Robot
0b2c1a8079 Merge "Demote and promote flicker tests" 2022-02-15 23:21:20 +00:00
Pablo Gamito
5283cc714d Demote test class with flaky transitions
Test: NA
Change-Id: I5b38bf8281c286cf1feb9160718450c30f807340
2022-02-15 21:06:08 +01:00
Pablo Gamito
11e8f789e1 Demote and promote flicker tests
To stablize fliker tests and move stable ones back to presubmit

Test: N/A
Change-Id: Id21a1fcf8b1cf0b950618444cf65711e8dc7c0e6
2022-02-15 17:39:29 +01:00
Nataniel Borges
24512f91a6 Disable failing PIP tests while checking the issue
PIP is not automatically appareing when launching via intent after
the Bubbles tests, when launching independently it works fine.

Bug: 218604389
Test: atest WMShellFlickerTest
Change-Id: Ib5dd76476cbe5cc054e5d4964e6dd4a5cb0ae5cc
2022-02-11 14:01:41 +01:00
TreeHugger Robot
af9e9264f9 Merge "Fix PIP keyboard test" 2022-02-10 16:37:46 +00:00
Pablo Gamito
2c37d7a5e0 Merge "Remove fass assertions from tests" 2022-02-10 14:46:06 +00:00