Commit Graph

2991 Commits

Author SHA1 Message Date
Svetoslav Ganov
bc595b798e am b59d0618: am b6585d19: Merge "Double input focus and focus movement in list not working." into jb-dev
* commit 'b59d06186130921c02b6a4b0c98d0c43379df6d4':
  Double input focus and focus movement in list not working.
2012-06-03 18:59:50 -07:00
Svetoslav Ganov
b59d061861 am b6585d19: Merge "Double input focus and focus movement in list not working." into jb-dev
* commit 'b6585d19311f13ec28fa38a3c849589dba8c293a':
  Double input focus and focus movement in list not working.
2012-06-03 18:55:22 -07:00
Svetoslav Ganov
b552d89e90 Double input focus and focus movement in list not working.
1. The clearFocus routine in ViewGroup was clearing the pointer
   to the descendant which has focus after calling clear focus
   on that child. However, currently clearing the focus of a view
   causes the view that loses focus to try to give the focus to
   the first focusable which potentially sets the pointer to the
   child that has input focus in the ViewGroup but the ViewGruop
   essentially clears that pointer. This resulted in having two
   focused views at the same time in some cases.

2. AbsListView was not calling the super implementation of add
   focusables if the focus type was not accessibility.

bug:6559819

Change-Id: I478dfed000b5de3f9b15e12eb82aa3d34c2301e4
2012-06-02 14:35:13 -07:00
Svetoslav Ganov
665ef836b5 am 40404f43: am cba5e879: Merge "Calling the correct method when adding accessibility focusables." into jb-dev
* commit '40404f435c17dfbbedfdf358c48f0f91df91b84f':
  Calling the correct method when adding accessibility focusables.
2012-06-02 08:40:16 -07:00
Svetoslav Ganov
40404f435c am cba5e879: Merge "Calling the correct method when adding accessibility focusables." into jb-dev
* commit 'cba5e879e825fe37bc1eb092c14f3a5c4d7a29d1':
  Calling the correct method when adding accessibility focusables.
2012-06-02 08:35:24 -07:00
Dianne Hackborn
cbc5e0aae4 am 3522225d: am ea01e4a2: Merge "Survey says: NIET!" into jb-dev
* commit '3522225dba19e77defaf56f0e70c0382c2cbb0a2':
  Survey says: NIET!
2012-06-02 08:20:36 -07:00
Jean-Baptiste Queru
c96132ff53 Revert "Clean up layout direction APIs for Drawable"
This reverts commit c1da65187a.
2012-06-02 05:46:20 -07:00
Svetoslav Ganov
a90e4512ab Calling the correct method when adding accessibility focusables.
1. Since we added explicit accessibility focusable attribute when
   adding focusables views that do so should call this method. Some
   views were not updated to do so.

bug:6581924

Change-Id: Id64c0b2d76e5269ebf3fbe17203e73b174bdb843
2012-06-01 19:02:42 -07:00
Dianne Hackborn
3522225dba am ea01e4a2: Merge "Survey says: NIET!" into jb-dev
* commit 'ea01e4a2d5cc28093e9fd720055082b2d3f708d9':
  Survey says: NIET!
2012-06-01 19:01:33 -07:00
Dianne Hackborn
ea01e4a2d5 Merge "Survey says: NIET!" into jb-dev 2012-06-01 14:13:08 -07:00
Dianne Hackborn
4034bc431d Survey says: NIET!
Bug: 6593206
Change-Id: I5390609a5615d6aff1793a9bc361012a0cea330b
2012-06-01 13:38:48 -07:00
Fabrice Di Meglio
7806882541 Merge "Clean up layout direction APIs for Drawable" 2012-06-01 11:41:58 -07:00
Fabrice Di Meglio
c1da65187a Clean up layout direction APIs for Drawable
- see bug #6427629

Change-Id: I3119db3022bba0ee325b6d0d4471bfebd850ec10
2012-06-01 11:39:10 -07:00
Svetoslav Ganov
2a086877a4 am 570ad8c2: am 00ca7a88: Merge "Accessibility focus traversal of lists inconsistent." into jb-dev
* commit '570ad8c2b6f89f6ca9f2dfeb33d0eca19278e739':
  Accessibility focus traversal of lists inconsistent.
2012-06-01 08:58:35 -07:00
Svetoslav Ganov
570ad8c2b6 am 00ca7a88: Merge "Accessibility focus traversal of lists inconsistent." into jb-dev
* commit '00ca7a88271916f6022b2aa16acfb415fc1b5247':
  Accessibility focus traversal of lists inconsistent.
2012-06-01 08:54:38 -07:00
Svetoslav Ganov
00ca7a8827 Merge "Accessibility focus traversal of lists inconsistent." into jb-dev 2012-06-01 08:52:19 -07:00
Svetoslav Ganov
2dda468606 Accessibility focus traversal of lists inconsistent.
1. Now the list traversal forward is the exact opposite
   of the traversal backward.

2. The focus search starts from the view against which
   the call is made as opposed to the one that has focus.
   This is now consistent with the rest of the focus search.

bug:6537747

Change-Id: Ida6a696636a3099531155fcbff256f71264f5008
2012-05-31 20:16:40 -07:00
Philip Milne
0597161ee4 Merge "Fix for bug 6050753." 2012-05-31 10:30:09 -07:00
Svetoslav Ganov
4305cd3276 am c6dd2dd4: am f14c078c: Merge "Don\'t mark list headers or invalid items as disabled." into jb-dev
* commit 'c6dd2dd4b38b96be3deee94540973c83498a496c':
  Don't mark list headers or invalid items as disabled.
2012-05-30 17:53:55 -07:00
Svetoslav Ganov
c6dd2dd4b3 am f14c078c: Merge "Don\'t mark list headers or invalid items as disabled." into jb-dev
* commit 'f14c078ccc8fe8a2435d3c6b6e47aad81fffd663':
  Don't mark list headers or invalid items as disabled.
2012-05-30 17:49:17 -07:00
Svetoslav Ganov
f14c078ccc Merge "Don't mark list headers or invalid items as disabled." into jb-dev 2012-05-30 17:47:02 -07:00
Fabrice Di Meglio
3b6a3f004f am 875713c6: am f053e236: Merge "Fix bug #6567507 [Bidi] - Cursor is sometimes not visible on EditText" into jb-dev
* commit '875713c6886a5b24fff3a2ce36eb95bc9446e749':
  Fix bug #6567507 [Bidi] - Cursor is sometimes not visible on EditText
2012-05-30 15:37:40 -07:00
alanv
325ea8deb8 Don't mark list headers or invalid items as disabled.
Bug: 6581689
Change-Id: I4088cdc7e785e60fe7e30807cdf045131584f29d
2012-05-30 15:36:18 -07:00
Fabrice Di Meglio
875713c688 am f053e236: Merge "Fix bug #6567507 [Bidi] - Cursor is sometimes not visible on EditText" into jb-dev
* commit 'f053e2367d4859adf9488bd1712bdbe8f647eeb8':
  Fix bug #6567507 [Bidi] - Cursor is sometimes not visible on EditText
2012-05-30 15:34:07 -07:00
Fabrice Di Meglio
f053e2367d Merge "Fix bug #6567507 [Bidi] - Cursor is sometimes not visible on EditText" into jb-dev 2012-05-30 15:31:23 -07:00
Fabrice Di Meglio
0ed59fae6f Fix bug #6567507 [Bidi] - Cursor is sometimes not visible on EditText
- take the hint layout primary horizontal offset if needed

Change-Id: Ib5c4dd990278e1fd8bb9ba4f4b6940a62dba91e3
2012-05-29 20:32:51 -07:00
Svetoslav Ganov
b616547cd5 am 378aa011: am a5c896af: Merge "Updating the behaviour of accessibility text iterators." into jb-dev
* commit '378aa011d5f989166b62e9db6328a5881a1a73a0':
  Updating the behaviour of accessibility text iterators.
2012-05-29 17:38:18 -07:00
Svetoslav Ganov
378aa011d5 am a5c896af: Merge "Updating the behaviour of accessibility text iterators." into jb-dev
* commit 'a5c896afe89aaf40166343232d85980b94974032':
  Updating the behaviour of accessibility text iterators.
2012-05-29 17:32:39 -07:00
Svetoslav Ganov
a5c896afe8 Merge "Updating the behaviour of accessibility text iterators." into jb-dev 2012-05-29 17:30:16 -07:00
Svetoslav Ganov
39f2aee640 Updating the behaviour of accessibility text iterators.
1. Iterators were skipping content on reversing direction.

2. The cursor was positioned at the beginning of the next text segment
   when moving forward and at end of the previous text segment when moving
   backwards. This is incorrect and now the cursor is positioned at the
   end of the segment when moving forward and at the beginning when moving
   backward.

3. The cursor position was not properly set when reaching the end/start
   of the text.

4. The iterators were reporting strictly the next/previous segment even
   if the cursor is within such a segment. Thus, when traversing some
   content may be skipped. Now moving forward moves the selection to
   the next segment end and the start position is either the old index
   if it was within a segment or the start of the segment. Same in
   reverse.

bug:6575099

Change-Id: Ib48a649cec53910339baf831a75e26440be6e576
2012-05-29 15:16:19 -07:00
Gilles Debunne
31d869ce07 am 1cf99631: am 18afc622: Merge "Fix for IOOB in SearchView" into jb-dev
* commit '1cf99631ca6859785ef5716def75169f77b1bee3':
  Fix for IOOB in SearchView
2012-05-25 12:50:14 -07:00
Gilles Debunne
1cf99631ca am 18afc622: Merge "Fix for IOOB in SearchView" into jb-dev
* commit '18afc622c3d80713a6ffb91792cce399e1715bfb':
  Fix for IOOB in SearchView
2012-05-25 12:46:09 -07:00
Gilles Debunne
2427192e58 Fix for IOOB in SearchView
Bug 6476578

The latest bug report show a query.length() of 33 while
mQueryTextView.length() is 0 on line 514.

I can see 2 reasons which can explain this discrepancy:
- the mQueryTextView has a filter, which alters the text.
- some asynchronous event (IME?) changes the text in the mean time.

I would favor the second one, which seems to break a lot of single
thread assumptions in the code and generates other IOOB exceptions.

Note that depending on what they are used for, it may be more consistent
to use mQueryTextView.getText() instead of query in the following
assignment.

Change-Id: Ie8a5486b11a80543f8f90980454933c5a74c073e
2012-05-25 14:04:05 +02:00
satok
5284148f28 am 77f79a39: am f927e17a: Use correct spell check locale
* commit '77f79a39c0e6aa540f8204adb39ec6671ee053e7':
  Use correct spell check locale
2012-05-24 01:43:32 -07:00
satok
77f79a39c0 am f927e17a: Use correct spell check locale
* commit 'f927e17ae543b6edeae8200cc86c59c3ee740670':
  Use correct spell check locale
2012-05-24 01:39:35 -07:00
satok
f927e17ae5 Use correct spell check locale
Bug: 6542210
Change-Id: I414aa2321f30e396996d90fb8e90c1dbb3bb7b9e
2012-05-24 16:52:54 +09:00
Adam Powell
b24f0c99d6 am 7c485c38: am 75ac4e84: Merge "Fix a bug with deferred position scrolling in lists while data changes are pending" into jb-dev
* commit '7c485c38045dd5a94f80d7eec05931afafd6579c':
  Fix a bug with deferred position scrolling in lists while data changes are pending
2012-05-23 17:54:55 -07:00
Adam Powell
7c485c3804 am 75ac4e84: Merge "Fix a bug with deferred position scrolling in lists while data changes are pending" into jb-dev
* commit '75ac4e8479a415b4bec657b8f333e38d160b6b3e':
  Fix a bug with deferred position scrolling in lists while data changes are pending
2012-05-23 17:51:15 -07:00
Adam Powell
75ac4e8479 Merge "Fix a bug with deferred position scrolling in lists while data changes are pending" into jb-dev 2012-05-23 17:49:21 -07:00
Adam Powell
161abf3d44 Fix a bug with deferred position scrolling in lists while data changes
are pending

Save the pending position scroll until the data change is actually
serviced before posting it to run. This avoids handler loops on
GONE subtrees or when the view is detached.

Bug 6547649

Change-Id: Iab108cfcb7dd11ece703762d311a5f5985f38c3b
2012-05-23 17:24:27 -07:00
Svetoslav Ganov
db120c4dd2 am 1de7af86: am a587b890: Merge "ActivityChooser view not handling its removal and relayout properly." into jb-dev
* commit '1de7af86d720accda08df4c5bcf0b55da90f9208':
  ActivityChooser view not handling its removal and relayout properly.
2012-05-23 16:12:15 -07:00
Svetoslav Ganov
1de7af86d7 am a587b890: Merge "ActivityChooser view not handling its removal and relayout properly." into jb-dev
* commit 'a587b890bb0c2f800fe4dfd3267f26366d00d32c':
  ActivityChooser view not handling its removal and relayout properly.
2012-05-23 16:08:49 -07:00
Svetoslav Ganov
748ee2e82a ActivityChooser view not handling its removal and relayout properly.
1. ActivityChooserView did not hide the popup window when detached.

bug:6544220

2. ActivityChooserView was calling show popup when it was already
   showing it resulting in an incrrect update and losing one item
   per rotation.

bug:6522041

Change-Id: Iec1682ca5d27e38caf57214fa86060edf82a2166
2012-05-23 15:21:16 -07:00
Craig Mautner
2b5d509584 am 4d7b752e: am 85aea366: Merge "Remove Popup immediately rather than defer it." into jb-dev
* commit '4d7b752ee9f739e3b178261728fc6b9ae0d8eac4':
  Remove Popup immediately rather than defer it.
2012-05-23 10:55:50 -07:00
Craig Mautner
4d7b752ee9 am 85aea366: Merge "Remove Popup immediately rather than defer it." into jb-dev
* commit '85aea3664992cd1e16ef4497c3450b26bdef06b0':
  Remove Popup immediately rather than defer it.
2012-05-23 10:52:04 -07:00
Craig Mautner
85aea36649 Merge "Remove Popup immediately rather than defer it." into jb-dev 2012-05-23 10:47:46 -07:00
Craig Mautner
b82d074038 Remove Popup immediately rather than defer it.
Delaying the popup by using removeView instead of removeViewImmediate
caused an error when the removal was actually executed after the parent
window was deleted along with the popup.

Fixes bug 6407801.

Change-Id: Ieb17d58467aaf16e1a24f47187f52766d694ba32
2012-05-23 10:15:09 -07:00
Adam Cohen
3be398ab3c am 2628c678: am 662e4a45: Merge "Fix ANR which could occur for collection widgets with very large items" into jb-dev
* commit '2628c678cde4bc4c99668130136714187aeca9dc':
  Fix ANR which could occur for collection widgets with very large items
2012-05-22 14:49:52 -07:00
Adam Cohen
2628c678cd am 662e4a45: Merge "Fix ANR which could occur for collection widgets with very large items" into jb-dev
* commit '662e4a456bf1f7a3a2a2c971f7c0861ef1c159e0':
  Fix ANR which could occur for collection widgets with very large items
2012-05-22 14:45:24 -07:00
Adam Cohen
662e4a456b Merge "Fix ANR which could occur for collection widgets with very large items" into jb-dev 2012-05-22 14:41:54 -07:00