Commit Graph

4659 Commits

Author SHA1 Message Date
Emilian Peev
a72b3e92e9 Camera: Don't override extension surface native format
Avoid overriding the native extension surface format when
retrieving the surface parameters.
The native surface format can later be used to configure
the device extension so the original value must be known.

Bug: 195366395
Test: atest -c
cts/tests/camera/src/android/hardware/camera2/cts/CameraExtensionSessionTest.java

Change-Id: I52d091fd782dc9ca2af60ba42ec1c5bbe080c1ca
2021-08-03 13:13:03 -07:00
Evan Severson
705c7539eb Merge "Check the current user in the system server for SensorPrivacyManager" into sc-dev 2021-07-30 15:55:22 +00:00
Evan Severson
6abae2a070 Check the current user in the system server for SensorPrivacyManager
Instead of querying for the current user application side we can just
pass UserHandle.CURRENT_USER, this eliminates an IPC and the need for
INTERACT_ACCROSS_USERS permission which should not be needed for these
APIs.

Test: CtsSensorPrivacyTestCases
Bug: 194806109
Change-Id: I3a0aed0c403338aaebdfb4e2791a84b4e7e3cb3a
2021-07-29 11:23:43 -07:00
Emilian Peev
e922ec31aa Merge changes from topic "b194508189" into sc-dev
* changes:
  Camera: Support common outputs between regular and extension sessions
  Camera: Include the parceled image dimensions
2021-07-29 00:20:06 +00:00
Jayant Chowdhary
782b4e9e08 Merge "camera2: Add fwk-only tags for SCALER_CROP_REGION and metering regions." into sc-dev 2021-07-28 22:45:01 +00:00
Jayant Chowdhary
5c2a840de8 camera2: Add fwk-only tags for SCALER_CROP_REGION and metering regions.
Default sensor mode capture requests would have their scaler crop
regions set to the default active / pre-correction array coordinate
system. Cameraserver needs to correct this for max res sensor pixel mode CaptureRequests.
In order to facilitate the correction, we add fwk-only CaptureRequest tags which are set when camera
clients set SCALER_CROP_REGION / metering regions.

Bug: 194143991

Test: CTS

Change-Id: I66393a1e6310f149138be4799f20ced377b11eb4
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2021-07-26 17:06:51 -07:00
Kevin Chyn
88a506aad4 Merge changes from topic "facemanager-bypassflag" into sc-dev
* changes:
  12/n: Send bypassEnabled to AuthenticationClient
  11/n: Enable CoexCoordinator advanced logic by default
  10/n: Always send feedback if capacitive (or unknown) sensor
2021-07-26 18:12:28 +00:00
Kevin Chyn
4443159caf 12/n: Send bypassEnabled to AuthenticationClient
Adds this flag via FaceManager#authenticate (instead of other other
potential ways, such as reading the settings/config values from
system_server directly). This allows for a single source of truth.

Stores this flag in AuthenticationClient, which can then be retrieved
from the CoexCoordinator.

Also removes unnecessary FaceManager#authenticate method, as keyguard
is really the only supported client

Bug: 193089985
Test: atest KeyguardUpdateMonitorTest
Test: atest com.android.server.biometrics
Change-Id: I647c2e5926d1bb964b12dc580d2cd2178c30a790
2021-07-23 17:26:11 -07:00
Evan Severson
8f7f7ab98a Update mic/cam quicksetting toggles when user changes
On a secondary/guest user the mic/cam toggles show for user 0. We want
the user-free calls to reflect the state of the current user so things
like the UI is accurate. Before this change the user free calls always
checked for user 0 since the context was cached in SensorPrivacyManager.

This change also fixes some issues with removing listeners.

Test: use toggles on main, work profile, and secondary user
      atest CtsSensorPrivacyTestCases --user-type secondary_user
Fixes: 178751362
Change-Id: Ieb90ea7ba4074446eb01d1093e280ac7018f9e73
2021-07-23 15:31:53 -07:00
Emilian Peev
83eb162a5d Camera: Support common outputs between regular and extension sessions
Camera clients must be able to re-use the same output/outputs between
regular capture and extension sessions.
Re-shuffle the extension logic so that user registered outputs are
always accessed/connected to after the camera device configures its
streams.
Additionally disconnect any user registered outputs as soon as the
client requests a new regular capture session.

Bug: 194508189
Test: Partner testing,
Camera CTS

Change-Id: I112ad916e5d019d313767d3a0b0454165a6feb12
2021-07-23 11:26:18 -07:00
Emilian Peev
aee0d658d6 Camera: Include the parceled image dimensions
All parceled images need to include valid and correct
dimensions.

Bug: 194324683
Test: Manual using extensions sample application,
Camera CTS

Change-Id: I5ba90757e6edb0bb6bf1756d158c7ee402ce54ca
2021-07-22 13:40:26 -07:00
Ilya Matyukhin
2151a28c7c Merge "Fix enrollment preview surface leak" into sc-dev 2021-07-21 17:41:34 +00:00
Ilya Matyukhin
3662a98bbd Fix enrollment preview surface leak
Bug: 189057897
Test: adb shell dumpsys SurfaceFlinger | grep -A 10 Offscreen | grep EnrollActivity
Change-Id: I9e11d0f1efc4428f2181370cb8be1b933aa5f548
2021-07-20 17:33:42 -07:00
Shuzhen Wang
3e72b3e16f Merge "Camera: Improve logical camera RAW capture docs" into sc-dev 2021-07-21 00:09:26 +00:00
TreeHugger Robot
5cb13bbebf Merge "Revert "wifidisplay: restrict broadcast by the proper permission"" into rvc-dev am: 30c6383d1d am: 17d1be8efc
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15287612

Change-Id: I67a349870a799a1cdf3df9577786a326901d65e5
2021-07-20 02:44:02 +00:00
TreeHugger Robot
17d1be8efc Merge "Revert "wifidisplay: restrict broadcast by the proper permission"" into rvc-dev am: 30c6383d1d
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15287612

Change-Id: I2fba182703b7e2362a0cd0934903c6a2af849751
2021-07-20 02:31:53 +00:00
Shuzhen Wang
252b7958bb Camera: Improve logical camera RAW capture docs
- Clarify raw capture behavior for logical camera with backward
compatible approach and MultiResolutionImageReader.
- Some logical camera devices may have identical physical cameras with
different focal length. Allow such logical camera to switch physical
cameras when outputing raw.

Bug: 182217158
Test: Build
Change-Id: I64458683f4eb8be6fc1e35270a8c22864d962be9
2021-07-16 12:56:46 -07:00
Jimmy Chen
955b64a6e7 Revert "wifidisplay: restrict broadcast by the proper permission"
This reverts commit cff8340c84.

Reason for revert: Remove from July 2021 Android Security Bulletin due to break existing applications.

Bug: 176541017
Change-Id: Iacef744056630e85fb43d838a72abfae331cbaf4
Test: install WFD application and check whether it works normally.
2021-07-15 00:56:19 +00:00
Arthur Ishiguro
14c466a999 Add additional clarification regarding nanoapp loading APIs
Fixes: 190533027
Test: None, comment only
Change-Id: If54e4093092be697845a53fbd617f6b2b46f420f
2021-07-14 17:30:29 +00:00
Evan Severson
41ff39a156 Merge "Update the sensor use dialog if more sensors are accessed" into sc-dev 2021-07-13 23:35:32 +00:00
Joshua Mccloskey
b7020910d3 Merge "Enable vendor error/acquire messages on user build" into sc-dev 2021-07-13 06:15:50 +00:00
Joshua Mccloskey
27f49c34b9 Enable vendor error/acquire messages on user build
Test: It builds.
Bug: 184591799
Change-Id: I81d19610e39998e4815da62c21068f4850c41c1e
2021-07-12 15:15:26 -07:00
Evan Severson
85d7336db0 Update the sensor use dialog if more sensors are accessed
If another sensor is accessed after the dialog has been shown we now
update the dialog to reflect all accessed sensors.

Test: Wrote app which opens mic/cam at different times
Fixes: 187139024
Fixes: 187132341
Change-Id: I178bb4f6ea1913e3ee0e2153cf8ac3b2f24e4623
2021-07-09 13:38:47 -07:00
Rucha Katakwar
4f83d813d6 Revert "Camera: Restore FastNative annotation."
Bug: 193176503

This reverts commit 99ebd95ef1.
Reason for revert: Recent flakiness as mentioned in b/193176503.This cl was merged in build:7532561. Any test failures post this build shows exception linked to CameraMetadataNative.Reverting this cl to find and fix the issue.

Change-Id: If9fe3ce69f013b842a47745d976942aa71dfb8f6
2021-07-09 17:20:57 +00:00
TreeHugger Robot
d377029798 Merge "Camera: Clarify zoom and crop behavior for capture result" into sc-dev 2021-07-08 20:40:03 +00:00
Emilian Peev
07d8600a35 Camera: Set metadata vendor id in extension proxy service
Set the appropriate vendor id for any native metadata
instantiated within the camera extension proxy service.

Bug: 187341271
Test: Partner verified,
Camera CTS

Change-Id: I07e0be304baac017d44606c1612a24c520bed588
2021-07-08 11:51:56 -07:00
Pyuli Naithani
cd40c7406f Merge "Add statsd logs for Sensor Privacy." into sc-dev 2021-07-08 17:24:53 +00:00
Rucha Katakwar
8893160900 Merge "Camera: Restore FastNative annotation." into sc-dev 2021-07-08 17:17:17 +00:00
Pyuli Naithani
76be38c05c Add statsd logs for Sensor Privacy.
BUG: 192269258

Test: ran statsd_testdrive 381

Change-Id: I6f1f2bfe13889f7b3a39684769715cbd4f6009e3
2021-07-07 22:26:45 +00:00
Rucha Katakwar
99ebd95ef1 Camera: Restore FastNative annotation.
FastNative annotations were removed from native methods since it can't
be used with 'synchronized'. These methods need not be synchronized.
As per comments in ag/13184856, when the annotations were added first
effect was that ART did the fast native calls but because synchronized
fast native methods are not supported it was not doing the synchronized
nor the unlock at exit.So FastNative but not synchronized.

Removing synchronized and restoring FastNative annotation to optimize.
Did sanity testing like open/close camera,taking photos,clear all apps.

bug:175396433

Test: Camera ITS scene0 Pass, All Camera CTS tests Pass.
Change-Id: Ib7acd363120ee0bf2a1dea92628b4697f3b211bb
2021-07-07 22:20:27 +00:00
Evan Severson
83ed960b96 Update documentation about the SensorPrivacyManager
Remove information about system api methods so they don't end up in the
public documentation.

Test: None
Fixes: 193049421
Change-Id: Iff2bae46f935b63366c737dab6610da7b3ffff39
2021-07-07 12:50:13 -07:00
Shuzhen Wang
6ae7bfcf02 Camera: Clarify zoom and crop behavior for capture result
Test: Build
Bug: 191317747
Change-Id: I403a1019be8c0cdcd69519bf4b17142c3b1726b2
2021-07-07 10:51:29 -07:00
Jayant Chowdhary
f9158d2217 Merge "camera2: Update mandatory streams for ultra high resolution sensors." into sc-dev 2021-07-03 05:35:54 +00:00
Jayant Chowdhary
53be09b2df camera2: Update mandatory streams for ultra high resolution sensors.
The updated mandatory streams include default sensor pixel mode targets
in addition to maximum resolution sensor pixel mode targets, in the same
camera capture session. This is so that sensor pixel mode can be
switched per CaptureRequest without creating a new session.

Bug: 184574750

Test: Camera CTS

Change-Id: Idc2c23f4942942fb81f243dc7ffea5dcbf94dec5
Signed-off-by: Jayant Chowdhary <jchowdhary@google.com>
2021-07-02 12:04:59 -07:00
Joshua Mccloskey
55ffd5b10c Merge "Added rate limiter for calibration notification" into sc-dev 2021-07-02 14:14:09 +00:00
Curtis Belmonte
80cfdd10db Merge "Don't attempt caching for BiometricManager.Strings" into sc-dev 2021-07-01 20:47:01 +00:00
Curtis Belmonte
8858de4478 Don't attempt caching for BiometricManager.Strings
Always fetch the latest requested string when a getter method of
BiometricManager.Strings is called, rather than attempted to cache the
strings.

Test: atest BiometricManagerTest

Fixes: 192573011
Change-Id: Ic73e2d0092d200e5912084e1b8f4efdb81bbf2d8
2021-07-01 11:14:11 -07:00
Ady Abraham
ac57d157da Merge "Add preferredMinDisplayRefreshRate" into sc-dev 2021-07-01 17:58:23 +00:00
Joshua Mccloskey
1862a1ac04 Added rate limiter for calibration notification
Test: Manually verified notification was only shown once per time period
Fixes: 192105305
Change-Id: I115996ee0ad51ac5bb160a0f6aa3395df49f724f
2021-06-30 13:48:18 -07:00
Ady Abraham
540012bf1e Add preferredMinDisplayRefreshRate
Add a new private window attribute for allowing apps to specify the min
display refresh rate in addition to the existing
preferredMaxDisplayRefreshRate. This is useful for use cases such as
keyguard where the refresh rate should be limited to a single value,
and using preferredDisplayModeId would not lock the display
refresh rate, as frame rate override might be enabled.

Test: atest RefreshRatePolicyTest FrameRateSelectionPriorityTests DisplayModeDirectorTest
Bug: 183226498
Bug: 184176119
Change-Id: I343569b3cbccd73001703dca78f0f99e196a4d52
2021-06-30 11:32:26 -04:00
Joshua Mccloskey
7580fad2fd Added fingerprint acquired too bright
Test: Manually verified too too bright acquired message appears
on keyguard.
Bug: 191954958

Change-Id: I679acf4f4fd07f0a6d7d8f05a89bc239ff117fbe
2021-06-29 12:15:18 -07:00
TreeHugger Robot
efb3fafeff Merge "Camera: Disallow concurrent extension sessions" into sc-dev 2021-06-28 18:31:16 +00:00
Joshua Mccloskey
c3ecb5fffb Added fingerprint bad calibration notification
Test: Verified notification shows upon receiving error message and
disappears after enrollment.
Bug: 189133688

Change-Id: I6552326c9d9d2078fc39163be45524b3da7d00d8
2021-06-24 16:32:59 -07:00
Emilian Peev
876e6afd6c Camera: Disallow concurrent extension sessions
Support for concurrent extension processing sessions
is not yet mandated. To avoid inconsistent behavior
across devices, explicitly document and disallow
concurrent extension sessions at the framework level.

Bug: 187341271
Test: Manual using test application,
Camera CTS

Change-Id: Ibff194c58bbb37e884c27151a2a27fb21e3db928
2021-06-24 15:33:35 -07:00
Anh Pham
3e244be4e9 Merge "Update API doc w/ high-rate permission requirement" into sc-dev 2021-06-24 06:22:24 +00:00
TreeHugger Robot
81419f4be3 Merge "Camera: Switch camera extension proxy service package name" into sc-dev 2021-06-23 18:55:59 +00:00
Anh Pham
629ba4958e Update API doc w/ high-rate permission requirement
Test: Build successfully
Bug: 191301110
Change-Id: I653036036bea0e2889807ec44ed98206a427dfb8
2021-06-23 19:49:50 +02:00
TreeHugger Robot
64e22ca06d Merge "Added fingerprint acquire immobile message" into sc-dev 2021-06-22 19:28:04 +00:00
TreeHugger Robot
55a8db6450 Merge "Split long vibration composition using HAL limits" into sc-dev 2021-06-22 16:08:22 +00:00
Lais Andrade
a1167c2a06 Split long vibration composition using HAL limits
Load composition and pwle limits from the HAL and apply them on
VibrationThread to split long vibrations in multiple calls.

This ensures that long vibration will be performed by the HAL.

Bug: 188431691
Fix: 183517124
Test: VibrationThreadTest & VibrationInfoTest
Change-Id: I09a04c7b1de331320d453899f59b01e4bbb42ac3
2021-06-22 15:36:23 +01:00