Commit Graph

2911 Commits

Author SHA1 Message Date
Svetoslav Ganov
378aa011d5 am a5c896af: Merge "Updating the behaviour of accessibility text iterators." into jb-dev
* commit 'a5c896afe89aaf40166343232d85980b94974032':
  Updating the behaviour of accessibility text iterators.
2012-05-29 17:32:39 -07:00
Svetoslav Ganov
a5c896afe8 Merge "Updating the behaviour of accessibility text iterators." into jb-dev 2012-05-29 17:30:16 -07:00
Svetoslav Ganov
39f2aee640 Updating the behaviour of accessibility text iterators.
1. Iterators were skipping content on reversing direction.

2. The cursor was positioned at the beginning of the next text segment
   when moving forward and at end of the previous text segment when moving
   backwards. This is incorrect and now the cursor is positioned at the
   end of the segment when moving forward and at the beginning when moving
   backward.

3. The cursor position was not properly set when reaching the end/start
   of the text.

4. The iterators were reporting strictly the next/previous segment even
   if the cursor is within such a segment. Thus, when traversing some
   content may be skipped. Now moving forward moves the selection to
   the next segment end and the start position is either the old index
   if it was within a segment or the start of the segment. Same in
   reverse.

bug:6575099

Change-Id: Ib48a649cec53910339baf831a75e26440be6e576
2012-05-29 15:16:19 -07:00
Gilles Debunne
1cf99631ca am 18afc622: Merge "Fix for IOOB in SearchView" into jb-dev
* commit '18afc622c3d80713a6ffb91792cce399e1715bfb':
  Fix for IOOB in SearchView
2012-05-25 12:46:09 -07:00
Gilles Debunne
2427192e58 Fix for IOOB in SearchView
Bug 6476578

The latest bug report show a query.length() of 33 while
mQueryTextView.length() is 0 on line 514.

I can see 2 reasons which can explain this discrepancy:
- the mQueryTextView has a filter, which alters the text.
- some asynchronous event (IME?) changes the text in the mean time.

I would favor the second one, which seems to break a lot of single
thread assumptions in the code and generates other IOOB exceptions.

Note that depending on what they are used for, it may be more consistent
to use mQueryTextView.getText() instead of query in the following
assignment.

Change-Id: Ie8a5486b11a80543f8f90980454933c5a74c073e
2012-05-25 14:04:05 +02:00
satok
77f79a39c0 am f927e17a: Use correct spell check locale
* commit 'f927e17ae543b6edeae8200cc86c59c3ee740670':
  Use correct spell check locale
2012-05-24 01:39:35 -07:00
satok
f927e17ae5 Use correct spell check locale
Bug: 6542210
Change-Id: I414aa2321f30e396996d90fb8e90c1dbb3bb7b9e
2012-05-24 16:52:54 +09:00
Adam Powell
7c485c3804 am 75ac4e84: Merge "Fix a bug with deferred position scrolling in lists while data changes are pending" into jb-dev
* commit '75ac4e8479a415b4bec657b8f333e38d160b6b3e':
  Fix a bug with deferred position scrolling in lists while data changes are pending
2012-05-23 17:51:15 -07:00
Adam Powell
75ac4e8479 Merge "Fix a bug with deferred position scrolling in lists while data changes are pending" into jb-dev 2012-05-23 17:49:21 -07:00
Adam Powell
161abf3d44 Fix a bug with deferred position scrolling in lists while data changes
are pending

Save the pending position scroll until the data change is actually
serviced before posting it to run. This avoids handler loops on
GONE subtrees or when the view is detached.

Bug 6547649

Change-Id: Iab108cfcb7dd11ece703762d311a5f5985f38c3b
2012-05-23 17:24:27 -07:00
Svetoslav Ganov
1de7af86d7 am a587b890: Merge "ActivityChooser view not handling its removal and relayout properly." into jb-dev
* commit 'a587b890bb0c2f800fe4dfd3267f26366d00d32c':
  ActivityChooser view not handling its removal and relayout properly.
2012-05-23 16:08:49 -07:00
Svetoslav Ganov
748ee2e82a ActivityChooser view not handling its removal and relayout properly.
1. ActivityChooserView did not hide the popup window when detached.

bug:6544220

2. ActivityChooserView was calling show popup when it was already
   showing it resulting in an incrrect update and losing one item
   per rotation.

bug:6522041

Change-Id: Iec1682ca5d27e38caf57214fa86060edf82a2166
2012-05-23 15:21:16 -07:00
Craig Mautner
4d7b752ee9 am 85aea366: Merge "Remove Popup immediately rather than defer it." into jb-dev
* commit '85aea3664992cd1e16ef4497c3450b26bdef06b0':
  Remove Popup immediately rather than defer it.
2012-05-23 10:52:04 -07:00
Craig Mautner
85aea36649 Merge "Remove Popup immediately rather than defer it." into jb-dev 2012-05-23 10:47:46 -07:00
Craig Mautner
b82d074038 Remove Popup immediately rather than defer it.
Delaying the popup by using removeView instead of removeViewImmediate
caused an error when the removal was actually executed after the parent
window was deleted along with the popup.

Fixes bug 6407801.

Change-Id: Ieb17d58467aaf16e1a24f47187f52766d694ba32
2012-05-23 10:15:09 -07:00
Adam Cohen
2628c678cd am 662e4a45: Merge "Fix ANR which could occur for collection widgets with very large items" into jb-dev
* commit '662e4a456bf1f7a3a2a2c971f7c0861ef1c159e0':
  Fix ANR which could occur for collection widgets with very large items
2012-05-22 14:45:24 -07:00
Adam Cohen
662e4a456b Merge "Fix ANR which could occur for collection widgets with very large items" into jb-dev 2012-05-22 14:41:54 -07:00
Adam Cohen
35fbe2a592 Fix ANR which could occur for collection widgets with very large items
-> We cache RemoteViews which populate the AdapterViews, but only
   up to a total memory amount of 2MB. The remainder of the cache
   is pruned out. If _every_ item is greater than 2MB, we were failing
   to prune the last item, leaving the framework in a loop on a bg
   thread, but holding a lock required by the main thread.

Change-Id: I0574a25a59ebec6586ae223fff6605c0fee953c3
2012-05-22 14:10:14 -07:00
Svetoslav Ganov
d429f8772c am 084c63eb: Merge "Fix accessibility actions in AbsListView." into jb-dev
* commit '084c63eb6a44fdab7507f828062a2c4a8872f8c8':
  Fix accessibility actions in AbsListView.
2012-05-21 18:17:55 -07:00
Svetoslav Ganov
084c63eb6a Merge "Fix accessibility actions in AbsListView." into jb-dev 2012-05-21 18:15:48 -07:00
Svetoslav Ganov
5182a5bcf7 am 4ce106f5: Merge "Fixing some minor issues in accessibility focus." into jb-dev
* commit '4ce106f5cff5670bf1aae4190612dc8e972f5c28':
  Fixing some minor issues in accessibility focus.
2012-05-21 15:58:12 -07:00
Svetoslav Ganov
4ce106f5cf Merge "Fixing some minor issues in accessibility focus." into jb-dev 2012-05-21 15:55:28 -07:00
Svetoslav Ganov
f76a83cfcf Fixing some minor issues in accessibility focus.
1. Now accessibility focus does not drag input focus and
   vice versa. Having the two focuses chase each other
   can lead to some pathological cases. For example, a
   container is input focusable and manages input focus
   for its children i.e. as soon as it gets input focus
   it sets input focus to a child. Now assume input and
   accessibility focus are on a child and focus search
   finds the parent to take accessibility focus, now
   putting accessibility focus to the parent will put
   input focus there and the parent will put input focus
   to the child which as a result will put accessibility
   focus there, thus resulting in traversal loop.

bug:6522900

2. Fixed asymmetrical behavior of accessibility focus search
   for AbsListView.

bug:6520016

3. Fixed accessibility focus search getting stuck in an
   empty AbsListView.

bug:6520049

Change-Id: Ia26e5be7b5a9f340f873861ff466c787467b98dc
2012-05-21 15:32:28 -07:00
Svetoslav Ganov
f7b8bbadf5 am de83e7aa: Merge "Make TextView respect ACCESSIBILITY_SPEAK_PASSWORD preference." into jb-dev
* commit 'de83e7aa32e7b1a6c8aea780664150345b7ae097':
  Make TextView respect ACCESSIBILITY_SPEAK_PASSWORD preference.
2012-05-21 15:11:07 -07:00
Svetoslav Ganov
de83e7aa32 Merge "Make TextView respect ACCESSIBILITY_SPEAK_PASSWORD preference." into jb-dev 2012-05-21 15:08:53 -07:00
alanv
7d62419c85 Make TextView respect ACCESSIBILITY_SPEAK_PASSWORD preference.
Bug: 6523447
Change-Id: I2610b558395dc53a74b5c8c36c09673898da44f2
2012-05-21 14:23:17 -07:00
Romain Guy
6fa51de80b am 46a8b1ac: Merge "Remove unused, obsolete debug code" into jb-dev
* commit '46a8b1acdbbaa9bcbd0127b4f4580b5a8ec38119':
  Remove unused, obsolete debug code
2012-05-21 13:43:02 -07:00
Romain Guy
46a8b1acdb Merge "Remove unused, obsolete debug code" into jb-dev 2012-05-21 13:40:41 -07:00
Daniel Sandler
7a999b8204 am 2926948d: Merge "Add RemoteViews.setViewPadding()." into jb-dev
* commit '2926948d2092fcf6e38328d690dd60510fe9bf1f':
  Add RemoteViews.setViewPadding().
2012-05-21 13:39:42 -07:00
Daniel Sandler
2926948d20 Merge "Add RemoteViews.setViewPadding()." into jb-dev 2012-05-21 13:37:16 -07:00
Romain Guy
13b907353f Remove unused, obsolete debug code
All these features have either been abandonned and left un-maintained
for years or can be replaced by systrace.

Change-Id: I42e4579a8078744047e5fe08a7a15254970b09bc
2012-05-21 13:29:06 -07:00
Daniel Sandler
99d1f74864 Add RemoteViews.setViewPadding().
Bug: 6519374
Change-Id: I29ad738d741153a9d9e74c9e2ac110a8b97f046b
2012-05-21 16:15:06 -04:00
Daniel Sandler
97ccf4a852 am 90497c18: Merge "Remotable view method for TextView.setTextSize(int, float)." into jb-dev
* commit '90497c18f72cf3d7ea2fd611502d0da2c9c69879':
  Remotable view method for TextView.setTextSize(int, float).
2012-05-21 12:14:05 -07:00
Daniel Sandler
90497c18f7 Merge "Remotable view method for TextView.setTextSize(int, float)." into jb-dev 2012-05-21 12:12:13 -07:00
Daniel Sandler
7264f71399 Remotable view method for TextView.setTextSize(int, float).
The only remotable method on TextView is setTextSize(float)
which assumes "sp" dimensions, making it tricky to get exact
text sizes.

Bug: 6519374
Change-Id: I961bbdd607ca6786c0630ff1ce19186f54f6f31f
2012-05-21 14:51:51 -04:00
Philip Milne
464c4e9879 am bfa3d50b: Merge "Doc changes for GridLayout." into jb-dev
* commit 'bfa3d50b49a93a7d02f93c9ac54a74c40c6f2046':
  Doc changes for GridLayout.
2012-05-21 11:36:05 -07:00
Philip Milne
b65408fc0f Doc changes for GridLayout.
Add some javadoc to explain orientation property properly.

Change-Id: I1e2092f32fe2f524eda7d1c46c6daad571733c1f
2012-05-21 10:46:56 -07:00
Jeff Brown
3ec5724d60 am 51f24302: Support toast cancellation.
* commit '51f2430217a377bc2913862d98a97d0087914540':
  Support toast cancellation.
2012-05-20 21:53:32 -07:00
Jeff Brown
51f2430217 Support toast cancellation.
Change-Id: Idd00b9c6e3049822e437afaf56351575a5c167df
2012-05-20 12:09:37 -07:00
Dianne Hackborn
944d624fc2 am 35013d0e: Merge "DO NOT MERGE: Remove a few left-over layout direction things." into jb-dev
* commit '35013d0e8be6b67c6a0161b8472496a825657944':
  DO NOT MERGE: Remove a few left-over layout direction things.
2012-05-18 18:06:27 -07:00
Dianne Hackborn
35013d0e8b Merge "DO NOT MERGE: Remove a few left-over layout direction things." into jb-dev 2012-05-18 18:04:11 -07:00
alanv
9c3e0e6826 Fix accessibility actions in AbsListView.
Check adapter for position enabled state, check selection index.

Bug: 6508142
Change-Id: If25a133533a7316ef7eba8761522bd2ee4f6338d
2012-05-18 17:43:35 -07:00
Romain Guy
86ed8bfa5e am 52fcdd01: Merge "Fix documentation" into jb-dev
* commit '52fcdd013943954e4baa4542f78557da33bc646b':
  Fix documentation
2012-05-18 17:40:37 -07:00
Dianne Hackborn
39af624f31 DO NOT MERGE: Remove a few left-over layout direction things.
Change-Id: Id66b171594af939df4716aa0e0baa25fe47eecee
2012-05-18 17:34:06 -07:00
Romain Guy
c301e78c78 am 9579bf82: Merge "Gallery, we need to talk..." into jb-dev
* commit '9579bf821ea4c1c5435f8e62973acd9b72c7902c':
  Gallery, we need to talk...
2012-05-18 17:33:05 -07:00
Romain Guy
d2aed40a37 Fix documentation
Change-Id: Id3a5d3b6b43ce684c2328f046e4991e64e97575a
2012-05-18 17:32:08 -07:00
Romain Guy
5a418c771d Gallery, we need to talk...
Change-Id: Ie4b62df03c27161565d303d11447e3d7ff3115c4
2012-05-18 17:09:53 -07:00
Svetoslav Ganov
cefd97c854 am e54c5f13: Merge "Exposing some accessiblity actions only for enabled views." into jb-dev
* commit 'e54c5f13652166c5896ccfa55f047301a6c8b876':
  Exposing some accessiblity actions only for enabled views.
2012-05-16 18:45:31 -07:00
Svetoslav Ganov
e54c5f1365 Merge "Exposing some accessiblity actions only for enabled views." into jb-dev 2012-05-16 18:43:31 -07:00
Svetoslav Ganov
fb1e80a247 Exposing some accessiblity actions only for enabled views.
1. Some accessibility actions should not be performed on disabled
   views. For example, scrolling should not be permitted while
   accessibility focus should be. Made a quick pass over the
   actions we expose now.

Change-Id: I36626dfbc0d2f480309a910f58f1de64e9e05675
2012-05-16 17:51:52 -07:00