Commit Graph

7304 Commits

Author SHA1 Message Date
Siyamed Sinir
8b7053dd45 Merge "Fix EditText cursor when line spacing is set" 2017-08-01 22:37:55 +00:00
Sergey Vasilinets
ee73c957a5 Merge "Revert "Revert "Update overscroll and toast UI""" into oc-dr1-dev am: 2cf8f91637 am: 3c9c422d33
am: 98e73b856a

Change-Id: I633ca5e543781eb86f25fe82c9bae91e7af7979e
2017-07-28 23:08:13 +00:00
Sergey Vasilinets
3c9c422d33 Merge "Revert "Revert "Update overscroll and toast UI""" into oc-dr1-dev
am: 2cf8f91637

Change-Id: Ia0f4dc6193776e0b37eb7e2d2048918510cae535
2017-07-28 22:02:14 +00:00
Sergey Vasilinets
2cf8f91637 Merge "Revert "Revert "Update overscroll and toast UI""" into oc-dr1-dev 2017-07-28 21:46:43 +00:00
TreeHugger Robot
4ecf2de06b Merge "Remove secondary bidi cursor" 2017-07-27 23:58:07 +00:00
Sergey Vasilinets
ebfaca5246 Revert "Revert "Update overscroll and toast UI""
This reverts commit 45c493f2c2.

Change-Id: Idefc8e1b6f954def7ef4cdf08b687042a6091a0d
2017-07-27 23:29:34 +00:00
Roozbeh Pournader
9c13307c38 Remove secondary bidi cursor
The double bidi cursor is not user friendly. Almost no native speaker
of bidi languages likes the double cursor.

Now we always show one cursor.

Change-Id: I249befaf70630bef435c8db9039e8aacf233bf7c
Fixes: 63542996
Test: Manual (no more double cursors, bidi editing feels OK)
Test: bit CtsTextTestCases:*
Test: bit CtsWidgetTestCases:android.widget.cts.EditTextTest
Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest
Test: bit FrameworksCoreTests:android.text.
Test: bit FrameworksCoreTests:android.widget.EditorCursorTest
Test: bit FrameworksCoreTests:android.widget.TextViewTest
2017-07-27 11:58:42 -07:00
Felipe Leme
83a8429dd7 Merge "Move cursor to end of text when autofilling." into oc-mr1-dev am: de499f469f
am: 453f2a60fa

Change-Id: If94c356c3a814c800285057bff95dac0ebe3e13b
2017-07-27 05:10:51 +00:00
Aurimas Liutikas
ba9dddc08c Merge "Revert "Update overscroll and toast UI"" into oc-dr1-dev am: 0aadeed536 am: 4d5a1ff81c
am: 3a95583d2a

Change-Id: I49fccc9953bc26febafe2b57cec5bc13c56f0c23
2017-07-27 00:02:59 +00:00
Aurimas Liutikas
3a95583d2a Merge "Revert "Update overscroll and toast UI"" into oc-dr1-dev am: 0aadeed536
am: 4d5a1ff81c

Change-Id: Id0158fe95811436fccda10bf270a2e8d550dcdec
2017-07-26 23:00:57 +00:00
Aurimas Liutikas
0aadeed536 Merge "Revert "Update overscroll and toast UI"" into oc-dr1-dev 2017-07-26 22:36:59 +00:00
Aurimas Liutikas
45c493f2c2 Revert "Update overscroll and toast UI"
This change broke android.uirendering.cts.testclasses.EdgeEffectTests.

This reverts commit 6085f8a16b.

Bug: 64085792

Change-Id: I70ccebebb54dabf1ec0ee5002adca93e44104a1e
2017-07-26 22:24:21 +00:00
Siyamed Sinir
a60b59d1cc Fix EditText cursor when line spacing is set
Test: bit FrameworksCoreTests:android.widget.TextViewTest
Test: bit FrameworksCoreTests:android.widget.EditorCursorTest
Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest
Test: bit CtsWidgetTestCases:android.widget.cts.EditTextTest

Bug: 30870806
Change-Id: I54f014b06af328c3e9a9c4ddb5a3348a26e290c2
2017-07-26 11:12:53 -07:00
Chet Haase
fd7cfd1a5a Merge "Update overscroll and toast UI" into oc-dr1-dev am: 1c31f9653f am: 36fa7f4eec
am: 832407ab96

Change-Id: I28bab5cb9f3f45a8583f86db75b9f266d074ee62
2017-07-26 06:08:06 +00:00
Chet Haase
36fa7f4eec Merge "Update overscroll and toast UI" into oc-dr1-dev
am: 1c31f9653f

Change-Id: Ib76daf28d94791f0c525aa1dcc57939ac60050c9
2017-07-26 05:47:47 +00:00
Chet Haase
1c31f9653f Merge "Update overscroll and toast UI" into oc-dr1-dev 2017-07-26 05:40:41 +00:00
Chet Haase
6085f8a16b Update overscroll and toast UI
Overscroll updates:
Same shape, but smaller radius (doesn't come as far into the view)
and more translucent (max 15% instead of 50%). Overall, more subtle.

Toast updates:
Light background, smaller, dark font, closer to the bottom of the
container.

Test: manual unit tests. Also:
cts test ToastTest for toast changes
cts test EdgeEffectTests for EdgeEffect changes (adding some tests to
known-failures for now, due to brittle golden-image failures - see
CL ag/2596621)
Bug: 30563264  Refresh toast visuals for Android ODR
Bug: 63010438  Tweaks to overscroll animation
Change-Id: I0fac6322b0b81d030c8d174852c134211290bbea
2017-07-26 05:40:02 +00:00
Felipe Leme
2e58b1672e Move cursor to end of text when autofilling.
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.LoginActivityTest#testAutofillMovesCursorToTheEnd
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 62669787

Change-Id: I70a583c71057804334e86ed3f7dd2aca8da20922
2017-07-25 10:37:02 -07:00
Andrei Stingaceanu
1244815e8f Remove @hide from ViewGroup debug methods
Allow developers to easily add their own debugging info
when developing custom ViewGroups.

Bug: 30117235
Test: tests still pass
Change-Id: Ia83005b4dc727c7b959a50e7b0130582f6e89762
2017-07-25 10:00:21 +00:00
TreeHugger Robot
1e2df08ade Merge "Define constants for ellipsize values" 2017-07-24 21:24:38 +00:00
Roozbeh Pournader
3f9cfa77d8 Define constants for ellipsize values
Also remove an already-done TODO item.

Test: bit CtsTextTestCases:*
Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest
Test: bit CtsWidgetTestCases:android.widget.cts.EditTextTest
Test: bit CtsWidgetTestCases:android.widget.cts.CheckedTextViewTest
Test: bit CtsWidgetTestCases:android.widget.cts.AutoCompleteTextViewTest
Test: bit CtsWidgetTestCases:android.widget.cts.MultiAutoCompleteTextViewTest
Test: adb shell am instrument -w -e package android.text com.android.frameworks.coretests/android.support.test.runner.AndroidJUnitRunner
Change-Id: I0c91ac3ad4ab5794c1e36f1f5e576d52acad66b2
2017-07-24 10:05:59 -07:00
Siyamed Sinir
967805ca47 Merge "Handle long text for share/cut/copy operations." 2017-07-21 18:07:07 +00:00
Siyamed Sinir
ce3b05abc0 Handle long text for share/cut/copy operations.
When TextView or EditText contains text that is larger than the
total parcelable limit, some of the FloatingToolbar operations would
crash.

This CL changes the behavior as follows:
- Show a toast message if cut or copy operation fails because it cannot
  set the primary clip.
- Trim the text for share and process_text actions
- A simple app with an EditText and a long text in it, would not open
since Autofill value was being sent over IPC. Trimmed the text that is
sent for Autofill feature.
- Trim the value send to accessibility services

Test: bit CtsWidgetTestCases:.TextViewTest
Test: bit FrameworksCoreTests:android.widget.TextViewTest
Test: bit FrameworksCoreTests:android.text.TextUtilsTest
Test: Manual sample app test

Bug: 8013261
Change-Id: Ia0df6b4eb4c13071a1bf75cedac7241c7239663c
2017-07-20 15:01:18 -07:00
Siyamed Sinir
5b522e204c Merge "Update TextView ApiDoc for lineSpacing attributes" 2017-07-20 15:26:51 +00:00
Siyamed Sinir
7f9b0909f9 Update TextView ApiDoc for lineSpacing attributes
lineSpacing attributes are not applied for last lines of a text. Update
ApiDocs accordingly.

Test: none
Bug: 30508784
Change-Id: I83593d0b57f717deb90ac8d589673b61358bc914
2017-07-19 18:20:07 -07:00
Selim Cinek
8ffa981686 Merge "Reducing bitmap sizes in notifications" into oc-dr1-dev 2017-07-19 23:41:44 +00:00
Selim Cinek
15733d1f85 Reducing bitmap sizes in notifications
Bitmap sizes could be arbitrary large when they were sent
over to the system. We're now reducing them to reasonable
sizes.s

Also fixed that notification bitmaps were not put into
ashmem anymore since it got lost in a refactor.

Test: code inspection
Bug: 62319200
Merged-In: I87db7656e749666b9eab1f67fd497f155c407e18
Change-Id: I87db7656e749666b9eab1f67fd497f155c407e18
2017-07-19 18:06:09 +00:00
Selim Cinek
d0426628f6 Reducing bitmap sizes in notifications
Bitmap sizes could be arbitrary large when they were sent
over to the system. We're now reducing them to reasonable
sizes.s

Also fixed that notification bitmaps were not put into
ashmem anymore since it got lost in a refactor.

Test: code inspection
Bug: 62319200
Change-Id: I87db7656e749666b9eab1f67fd497f155c407e18
2017-07-19 11:05:26 -07:00
TreeHugger Robot
e38db1b9be Merge "Fix calculation of RelativeLayout width in RTL mode" 2017-07-14 21:10:57 +00:00
TreeHugger Robot
41db50cd25 Merge "Disable smart sharing for password fields." 2017-07-14 20:21:59 +00:00
Abodunrinwa Toki
76b51dc450 Disable smart sharing for password fields.
Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest
bit CtsWidgetTestCases:android.widget.cts.TextViewTest
Bug: 62340817
Change-Id: Ifbf2c39d9f304251adc8c4acdf1b4fd6914011d8
2017-07-14 18:31:04 +01:00
TreeHugger Robot
267c6b2a5b Merge "Avoid FloatingToolbar flickers" 2017-07-14 13:44:45 +00:00
Roozbeh Pournader
4d4596aae8 Fix calculation of RelativeLayout width in RTL mode
Fixes: 37035671
Test: Manual
Test: bit CtsWidgetTestCases:.RelativeLayoutTest
Change-Id: I82feecdba7d1ed1198580758ab1f68932bb50aa7
2017-07-13 19:11:05 -07:00
Roozbeh Pournader
bfe8b1cdd6 Merge "Merge "Make TextInputTimePickerView use localized input" into oc-dr1-dev am: dd74c1a8cd" into oc-dr1-dev-plus-aosp
am: d792c31806

Change-Id: I91e28ff9aa7b2bea64dcfe2371f8a734ea8cbb6e
2017-07-14 00:57:59 +00:00
Roozbeh Pournader
f3cda89def Make TextInputTimePickerView use localized input
Previously, TextInputTimePickerView used the default numeric IME, which
could result in cases where the digits displayed in the text fields were
native, but the IME showed ASCII digits resulting in a mix.

Now we use setImeHintLocales to hint that we need a localized IME.

Change-Id: Ic4041dcc65a31bd00741c6d96d8cbc5dac9d77c8
Fixes: 63650251
Test: Manual (tested under en-US and ar-BH locales)
2017-07-13 15:25:24 -07:00
Abodunrinwa Toki
4a7aeb3cb0 Avoid FloatingToolbar flickers
by:
 1. Restricting 'moving hide' -- where we hide the toolbar if the
    toolbar is moving.
 2. Hide the toolbar when transitioning to 'select all' -- where the
    toolbar is refreshed.

Bug: 32910217
Bug: 30418276
Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest
bit CtsWidgetTestCases:android.widget.cts.TextViewTest

Change-Id: I1f44ee765d74bbcf08e6e7cd635f76d1e8f6305b
2017-07-13 21:48:51 +01:00
Sumir Kataria
37b8567a87 clearChoices when setting AbsListView adapters.
This allows us to reset mCheckedItemCount to 0 to match the clearing
of check states.

Bug: 63559021
Fixes: 63559021
Test: Added test to AbsListViewTest.

Change-Id: I47a0fbc25448addf75a3f7e5a282bb98360200dd
2017-07-12 10:39:41 -07:00
Phil Weaver
9e90a7236a Merge "NumberPicker a11y (and a11y-inspired) fixes" 2017-07-11 23:12:20 +00:00
TreeHugger Robot
ed8c1eb56a Merge "Respect the locale in vertical location of AM/PM" 2017-07-06 22:08:25 +00:00
Anthony Chen
10fccb0473 Merge "Merge "Fix bug where RemoteViews addView is backwards." into oc-dr1-dev am: 25c84b3321" into oc-dr1-dev-plus-aosp
am: 7730f5ad86

Change-Id: Id53671bbdefa0683c19e84f245cf60ba9460278c
2017-07-06 21:46:50 +00:00
Roozbeh Pournader
6791c7bf67 Respect the locale in vertical location of AM/PM
If the locale puts the AM/PM before the hour and minute in time
formatting, make sure TimePicker respects that by putting the AM/PM
above the hour and minute in landscape mode, where the AM/PM used to
always appear below the hour and minute.

Two sets of locales are affected. All of them put the AM/PM before
the hour and minute, but the first set also defaults to 12-hour, so
the change is most visible in these: Ewe, Chinese (both Simplified
and Traditional, including Cantonese), Korean, and Tamil. The second
set, Hungarian, Japanese, Myanmar, Sinhala, and Turkish, would only
see the difference if the time picker is forced into 12-hour mode.

Test: manual (tested en-US, ar-EG, ta-IN, zh-Hans-CN, ko-KR)
Change-Id: Ic5840d46d81a004294bda4644df02c721152686b
Fixes: 63352170
2017-07-06 13:18:02 -07:00
Roozbeh Pournader
01bcf1ef5c Respect locale direction in TimePicker AM/PM location
Previously, the code that decided where the AM/PM indicator should
end up relative to the hours and minutes assumed that the locale was
LTR. Now it works correctly for RTL locales too.

Bug: 62846484
Test: manual (tested adding an alarm under ar-EG, en-US, and ta-IN, all of which are 12-hour)
Change-Id: I748baff01e2b3398747a2f8c074edbd16322bdf9
2017-07-05 18:32:47 -07:00
TreeHugger Robot
60b108d758 Merge "Fix RTL issue in RelativeLayout" 2017-07-05 23:45:24 +00:00
Chet Haase
bcd3520be6 Fix RTL issue in RelativeLayout
A long-standing bug in RelativeLayout meant that items inside a
RelativeLayout with layout centering (layout_centerHorizontal)
and WRAP_CONTENT would cause the surrounding RelativeLayout to be
sized incorrectly, resulting in bad layouts overall (the RelativeLayout
could end up much too large, pushing other layouts out of view). This
artifact was visible in TimePicker in landscape mode, but worked
around in the O release by forcing LTR on the parent layout of the
RelativeLayout.

The problem was that the case of center/wrap would end up positioning
the view on the left of the layout, instead of the RTL-friendly right
side. The fix is to do the correct thing in RTL mode (position relative
to the right side of the layout instead).

Bug: 63003526  TimePicker RTL issue
Bug: 62846484  TimePicker layout is broken in RTL landscape mode
Test: manual (run Clock app in RTL and non-RTL modes and observe layout behavior in
both portrait and landscape modes).

Change-Id: I9033857a39f422e3d6fb6e4d313d1739ae3f5c63
2017-07-05 21:45:50 +00:00
Anthony Chen
ea202f6646 Fix bug where RemoteViews addView is backwards.
The index on where to add a child view was not being saved when writing
to a Parcel. This causes the index to default to 0 and resulted in views
always being added as the first view.

Now, persist this value to the Parcel and restore it.

Test: booted up on Nexus 6P, created notification with RemoteView, added
two views and verified views added in correct order.
Bug: 63177271

Change-Id: I94384e348b8a5168efe0601f382cdd2db6791fdb
2017-07-05 21:12:41 +00:00
Abodunrinwa Toki
1d263b8a38 Merge "No smart text assist for unprovisioned device." into oc-dr1-dev am: bda6275cf6
am: 925eb60a2c

Change-Id: Ib08b1a455c69ec499488d89df6c2419c368ca27c
2017-06-30 22:49:45 +00:00
Abodunrinwa Toki
9796a1bd00 No smart text assist for unprovisioned device.
Test: bit CtsViewTestCases:android.view.textclassifier.cts.TextClassificationManagerTest
bit FrameworksCoreTests:android.widget.TextViewActivityTest
bit FrameworksCoreTests:android.widget.TextViewActivityMoutseTest
Bug: 62745625
Change-Id: I360250a5c2a92d09c8d8f559b51c74f490f70c2c
2017-06-30 00:50:39 +01:00
TreeHugger Robot
c1323664d4 Merge "Make the android.R.string.autofill public." 2017-06-28 01:55:57 +00:00
Phil Weaver
53a8e4370a Merge "Clean up popup window titles" 2017-06-27 00:39:30 +00:00
Phil Weaver
dd6978545f Clean up popup window titles
Removing the recently-added APIs to adjust the title for
the popup window, and moving setting the title to
preparePopup(), which is guaranteed to have a context.
(The bug is a crash because we didn't have a context.)

Apps wishing to specify their own title can still do so
in the LayoutParams without bothering with the get/set.

Bug: 62675086
Test: With TalkBack running, navigate to Settings->
Network & Internet. Select the more options button and
double-tap to select it. It now announces "Popup Window".

Change-Id: I9735ace42c24ef4977d3f4d5150f768d44aff351
2017-06-26 15:32:21 -07:00