Commit Graph

1335 Commits

Author SHA1 Message Date
Abhijeet Kaur
ba720eb16d Turn on feature flag to use bugreport API by default
Bug: 136548098
Test: build, flash, take bugreport from Settings uses API workflow by
default. Turning off the feature flag from Settings uses old bugreport
workflow

Change-Id: I6462fcd77e812420dfeb9d3e5a0a8646745606f2
2019-08-08 15:09:33 +01:00
Abhijeet Kaur
57fb463e01 Merge "Make USE_BUGREPORT_API more widely available." 2019-08-08 10:53:31 +00:00
Abhijeet Kaur
943c64b25f Make USE_BUGREPORT_API more widely available.
Previously this flag was in FeatureFlag for Settings, as only Settings
was using this flag. Now, we also need to use this feature flag while
migrating bugreports(from other callers such as Power buttons) to use the API.

In order to avoid flag duplication, adding it here, as Settings can
still access this feature flag.

Bug: 136548292
Test: Settings can still access this feature flag as before
Test: Builds and bugreports generated from Settings use the API flow
when the flag is turned on

Change-Id: Ia7409fc821e1438382e9b59c523ab72de519e861
2019-08-07 16:49:56 +01:00
Vinit Nayak
3e73749c13 Create general callback for changes to RecentTaskList
New callback called whenever a user visible task
is added or removed to the recents list. This results
in less work by updating only when recent task list
changes instead of listening for active task list
changes.

Test: atest RecentTasksTest

fixes: 111077107

Change-Id: I9acf13762d0c79bfde90b64fa5e0edaf882068cc
2019-07-26 12:10:47 -07:00
Quang Luong
3fbca101a8 Added feature flag for WifiTracker2
Feature flag intended to toggle between WifiTracker and the
WifiTracker2 refactor in WifiSettings.

Bug: 70983952
Test: build, check Developer Settings > Feature Flags for new toggle
Change-Id: I06b1346df9ddbc0bce4d40902ed7752827e14ecf
2019-07-19 14:37:12 -07:00
Kweku Adams
6acbca3a9a Rename ProtoInputStream.isNextField to nextField.
ProtoInputStream.isNextField() skips over the current field to read the
next tag. This side effect means that calling isNextField prevents the
caller from reading the field it was just on. The "is" prefix makes it
easy to assume that the method has no side effects. Renaming to
nextField(long) with a parameter should help make it clear that the call
is as dangerous as calling nextField().

Fixes: 137294060
Test: atest android.app.usage.UsageStatsTest
Test: atest android.app.usage.cts.UsageStatsTest
Test: atest com.android.server.usage.UsageStatsDatabaseTest
Test: atest ProtoInputStreamTests
Change-Id: Ibfb8ef741f27a211f076dc0b715b64acbfc0696a
2019-07-12 17:10:39 -07:00
Felipe Leme
b769296531 Improved TimingsTraceLog performance by using arrays, instead of Deque of Pairs.
Test: manual verification
Test: atest FrameworksMockingCoreTests:android.util.TimingsTraceLogTest

Fixes: 135754571

Change-Id: I7a3571a422d09cd618f6610d3403a870af1ebafa
2019-06-25 15:34:02 -07:00
Felipe Leme
137e7812f0 Moar SystemServer boot timing improvements:
- Added (optional) constant to log duration of bottlenecks.
- Added TimingsTraceLog.getUnifinishedTraces()
- Added more traceBegin() / traceEnd() statements
- Uses Truth on TimingsTraceLogTest
- Logs total boot duration

Test: manual verification
Test: atest FrameworksCoreTests:android.util.TimingsTraceLogTest

Bug: 133242016
Bug: 132466534

Change-Id: Ib9bb38d357e0d87a9b7da3456c97029a8b0342a3
2019-06-18 18:59:58 -07:00
TreeHugger Robot
2a0fdd14c7 Merge "Add DENSITY_450" 2019-06-13 01:14:01 +00:00
Beverly
d310586c60 Merge "Merge "Add feature flag to enable skip direction mapping" into qt-r1-dev am: 79f7ac9922" into qt-r1-dev-plus-aosp
am: ffa1f390f7

Change-Id: Id81327f4a59febd57c982d7677f7fde9497a0ce6
2019-06-12 11:14:43 -07:00
Beverly
600211a639 Merge "Add feature flag to enable skip direction mapping" into qt-r1-dev
am: 79f7ac9922

Change-Id: I1f4561a0a1104fb64b763fc168f10430b449098f
2019-06-12 10:56:44 -07:00
bj1211jeon
ecd6e71aa6 Add DENSITY_450
Add 450dpi as a supported screen density.
This change follows up below change Id : Iac673eae2d82c27d96e279c076454af2f5933208

Originally 600dpi was added to support sw384 with WQHD resolution,
though it was lack of for the cases when resolution is FHD resolution. (In case of other resolutions, there already exist 300 and 200 for HD and WVGA resolutions).

Bug: 78283907
Test: run android.dpi.cts.ConfigurationTest#testScreenConfiguration and android.app.cts.ActivityManagerMemoryClassTest#testGetMemoryClass
(cherry picked from commit 13ca0450ede3eedf7d34bbd0b69525cb6ebc63f1)
2019-06-11 07:30:31 -07:00
Beverly
4844d722a9 Add feature flag to enable skip direction mapping
When this feature if enabled, users can change the directionality
of the skip gesture

Test: manual
Bug: 132788434
Change-Id: I43fb58c3abeafc36424b1ce6ef4140428de84f4e
2019-06-10 11:52:16 -04:00
Neil Fuller
ca1e48d841 Merge "Delete ByteStringUtils: it is no longer used" am: a677e4d5a0 am: ee2ded047a am: d894c2498a
am: 7a635dcae9

Change-Id: I953179efa0caa8b1db5b56eb7b448f2a7f648b74
2019-06-06 06:18:24 -07:00
Neil Fuller
d894c2498a Merge "Delete ByteStringUtils: it is no longer used" am: a677e4d5a0
am: ee2ded047a

Change-Id: I0752abd2b5e739f8fde780a07a5e417daa058ba7
2019-06-06 06:09:37 -07:00
Neil Fuller
48481e6f93 Delete ByteStringUtils: it is no longer used
The class has odd null handling and refuses to
encode odd numbers of bytes.

Bug: 124232146
Test: build only
Change-Id: Iefca8a870a12df6dec77147957cf4c8084daa506
2019-06-04 08:13:40 +00:00
PO HUNG CHEN
e743aeb922 Merge "Fix StrictModeTest#testNonSdkApiUsage" into qt-dev
am: 4f179bb174

Change-Id: Ic8177c57829e8f28b881c3347b1a4b93084c7fe4
2019-05-28 19:16:26 -07:00
Abhijeet Kaur
2ae76e468b Merge "Migrate Shell app to use the new bugreport API." 2019-05-28 16:56:32 +00:00
Howard Chen
40abbb0fe9 Fix StrictModeTest#testNonSdkApiUsage
Test: atest android.os.cts.StrictModeTest#testNonSdkApiUsage
Bug: 131923046
Bug: 129892635

Merged-In: I6759339000eb239112c0c83ce1131f34164ee0cf
Change-Id: I6759339000eb239112c0c83ce1131f34164ee0cf
2019-05-28 16:25:20 +01:00
Abhijeet Kaur
767c8bb96a Migrate Shell app to use the new bugreport API.
Add new calls to bugreport API, all the while keeping the previous code
and logic untouched.

Added feature flag in Settings which if untouched, runs the old dumpstate workflow
by default. To test the new workflow turn on the feature flag from UI or
`adb shell setprop settings_call_bugreport_api true`.

Add permission TRIGGER_SHELL_BUGREPORT so that not all can send
broadcasts to trigger bugreports.

Create new receiver BugreportRequestedReceiver for the new broadcast intent that the shell app will
use.

Whitelist Shell app to use the bugreport API.

Bug: 123617758

Test: manually built and flash to device. Turn on the feature flag, generate bugreports and check
the onProgress and onFinish notifications.
Test: Turn off the feature flag test old workflow.

Change-Id: I1c7c258a48815a0386d7d4771301cd76f9cae3d0
2019-05-28 14:31:57 +01:00
Mathew Inwood
8b1ed3a51c Merge "Fix StrictModeTest#testNonSdkApiUsage" 2019-05-28 08:30:22 +00:00
Tej Singh
019e7e8dfd Merge "Statsd: Add watchdog rollback to experiment ids" into qt-dev am: 42fb4bb1e9 am: ea2bdcd36f
am: 2fe1e333d5

Change-Id: I405037efc0af8e5bd0094f02036824d32d4ae1a3
2019-05-24 17:13:36 -07:00
Howard Chen
a7e62a828e Fix StrictModeTest#testNonSdkApiUsage
Test: atest android.os.cts.StrictModeTest#testNonSdkApiUsage
Bug: 131923046
Bug: 129892635

Change-Id: I6759339000eb239112c0c83ce1131f34164ee0cf
2019-05-24 23:19:35 +08:00
Tej Singh
ea2bdcd36f Merge "Statsd: Add watchdog rollback to experiment ids" into qt-dev
am: 42fb4bb1e9

Change-Id: Ia47f663b1dcbab9c4f9f8ce2b49cde6545d46ba1
2019-05-23 12:47:46 -07:00
TreeHugger Robot
42fb4bb1e9 Merge "Statsd: Add watchdog rollback to experiment ids" into qt-dev 2019-05-23 19:25:43 +00:00
Josh Gao
c488ccb834 Merge "MemoryIntArray: dup in writeToParcel." into qt-dev am: 6429b70cf6 am: 34ec95fb76
am: 69c187b0bd

Change-Id: Icb0ab63aa1fa09bdf2f36f8c7dc99199a829e487
2019-05-21 03:29:34 -07:00
Josh Gao
34ec95fb76 Merge "MemoryIntArray: dup in writeToParcel." into qt-dev
am: 6429b70cf6

Change-Id: Ia5ed094e4f2c5579617037dc0140c34c412f09cc
2019-05-20 16:27:54 -07:00
Tej Singh
73f8e9b086 Statsd: Add watchdog rollback to experiment ids
Stores experiment ids to disk for watchdog rollback initiate/success
events as discussed.

Test: gts in topic
Bug: 131768455
Change-Id: I32768fe5c5c21c43811e25d8f87faae0c8d82c1f
2019-05-20 22:52:40 +00:00
Josh Gao
536cf5e016 MemoryIntArray: dup in writeToParcel.
Previously, if a MemoryIntArray is written to a parcel from multiple
threads, we'll create multiple ParcelFileDescriptors that own the same
file descriptor, which fdsan doesn't like. Instead of adopting and then
detaching, use ParcelFileDescriptor::fromFd which dups behind the scenes.

Bug: http://b/132720476
Test: treehugger
Change-Id: Iad4930cc2d8c59a9348fedb0889d24cb566afa62
2019-05-15 14:05:26 -07:00
Aran Ink
3ff2f70f39 Remove GlobalActionsDialog values from FeatureFlagUtils.
am: f4744c686f

Change-Id: Idce0f146dcf5540803bc9f1b079742958088ba55
2019-05-14 07:43:53 -07:00
Aran Ink
f4744c686f Remove GlobalActionsDialog values from FeatureFlagUtils.
Merged-in: I5ca5e760d9a987c75a93c43783ad2b38728d48fc
Test: Automated tests pass. Manual testing shows GAD still works.
Fixes: 123397865
Fixes: 127644235

Change-Id: I0a8e285c96eea566ed1b19fa05e4143324f5937b
2019-05-14 14:31:07 +00:00
Eugene Susla
959d9c4bd3 Merge "Revert "MemoryIntArray: track the owned file descriptor in a PFD."" into qt-dev am: 1198fc4e71
am: 97fb2a69bf

Change-Id: I1129063e86c6299fcc646fb96466ffa356f66e62
2019-05-13 16:15:01 -07:00
Eugene Susla
97fb2a69bf Merge "Revert "MemoryIntArray: track the owned file descriptor in a PFD."" into qt-dev
am: 1198fc4e71

Change-Id: Ifb91c1e8bb2c72e607bce0f733b0c95c5b5fdce6
2019-05-13 15:59:27 -07:00
Eugene Susla
1198fc4e71 Merge "Revert "MemoryIntArray: track the owned file descriptor in a PFD."" into qt-dev 2019-05-13 22:21:48 +00:00
Aran Ink
3f5945539f Remove FeatureFlagUtils entries for Global Actions Dialog.
Test: Automated tests pass. GAD still displays correctly when holding down power button.

Bug: 123397865
Bug: 127644235
Change-Id: I5ca5e760d9a987c75a93c43783ad2b38728d48fc
2019-05-13 14:29:35 -04:00
Kweku Adams
87bb29662f Merge "Add extra comment for implementation." into qt-dev am: b60e619257
am: 27657de659

Change-Id: Ie0796ac5121a52a2aa0021ec7b66045efff32e91
2019-05-11 00:47:39 -07:00
Kweku Adams
27657de659 Merge "Add extra comment for implementation." into qt-dev
am: b60e619257

Change-Id: I6a12f48c1b90b46e3dd8cfd69c280a97705aec22
2019-05-10 18:10:06 -07:00
TreeHugger Robot
b60e619257 Merge "Add extra comment for implementation." into qt-dev 2019-05-10 23:33:39 +00:00
Svet Ganov
d2404405e7 Revert "MemoryIntArray: track the owned file descriptor in a PFD."
The reverted change causes a regression where we can get an IllegalStateException
during finalization as we are adopting the native fd in a ParcelFileDescriptor
which takes ownership of the fd. However, the order of finalization is undefined
and if the ParcelFileDescriptor is finalized before the MemoryIntArray we would
get an exception when running the finalization of the latter.

bug:124056170

This reverts commit c81f53f7f1.

Change-Id: I8debb9c5f4c87b1a657084139b27f40b7956fe59
2019-05-10 14:08:00 +00:00
Hyunyoung Song
0c2e4a04b8 Merge "ic_corp_badge shape change on adaptive icon shape change" into qt-dev am: e967fe3dab
am: df0be35708

Change-Id: I1967f0fb965e35cbcb95604c5bf1134989664fdf
2019-05-08 00:00:20 -07:00
Hyunyoung Song
df0be35708 Merge "ic_corp_badge shape change on adaptive icon shape change" into qt-dev
am: e967fe3dab

Change-Id: I1303877c07ea567d06b3a46db5ffbc2d9dc5347a
2019-05-07 22:42:24 -07:00
Hyunyoung Song
e967fe3dab Merge "ic_corp_badge shape change on adaptive icon shape change" into qt-dev 2019-05-08 05:10:00 +00:00
Hyunyoung Song
3ba5d5642c ic_corp_badge shape change on adaptive icon shape change
Bug:127867721
Test: UI looks exactly the same even after swapping out the path
Change-Id: I030c5d53a1d7f86c70b66bb6abf5d351bfc7571b
2019-05-06 02:13:58 -07:00
yuanjiahsu
943012b986 Merge "Clean Safetyhub feature flag." into qt-dev am: fe77152334
am: da52c2ecef

Change-Id: I8908c05e82fe2a139a8cd527d0a5cd979eda0433
2019-05-02 19:02:34 -07:00
yuanjiahsu
da52c2ecef Merge "Clean Safetyhub feature flag." into qt-dev
am: fe77152334

Change-Id: Ib36a78df4cca4e61ad93fd8d759ca6cdf993b4ab
2019-05-02 16:19:24 -07:00
Kweku Adams
f7c4e23fb7 Merge "Gating OutOfBoundsException on targetSdkVersion." into qt-dev am: 8f24a0fb56
am: 9c60ad272f

Change-Id: Ibe6555fd0ff175ab936837a61d5868f5bd20c86f
2019-04-30 07:17:00 -07:00
Kweku Adams
9c60ad272f Merge "Gating OutOfBoundsException on targetSdkVersion." into qt-dev
am: 8f24a0fb56

Change-Id: I3f49f2aeae973ffc07117a5aaf70aabfea239b6a
2019-04-30 05:51:09 -07:00
yuanjiahsu
a74894d5b2 Clean Safetyhub feature flag.
Clean all related code, need submit together.

Test: Manually
Bug: 118848485
Change-Id: Iaeb55de3eecf54dfefff92253f71fe2fabcb5f24
2019-04-30 18:34:57 +08:00
Kweku Adams
3858b2d1dc Add extra comment for implementation.
Add a comment noting that the check to throw the exception is
intentionally second so that it's out of the critical path.

Bug: 118339123
Test: N/A
Change-Id: I36c5ea67579bcd7906f711530392110d9987ffb4
2019-04-29 11:47:41 -07:00
Kweku Adams
4be0b1acaf Gating OutOfBoundsException on targetSdkVersion.
Apps targeting Pie or older will get the old undefined behavior. Apps
targeting Q or newer will get the OutOfBoundsException.

Bug: 118339123
Test: atest CtsUtilTestCases
Change-Id: Ibf5467aadec4a2f76ee180e963afeaf5a8a013a2
2019-04-26 12:22:16 -07:00