Commit Graph

81 Commits

Author SHA1 Message Date
Steve Block
1358a1c806 Fix DumpRenderTree2 to clear AppCache between tests
Change-Id: I1bafc79bbdbec0df7e4c8039488478a3bfcb3bd4
2010-09-22 15:43:34 +01:00
Steve Block
3cf18f5c96 Fix DumpRenderTree2 to wait for the WebCore thread to become ready
This is required to make sure that the WebCore thread's message
handlers are ready to receive settings.

Change-Id: I2c4df95e3b7409535b739ada957d93a7e6cd78d6
2010-09-22 15:43:34 +01:00
Steve Block
34f3851e95 Fix DumpRenderTree2 to make AbstractResult serializable
This should have been doen as part of
https://android-git.corp.google.com/g/#change,65283

Change-Id: I7a4681f98014ff5a7546a7346fc5523e01f62e19
2010-09-22 15:33:05 +01:00
Steve Block
f09aafa275 Fix DumpRenderTree2 to handle SSL errors
This fixes http/tests/appcache/different-https-origin-resource-main.html

Change-Id: I90e151c027b2d8c55ea82104c02e4a641b933024
2010-09-22 15:33:05 +01:00
Steve Block
70727d1f75 Merge "Fix DumpRenderTree2 to correctly add JavaScript interfaces to new windows" 2010-09-22 07:28:29 -07:00
Maksymilian Osowski
394e0fb849 Updated Summarizer to use SQLite DB.
It avoids OOM issues by dumping the memory to the DB every
few hundred tests and then reading them in chunks when
generating summaries, etc.

Change-Id: I5f63d960d456f17e9f2189230a7ae0ca5607ce51
2010-09-17 16:35:46 +01:00
Maksymilian Osowski
fadb0de33d Changed Summarizer to dump generated html code to file every few hundred tests to avoid OOM errors.
Change-Id: Id0917d45ffab2e47d67d17d629f342add5292d4e
2010-09-17 16:14:39 +01:00
Steve Block
76c97ee414 Fix DumpRenderTree2 to serve HTTP tests on http://127.0.0.1:8000
Currently DumpRenderTree2 serves HTTP tests on http://localhost:8080.
Some of the tests hardcode 'http://127.0.0.1:8000' for resources, so
we must use this scheme and port for the requests to be same-origin.

This fixes LayoutTest http/tests/appcache/credential-url.html

Change-Id: I2a9c402fc7b0e0b62eb4a278d67ac0e63ef96e8b
2010-09-17 16:12:21 +01:00
Maksymilian Osowski
9893d96d12 Updated ManagerService to call Summarizer.summarize() in a separate thread.
This could potentially take a long time and result in ANR.

Change-Id: Ib8b246e627e841217b68c955d92c97801e93d923
2010-09-17 15:11:15 +01:00
Steve Block
f0c289e24c Fix DumpRenderTree2 to correctly add JavaScript interfaces to new windows
When adding JavaScript interfaces to a WebView, they must be passed to
the WebView constructor, rather than to
WebView.addJavascriptInterface() if they are to be used immediately
without the risk of race conditions.

This fixes LayoutTest
http/tests/appcache/crash-when-navigating-away-then-back.html

This was fixed for DumpRenderTree in
https://android-git.corp.google.com/g/23804

Change-Id: I1581d6d6cfc1b35be1ec2f2e5b5b944da2b4b935
2010-09-17 13:21:51 +01:00
Steve Block
8a6def0247 Update DumpRenderTree2 to handle failing tests where no meaningful diff is available
Currently, DumpRenderTree2 asigns the following result codes
{PASS, FAIL_RESULT_DIFFERS, FAIL_NO_EXPECTED_RESULT, FAIL_TIMED_OUT,
FAIL_CRASHED}

This is not strictly correct, as a test may fail for any of three
reasons - crashing, timing out, or the the result not being as
expected. Therefore, it's possible for a test to fail even if the
result is as expected.

This patch updates AbstractResult to handle each of the three reasons
for failure separately. We then test all three to determine if the
test has passed.

This allows us to correctly report whether or not the result differs
from expected for a failing test.

Change-Id: I7adcfe72c4dd0bd3de2e1b868d9807be6eb5bddf
2010-09-17 13:21:22 +01:00
Steve Block
c0847c55ea Remove superfluous CSS from DumpRenderTree2's Summarizer
Change-Id: Ifc3764ec3cf7bd5ee412abaf45112eed22083456
2010-09-17 12:30:21 +01:00
Steve Block
2c38de8436 Implement WebViewClient.onReceivedHttpAuthRequest() in DumpRenderTree2
This fixes LayoutTest http/tests/appcache/auth.html.

Change-Id: Idd9ead9c35341cc6a787d409ae2fe1bebef01d60
2010-09-17 12:30:21 +01:00
Maksymilian Osowski
d96c5e0cb3 Added setXSSAuditorEnabled() LayoutTestController function.
Change-Id: I262e434573ee79c998f3ace5103c191fc0989bd2
2010-09-15 11:27:49 +01:00
Maksymilian Osowski
023606abb6 Merge "Changed Summarizer to add header before printing the path in summary.txt and details.html" 2010-09-14 10:37:46 -07:00
Maksymilian Osowski
75aa0d3828 Changed Summarizer to add header before printing the path in summary.txt and details.html
Change-Id: I6413e1871ede077793d49b7d4732f90d0aea352f
2010-09-14 18:13:07 +01:00
Steve Block
757dcbb803 Implement LayoutTestController.setAppCacheMaximumSize() for DumpRenderTree2
Change-Id: I7db486ccee1b9ebe84b89b98ba1a9b6e933d8f4e
2010-09-14 16:59:17 +01:00
Steve Block
5de8b998f5 Sort LayoutTestController methods alphabetically
This makes it easier to keep trac of which methods are implemented.
No functional changes.

Change-Id: I389ec5c0f7e77def6a479e387d1373b2b87f60c2
2010-09-14 14:44:29 +01:00
Maksymilian Osowski
8e0835c08e Merge "Added overridePreference() layoutTestsController function." 2010-09-13 10:54:28 -07:00
Maksymilian Osowski
5e689a7486 Added overridePreference() layoutTestsController function.
Change-Id: I99fbf7490c3c6eb063bf5ed0bbd2bced0f10a967
2010-09-13 18:49:59 +01:00
Steve Block
ab87db4ad8 Update DumpRenderTree2 to only calculate the WebKit revision once per test run
This is obtained by a HTTP request to ThirdPartyProject.prop

Change-Id: I34e310cf52fbcef24bb2a76e64aab5263b3052f1
2010-09-13 17:32:16 +01:00
Steve Block
c54df24fa9 Remove superfluous FileFilter from DumpRenderTree2 DirListActivity.java
Change-Id: I5e7d86fc4e05ac512ce1b2c55660d3b7f0de2750
2010-09-13 16:04:18 +01:00
Steve Block
bdebd0621b Update DumpRenderTree2 to store results in /sdcard/layout-test-results
This more closely follows other WebKit platforms, which use
/tmp/layout-test-results.

Change-Id: Ice702b73d7425250d595e8321e14ff3becb66ed5
2010-09-13 15:55:13 +01:00
Steve Block
34c68912be Remove the last remnants in DumpRenderTree2 of the absolute path to the tests
This is no longer required.

Change-Id: I27db10e8c723162b319d9a714b086f508db706e0
2010-09-13 15:51:11 +01:00
Steve Block
7438b53487 Update DumpRenderTree2 text results output to better match HTML version
Always print number of crashes and line things up nicely.

Change-Id: I79a72056ba5ce007fdd4154f1518b9535b595317
2010-09-13 14:28:46 +01:00
Maksymilian Osowski
5af84db492 Updated the AdbUtils class to better manage opening and closing the resources.
Change-Id: I83ebc6409d57a28f9015ec9726f797417ec03212
2010-09-13 10:51:08 +01:00
Maksymilian Osowski
741fdc8088 Merge "Updated FsUtils to use apache HttpClient instead of java.net UrlConnection." 2010-09-13 02:49:09 -07:00
Maksymilian Osowski
ce2ef18c8f Updated FsUtils to use apache HttpClient instead of java.net UrlConnection.
It fixed sockets leaking during readDataFromUrl() invocations.

Change-Id: Ifb1aeb32fe9bb4ffa353cf521b5174a83de270db
2010-09-13 10:47:50 +01:00
Steve Block
0e2bae14b4 Update DumpRenderTree2 to reflect removal of WEBKIT_MERGE_REVISION
We now use ThirdPartyProject.prop
See https://android-git.corp.google.com/g/#change,64831

Change-Id: Ib52fdd93ac08fb19ec8b7f539eb084c0b668e01b
2010-09-07 22:05:21 +01:00
Maksymilian Osowski
bd8c83db8f Fixed the bug in forwarder that prevented ConnectionHandler threads from exiting.
There was a deadlock when ConnectionHandler exited the loop in SocketPipeThread, and would call the onFinishedCallback, which called the synchronized method in Forwarder that would
deadlock. Changing the Forwarder class solved the issue and made it more efficient.

Change-Id: I947450a19573f2e88274b1ebc7b77d4df6afffa7
2010-09-06 12:24:26 +01:00
Maksymilian Osowski
fddedbf999 Merge "Updated Summarizer to parse CRASH instead of SKIP." 2010-09-02 09:33:08 -07:00
Maksymilian Osowski
2ca8acdb56 Adds webkit revision to the summary and details.
The revision number is taken from external/webkit/WEBKIT_MERGE_REVISION and is served to the java code by apache server. To be able to do that, the new alias directive had to be
added to the run_apache2.py script.

Bug: 2889572
Change-Id: Ie3d147e4d8ea9edd0144b819152121563b8bd759
2010-09-02 17:27:35 +01:00
Maksymilian Osowski
01c1f9d9e9 The results now show which expected result was used.
Bug: 2889857
Change-Id: If2b7e6e6a22ddb5db6c6a50a358e8f263914e6c0
2010-09-02 17:18:48 +01:00
Maksymilian Osowski
5f21f5a4a9 Updated Summarizer to parse CRASH instead of SKIP.
Bug: 2970575
Change-Id: Idc8b514f4878bcd62729a47d7fe681ade114497a
2010-09-02 17:17:06 +01:00
Maksymilian Osowski
cbba4ae260 Merge "Shows the details when all the tests finish and fixes the orientation issue." 2010-09-02 06:57:50 -07:00
Maksymilian Osowski
84daaf8b41 Merge "Fixed and slightly improved crash detection mechanism." 2010-09-02 06:55:13 -07:00
Maksymilian Osowski
1b034781f4 Shows the details when all the tests finish and fixes the orientation issue.
The tests no longer restart when orientation changes.

Bug: 2904456
Change-Id: Ie1ee463dbd63fb1a2ad2e9c28bf5989002f22215
2010-09-02 14:49:04 +01:00
Maksymilian Osowski
bcf114c2bb Fixed and slightly improved crash detection mechanism.
Before, if a crash was detected, but the "Force quit" dialog remained on the screen, sending the intent to restart the executor would do nothing. It's fixed now with default
uncaught exception handler. Also, when we catch the uncaught exception, we can restart the executor straight away, without waiting for the time-out.

Change-Id: I2f0b4b5f2abd180ff518f1a40ad1294bed2f7f67
2010-09-02 13:39:11 +01:00
Maksymilian Osowski
f072bced91 Merge "Updated Summarizer to report tests under all 4 possible categories now." 2010-09-02 04:55:24 -07:00
Maksymilian Osowski
6ae5ce4b40 Updated Summarizer to report tests under all 4 possible categories now.
Categories: ((un)expected passes/failures).
Also, FileFilter uses FAIL instead of IGNORE_RESULTS now.

Bug: 2899965
Change-Id: I06835b3d5cea84cbc92225a940bf7361cf832f59
2010-09-02 12:53:26 +01:00
Maksymilian Osowski
15116bcc76 Merge "Fixed a bug when there are too many open sockets." 2010-09-02 03:36:57 -07:00
Maksymilian Osowski
5926723f82 Fixed a bug when there are too many open sockets.
Also, some minor corrections to shutdown() in ConnectionHandler.

Change-Id: I937f200c14c185b0867f997645d8b288a19b9889
2010-09-02 11:34:03 +01:00
Maksymilian Osowski
ff314d7094 Added "run all tests in the current directory" menu option.
Bug: 2906954
Change-Id: Ib68219dc4d4d517ad859679bc8d52a02b0b631f4
2010-09-02 10:25:45 +01:00
Maksymilian Osowski
9c12bd3932 Merge "Updated the Summarizer to link to the source of the tests." 2010-09-01 04:34:46 -07:00
Maksymilian Osowski
603b70dd8b Updated the Summarizer to link to the source of the tests.
Change-Id: I90018898c627b99f5a49c301e87593b52cd18ce4
Bug-Id: 2889573
2010-09-01 12:31:33 +01:00
Maksymilian Osowski
ef9a2175ee Fixed a bug in forwarder where calling the stop method on ForwarderManager would deadlock. Also some style fixes.
The call would deadlock because lines 62-67 in ConnectionHandler were in the synchronized block. The is.read() would block and therefore call to shutdown() would block too.
is.read()
would never unblock because the stream was ready to be closed, and it needs to be done so from shutdown(). Removing the synchronized block fixes it and is save, as it was not
needed here.

Change-Id: I3326098c47ee18c4eabaa8510b27ca82debce360
2010-09-01 12:18:13 +01:00
Maksymilian Osowski
c6a341d34c Changed the code to use forwarding service.
Change-Id: I2504ef01270f9c8e82acbe6a4069d2b4b77b35f2
2010-09-01 11:59:16 +01:00
Maksymilian Osowski
2e5982a55a Tweaked the logging + some minor style fixes.
Change-Id: If89fe8ab1845780ecf23c5fd339a4932ebec9c0c
2010-08-26 16:48:41 +01:00
Maksymilian Osowski
56d7e400ec Added forwarding service.
It creates the sockets on the device that allow DumpRenderTree2 to get tests from the server running on the remote machine. Communication happens through the adb.

Change-Id: I7f26ffc78195b6c5f4d423a57d5ee5f0f4a9c615
2010-08-26 13:38:54 +01:00
Steve Block
f0f30c677a Implement logic for new Geolocation delayed permission LayoutTests
Bug: 2914450
Change-Id: Ic0be3120e88efe9199f7719b9ccb1090baaabed6
2010-08-18 15:50:48 +01:00