Commit Graph

2266 Commits

Author SHA1 Message Date
Josh Tsuji
7c36e75d6b Merge "Revert "Align bubble behavior with DND settings."" into qt-dev 2019-05-19 03:11:35 +00:00
TreeHugger Robot
9faaa2733a Merge "Add DeviceConfig flags to Privacy Indicators" into qt-dev 2019-05-18 06:14:40 +00:00
Josh Tsuji
890a79599e Revert "Align bubble behavior with DND settings."
This reverts commit 7aa18112b5.

Reason for revert: b/132891091

Bug: 132891091
Change-Id: I7775bfe2d0c65908f0f6ec14e52beaf58528e19a
2019-05-18 01:56:48 +00:00
TreeHugger Robot
1add7b84d5 Merge "Correct pointer position" into qt-dev 2019-05-18 00:24:50 +00:00
Lyn Han
6f6b3ae3f3 Correct pointer position
Pointer pointed to the right of bubble center. This happened because:
- Bubbles live in expanded view container (x includes expanded view padding)
- Pointer lives in expanded view, which has padding (x does not include padding)

This change removes expanded view padding when deriving pointer location from bubbles.

Bug: 132907741
Test: manual

Change-Id: Ic301d578fee4e6a36be9642ba30ac0cc74cdd3cb
2019-05-17 11:35:51 -07:00
Fabian Kozynski
16b26998ac Add DeviceConfig flags to Privacy Indicators
Restricts Privacy Indicators behind the same flags as Permissions Hub.

When flag is set to false:
* PrivacyItemController is set to not listening (listens to changes in
flag)
* Location icon is reverted back to P behavior
* Location icon is shown in QS Header icons (listens to changes in
flags)
* No privacy chip shown.

We need to listen to changes because most of our views/controllers
persist forever.

Test: manual, change the flag and observe things appear/disappear
Fixes: 131826452
Fixes: 132644949

Change-Id: I329596760f3c06feb2161b077af008da782a50be
2019-05-17 12:19:05 -04:00
Andy Chou
0ab517141f Merge "Fix Invalid SIM is not displayed for card error condition and add test case testTelephonyCapable_SimState_CardIOError()" into qt-dev 2019-05-17 13:38:53 +00:00
Joshua Tsuji
7aa18112b5 Align bubble behavior with DND settings.
As described at https://docs.google.com/presentation/d/1mPxqu8QBWpz-ieWkJGyLzBLcfAJNVUn8sxS1m58ogn8/edit#slide=id.g51f96ac1fd_25_230.

Due to b/132699005, the 'new' dot won't appear if 'Don't pop notifications on screen' is selected in DND restrictions.

Test: atest SystemUITests
Bug: 123540994
Fixes: 123540994
Change-Id: I38958555721fa3d9dd44c451c32c28d9a73415f5
2019-05-17 03:19:54 +00:00
Joshua Tsuji
33c0e9cebd Don't animate new bubbles in until the stack pos is set.
Test: atest SystemUITests
Bug: 132782486
Change-Id: Ie6879de845dc1acb4fc5ee467e2384407394d345
2019-05-16 19:08:57 -04:00
Lucas Dupin
5c3320d720 Merge "Hide media on AOD when not playing" into qt-dev 2019-05-16 22:33:45 +00:00
Lucas Dupin
6b40d5ed49 Hide media on AOD when not playing
Media seems stuck on AOD if paused or stopped and still visible.

Test: play pause with bluetooth headphones
Test: play pause on lock screen
Test: skip songs on lock screen, go to aod
Fixes: 131314881
Change-Id: I3574bbf628b708d2f9d4c4363a912de5ded951ac
2019-05-16 12:05:01 -07:00
andychou
695a76090f Fix Invalid SIM is not displayed for card error condition and add test
case testTelephonyCapable_SimState_CardIOError()

There is existing bug that KeyguardUpdateMonitor doesn't notify
CarrierTextController in State.CARD_IO_ERROR condition, so invalid text
doesn't display.
Notify CarrierTextController in State.CARD_IO_ERROR condition to allow
correct text to display

Bug: 132376981
Test: fake SIM state with State.CARD_IO_ERROR and make sure invalid text
is displayed. Also atest testTelephonyCapable_SimState_CardIOError pass

Change-Id: Iecb404689f57776c21591a049bc660fec17127d4
2019-05-16 23:29:28 +08:00
TreeHugger Robot
4360543283 Merge "Talkback for focus on collapsed bubble stack" into qt-dev 2019-05-15 23:09:47 +00:00
Lyn Han
6c40fe70a8 Talkback for focus on collapsed bubble stack
Bug: 131610000
Test: manual
Change-Id: I6aa79dfea751c47c86e93f56f7916dd56dbc003f
2019-05-15 11:01:43 -07:00
Lucas Dupin
ca88e5fb18 Block face auth when lock icon is pressed
It's necessary to lock the current user, until the next screen power
cycle, to avoid unlocking the device accidentally.

Fixes: 132129109
Test: atest KeyguardIndicationControllerTest
Test: Unlock with biometrics, long press lock icon, swipe up
Test: Unlock with biometrics, swipe up
Change-Id: I23258a79531c21d0e63bd0a91db59d8950526197
2019-05-14 16:27:50 -07:00
Josh Tsuji
61b91750c8 Merge "Make the flyout dismissable with a gesture." into qt-dev 2019-05-14 15:34:38 +00:00
Hyunyoung Song
a639930052 Merge "Revert "Notify OverviewProxyService of scrim colors"" into qt-dev 2019-05-13 22:53:06 +00:00
Joshua Tsuji
6549e70afc Make the flyout dismissable with a gesture.
This adds the flyout-to-dot transition, and encapulates the flyout logic in a custom view. This also adds support for the 'new' dot changing sides (previously unimplemented) and animates it changing sides when the stack changes sides.

Test: atest SystemUITests
Fixes: 129768381
Bugs: 129768381
Change-Id: I90697b437cf14e5c5a211c87ed2c131a12e697e7
2019-05-13 18:47:54 -04:00
Hyunyoung Song
d200fa1908 Revert "Notify OverviewProxyService of scrim colors"
Bug: 130451254
Test: manual

This reverts commit d9b9847ad6.

Reason for revert: found a better way to extract scrim colors without going through OverviewProxy

Change-Id: Iac97fee4d9b15757f7211889f6c370757c0870e3
2019-05-13 16:53:56 +00:00
TreeHugger Robot
1468725e06 Merge "Notify OverviewProxyService of scrim colors" into qt-dev 2019-05-10 21:16:11 +00:00
Lucas Dupin
d9b9847ad6 Notify OverviewProxyService of scrim colors
Bug: 130451254
Test: manual
Test: atest SysuiColorExtractorTests
Change-Id: I0ce271d3250ff5292a8e195c4c19ee99328ebad4
2019-05-10 11:00:33 -07:00
TreeHugger Robot
cdfa13da4a Merge "Add support for FalsingPlugin to supply a replacement FalsingManager." into qt-dev 2019-05-10 17:55:25 +00:00
TreeHugger Robot
7de91bb87e Merge "Fix flaky test" into qt-dev 2019-05-10 17:45:12 +00:00
Dave Mankoff
468d4f6f79 Add support for FalsingPlugin to supply a replacement FalsingManager.
Bug: 130256776
Test: Manual
Change-Id: Icdf150e6e23d216f04a9243fe57919aa622706d5
2019-05-10 12:14:27 -04:00
Fabian Kozynski
5e23231f82 Merge "Fix race condition in TileServices" into qt-dev 2019-05-10 14:22:25 +00:00
Fabian Kozynski
a8b20b3191 Fix flaky test
Test was flaky because the messages were posted in main looper (that is
not injected) and needed to be flushed.

Test: this test
Fixes: 132420431
Change-Id: Ie0765b574f3b1425a4d65ca13c3a1ae5eaf53b5c
2019-05-10 10:01:54 -04:00
Sherry Huang
4645ba6e6b Merge "SystemUI: overheat warning enhancements and bug fixes." into qt-dev 2019-05-10 13:00:52 +00:00
Josh Tsuji
2644c71e15 Merge "Disable flaky new test to unblock submits." into qt-dev 2019-05-10 01:35:45 +00:00
Joshua Tsuji
15e7262c1f Disable flaky new test to unblock submits.
Test: atest SystemUITests
Bug: 132384561
Change-Id: I5d5c4f5d8aaac3bea2e415195ad6525c0227fd8e
2019-05-10 01:33:15 +00:00
Sherry Huang
18d2704a0b SystemUI: overheat warning enhancements and bug fixes.
1) Add support of dynamically enabling/disabling overheat warning
   upon Settings change at runtime.
2) Rename related classes, methods, and variables to improve the
   readability.
3) Fix an issue where skin overheat warning fails to show when previous
   dismissal is triggered by intent ACTION_DISMISSED_TEMP_WARNING or
   ACTION_CLICKED_TEMP_WARNING.

Test: atest SystemUITests
Test: enable/disable overheat warning via adb command and trigger the
      warning with emulated temperature.

Bug: 126326427
Bug: 129043751
Change-Id: I844f75a042651bdd433715fedfc190b8fbff0fd4
2019-05-10 08:57:18 +08:00
Fabian Kozynski
31cf0ff5b7 Merge "Add BluetoothControllerImpl#onACLConnectionStateChanged" into qt-dev 2019-05-09 20:06:40 +00:00
TreeHugger Robot
d8f241214d Merge "Create notification channel interstitial shelf" into qt-dev 2019-05-09 19:52:41 +00:00
Lucas Dupin
0ba00953e0 Merge "Revert LockIcon click behavior" into qt-dev 2019-05-09 17:47:40 +00:00
Evan Laird
47dc4546ec Create notification channel interstitial shelf
From NotificationGuts, tapping "Turn off notifications" will now present
a half-shelf allowing the user to directly block up to 4 channels (the
one given from the notification guts + up to 3 other channels from
that app) or the app itself.

Test: visual (for now)
Bug: 130307442
Fixes: 131432719
Change-Id: I7e82928dfd56b9e25e5bef02607eede55b11d9e3
2019-05-09 11:13:19 -04:00
Joshua Tsuji
4accf598a9 Adds the new dismiss target, with fling/magnet to dismiss.
Test: atest SystemUITests
Bug: 123541855
Change-Id: Id2a149f8551eb58b240ece35569ca394c06e811d
2019-05-08 18:37:32 -04:00
Mark Renouf
d6cddfedf9 Merge "Updates BubbleData sorting and grouping to spec" into qt-dev 2019-05-08 16:58:20 +00:00
Mark Renouf
ba5ab51bc3 Updates BubbleData sorting and grouping to spec
This change adds onBubbleOrderChanged to BubbleStackView
to try to keep the order synchronized. There are some known
issues with the animation and visual state, which will be
addressed in a follow up CL.

Bug: 123542488
Test: BubbleControllerTest BubbleDataTest
Change-Id: Ie5a679df2f3069236f4d67a3fce4189b39b9eb28
2019-05-08 11:23:15 -04:00
Fabian Kozynski
7f27b8ee65 Add BluetoothControllerImpl#onACLConnectionStateChanged
In some cases, a BT device can change its ACL connection state without
going through proper disconnection and then BluetoothControllerImpl
would not be updated without this. Listening to this changes makes
BluetoothControllerImpl aware of more state changes in BT state.

In the BR, there is an ACL_DISCONNECTED right before the screenshots
time, that does not have a CONNECTION_STATE_CHANGED so this seems to be
the issue.

Also added DEBUG logs for the different state changes

Test: atest BluetoothControllerImpl
Bug: 130058055

Change-Id: I40449dba4fb30673fc21ce6b9955d66261776ea2
2019-05-08 10:40:58 -04:00
Ned Burns
31b02a613f Merge changes from topic "gentle-header" into qt-dev
* changes:
  Add "clear all" button to gentle notif section header
  Add "Gentle Notifications" header to gentle section
2019-05-07 21:13:31 +00:00
Lucas Dupin
d54f00e385 Revert LockIcon click behavior
Modifying StatusBar#showBouncer to collapse the shade is not always the right things to do.
It caused a regression where KeyguardSecurityView would be visible but KeyguardSecurityContainer
would never be initialized.
This is a partial revert of ag/7157531

Fixes: 131322107
Test: remove locked sim card, add locked sim card, swipe up
Change-Id: I5fe41b0426c2975c0b0ffdc30c0f5e8adb3b00bc
2019-05-07 09:28:55 -07:00
Ned Burns
9eb06333c4 Add "Gentle Notifications" header to gentle section
Missing "clear all" support, will add in later CL.

Test: manual

Bug: 131358199
Change-Id: I18aaacb1bf3f173b151bcac8df9dd953d0a7f513
2019-05-06 14:52:07 -04:00
TreeHugger Robot
0452dcf0b4 Merge "Update icon packs." into qt-dev 2019-05-06 17:47:51 +00:00
Mady Mellor
1a4e86fb33 Follow up for a comment from ag/7080956
Test: treehugger
Bug: 128459529
Change-Id: I79a559b3f992eae38bface74383a7a42d2261769
2019-05-04 02:25:25 +00:00
TreeHugger Robot
c3cfb0f702 Merge "Make sure to read the opportunistic carrier display property" into qt-dev 2019-05-04 00:27:22 +00:00
TreeHugger Robot
c47b4a8d2a Merge "Change FalsingManager to an interface for easier swapping." into qt-dev 2019-05-03 22:09:37 +00:00
Sooraj Sasindran
b7d633b4a6 Make sure to read the opportunistic carrier display property
Make sure to read the opportunistic carrier display property
Bug: 131849855
Test: verified that carrier text is displayed correctly

Change-Id: I93f9da8d0a9a8dae276370a0cca2df889229d4c3
2019-05-03 14:25:43 -07:00
Amin Shaikh
b7b4c25cad Update icon packs.
- Add back arrow for QS customizer
- Update work profile status bar / QS / corp badge icon to GM2
- Add Settings and Launcher overlay icons

Bug: 131346125
Test: visual
Change-Id: I61b56b04993ef19b5e66c9ad3d78eddcfce3aeb1
2019-05-03 14:29:54 -04:00
Mady Mellor
8496f4eeef Merge "Ensure the notification is removed when bubble is removed & fix cancel all" into qt-dev 2019-05-03 17:06:39 +00:00
Fabian Kozynski
e6395dd71a Fix race condition in TileServices
TileServices#getTileWrapper created a TileServiceManager (that triggered
the binding of TileService through a Handler) and after populated the
maps with the respective tokens. As one of the keys is the
TileServiceManager, this had to do after creating it.

This created the situation that in certain cases, the binding would
happen before all the maps were populated (in particular mTokenMap but
sometimes mServices).

By decoupling the binding triggering from TileServiceManager constructor
into a separate method in TileServiceManager we can guarantee that by
the time the service is bound, the maps are populated. Also added some
guards to make sure that this method has been called and the tile has
been added.

The new method is called after populating the maps, and it would not
make sense for the TileService to be bound if the maps are not
populated.

Test: atest TileServiceMaanger TileLifecycleManager TileServicesTest
Test: atest CtsAppTestCases:android.app.cts.TileServiceTest (approx 50
times)
Test: test TileServiceTest ActiveTileServiceTest
Test: Development tiles and adding Grayscale tile work perfectly
Fixes: 124735442
Fixes: 129684780
Fixes: 130796699

Change-Id: Ie3c7277756c74551ba2e6b3e88dad4a98aeafc96
2019-05-03 12:18:43 -04:00
Dave Mankoff
dde5ee6953 Change FalsingManager to an interface for easier swapping.
This is a refactor. It touches a lot of files, but zero functionality.
The primary change is changing FalsingManager.getInstance() into
FalsingManagerFactory.getInstance(); chaning FalsingManager into an
interface, and then turning the existing FalsingManager into
FalsingManagerImpl, an implementation of that interface. Other changes
are merely references to those classes.

Bug: 130256776
Test: atest SystemUITests
Change-Id: I5d64a7673e4efc554105dd841b27807361ed3828
2019-05-03 10:13:39 -04:00