Commit Graph

13449 Commits

Author SHA1 Message Date
TreeHugger Robot
d4deaec1a5 Merge "Add missing nullability annotations" 2019-11-05 23:58:53 +00:00
Chavi Weingarten
ffb4315a85 Merge "Added format to WindowlessWindowManager SurfaceControls" 2019-11-05 23:02:17 +00:00
Yinglei Wang
0cf1081834 Merge "Make getStateDescription() in View none final" 2019-11-05 21:20:01 +00:00
Taran Singh
90ebd2b809 Merge "Move startInput for WINDOW_FOCUS_GAIN to background thread" 2019-11-05 17:16:04 +00:00
TreeHugger Robot
60c4367006 Merge "Remove InputChannel::setToken" 2019-11-05 01:41:56 +00:00
John Reck
582f6bdcb0 Add missing nullability annotations
Bug: 123674035
Test: none
Change-Id: I5fa3a52f98a495b25c8aa01554ebba73ac89eb9f
2019-11-04 21:50:44 +00:00
chaviw
183aa5bc71 Added format to WindowlessWindowManager SurfaceControls
Currently, format is used to check for opaque but is not sent to
SurfaceFlinger to use when creating the SurfaceControl.

Test: format is set for WindowlessWindowManager
Bug: 134365580
Change-Id: Ia0707e49fa635313d3d54ca825173c71d2b17f14
2019-11-04 10:56:34 -08:00
TreeHugger Robot
f822d418e3 Merge "Add additional javadoc for listener parameter." 2019-11-04 16:27:33 +00:00
Siarhei Vishniakou
6742983aa8 Remove InputChannel::setToken
The token is now generated at the native level, inside InputTransport,
when you open an inputchannelpair. It is read-only.

Bug: 142581626
Test: presubmit
Change-Id: I67314f9854c2f720eb4fc2cb489755eae8863f8f
2019-11-01 18:27:42 -07:00
Evan Rosky
5998c1831f Merge "Add a remote control mechanism for window containers" 2019-11-02 00:26:59 +00:00
TreeHugger Robot
12eafbf173 Merge "Surface CONFIRM and REJECT vibration constants" 2019-11-01 14:26:35 +00:00
yingleiw
c9cb2e8307 Make getStateDescription() in View none final
Do not make getStateDescription final, since it can cause
compatibility issues with existing derived classes that define
a getStateDescription. Also replaced call to
getContentDescription() to mContentDescription. This is because
if a subclass overrides it, we don't want it to affect the value
used in accessibility service (cause divergence in accessibility
event and accessibilityNodeInfo).

Bug: 143652980
Test: no needed
Change-Id: I36c94c85eb258b3c9474090d841c925331d22d73
2019-10-31 12:38:03 -07:00
Paul Sowden
afe846d879 Add additional javadoc for listener parameter.
Test: make -j20 docs
Change-Id: I6f8c30014c63bc41609b9a683c2ddd5de48eb713
2019-10-31 11:01:56 -07:00
John Reck
be69644c78 Merge "Ensure SKP serialization occurs on RenderThread" into qt-qpr1-dev am: ab9d0b5103
am: 48145618d2

Change-Id: I8713f1ea467de5f7fdad7a27d41dfdfaab7e16c7
2019-10-31 10:57:41 -07:00
John Reck
48145618d2 Merge "Ensure SKP serialization occurs on RenderThread" into qt-qpr1-dev
am: ab9d0b5103

Change-Id: I7176a638d66e74ceb555e867dcea471c7ef6fe53
2019-10-31 10:50:38 -07:00
Tarandeep Singh
e0172102b9 Move startInput for WINDOW_FOCUS_GAIN to background thread
For a typical window with Editor, IMM#startInputOrWindowGainedFocus
is called twice: first for WINDOW_FOCUS_GAIN (dummyInput), then
CHECK_FOCUS when actual editor receives focus and startsInput.
The first once can be moved to background thread and second startInput
will wait till its finished.

Bug: 139806621
Test: Manually launch activities with editors and confirm no change in
behavior.

Change-Id: I6aa4a664cfd0c86f75cee2457715317194bbe5e2
2019-10-31 10:12:34 -07:00
Wale Ogunwale
ed38d4f967 Merge "Revert "Remove native calls to HWUI from Surface and use the public API instead"" 2019-10-30 13:33:31 +00:00
Derek Sollenberger
a320e92c56 Revert "Remove native calls to HWUI from Surface and use the public API instead"
This reverts commit 79201b16f1.

Reason for revert: breaks wm-presubmit

Change-Id: I3245e202f88b16d30b924e229cbc05fca37a3759
2019-10-30 13:17:41 +00:00
Derek Sollenberger
2db814af51 Merge "Remove native calls to HWUI from Surface and use the public API instead" 2019-10-30 03:11:06 +00:00
TreeHugger Robot
2bbe7de417 Merge "Remove StartInputFlags.FIRST_WINDOW_FOCUS_GAIN" 2019-10-29 23:51:56 +00:00
Evan Rosky
ddedfd46a9 Add a remote control mechanism for window containers
This adds a "IWindowContainer" interface which is an opaque
handle to a window-container in WM. It has very minimal
functionality and is intended to be used mostly as an
identifier.

Along with this handle, there is a WindowContainerTransaction
which can collect a set of container + configuration changess
and apply them all together. This will be used for remote
rotation control and other batched operations in the future.

Bug: 124011688
Test: Added some wm/core tests.
Change-Id: I691e7c11cd8c30f1a24fd64c6018a18933047847
2019-10-29 14:52:52 -07:00
TreeHugger Robot
bc056fcb73 Merge "Fix mistake in SurfaceView lifetime refactoring." 2019-10-29 18:04:53 +00:00
lumark
847a7d97e9 Remove StartInputFlags.FIRST_WINDOW_FOCUS_GAIN
Since this flag does not do any check during start input,
Remove this flag and the related parameter for IMM#onPostWindowFocus
to keep the logic simpler (included removing
ViewRootImpl#mHasHadWindowFocus).

This is refector CL and does not impact any behavior change.

Bug: 141738570
Test: Refector CL, make sure all existing test passed.
Change-Id: I9119f4846cbbd2b15246dea9a3b1fc5845dce951
2019-10-29 21:40:45 +08:00
Derek Sollenberger
79201b16f1 Remove native calls to HWUI from Surface and use the public API instead
Test: CtsGraphicsTestCases
Bug: 137655431
Change-Id: I1eda485282306d571ca973e179e7202958b59105
2019-10-25 16:25:39 -04:00
Robert Carr
de63cc6e8f Fix mistake in SurfaceView lifetime refactoring.
When moving the SurfaceControl lifetime to the render-thread
callback I also moved the Surface lifetime. There was no reason to
do this since the SurfaceView Surface isn't accessed from render-thread.
It introduces a small indeterminism in lifetime making a test fail, so we
revert it for cleanness.

Bug: 142011183
Test: Manual
Change-Id: I98a3daf21e7ed598d557046fc5b2e4cfebf1c845
2019-10-25 13:18:29 -07:00
Tarandeep Singh
95a3dbf03a Allow floating IME to apply final state.
Floating IME has zero insets and hence it becomes a special case where
Insets type to side map will have to be statically created per
form-factor. Realistically, IME side shouldn't change on any
form-factor.

Fix: 142713934
Test: Manually
     1. Enable floating mode in gboard.
     2. Tap on editor to verify gboard shows
     3. press back to verify gboard hides.

Change-Id: Ie2e2df3fdc5f637cf2efdf14bb5b74f45e3a929f
2019-10-24 21:20:40 +00:00
Jorim Jaggi
956ca413e3 Window Manager Flag Migration (4/n)
Wire up the appearance and the transient state of system bars between
WMS and System UI. The derived classes of CommandQueue.Callbacks no
longer listen to setSystemUiVisibility, but listen to showTransient,
abortTransient, and onSystemBarAppearanceChanged instead.

Bug: 118118435
Test: atest InsetsSourceProviderTest InsetsStateControllerTest
            InsetsPolicyTest WindowStateTests CommandQueueTest
            RegisterStatusBarResultTest InsetsFlagsTest
            LightBarControllerTest
Test: build on specific target
Change-Id: Ie35f4b4468bce7ef8c76f091e306610c069fba85
2019-10-19 16:59:06 +08:00
Alexey Kuzmin
31664f9093 Surface CONFIRM and REJECT vibration constants
Bug: 142971918
Test: manual
Change-Id: I5013dbbe4d5afb2f11de66ab31080f73179f0e72
2019-10-19 00:15:06 +01:00
TreeHugger Robot
542b2aac7b Merge "Add missing @NonNull" 2019-10-17 19:32:30 +00:00
John Reck
4a6f2c59c0 Add missing @NonNull
Test: builds
Bug: 142875299
Change-Id: I7a8d6edcc83175c48948de0295c312494141a147
2019-10-17 17:21:29 +00:00
Ioannis Ilkos
5a5678d244 Merge "Revert "Window Manager Flag Migration (4/n)"" 2019-10-17 09:49:58 +00:00
Ioannis Ilkos
8cca14103c Revert "Window Manager Flag Migration (4/n)"
This reverts commit cb1b848084.

Reason for revert: Droidcop-triggered revert due to b/142849532

Change-Id: If81eba4e979e21202e78839bb1afbc66691098d2
2019-10-17 09:38:00 +00:00
Jackal Guo
41c5b259e8 Merge "Allow restarting of crashed a11y services" 2019-10-17 06:21:10 +00:00
Jorim Jaggi
cb1b848084 Window Manager Flag Migration (4/n)
Wire up the appearance and the transient state of system bars between
WMS and System UI. The derived classes of CommandQueue.Callbacks no
longer listen to setSystemUiVisibility, but listen to showTransient,
abortTransient, and onSystemBarAppearanceChanged instead.

Bug: 118118435
Test: atest InsetsSourceProviderTest InsetsStateControllerTest
            InsetsPolicyTest WindowStateTests CommandQueueTest
            RegisterStatusBarResultTest InsetsFlagsTest
            LightBarControllerTest
Change-Id: I1dcaff47ae57ccee91146fdc042cde5e26fc0b3f
2019-10-17 01:41:34 +08:00
TreeHugger Robot
eb64817aad Merge changes I2915cdc9,Ide6ba9d8
* changes:
  Remove name from InputMonitor
  Simplify creation of NativeInputChannel
2019-10-16 06:02:56 +00:00
Jackal Guo
fbac83822e Allow restarting of crashed a11y services
After an accessibility service crashes a few times in a short period
of time, framework would add it into a “blacklist”. User wouldn’t be
able to use (re-enable) it. If users express an intent in them working
again, we remove the crashed accessibility service from the blacklist.

Bug: 129689483
Test: a11y CTS & unit tests
Test: manual
      1. Install and enable an intentional crashed a11y service.
      2. After it's crashed and malfunctioning, re-enable it.
      3. Check if it's bound again.

Change-Id: Ia89121f11bc5e05fc829e0e3ecb266150409678b
2019-10-16 10:15:30 +08:00
TreeHugger Robot
453033f64d Merge "Use different reorder modes for fail safe before and after Overview" 2019-10-16 01:30:38 +00:00
Siarhei Vishniakou
7480ae28e4 Remove name from InputMonitor
InputMonitor already contains an inputchannel. And inputchannel has a
name. Using the latest codegen tool, toString would already properly
print name because InputChannel has toString. So we don't need to
duplicate this field in InputMonitor.

Bug: 142581626
Test: presubmit
Change-Id: I2915cdc9928ab50991539593e584173e2231c16f
2019-10-15 17:27:21 -07:00
Tracy Zhou
9e0354f651 Use different reorder modes for fail safe before and after Overview
Currently, when recents animation is cancelled from fail safe mechanism,
we put the previous app back to the top. It no longer makes sense when
live tile is in the picture since we don't want the user to see the
previous app being brought up when they turn off and on the phone.

Fixes: 142088072
Test: Turn off and screen and back on. Make sure the user goes back to
home instead of previous app in live tile mode.

Change-Id: I5f16c4c8c77b918dc706c45acadf143edc454de9
2019-10-15 13:39:17 -07:00
TreeHugger Robot
ec214fe895 Merge "Improving hierarchy dump speed" 2019-10-15 10:25:37 +00:00
Roshan Pius
20bce169a5 Merge "Window: Mark SHOW_FOR_ALL_USERS flag as @SystemApi" 2019-10-14 18:03:23 +00:00
TreeHugger Robot
d6fd6f27f5 Merge changes from topic "b/142461756"
* changes:
  Ime target window should control when to hide IME (2/2)
  Ime target window should control when to hide IME (1/2)
2019-10-14 17:04:57 +00:00
Taran Singh
d7fc5864f4 Ime target window should control when to hide IME (2/2)
This followup CL implements hideInsets() introduced in 1/2.

Bug: 142461756
Bug: 111084606
Test: Manually tested using steps below:
  1. Make sure new insets flag is enabled
  2. Launch any activity which has child window with NOT_FOCUSABLE,
     ALT_FOCUSABLE_IM (e.g. Instagram login screen)
  3. Verify IME can be shown and hidden by this window.

Change-Id: I307594014eca8a06397c739ffbc9c12eac160fdc
2019-10-14 12:40:09 +00:00
Roshan Pius
a3f89c6882 Window: Mark SHOW_FOR_ALL_USERS flag as @SystemApi
Bug: 142090228
Test: Compiles
Change-Id: I850c7759dc909727f73e40fb6331871a9de25f20
2019-10-12 08:32:44 -07:00
Sunny Goyal
7a889e14a3 Improving hierarchy dump speed
> Moving the dump to UI thread instead of making every method call individually to UI thread

Test: Launcher view hierarchy dump changed from ~4.5 seconds to 260ms

Change-Id: I3a815755bc63fdd7a729aae46339dd3c55f09cd4
2019-10-11 15:14:35 -07:00
TreeHugger Robot
963754df14 Merge "Replace client token with a new token in InputWindowHandle" 2019-10-11 15:32:19 +00:00
Issei Suzuki
b4b372550e Merge "Removed dead code around TRANSIT_TASK_IN_PLACE" 2019-10-11 12:16:41 +00:00
Taran Singh
f1e0887eb8 Ime target window should control when to hide IME (1/2)
Input method frameworks uses focused window and some tricks
to best guestimate IME target. Though it doesn't always know the
actual IME target. e.g. when window has both NOT_FOCUSABLE,
ALT_FOCUSABLE_IM; IMF thinks focued window is IME target but it isn't
the case.

The right thing to do is to call both show(IME), hide(IME) on IME
target.

Bug: 142461756
Bug: 111084606
Test: Manually tested using steps below:
  1. Make sure new insets flag is enabled
  2. Launch any activity which has child window with NOT_FOCUSABLE,
     ALT_FOCUSABLE_IM (e.g. Instagram login screen)
  3. Verify IME can be shown and hidden by this window.

Change-Id: I13f3e04f6f9e1574db9cbb56bdb7817152499d03
2019-10-11 10:09:06 +02:00
Ember Rose
4ac4411300 Merge "Update Ember's email" am: 0e6683ef7e am: bf7239e2fb
am: 159091ed3f

Change-Id: I1038c7e807080205a38e725d02bef069a6d8e2c2
2019-10-10 22:01:37 -07:00
Ember Rose
159091ed3f Merge "Update Ember's email" am: 0e6683ef7e
am: bf7239e2fb

Change-Id: I394749d83ceac0e1373aa83f5f85ccf9cb29483b
2019-10-10 21:46:22 -07:00