Commit Graph

632 Commits

Author SHA1 Message Date
TreeHugger Robot
1cbfe74fc2 Merge "AOD: Fix navbar flicker when transitioning to AOD" into oc-dr1-dev 2017-08-11 23:43:11 +00:00
Adrian Roos
8db9311cb6 AOD: Fix navbar flicker when transitioning to AOD
Under certain circumstances, the transition to AOD can happen before
the navigation bar gets a chance to hide itself, which happens in a
traversal. To work around this, post turning the screen on such that
it only happens after the next traversal.

Change-Id: I178b9394e7cc6baa8e9552c9819c3ce9b044defb
Fixes: 64599221
Test: Open Whatsapp / Gmail, turn off screen, verify navbar does not flicker.
2017-08-11 14:29:35 -07:00
Jason Monk
d819c31050 Change default temp threshold to use shutdown temp
Base the temp threshold to be based on the shutdown temp lowered
by some amount to ensure the warning can be seen before a shutdown.

Test: runtest systemui
Change-Id: I033a776e874d76018592954932ed5127e1b228ae
Fixes: 62845934
2017-08-11 14:44:51 -04:00
TreeHugger Robot
a083c8f83a Merge "Make NearestTouchFrameTest run on more device configurations" into oc-dr1-dev 2017-08-04 17:26:55 +00:00
Jason Monk
e57e9dcadf Make NearestTouchFrameTest run on more device configurations
Test: runtest systemui
Change-Id: Ied095c1e884d1ca95531e2f4e182f1d1bcaaeb35
Fixes: 64339927
2017-08-04 10:59:13 -04:00
Adrian Roos
6583c37a1b Merge "AsyncSensorManager: Fix unregistration bug" into oc-dr1-dev 2017-08-04 13:59:33 +00:00
Adrian Roos
47aac56746 Merge changes I901908d9,Iac9835ad into oc-dr1-dev
* changes:
  AOD: Fix RemoteInput from dozing
  AOD: Fix janky launch transition from AOD2
2017-08-04 13:20:02 +00:00
Adrian Roos
b1f77247c2 AsyncSensorManager: Fix unregistration bug
Fixes an issue where unregistering a listener without specifying a sensor did
not work correctly; when passing null as the sensor, SensorManager.unregisterListener
silently ignores the call; instead, we now call the proper variant if given a null
sensor.

Change-Id: Iac362d8d6ae966308578cb4f177bd37af10b81a2
Fixes: 64357270
Test: runtest -x $T/frameworks/base/packages/SystemUI/tests/src/com/android/systemui/util/AsyncSensorManagerTest.java
2017-08-04 13:17:44 +02:00
Adrian Roos
6d5ebb7b70 AOD: Fix janky launch transition from AOD2
Fixes the transition that happens when when a notification is launched
from AOD2 and the keyguard can be unlocked without going through the
bouncer.

Change-Id: Iac9835ade42be4ecf02ee7430cf76d05fc006361
Fixes: 64164248
Test: Disable lockscreen security, turn off phone, receive SMS, double tap; verify no jank
2017-08-04 11:45:58 +02:00
Adrian Roos
c8e29e7886 AOD: Add support for dimming in software
Some devices cannot dim low enough in hardware in low power states.
To work around that, keep the front scrim at higher opacity when needed
to simulate lower brightness.

Bug: 63995944
Test: Configure scrim in config.xml; use device in very dim light at night, observe AOD is sufficiently dim.
Change-Id: I92fffedeea89b9327d76dfb184c5c761364ead11
2017-08-03 20:14:31 +02:00
TreeHugger Robot
6407874ae0 Merge "Added null test to avoid regression for onRemoteVolumeChanged." into oc-dr1-dev 2017-08-02 18:22:03 +00:00
Beverly
4e9366183f Added null test to avoid regression for onRemoteVolumeChanged.
Change-Id: Iebcf30a381250c06055143528914632a00e474bc
Fixes: 63946353
Test: runtest systemui
2017-08-02 13:53:58 +00:00
Jason Monk
9262c942b5 Make it easier to click on phone nav buttons
When touches fall through the normal click targets, redirect them
to the nearest view.

Test: runtest systemui
Change-Id: I48267d9b1e15bf8dbe8725b72326751b03196efa
Fixes: 64080938
2017-08-01 12:29:59 -04:00
Adrian Roos
a6c03f8d27 AOD: When prox covered disable touch during pulse instead of aborting
Fixes a UX issue where covering the prox would abort dozing. This
was done to prevent falsing and save power, but in practice results
in a frustrating experience when the proximity sensor is covered
transiently when reaching for the device.

Instead, just ignore touch while the sensor is covered.

Change-Id: Id70f8605c6c7a37288a383d587025bb9b4191b42
Fixes: 64007762
Test: Trigger AOD2, cover sensor. Verify phone stays on but double tap does nothing.
2017-07-28 14:09:52 +02:00
TreeHugger Robot
382644aa74 Merge "Volume dialog doesn't show on ambient/aod." into oc-dr1-dev 2017-07-26 15:34:32 +00:00
TreeHugger Robot
a1f64b0a91 Merge "Fix jank when switching themes" into oc-dr1-dev 2017-07-25 17:40:02 +00:00
Adrian Roos
55bc522d0d Merge "Keyguard: Remove fancy colon" into oc-dr1-dev 2017-07-25 11:45:43 +00:00
Lucas Dupin
e17ce5286f Fix jank when switching themes
Turning overlays on and off takes time,
it also doesn't allow us to have fine control
over which view is using which theme.
Lock screen colors are now driven by themes.

Change-Id: Ie8860d00dbb0705ed76edf60a9d3030618dd21ca
Fixes: 63751714
Test: Visual. Set wallpapers, unlock.
Test: runtest -x packages/SystemUI/tests/src/com/android/keyguard/KeyguardSecurityContainerTest.java
Test: runtest -x tests/Internal/src/com/android/internal/colorextraction/ColorExtractorTest.java
Test: systrace
2017-07-24 13:26:22 -07:00
Adrian Roos
b670f4b2d1 Keyguard: Remove fancy colon
The new fonts do not have a dedicated fancy colon for the lockscreen clock
and fall back to Roboto which breaks the kerning.

Change-Id: I4621c6248de3f42f6c3c49ee4149bc1c0bb233e6
Fixes: 63891134
Test: visual; runtest -x packages/SystemUI/tests/src/com/android/keyguard/KeyguardClockAccessibilityDelegateTest.java
2017-07-24 14:46:27 +00:00
Christine Franks
509711105d Don't display QS security footer in demo mode
Bug: 63843869
Test: runtest systemui
Change-Id: I50e408749262b33644c5c007cd1f78138e1d5c3b
2017-07-21 20:56:18 +00:00
Beverly
85e05eb545 Volume dialog doesn't show on ambient/aod.
Fixes: 62598406

Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/volume/VolumeDialogControllerImplTest.java
Change-Id: Ibb2e1119f0c6d96e9016ebe8fdd9d03b6a3c71b8
2017-07-21 16:15:14 -04:00
Adrian Roos
e4cb6c8a31 Flicker free screen-on from AOD
When pulsing from AOD, we force the display OFF first. This allows
us to transition smoothly from AOD.

Also, we add a scrim transition for whenever we are waking up from
dozing. This relies on I4f3a863709a970f0fc8682c0a0c3547886e1fd0f
which forces the DOZE -> ON transition through OFF first.

Also fixes the WAKE_AND_UNLOCK transition that happens when waking
up with the fingerprint sensor.

Also fix an issue where KeyguardViewMediator's mWakeAndUnlocking
was cleared in onScreenTurnedOff; this should have been added to
the wakefulness lifecycle instead and now that the AOD -> ON transtion
dispatches the screen off callback it broke the fingerprint unlock
transition.

Fixes: 35849781
Fixes: 63887857
Fixes: 63783651
Fixes: 63727166
Test: AOD, receive notification; AOD, unlock with fingerprint; AOD, wake to lockscreen. Verify that everything is flicker-free.
Change-Id: I7d539db80a1c7e9216cf4c5c1e6d314c1893f12d
2017-07-21 11:20:26 +02:00
Adrian Roos
d3878b5e12 Merge "Keyguard: Factor out Screen and Wakefulness lifecycles" into oc-dr1-dev 2017-07-20 11:22:39 +00:00
Philip Quinn
c3a503d8fd Ping the StatusBar about power key events.
Bug: 63183852
Test: runtest systemui

Change-Id: I5d8209396e3e761b404c1071a7004f34c6e6c927
2017-07-20 03:51:51 +00:00
Philip Quinn
1659b400b5 Expose KeyguardMonitor.isOccluded().
Bug: 63806767
Test: runtest systemui

Change-Id: I36b96974c7a27e31ddbc3e8cdddf2516cce87b21
2017-07-20 01:27:26 +00:00
Adrian Roos
369907f02e Keyguard: Factor out Screen and Wakefulness lifecycles
Test: runtest systemui
Bug: 62446740
Change-Id: Ife34c1f4299b152a6352445adc8c9fc3c757e87c
2017-07-19 18:26:51 +02:00
TreeHugger Robot
dc7b2bc5e3 Merge ""Block notifications screen off" setting is used" into oc-dr1-dev 2017-07-19 15:21:32 +00:00
Beverly
38159cee76 "Block notifications screen off" setting is used
Fixes: 63520128

Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarTest.java

Change-Id: Ib0f737999aac9fc944812fb90644a5be5c801da2
(cherry picked from commit 6cfa71486e)
2017-07-17 13:55:01 +00:00
Beverly
8ebef8494e Added check for AOD before showing volume dialog.
Fixes: 62598406

Test: runtest systemui

Change-Id: I407eed0e0559ef0bc61d36ad9c5e84c6924c161e
2017-07-17 13:17:52 +00:00
TreeHugger Robot
e1036c93a0 Merge "Take a wrench to the pipes" into oc-dr1-dev 2017-07-14 21:33:51 +00:00
TreeHugger Robot
8d5b831095 Merge "Move palette constants to XML" into oc-dr1-dev 2017-07-14 20:24:37 +00:00
Lucas Dupin
6e69c85ddc Move palette constants to XML
Test: runtest -x tests/Internal/src/com/android/internal/colorextraction/types/TonalTest.java
Change-Id: I22a5ef9b89c113f75261e8884fa1affb07b2265f
Fixes: 62373429
2017-07-14 09:35:05 -07:00
TreeHugger Robot
930297e040 Merge "AOD: Refactor low and high brightness modes" into oc-dr1-dev 2017-07-14 15:49:57 +00:00
Jason Monk
3b9357f3b9 Take a wrench to the pipes
- Track extensions in garbage tracking because they could be big
 - Fix volume dialog cleanup to not leak
 - Fix QSFragment cleanup to not leak
 - Make DockedStackExistsListener static because it is going to leak
   because /Binder/
 - Add a secure setting to force on notifications for garbage monitoring
   for those that really really want it.

Test: adb shell dumpsys activity service SystemUI | grep -A 12 LEAK
Change-Id: Id5689febd65eb8a22dbb4a0a15ec051fcdbbf8be
Fixes: 38461559
2017-07-14 09:47:58 -04:00
Adrian Roos
3a8f892bd8 AOD: Refactor low and high brightness modes
Bug: 63427319
Test: Receive notification on AOD, observe that brightness does not change.
Change-Id: I6ab6d75121f51ac16c08e59a3e552808a8e70853
2017-07-14 13:02:16 +00:00
TreeHugger Robot
31ff02ecd2 Merge "Fix qs tile drawing in edit QS panel" into oc-dr1-dev 2017-07-13 18:39:39 +00:00
Lucas Dupin
717dd58c52 Merge "In-app gradient color based on systemui theme." into oc-dr1-dev 2017-07-13 17:03:47 +00:00
Evan Laird
929bd54c6a Fix qs tile drawing in edit QS panel
The problem here was reuse:

1. Tile has a SlashState -> gets SlashDrawable
2. Reused tile has no SlashState -> doesn't know how to gracefully
remove the slash and draw regularly, so it gets a slash anyway.

Unrelated, but also fixed: turn off slash animations in QS edit panel

Fixes: 63160044
Test: runtest -x
frameworks/base/packages/SystemUI/tests/src/com/android/systemui/qs/SlashImageViewTest.java

Change-Id: I6841bfafcef0588d1ca63b3326dfee1a856618f3
2017-07-12 16:43:59 -04:00
Lucas Dupin
c77b71d7f0 In-app gradient color based on systemui theme.
When viewing your scrim on top of an app (wallpaper not visible),
the gradient color should be dark if your wallpaper is dark and
light if your wallpaper is light.

Change-Id: I5f3aea5bf9ec066b7caecd7cadfd2814e3758bd1
Fixes: 63121129
Bug: 63365056
Test: runtest -x tests/Internal/src/com/android/internal/colorextraction/types/TonalTest.java
Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/colorextraction/SysuiColorExtractorTests.java
2017-07-12 10:40:23 -07:00
Geoffrey Pitsch
ba918dbf0c Move @Ignore from class-level to test level.
Workaround for reporting error.

Test: runtest systemui
Bug: 63521982
Change-Id: I81e70605471469b0ffa630ff874427a621fc1135
2017-07-12 11:40:32 -04:00
Jason Monk
b05395f53c Try to work on test flakyness.
- Add bt permission
 - mock more BT stuff
 - Disable test that is causing crash on main thread

Test: runtest systemui
Change-Id: I5cddb71941cce4f9b595c65ef69919186addb6df
Fixes: 63568935
2017-07-11 10:05:03 -04:00
TreeHugger Robot
456cb9603a Merge "Moving color extraction classes" into oc-dr1-dev 2017-07-08 00:21:44 +00:00
TreeHugger Robot
eacef7a03a Merge "AOD: Block when fingerprint is already authenticated but waiting for goingToSleep to complete" into oc-dr1-dev 2017-07-07 19:07:32 +00:00
Lucas Dupin
e2292a94bb Moving color extraction classes
Fixes: 62220212
Test: make
Test: runtest -x tests/Internal/src/com/android/internal/colorextraction/ColorExtractorTest.java
Test: runtest -x tests/Internal/src/com/android/internal/colorextraction/types/TonalTest.java
Test: runtest systemui
Change-Id: I7c4cf5c40a88555e81fbad9bec2b32c55c927468
Merged-In: I7c4cf5c40a88555e81fbad9bec2b32c55c927468
2017-07-07 10:48:43 -07:00
Adrian Roos
710a0b1362 AOD: Block when fingerprint is already authenticated but waiting for goingToSleep to complete
Improves an issue where immediately triggering fingerprint after
the devices goes to sleep results in a lot of flickering.

There's still flicker however if the fingerprint authenticates after we've requested the AOD
display state, but before it has actually been applied.

Bug: 62887179
Test: Go to Home. Lock screen. Immediately unlock via fingerprint. Verify that the AOD screen does not even show.
Change-Id: Ib6425eee803a8c7e02f9621a571e562e825af57f
2017-07-07 19:02:36 +02:00
Adrian Roos
3e23eb59d0 AOD: Keep doze brightness when unlocking with fingerprint
Updates the logic that was already in place to prevent lighting up
the display before the unlock transition starts:
- treat AOD as pulsing in FingerprintUnlockController
- now that doze can use more than one brightness level, use the current

Bug: 62885451
Test: Unlock with fingerprint from AOD. Observe that the unlock transition does not prematurely change the brightness level
Change-Id: I266bd5e4c0a1d5b4c347a65c0e7936247e333cfc
2017-07-07 16:07:38 +02:00
TreeHugger Robot
c424b22979 Merge "Fix crash when no StatusBarView" into oc-dr1-dev 2017-07-06 21:38:06 +00:00
TreeHugger Robot
20b9b73e80 Merge "Fix leak in ScrimView" into oc-dr1-dev 2017-07-06 21:29:57 +00:00
Jason Monk
5ecf80ceb8 Fix crash when no StatusBarView
Test: runtest systemui
Change-Id: Ia0a4a97f554e0b9d6e41c295e8e07d278f8ad248
Fixes: 63260821
2017-07-06 15:28:17 -04:00
TreeHugger Robot
21fe942d88 Merge "Disable test in presubmit" into oc-dr1-dev 2017-07-06 19:19:06 +00:00