Commit Graph

7144 Commits

Author SHA1 Message Date
Kirill Grouchnikov
b07544cf69 Merge "Tweak initialization order of LinearLayout's dividers" into oc-dev 2017-04-28 13:56:28 +00:00
Svetoslav Ganov
70c0221813 Merge "Implement the rest of autofill importance modes" into oc-dev 2017-04-28 06:30:07 +00:00
Svetoslav Ganov
64cf2bb19b Merge "Force autofill on overflow only if empty" into oc-dev 2017-04-28 06:29:25 +00:00
Svet Ganov
fd31f85d0c Implement the rest of autofill importance modes
Test: CTS tests pass; augmented tests to verify new behavior

bug:36171235

Change-Id: Ieff2b8d7e1c3a3eba456deca7bed70c8e29c415e
2017-04-27 18:16:08 -07:00
Evan Rosky
d0c6cf9bc0 Merge "Only restrict arrows out of text fields from keyboard" into oc-dev 2017-04-27 21:28:13 +00:00
Svet Ganov
54523413f8 Force autofill on overflow only if empty
Test: manual

bug:37244196

Change-Id: I0953546492ade815617d30f698e92282a1172302
2017-04-27 12:32:08 -07:00
TreeHugger Robot
e6746726bc Merge "Revise method comment on setFontVariationSettings" into oc-dev 2017-04-27 17:34:48 +00:00
TreeHugger Robot
cc7f08e997 Merge "docs: Update EditText JavaDoc comments" into oc-dev 2017-04-27 05:24:51 +00:00
TreeHugger Robot
1e5d0768cd Merge "docs: Update Button JavaDoc comments" into oc-dev 2017-04-27 05:21:23 +00:00
TreeHugger Robot
47ca22e361 Merge "docs: Update ScrollView JavaDoc comments" into oc-dev 2017-04-27 04:29:14 +00:00
TreeHugger Robot
b312d38868 Merge "docs: Update RelativeLayout.LayoutParams JavaDoc comments" into oc-dev 2017-04-27 04:28:36 +00:00
TreeHugger Robot
01d51288df Merge "Handle package changes in autofill manager service" into oc-dev 2017-04-27 04:22:24 +00:00
TreeHugger Robot
ca105f6c29 Merge "docs: Update LinearLayout JavaDoc comments" into oc-dev 2017-04-27 04:21:15 +00:00
TreeHugger Robot
80fe019f6b Merge "docs: Update ProgressBar JavaDoc comments" into oc-dev 2017-04-27 04:12:48 +00:00
Svet Ganov
48f10a2ab5 Handle package changes in autofill manager service
Autofill manager service was not observing package changes thus
we did not properly handle the cases of the service being updated,
added, and removed. Handling, additions is needed to properly
support restore from a backup. Fixed a few missing locks.

Test: all autofill CTS tests pass and manually tested update, add,
      and remove of autofill services.

bug:36638606
bug:36978445

Change-Id: Idd47891774ba2a4e562a1952cbb5a048211fd4e3
2017-04-26 19:22:05 -07:00
Kirill Grouchnikov
3218a4e4f5 Tweak initialization order of LinearLayout's dividers
In ag/969570 we've unified the treatment of divider logic
in LinearLayout. However, setDividerDrawable logic that was
calling setWillNotDraw added condition that the divider
position is not NONE. That made the initial flow effectively
not calling setWillNotDraw(false).

Changing the order to call setDividerDrawable() at the end
invokes the right logic.

Test:  adb shell am instrument -e class 'android.widget.cts.LinearLayoutTest'  -w 'android.widget.cts/android.support.test.runner.AndroidJUnitRunner'
Bug: 37698004
Change-Id: I8d95770b9f48277c402708fbc5279ba2ec56719f
2017-04-26 17:45:28 -04:00
Felipe Leme
5f7979222d Merge "Provide a way to set AutofillId on ViewStructure." into oc-dev 2017-04-26 18:38:21 +00:00
Joe Fernandez
1ef22a5a65 docs: Update ScrollView JavaDoc comments
- reworded introduction for clarity
- crosslink to nestedscrollview
- simplify language around the “don’ts”
- crosslink to the material design guidelines for scrolling techniques

Test: docs only change. Tested with doc build
Change-Id: Ia6d1e5ce0f9abd3db2c1988537bd42013851596f
2017-04-26 00:23:49 -07:00
Joe Fernandez
d9ffaa5eb8 docs: Update LinearLayout JavaDoc comments
Updated top-level description to:

- favor explanations of using XML for setting attributes (instead of using
methods like setGravity()
- add code example
- clarify what "child view" means
- add context around cross-link to layout params
- add context around cross-link Linear Layout guide (this guide focuses on
layout_weight)

Test: docs change only. Tested with doc build
Change-Id: Ifc1fa4cf24e2afa229f1c20b3f725073aff162d7
2017-04-25 23:39:17 -07:00
Joe Fernandez
72a9d591f0 docs: Update ProgressBar JavaDoc comments
- link to material design guidelines for a visual example of
determinate/indeterminate patterns
- reword introduction for clarity
- remove confusing code example, in favor of a concise explanation of
determinate/indeterminate uses
- adds a note about not using progress bar in a dialog

Test: docs change only. Tested with a docs build
Change-Id: I872f7a647eafa6d0f1652549ad2d9d2db4fc81e3
2017-04-25 23:14:09 -07:00
Joe Fernandez
a1bd1712d5 docs: Update RelativeLayout.LayoutParams JavaDoc comments
Added changes to make purpose/usage of RelativeLayout.LayoutParams more
clear:

- clarify the attributes are set on a view contained in a relative layout
- clarify that relative layout uses these values to position the view
- add note that these values are ignored if view is not contained in a
relative layout
- cross-link code sample in Relative Layout guide
- cross-link guide Layout guide to clarify layout params vs regular
attributes

Test: docs change only. Tested with a docs test build.
Change-Id: I4fe1088594c998cee4ff0b2f6295579956c19d6f
2017-04-25 22:38:45 -07:00
Joe Fernandez
38ed689d95 docs: Update EditText JavaDoc comments
rework the edit text introduction and overview.

- adds an example of a basic configuration
- discuss the inputType attribute
- cross link to relevant classes & methods
- Rework the edit text introduction and overview
- wrap guide link in a p to emphasize
- emphasize specifying the inputType is required

Test: docs only change. Verified with doc test build
Change-Id: I78d8c861c51117bfd61e8c37ad83854a2aeec967
2017-04-25 22:06:48 -07:00
Joe Fernandez
bc6c82c20d Merge "docs: Update ListView JavaDoc comments" into oc-dev 2017-04-26 04:56:11 +00:00
Joe Fernandez
0de19fcf6a Merge "docs: Update ArrayAdapter JavaDoc comments" into oc-dev 2017-04-26 04:55:38 +00:00
Felipe Leme
e4f30650ac Provide a way to set AutofillId on ViewStructure.
So far that was done indirectly by public methods that could
be overridden in away that does not set the proper id in the structure,
which would crash apps.

Bug: 36171235
Test: modified VirtualContainerActivityTest#testAutofillOverrideDispatchprovideAutofillStructure

Change-Id: I3f1c64020125cbb8349971a0bc52ccd1e0c81e62
2017-04-25 14:12:03 -07:00
Joe Fernandez
8e342c7b75 docs: Update Button JavaDoc comments
- Simplify first-line description
- Update top-level code sample
- Add caveat about onClick running on main thread
- Simplify button style discussion
- Add distinct See Also section
- Convert future tense to present tense
- Add closing paragraph tags
- Remove references to push-button
- Clean up code introduction sentence
- Use present tense
- Connect reasoning to user experience
- Format threading information as aside
- Change future tense to present tense
- Add transition statement
- Use active language in parameter description
- Use cannot instead of can not
- Use common parlance name for button
- Clean up parameter descriptions

Test: Docs change only. Tested with a doc build run.

Change-Id: Ie0cd25ed4f8372ba5ec58bdf8b7dfce9100ee3fc
2017-04-25 11:55:26 -07:00
Joe Fernandez
a3aa879166 docs: Update ListView JavaDoc comments
- Use more active and descriptive terms in first-line description
 - Recommend using RecyclerView
 - Add XML example code
 - Direct reader to set an adapter to populate list with views
 - Add pre tags to XML code snippet
 - Give example of displaying more complex views in list
 - Add aside about using convertView if provided
 - Link to guide on handling click events
 - Add cross-link to contextual action mode guide
 - Reframe link to list view guide
 - Advise reader to favor alternative approach to using ListActivity
 - Add paragraph tags
 - Escape @ symbol
 - Fix sentence fragment and change modern -> advanced
 - Fix title of cross-reference to layout guide
 - Remove reference to filename
 - Remove cross-link to contextual action mode
 - Fix malformed link tag
 - Add connecting word
 - Clean up links

Test: Docs change only. Tested with docs build.

Change-Id: Ideb5cc517a7bc08056bb2fe8025c7acea388128b
2017-04-25 11:51:17 -07:00
Adrian Roos
4554332475 Merge "Perf: Fix RemoteViews memory leak" into oc-dev 2017-04-25 17:09:24 +00:00
Adrian Roos
83fad0a35c Perf: Fix RemoteViews memory leak
Fixes an issue where the context wrapper created in
RemoteViews leaks the RemoteViews instance through the
implicit this pointer of anonymous inner classes.

Fixed by replacing with a static inner class.

Bug: 37630958
Test: m droid (this change is not testable)
Change-Id: Ia149b3d91f134f0c308200b46880e7f87542a338
2017-04-24 17:00:27 -07:00
Felipe Leme
85d1c2d290 Minor fixes on Autofill Framework:
- Removed default implementation of onProvideAutofillVirtualStructure() that
  was using accessibility API (it's useless because without the View calling
  AutofillManager.notifyViewEntered(), it would never be triggered).
- Fixed obsolete TODOs.
- Removed obsolete service class name constant.
- Removed unused debug constant.

Fixes: 37078783
Fixes: 33197203
Bug: 33802548
Bug: 35956626

Test: CtsAutoFillServiceTestCases pass
Merged-In: I834d34b8af8bf0d781dc7e0ffcd6e600bfa2d183
Change-Id: I834d34b8af8bf0d781dc7e0ffcd6e600bfa2d183
2017-04-24 16:01:12 -07:00
Joe Fernandez
d7ef95af60 docs: Update ArrayAdapter JavaDoc comments
update the introduction to:

- streamline wording by focusing on practical uses in introduction
- include crosslinks to relevant guides & examples
- a note about RecyclerView given it is mentioned in this context
- favor a p element with a note class applied
- incorporate reword via joe’s input on connecting topics

Test: Docs change only. Tested with doc build run.
Change-Id: I66511db5a978bff4e46d3d6080b00c2b7e6dfa64
2017-04-24 13:50:13 -07:00
TreeHugger Robot
31eeb08bdb Merge "Introduce TextView attribute for control justification." into oc-dev 2017-04-21 21:31:20 +00:00
Seigo Nonaka
4cbb441425 Introduce TextView attribute for control justification.
Bug: 37447278
Test: am instrument -w -e class android.widget.cts.TextViewTest
      android.widget.cts/android.support.test.runner.AndroidJUnitRunner
Change-Id: I7946f460ad8a6c2423b464c27225411d155d4d8d
2017-04-21 21:17:58 +00:00
TreeHugger Robot
62a24e9493 Merge "docs: Update Imageview JavaDoc comments" into oc-dev 2017-04-21 18:36:51 +00:00
TreeHugger Robot
28973b3817 Merge "docs: Update TextView JavaDoc comments" into oc-dev 2017-04-21 18:34:14 +00:00
TreeHugger Robot
6a60322157 Merge "Fix a11y text location in clipped views" into oc-dev 2017-04-21 01:11:12 +00:00
TreeHugger Robot
82629345c8 Merge "Renaming setAsyncExecutor to setExecutor" into oc-dev 2017-04-21 00:31:11 +00:00
Sunny Goyal
0ddf6aa0a4 Renaming setAsyncExecutor to setExecutor
Bug: 37534990
Test: Tests updated
Change-Id: I9ea467d05b4ac4d96c23d53750727096a511686d
2017-04-20 15:27:08 -07:00
Evan Rosky
53cfed57c9 Only restrict arrows out of text fields from keyboard
Otherwise, TV remotes and gamepads will get stuck in text
fields since they lack TAB key.

Started with revert of commit d4cef42ba1.

Bug: 37502292
Test: Added a CTS. Manually tested with BT keyboard (Pixel C) and
      BT gamepad.
Change-Id: Iff7e0bf714605555d4fb49d3e5e2680117b3af5b
2017-04-20 15:18:01 -07:00
Phil Weaver
cdc74590c3 Fix a11y text location in clipped views
Bug: 37482849
Test: Run Select to Speak, open apps, scroll so top row is
partially visible, have it read the screen.

Change-Id: Ibbd51221f8e93372ccff6d5fb57cdc2a09f2c19f
2017-04-20 12:11:15 -07:00
TreeHugger Robot
f4af35a5fe Merge "Moved getAutofillOptions() logic from SpinnerAbs to AdapterView and Adapter." into oc-dev 2017-04-20 17:25:19 +00:00
Andrei Stingaceanu
635d9dd864 Merge "AutoSize TextView - API polish - no RuntimeException in signature" into oc-dev 2017-04-20 13:14:06 +00:00
Abodunrinwa Toki
fa9d889d3e Merge "TRON: Log "textAssist" actions." into oc-dev 2017-04-20 13:08:52 +00:00
Andrei Stingaceanu
1b59a21c5c AutoSize TextView - API polish - no RuntimeException in signature
Do not mention RuntimeException subclasses in throws clauses in
method signatures.

Bug: 37514926
Test: cts-tradefed run cts-dev -m CtsWidgetTestCases -t \
      android.widget.cts.TextViewTest

Change-Id: Ia5bf4cd64e12c53dd7c409b6e44efec4983ae62e
2017-04-20 12:09:11 +01:00
TreeHugger Robot
4f3ba1aeed Merge "Move expensive TextClock operations to onAttach" into oc-dev 2017-04-20 00:26:52 +00:00
Abodunrinwa Toki
54486c16ba TRON: Log "textAssist" actions.
- Logs when the assist menu item appears in the text selection menu.
- Logs when the assist menu item is selected.
- Logs the the type of the assist menu item that was presented.

Test: Manually tested by looking at the logs. See: go/tron-howto
Bug: 32572232
Change-Id: Ibbbf59423b3f510ab6f2f072962a556c3d6e2f65
2017-04-19 22:10:51 +01:00
Felipe Leme
7e4c205d8f Moved getAutofillOptions() logic from SpinnerAbs to AdapterView and Adapter.
Fixes: 37330022
Test: CtsAutoFillServiceTestCases pass
Test: manual verification using app from bug 37327881

Change-Id: I66260131c7ef0d5b3c2b20514f29efd5eb10057e
2017-04-18 15:36:04 -07:00
Ian Lake
851957cbf9 Move expensive TextClock operations to onAttach
Registering and unregistering are expensive operations
that should not be done when the visibility of the
TextClock changes. However, we want to ensure that a
non-visible TextClock does not consume extra resources
or cause layout/redraw passes. By keeping the TextClock
registered but avoiding the side effects of onTimeChanged,
we can get the best of both worlds.

Test: manual testing

BUG: 33960344
Change-Id: I80771524a09ca57488834bafd97b570f2a8235db
2017-04-18 15:33:38 -07:00
Joe Fernandez
23fd176813 docs: Update TextView JavaDoc comments
- fix typographic errors (misspellings)
- Simplified the overview to essential info
- included a code example for common TextView usecase
- adds missing javadoc description and param for setScroller method

From BNR vendor, Project 01, android-developer-documentation/pull/1
Test: docs-only change. Tested with a check build

Change-Id: Id853c5587722c7125a33e25002e2bde73e397c0d
2017-04-18 14:35:43 -07:00
Ian Lake
95b193fdca Remove scale up animation for startActivity from RemoteViews
The scale up animation used by default for all startActivity calls coming from
RemoteViews overrides all custom animations set on the activity's theme. By
switching to ActivityOptions.makeBasic(), we allow custom animations on an
activity by activity basis.

This also fixes issues where activities would scale up from a click position in the
notification tray even after the notification tray collapses (which happens
concurrently with the startActivity call).

Test: visual inspection

BUG: 34235073
Change-Id: I922beee39d9fde9c00d41d07d8a8204421e7faa7
2017-04-18 13:20:34 -07:00