Commit Graph

9696 Commits

Author SHA1 Message Date
TreeHugger Robot
b63d261f9c Merge "Refactored Autofill to move starting flag out of Session." into oc-dev 2017-04-28 09:25:06 +00:00
TreeHugger Robot
3dfd827574 Merge "Changed HtmlInfo.getAttributes() to return List instead of ArrayList" into oc-dev 2017-04-28 06:42:22 +00:00
Felipe Leme
0aa4c5065d Refactored Autofill to move starting flag out of Session.
Otherwise, all onFillRequest() calls in the same partition would use
the same flags.

Fixes: 37675138
Test: existing CtsAutoFillServiceTestCases pass
Test: CtsAssistTestCases pass
Test: PartitionedActivityTest.testAutofill4ParitionsMixManualAndAuto() pass

Change-Id: I03c8a036637bae534904d4f41265e451088cf940
2017-04-27 23:38:14 -07:00
Svetoslav Ganov
70c0221813 Merge "Implement the rest of autofill importance modes" into oc-dev 2017-04-28 06:30:07 +00:00
Felipe Leme
09a70628da Changed HtmlInfo.getAttributes() to return List instead of ArrayList
Fixes: 37747396
Test: CtsAutoFillServiceTestCases pass

Change-Id: Ief53e6d71805f561577b73e57a9d36bc3769862a
2017-04-28 04:56:29 +00:00
TreeHugger Robot
17238a3f1a Merge "Fixed requestAutofill()." into oc-dev 2017-04-28 01:36:10 +00:00
Svet Ganov
fd31f85d0c Implement the rest of autofill importance modes
Test: CTS tests pass; augmented tests to verify new behavior

bug:36171235

Change-Id: Ieff2b8d7e1c3a3eba456deca7bed70c8e29c415e
2017-04-27 18:16:08 -07:00
TreeHugger Robot
e7172ff9fb Merge "AAPT2: Add workaround for non-standard package IDs" into oc-dev 2017-04-27 23:45:44 +00:00
Andrii Kulian
bfe5aa23e8 Merge "Hide onMovedToDisplay callback" into oc-dev 2017-04-27 18:09:17 +00:00
Felipe Leme
d114642764 Fixed requestAutofill().
It should behave like notifyViewEntered() but passing a flag, but the current
implementation always start a new session, which is a problem on partitions.

Fixes: 37709350

Test: existing CtsAutoFillServiceTestCases pass
Test: new PartitionedActivityTest.testAutofill4PartitionsManually pass

Change-Id: Ia625a8fa067670e888c2861609ede039abf0f474
2017-04-27 07:09:30 -07:00
TreeHugger Robot
a97608caa8 Merge "SmartSelection: Use downloaded model file." into oc-dev 2017-04-27 13:50:58 +00:00
Adam Lesinski
4ca56978a9 AAPT2: Add workaround for non-standard package IDs
The dynamic ref table used to map build-time IDs to runtime IDs
is mainly used for shared resource libraries and has a few built-in
mappings (app 0x7f and framework 0x01).

Using a non-standard package ID like 0x80 causes a failure in package ID
lookup. The solution is to ship the dynamic_ref_table with an identity mapping
with any resource table that uses a non-standard package ID.

Adds some tests to ensure this works correctly.

Bug: 37498913
Test: make libandroidfw_tests
Test: make aapt2_tests
Change-Id: Ic3f67942384d34e7fdcbc94ded360e940e3ebc8a
2017-04-26 21:55:31 -07:00
Svet Ganov
48f10a2ab5 Handle package changes in autofill manager service
Autofill manager service was not observing package changes thus
we did not properly handle the cases of the service being updated,
added, and removed. Handling, additions is needed to properly
support restore from a backup. Fixed a few missing locks.

Test: all autofill CTS tests pass and manually tested update, add,
      and remove of autofill services.

bug:36638606
bug:36978445

Change-Id: Idd47891774ba2a4e562a1952cbb5a048211fd4e3
2017-04-26 19:22:05 -07:00
Andrii Kulian
cadaccedac Hide onMovedToDisplay callback
There are no usages in O, so not exposing it for now.

Bug: 37638275
Test: android.server.cts.ActivityManagerDisplayTests
Change-Id: I30a8549191ac1cfad0fb1e4db71a702862c0e503
2017-04-26 18:09:54 -07:00
Felipe Leme
62bb027d12 Merge "Provide support for optimized ACTION_REQUEST_SET_AUTOFILL_SERVICE." into oc-dev 2017-04-26 23:46:21 +00:00
Rob Carr
bd1ef76684 Merge "Fix logspam NPE." into oc-dev 2017-04-26 21:43:30 +00:00
Abodunrinwa Toki
146d0d4f6d SmartSelection: Use downloaded model file.
This cl introduces support for reading the smart selection model
file downloaded via ConfigUpdater. It decides on whether to use this
file based on the language and version of the model file.

Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Bug: 34780396
Change-Id: Ie17b9908a0b4eac16a671b0bd633a89da7bc3fee
2017-04-26 21:31:16 +01:00
Felipe Leme
bb81092a31 Provide support for optimized ACTION_REQUEST_SET_AUTOFILL_SERVICE.
Also removed obsolete 'cmd autofill save'

Bug: 2153814
Test: manual verification

Change-Id: I082e6bb098e9be5d9e26d0941efcf6f28ab01e1d
2017-04-26 12:07:17 -07:00
Felipe Leme
5f7979222d Merge "Provide a way to set AutofillId on ViewStructure." into oc-dev 2017-04-26 18:38:21 +00:00
TreeHugger Robot
db8f2fc025 Merge "Fix ViewOverlay#onDescendantInvalidated" into oc-dev 2017-04-25 23:15:52 +00:00
Felipe Leme
e4f30650ac Provide a way to set AutofillId on ViewStructure.
So far that was done indirectly by public methods that could
be overridden in away that does not set the proper id in the structure,
which would crash apps.

Bug: 36171235
Test: modified VirtualContainerActivityTest#testAutofillOverrideDispatchprovideAutofillStructure

Change-Id: I3f1c64020125cbb8349971a0bc52ccd1e0c81e62
2017-04-25 14:12:03 -07:00
Chris Craik
bc44b1a693 Fix ViewOverlay#onDescendantInvalidated
Fixes: 37307001
Test: android.view.ViewInvalidateTest

Also removes damageChildInParent, since it's not called anywhere.

Change-Id: Ic81d4465e4828c5826957ace2c44ac263b4662bd
2017-04-25 13:32:19 -07:00
Robert Carr
3651ab8e09 Fix logspam NPE.
Harmless but spammy.

Bug: 37622525
Test: Repro from bug.
Change-Id: I7fa2404fddb0c62efdd4553d5c61e92ae8f3a876
2017-04-25 12:05:34 -07:00
Phil Weaver
efb859f2af Merge "Allow a11y listeners to specify handlers" into oc-dev 2017-04-25 17:18:03 +00:00
TreeHugger Robot
fc513f98d7 Merge "Added APIs that let AutofillService implementations set themselves as such." into oc-dev 2017-04-25 08:56:03 +00:00
TreeHugger Robot
59fe3108fa Merge "Hide deprecated APIs." into oc-dev 2017-04-25 05:09:27 +00:00
Felipe Leme
db041188bc Added APIs that let AutofillService implementations set themselves as such.
Bug: 37576671
Test: manual verification
Test: CtsAutoFillServiceTestCases (with new tests) pass

Change-Id: I6fd61f8a2826dbf6b6fce831f3deadf6df025386
2017-04-24 18:44:09 -07:00
Felipe Leme
85d1c2d290 Minor fixes on Autofill Framework:
- Removed default implementation of onProvideAutofillVirtualStructure() that
  was using accessibility API (it's useless because without the View calling
  AutofillManager.notifyViewEntered(), it would never be triggered).
- Fixed obsolete TODOs.
- Removed obsolete service class name constant.
- Removed unused debug constant.

Fixes: 37078783
Fixes: 33197203
Bug: 33802548
Bug: 35956626

Test: CtsAutoFillServiceTestCases pass
Merged-In: I834d34b8af8bf0d781dc7e0ffcd6e600bfa2d183
Change-Id: I834d34b8af8bf0d781dc7e0ffcd6e600bfa2d183
2017-04-24 16:01:12 -07:00
Felipe Leme
cb4dd8090b Hide deprecated APIs.
Test: CtsAutoFillServiceTestCases pass
Bug: 37563972

Change-Id: Ia5f33c5624b7a6be3c152e126c99800914d23cbd
2017-04-24 14:04:56 -07:00
Felipe Leme
4711ed9f9f Replaced getUrl() by getWebDomain().
Bug: 37566507
Test: CtsAssistTestCases pass

Change-Id: I1b4dfa7259040b3b8bf1014ebb806eb7a3b36c58
2017-04-24 09:43:08 -07:00
Abodunrinwa Toki
85ae12aee1 Hide TextClassifier.getLinks API.
Test: none
Bug: 37565246
Change-Id: I275a9d055ef0ab68f3ca339c37ee939257c4bd54
2017-04-21 17:39:23 +01:00
Phil Weaver
26d709fdfa Allow a11y listeners to specify handlers
This follows recommended practice for listeners, and also
allows ViewRootImpl to register for callbacks on its own
handler, which can prevent crashes in apps that have
different threads managing the UI at different times (for
example the system process).

Bug: 37542371
Test: Adding CTS tests for new APIs. A11y CTS still passes.
Change-Id: I65db025275e153c20b20567346246d5bc13bf418
2017-04-21 09:24:40 -07:00
Abodunrinwa Toki
8557802248 Hide TextClassificationManager.detectLanguages API
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Bug: 37562190
Change-Id: Ibc1b7f61a8c5c8109de70e9026434c91a3ea655c
2017-04-21 16:25:13 +01:00
TreeHugger Robot
5cb3d6bea3 Merge "Correctly compute visible views" into oc-dev 2017-04-21 05:15:40 +00:00
TreeHugger Robot
56879000d9 Merge "fix KeyEvent can't correctly finish when inputmethod time out happend" into oc-dev 2017-04-21 02:36:10 +00:00
TreeHugger Robot
dbc020983d Merge "Fixed NPE on dump() and other minor fixes..." into oc-dev 2017-04-21 01:20:23 +00:00
Phil Weaver
4a5ea54710 Merge "Hide API to listen to a11y service state" into oc-dev 2017-04-21 00:11:08 +00:00
Philip P. Moltmann
e0e287170e Correctly compute visible views
addToSet needs the same set as parameters as it returns. Otherwise the
returned set it overrridden.

In this case only the last visible view was added as the set was
overriden with the invisible views.

Test: CtsAutoFillTestCases
Fixes: 37550229
Change-Id: I80e16cbd8a1af83373d7ea7b0f84a7c4d157119f
2017-04-20 16:57:36 -07:00
TreeHugger Robot
b8305e9186 Merge "Added missing important-for-autofill mappings." into oc-dev 2017-04-20 23:43:38 +00:00
Felipe Leme
49e96960d4 Fixed NPE on dump() and other minor fixes...
Bug: 36871500
Test: manual verification
Change-Id: I1c3a8406344280da37b728eae56f26447c48e0b2
2017-04-20 15:53:06 -07:00
TreeHugger Robot
f4af35a5fe Merge "Moved getAutofillOptions() logic from SpinnerAbs to AdapterView and Adapter." into oc-dev 2017-04-20 17:25:19 +00:00
Felipe Leme
5a791c8584 Added missing important-for-autofill mappings.
Bug: 36171235
Test: m update-api
Change-Id: I7bbbe7a323110c89976cab3e4f5c8f4acba407d7
2017-04-20 08:26:14 -07:00
Phil Weaver
5d25f429bf Merge "Make a11y clickable span work after node recycle" into oc-dev 2017-04-20 14:51:43 +00:00
gaoshang
863ad2f89d fix KeyEvent can't correctly finish when inputmethod time out happend
Symptom: If inputmethod handle an KeyEvent time out ,
Did not finish this event correctly , eventually lead to app ANR
Root Cause: without seq number when obtainMessage MSG_TIMEOUT_INPUT_EVENT
Solution: add seq parameter

Test: Input
Test: InputMethod
Bug: 28635475

Change-Id: I3a2b964b34aa57267bd777305200a2bfdc66f65c
Signed-off-by: gaoshang <gaoshang@xiaomi.com>
2017-04-20 15:22:13 +01:00
Abodunrinwa Toki
fa9d889d3e Merge "TRON: Log "textAssist" actions." into oc-dev 2017-04-20 13:08:52 +00:00
Phil Weaver
4cab9308fc Hide API to listen to a11y service state
Hiding and adding the requested return value, so if we
later decide to unhide it we'll be up to snuff for API
review.

Bug: 35764675
Test: Verified that the two features that listen, a11y
volume and the accessibility button on the nav bar, work
properly. Also ran accessibility CTS.
Merged-In: I47b62f2b4fd1ea4a7e697d20a3bb2c3201f6bcce
Change-Id: I4df6164772eb01b4f988c201f46c788eb7124511
2017-04-19 16:19:53 -07:00
Jiaquan He
85cee7ab38 Opt out default focus highlight for TV.
Test: Checked that the default focus highlight doesn't show on TV.
Bug: 37160940
Change-Id: Id3719ce1aa602ba6792cc94c9fa034670509cda0
2017-04-19 21:14:05 +00:00
Abodunrinwa Toki
54486c16ba TRON: Log "textAssist" actions.
- Logs when the assist menu item appears in the text selection menu.
- Logs when the assist menu item is selected.
- Logs the the type of the assist menu item that was presented.

Test: Manually tested by looking at the logs. See: go/tron-howto
Bug: 32572232
Change-Id: Ibbbf59423b3f510ab6f2f072962a556c3d6e2f65
2017-04-19 22:10:51 +01:00
Phil Weaver
23161e7170 Make a11y clickable span work after node recycle
Services recycle nodes when gathering possible actions
for users to take. It's very confusing for them if they
can't recycle the node without breaking their ability
to activate a clickable span inside it.

Making ClickableSpans used for accessibility independent
of their parent nodes.

Also adjusting the value used for invalid window ids to
come from AccessibilityWindowInfo. I must have missed this
in an earlier cleanup. I needed the value for the spans,
so I figured I might as well use the correct one.

Bug: 37004527
Test: Now recycling the node in the a11y cts test.
Change-Id: I6de4e98a182dd43c4fcd0430a3c082fcc8e458c7
2017-04-19 14:08:34 -07:00
Evan Rosky
4ab21012a7 Merge "Improve ViewDebug reporting for focus properties" into oc-dev 2017-04-19 19:50:30 +00:00