Commit Graph

14516 Commits

Author SHA1 Message Date
Louis Chang
778d68307c Merge "Revert "Only add divider when it need to show"" into rvc-dev am: 77db95ce85
Change-Id: I3e07281119d0aad8b3c66186f5bcdbce1e32bd77
2020-05-28 14:48:08 +00:00
Louis Chang
77db95ce85 Merge "Revert "Only add divider when it need to show"" into rvc-dev 2020-05-28 14:45:46 +00:00
TreeHugger Robot
790e618c22 Merge "Insets: Allow animations when setting SYSTEM_UI_LAYOUT_* flags" into rvc-dev am: 9cf7941324
Change-Id: Iaf7e3cc9acef95cda544440c7d99ea4ff3e08e02
2020-05-28 14:25:16 +00:00
TreeHugger Robot
9cf7941324 Merge "Insets: Allow animations when setting SYSTEM_UI_LAYOUT_* flags" into rvc-dev 2020-05-28 14:14:15 +00:00
Adrian Roos
2e2631572a Insets: Allow animations when setting SYSTEM_UI_LAYOUT_* flags
Test: atest android.server.wm.WindowInsetsAnimationTests#testAnimationCallbacks_withLegacyFlags
Fixes: 155955734
Change-Id: Idb35218abb4e17688bfb985abb97ae739a60136b
2020-05-28 14:33:38 +02:00
Louis Chang
bf1a597b20 Revert "Only add divider when it need to show"
This reverts commit 91bba497c3.

Reason for revert: unblock wm presubmit

Fix: 157629296

Change-Id: I04fd8b79de025d7c531ac03218a7590e6a32e1be
2020-05-28 09:43:53 +00:00
Tony Huang
d888ed0e4d Merge "Only add divider when it need to show" into rvc-dev am: 8acb04e235
Change-Id: Ia7641633ab93d9d02e52ae5a3c2adef492e506cc
2020-05-28 04:41:01 +00:00
Tony Huang
8acb04e235 Merge "Only add divider when it need to show" into rvc-dev 2020-05-28 04:26:37 +00:00
Adrian Roos
bd5cc07426 Merge "InsetsController: Maintain type user animation when restarting input" into rvc-dev am: 792dc29a6e
Change-Id: I34909739edfef608d65a6594894766264e5d3541
2020-05-27 18:23:40 +00:00
Adrian Roos
ab431c4c6f Merge "InsetsController: Add missing onWindowInsetsAnimationEnd when cancelling" into rvc-dev am: c7577d48c0
Change-Id: Ia2fde50aeeb18b6fa595d22c8c491fedd9f31cfb
2020-05-27 18:23:14 +00:00
Adrian Roos
792dc29a6e Merge "InsetsController: Maintain type user animation when restarting input" into rvc-dev 2020-05-27 18:09:16 +00:00
Adrian Roos
c7577d48c0 Merge "InsetsController: Add missing onWindowInsetsAnimationEnd when cancelling" into rvc-dev 2020-05-27 18:08:19 +00:00
Heemin Seog
3eeb71d1eb Merge "Add climate bar insets" into rvc-dev am: 58169786a6
Change-Id: I38c88995a491c36a6b29950b52fbb8da0003c9d8
2020-05-27 15:48:53 +00:00
Heemin Seog
58169786a6 Merge "Add climate bar insets" into rvc-dev 2020-05-27 15:38:32 +00:00
Taran Singh
816b9c374c Merge "Add Insets dumps and IME debug logs" into rvc-dev am: e20c25ddc6
Change-Id: Ic644e48d41209ce171c568e87358a86090249b3f
2020-05-27 15:24:27 +00:00
Taran Singh
e20c25ddc6 Merge "Add Insets dumps and IME debug logs" into rvc-dev 2020-05-27 15:12:30 +00:00
Taran Singh
85661e3f9e Add Insets dumps and IME debug logs
Add more dumps and logs to better help debug IME insets better
Logging can be enabled by setting InsetsController.DEBUG to true.

Bug: 154348613
Test: manually build and flash.
      Verify showing and hiding IME shows logs.
      verify adb shell dumpsys window windows has new dumps

Change-Id: Iad0a21d81a22d6acfaaf5c5ca8b5131eec411e79
2020-05-27 15:12:07 +00:00
Tony Huang
91bba497c3 Only add divider when it need to show
By previous memory patch, the divider will always call update when
enter split when means it always add divider view when showing. So
we can reduce some update call to avoid any unnecessary surface
memory allocate.

Fix: 150190730
Test: Check split mode rotate normally and dump SF to check divider
      memory status
Change-Id: Ibccd0b998d299968ee6d68127c801fae656d2127
2020-05-27 11:25:05 +08:00
Heemin Seog
d79e4f49d2 Add climate bar insets
This can be used to support a 3rd kind of system bar to inset the
applicaiton space.

Bug: 152763889
Test: manual
Change-Id: I3ba75886e94a9fe80a0d1a920749d152dda64031
2020-05-26 14:26:25 -07:00
TreeHugger Robot
e9b6fa5da6 Merge "WindowlessWindowManager: Set size when creating surface" into rvc-dev am: 58c7846f6a
Change-Id: Id975b3b7206fa1abbabbcb9f54718726d45dbb65
2020-05-26 20:51:04 +00:00
TreeHugger Robot
58c7846f6a Merge "WindowlessWindowManager: Set size when creating surface" into rvc-dev 2020-05-26 20:41:22 +00:00
Adrian Roos
a2d2ba7e61 InsetsController: Maintain type user animation when restarting input
When the IME restarts input, it re-requests to show itself. If the app is
already animating, we should maintain that animation instead of cancelling
it.

Fixes: 155962435
Test: atest WindowInsetsAnimationControllerTests
Change-Id: I57618e43b2cddc55e5dfc32111abbbd82cc6ed48
2020-05-26 20:22:05 +00:00
Adrian Roos
a79b8851f7 InsetsController: Add missing onWindowInsetsAnimationEnd when cancelling
Fixes a few issues around cancelling insets animations:

- dispatch the onEnd callback when the animation gets cancelled
- When using the CancellationSignal, we need to properly cancel the
  animation, and not just the controller - otherwise we never actually
  remove it from mRunningAnimations.
- Now that cancellation dispatches to apps, make sure they do not
  restart a different animation of the same type we just cancelled

Bug: 156740834
Test: atest WindowInsetsAnimationControllerTests
Change-Id: I4c36470a816ff8e3b92cd03090b8e947a2234f13
2020-05-26 21:26:25 +02:00
Robert Carr
5d9d2ddca2 WindowlessWindowManager: Set size when creating surface
When we set the buffer size from relayout window, there is a race
condition where the client may then submit its first buffer but the
transaction hasnt applied yet on the SF side and so the buffer is
rejected. Setting a defualt size when creating fixes this. Luckily
SurfaceControlViewHost size is known at add time, since we force the
window size based on the values passed in to the SurfaceControlViewHost API.

Bug: 157153874
Test: Existing tests pass
Change-Id: I2566844aea81df92f1694f43254a480fc3b3c019
2020-05-26 11:29:39 -07:00
Hongwei Wang
3ffda8dade Merge "Ignores entering PiP animation on seamless rotation" into rvc-dev am: 047a550900
Change-Id: Id425cf6f338f1b03cb69a41210f5525002cf14a5
2020-05-21 03:16:37 +00:00
Hongwei Wang
047a550900 Merge "Ignores entering PiP animation on seamless rotation" into rvc-dev 2020-05-21 03:12:56 +00:00
Hongwei Wang
f4e4bab403 Ignores entering PiP animation on seamless rotation
- Added onFixedRotationStarted/onFixedRotationFinished callback in
  DisplayWindowListener
- onFixedRotationStarted shall be called before onTaskAppeared for PiP
- When onTaskAppeared is received in PipTaskOrganizer, we defer the
  entering PiP transition if fixed rotation is ongoing
- When onFixedRotationFinished is received in PipTaskOrganizer and the
  entering PiP transition is deferred, schedule an immediate
  transition to PiP to make sure all the expected callbacks from
  PipTaskOrganizer are still being sent

Video: http://go/recall/-/aaaaaabFQoRHlzixHdtY/bb8HjJvMZKtpN8YTPKZXmj
Bug: 153861223
Test: manually enter PiP from Play Movies / YT fullscreen
Test: atest ActivityRecordTests \
            RecentsAnimationControllerTest \
            ActivityTaskManagerServiceTests \
            PinnedStackTests
Change-Id: I0dea905d610e2387af56b611be5f93518cc9a153
2020-05-20 17:34:17 -07:00
Tiger Huang
1f8f560661 Merge "Dispatch the requested visibility if the client has the control" into rvc-dev am: 090ee6ff39
Change-Id: I3404301c600b7be6bfd38c24e7b78fe2761a9de3
2020-05-20 14:38:03 +00:00
Tiger Huang
090ee6ff39 Merge "Dispatch the requested visibility if the client has the control" into rvc-dev 2020-05-20 14:36:30 +00:00
Julian Odell
b508a77c44 Merge "Flush buffered data when session connects. Typically this data would have been flushed at the end of the first draw and there would otherwise be an extended delay before the data would be sent to the service." into rvc-dev am: 4946555a8e
Change-Id: I22c89fff90283640826088d9c323713af2eab4c3
2020-05-19 22:25:30 +00:00
Julian Odell
4946555a8e Merge "Flush buffered data when session connects. Typically this data would have been flushed at the end of the first draw and there would otherwise be an extended delay before the data would be sent to the service." into rvc-dev 2020-05-19 22:22:30 +00:00
Julian Odell
ef928f8a11 Flush buffered data when session connects.
Typically this data would have been flushed at the end of the
   first draw and there would otherwise be an extended delay
   before the data would be sent to the service.

Test: make -j
Test: Manually start WhatsApp - check for lost events
Test: atest CtsContentCaptureServiceTestCases

Bug: 154777879
Change-Id: Ia0a97e24ffcc1c189d5d0cd6b8888678fa48968e
2020-05-19 12:30:57 -07:00
Tiger Huang
2ab590a4b8 Dispatch the requested visibility if the client has the control
Otherwise, we would think its visibility needs to be cleared.

This CL:
- reverts parts of eb5a5920b7,
- prevents sending redundant MSG_DISPATCH_SYSTEM_UI_VISIBILITY, and
- cancels clearing visibility if a new reversed visibility is set.

Fix: 156994866
Test: atest --iterations 100 LayoutTests#testAddingImmersiveWindow
      atest WindowInsetsControllerTests InsetsAnimationControlImplTest
Change-Id: I8b8b7541523c0a94daf336f3be415aa5fa3f33da
2020-05-19 22:07:04 +08:00
Evan Rosky
79da850cfe Merge "Add a window dump for uiautomator" into rvc-dev am: bddd280556
Change-Id: I5b9b5d0536dd2a735b78926df6c1c2e72f67e29a
2020-05-15 18:16:56 +00:00
Evan Rosky
bddd280556 Merge "Add a window dump for uiautomator" into rvc-dev 2020-05-15 18:15:36 +00:00
TreeHugger Robot
ad6683cb04 Merge "Add tracing for Inset animations" into rvc-dev am: 5bf3f80f20
Change-Id: I7799f6e7eadd8bf24c43de58933365d7842ad2c2
2020-05-15 15:59:35 +00:00
Tiger Huang
88f47b7d0d Merge "Do not dispatch system UI visibility during traversal" into rvc-dev am: 8fd8a538b8
Change-Id: If80d3f6cb3c120aa32ae95e75b07149356583d34
2020-05-15 15:54:58 +00:00
Matt Casey
cdf533b8f2 Merge "Allow WindowManager.TYPE_SCREENSHOT to be focusable" into rvc-dev am: d8aa60aa0d
Change-Id: I6ed40dcec54942b982e312e5c975ec94fbb951ce
2020-05-15 15:53:25 +00:00
TreeHugger Robot
5f6997a91f Merge "Revert "Finish input when the screen state is off"" into rvc-dev am: d99569f88a
Change-Id: Ie7d45b61a1b6b2f31bb20c1ad4e6feaa43c33ce1
2020-05-15 15:50:11 +00:00
TreeHugger Robot
a51f14f3e5 Merge "Pass window type to the InputWindowHandle of embedded window" into rvc-dev am: 0e58daf022
Change-Id: I4a6cd0dd57c318aa5de26c7e3ca33cda961f7430
2020-05-15 15:47:45 +00:00
TreeHugger Robot
1fafd9ada3 Merge "Remove divider view when exiting splitscreen" into rvc-dev am: 3a6ec37a71
Change-Id: I7cbc233fca8687eba37c3127f9d13fe3c9e60c19
2020-05-15 15:44:34 +00:00
TreeHugger Robot
5bf3f80f20 Merge "Add tracing for Inset animations" into rvc-dev 2020-05-14 22:16:23 +00:00
Tiger Huang
8fd8a538b8 Merge "Do not dispatch system UI visibility during traversal" into rvc-dev 2020-05-14 17:25:56 +00:00
Matt Casey
d8aa60aa0d Merge "Allow WindowManager.TYPE_SCREENSHOT to be focusable" into rvc-dev 2020-05-14 16:37:58 +00:00
Jorim Jaggi
cb28ae6d17 Add tracing for Inset animations
So we can understand better what's going on.

Bug: 156367695
Test: Systrace
Change-Id: Ic9dc2c963f70a3bb787121d33476b84bd3dc5798
2020-05-14 17:46:32 +02:00
TreeHugger Robot
d99569f88a Merge "Revert "Finish input when the screen state is off"" into rvc-dev 2020-05-14 14:21:39 +00:00
TreeHugger Robot
0e58daf022 Merge "Pass window type to the InputWindowHandle of embedded window" into rvc-dev 2020-05-14 08:32:00 +00:00
arthurhung
d3f17d7df7 Pass window type to the InputWindowHandle of embedded window
A windowless SurfaceControl could grant input via
IWindowSession.grantInputChannel, but other window may receive the
obscured events because of the type value of input window is always 0.

The obscured or partially obscured flag indicates that the window
received this motion event is wholly or partially obscured by another
visible window above it.

We have to filter out the trusted overlap so the motion event could
properly dispatch to the view if it is a security sensitive application.

Bug: 156063505
Test: enter split window mode and check the motion event
Change-Id: I10f63ea131a70ee8cc7d5c4b3e5ca4e5f06fdbad
2020-05-14 11:59:23 +08:00
TreeHugger Robot
3a6ec37a71 Merge "Remove divider view when exiting splitscreen" into rvc-dev 2020-05-14 02:25:24 +00:00
Ming-Shin Lu
2c6e80be12 Revert "Finish input when the screen state is off"
This reverts commit 0df8812486.

The original CL is trying to reduce the dependency of PownerManager to
finish input when screen off by using display state.

However, it doesn't fully fix the original Bug 26851566 since we only
finish input connection but didn't callback onFinishInput callback for
IME client.

Also, for some scenarios, the window / view focus may not change
during screen turns off / on:
  - Focusing timing when disable keyguard, then quickly screen off / on.
  - Using P-sensor to turning screen off / on.

When the above scenario happens, makes input connection cannot re-start
and soft-keyboard can't be shown.
(The recovery is manually focus on next window or activity.)

As the above reason, we need to re-consider the lifecycle of
input connection, window / view focus when not only screen state but also
device inactive state when always-on-display.

Fix: 156045961
Fix: 154605805
Bug: 26851566
Bug: 156215187
Test: atest CtsInputMethodTestCases
Change-Id: If06daf71160aa44a4254ac125561974ecbdef4f2
2020-05-14 08:29:18 +08:00