Commit Graph

3793 Commits

Author SHA1 Message Date
Tobias Sargeant
e71eaf3f5e Merge "[webview] Fix handling of unicode digits in address detection."
am: 8abff6b4d0

Change-Id: I08b798ac8867c14098a48dd2782ceab794360683
2019-10-11 03:57:24 -07:00
Treehugger Robot
8abff6b4d0 Merge "[webview] Fix handling of unicode digits in address detection." 2019-10-11 10:30:36 +00:00
Tobias Thierer
093c1e4eaa Merge "Track MimeMap moving to libcore.content.type."
am: 0801b7c222

Change-Id: I63889b3eedb8f98c99d71172dc5cc32025a8afd4
2019-10-04 06:07:03 -07:00
Tobias Thierer
8edd837b79 Track MimeMap moving to libcore.content.type.
Another CL in this topic moves libcore.net.MimeMap to package
libcore.content.type. This CL updates associated references.

Bug: 136256059
Bug: 124232146
Test: Treehugger
Test: CtsMimeMapTestCases
Exempt-From-Owner-Approval: move affecting imports only
Change-Id: I30aac8b28a1740180ea01834a2bb66b61cb255d4
2019-10-04 12:52:38 +00:00
Tobias Sargeant
fdebc611b6 [webview] Fix handling of unicode digits in address detection.
Restrict the set of digits recognised to ASCII to avoid throwing a
NumberFormatException

Bug: 141534831
Test: atest CtsWebkitTestCases
Change-Id: Ifc39fef9b8e2b66b3e0a9a6590b5817136cccd2f
2019-09-30 13:29:45 +01:00
Nate Fischer
38b8fca177 Merge "WebView: prettyprint docs" into qt-dev am: 20f2f0b5ea
am: 6201d28952

Change-Id: I699c12ad87091c94601971ac56bf46966f16e740
2019-08-19 13:43:41 -07:00
Nate Fischer
6201d28952 Merge "WebView: prettyprint docs" into qt-dev
am: 20f2f0b5ea

Change-Id: Iad51d33c434a42272c448ba7a807bdcbe6cb51d0
2019-08-19 13:22:49 -07:00
Nate Fischer
06fd060c14 WebView: prettyprint docs
No change to logic, only docs.

Use class=prettyprint so docs are syntax highlighted. This also fixes a
section which should have been an ordered list but abused <pre> instead.

Bug: 125526827
Test: make -j4 docs
Change-Id: Iac780ace066be35620d5121b1977df404eaf18c1
2019-08-13 22:23:10 +00:00
Tao Bai
daa718b991 Merge "Update WebSettings.setSaveFormData deprecated doc" into qt-dev am: 7bb64fcf27
am: 22eceae195

Change-Id: I8afe18e9b51e59813b2b348666ff678e69eff1e1
2019-07-31 18:59:28 -07:00
Tao Bai
22eceae195 Merge "Update WebSettings.setSaveFormData deprecated doc" into qt-dev
am: 7bb64fcf27

Change-Id: Ife82891152d177e108db79f42fbe768fe8fb905a
2019-07-31 18:48:23 -07:00
Tao Bai
990f9a9fda Update WebSettings.setSaveFormData deprecated doc
Bug:69150750
Test: passed sdk build.
Change-Id: Ia33ef5eda9956bf60dabc51a592ff6e9ec697b4a
2019-07-09 21:07:28 +00:00
Torne (Richard Coles)
c2ed59a2da Merge "Clarify problems with Linkify.MAP_ADDRESSES." into qt-dev am: a0d66cf3f6
am: 0f0173f9e1

Change-Id: Ib8f8c29444f9cf6e1c4de4c15d3a0b4d12632556
2019-06-06 11:02:29 -07:00
Torne (Richard Coles)
0f0173f9e1 Merge "Clarify problems with Linkify.MAP_ADDRESSES." into qt-dev
am: a0d66cf3f6

Change-Id: I10e7f3f8d14d15e3dbc5fd6f97bafc7442c91bb4
2019-06-06 10:59:15 -07:00
Torne (Richard Coles)
a50d608b89 Merge "Clarify problems with Linkify.MAP_ADDRESSES." into qt-dev
am: a0d66cf3f6

Change-Id: I264a589322b87b09a5d250f1a7e71b7f1795f3dd
2019-06-06 10:59:10 -07:00
Torne (Richard Coles)
aa68ab8288 Clarify problems with Linkify.MAP_ADDRESSES.
Update the documentation for WebView.findAddress, as well as the related
functionality in Linkify and TextView, to clarify why the method is
deprecated, why it should not be used, and that it can cause unexpected
exceptions to be thrown from several places on older OS versions.

Fixes: 24676033
Test: m offline-sdk-docs
Change-Id: I45d82b9a4c9cf62d9566898dd21cd2139ad98f37
2019-06-04 14:14:05 -04:00
Felipe Leme
3fe70c6af0 DO NOT MERGE - Re-add ContentCapture support from standard SDK toolkit.
am: 911cb1fa76

Change-Id: I15c8da47beb6b4dd64b627aebb0288fcb359c3e5
2019-05-22 16:00:20 -07:00
Felipe Leme
911cb1fa76 DO NOT MERGE - Re-add ContentCapture support from standard SDK toolkit.
This reverts commit ef1c0b36ab.

Test: atest CtsContentCaptureServiceTestCases
Test: m update-api

Bug: 130726495

Change-Id: Iecda9df96722ac8a3184710796032b6c01bd8ea3
2019-05-16 16:05:51 -07:00
Torne (Richard Coles)
e5b1bc3f5f Merge "Increase 32-bit WebView VA reservation." into qt-dev
am: c7c7f9ecd7

Change-Id: I82628f43fe6e3f8d520424536d0b1918760e08e2
2019-05-08 09:15:49 -07:00
Torne (Richard Coles)
4d72998fda Increase 32-bit WebView VA reservation.
Most pre-Q devices actually reserved around 130MiB in the 32-bit zygote
for the WebView native library; 100MiB was only the lower limit and the
file size based calculation that older OS versions use would come up
with a larger number. Increase the hardcoded value for Q to 130MiB so
that the behaviour is roughly the same across OS versions.

Fixes: 132081320
Test: manually verified via inspection of process maps
Change-Id: I0f03ac2f118bb0627ea6be229e5064d4590d8afb
2019-05-06 16:24:54 -04:00
Tobias Thierer
e327e85014 Merge "Inline calls to MimeUtils." am: 304132e995
am: d0457b20a2

Change-Id: I6d8db5100e1fdbf1242ef8f48108cb73eae5b434
2019-05-02 07:10:16 -07:00
Tobias Thierer
d0457b20a2 Merge "Inline calls to MimeUtils."
am: 304132e995

Change-Id: Id40e722a539fd5212abac6ff1ed76e6ff0a6bff9
2019-05-02 06:58:38 -07:00
Tobias Thierer
bfa552c918 Inline calls to MimeUtils.
A separate CL in this topic adds MimeMap to the @CorePlatformApi and
deletes MimeUtils. This CL inlines calls to MimeUtils to call MimeMap
instead.

Bug: 120171727
Test: Treehugger
Change-Id: Ibad1e62a63342fa7527332d2b156b69517956364
2019-04-26 15:27:31 +01:00
Felipe Leme
ef1c0b36ab DO NOT MERGE - Removed ContentCapture support from standard SDK toolkit.
Test: atest CtsContentCaptureServiceTestCases
Test: m update-api
Test: make ds-docs

Fixes: 129982633

Change-Id: I5a0fa4231d0222638830c1abd8015d9f2635996a
2019-04-15 09:36:25 -07:00
Torne (Richard Coles)
05a766e876 Wait for RELRO before starting WebViewZygote at boot.
We start WebViewZygote at boot time to ensure the first app to use
WebView doesn't have to wait, but we were not waiting for RELRO creation
to finish before doing so. Move the background task which starts the
zygote to WebViewUpdateServiceImpl and have it wait for the RELRO first
to ensure that we get the memory saving of RELRO sharing whenever
possible, instead of only when the timing happens to work out by chance.

Fixes: 130305037
Test: manual, check logs and relro sharing status after boot
Change-Id: I55c3f80b0db1dc82727b90c70f777618ca77a942
2019-04-10 17:59:52 -04:00
Torne (Richard Coles)
5ca7aec419 Remove IWebViewUpdateService.isFallbackPackage.
All callers have been updated to no longer depend on this.

Bug: 129470358
Test: m checkbuild
Change-Id: Iff88e2825a9d1406b5d8f100ddcc5a11bdff2e68
2019-04-02 18:14:54 -04:00
Torne (Richard Coles)
ef47890d65 Migrate away from WebView fallback logic.
We no longer need to support fallback packages and need to migrate them
back to being enabled (but only once, to allow the user to disable them
manually later). This CL:

1) Removes the logic which enables/disables packages and the test cases
   which only cover the enabling/disabling logic.

2) Checks at boot time if the fallback logic is enabled; if so, it
   re-enables the fallback package if one exists and then disables the
   fallback logic permanently.

3) Amends remaining test cases to use "primary" and "secondary" instead
   of primary/fallback, to keep testing that higher priority packages
   are more preferred without involving the fallback behaviour.

4) Fixes a bug in the package selection logic that would not have
   triggered in the previous setup (as our production configs never had
   more than one available-by-default, non-fallback packages) that was
   revealed by one of the modified test cases: the boot time logic to
   reset the user's setting if their previously chosen provider was no
   longer available triggered even if the user had not actually chosen a
   provider, causing the automatically selected provider to be
   considered a manual user choice, and preventing a higher priority
   provider from being automatically chosen if it later becomes
   available.

Bug: 126588129
Test: atest WebViewUpdateServiceTest
Change-Id: I532c0faae2427de7132f716725bf62e256975410
2019-04-01 17:31:48 -04:00
Torne (Richard Coles)
689afe4149 Remove support for the WebView stub.
The WebView stub is only used in Monochrome configurations and is no
longer required with Trichrome. Remove the special case code used to
support it in the past.

Bug: 129470358
Test: atest CtsWebkitTestCases
Change-Id: Ieb11ae6698f370a1d601459e6253fc7dbe146014
2019-03-28 17:16:08 -04:00
Toby Sargeant
17501cab51 Merge "[wv-docs] Document force dark default, and behaviour of FORCE_DARK_AUTO" 2019-03-20 15:11:10 +00:00
Tobias Sargeant
e1fc791cff [wv-docs] Document force dark default, and behaviour of FORCE_DARK_AUTO
This adds a reference to the View method that controls framework force
dark, which impacts how FORCE_DARK_AUTO is interpreted. It also
documents that FORCE_DARK_AUTO is the default.

Test: documentation only change
Fixes: 128704481
Change-Id: I88e7996362da5b092b269c313e37ef9253b12872
2019-03-20 11:39:01 +00:00
Ashley Rose
d6b17862df Merge "Rename @EnumEntry and @FlagEntry" 2019-03-19 18:03:24 +00:00
Ashley Rose
73abdd3c59 Rename @EnumEntry and @FlagEntry
Test: atest CtsViewInspectorAnnotationProcessorTestCases
Bug: 127531820
Exempt-From-Owner-Approval: Annotation-only change
Change-Id: Id293e2b2ac9cf7bf2aaeb28645471ea227bb587b
2019-03-18 16:05:55 -04:00
Torne (Richard Coles)
85120a5474 WebView: add all APKs to asset path.
If there are multiple APKs as part of the WebView implementation (due to
splits, shared libraries, or overlays) add them all to the asset path,
instead of just the base APK.

Bug: 124116212
Test: manually tested with modified Trichrome build
Change-Id: I912e741b6de3154f66e5e82c9cf7154c6d39b1a4
2019-03-18 15:44:26 -04:00
Torne (Richard Coles)
3b6554e278 Partially revert "Handle WebView assets correctly when multiple APKs are used."
This reverts the WebViewFactory changes from commit
527fa8f4de which appear to have changed
the way that the asset path is updated in an incompatible way.

Bug: 124116212
Fixes: 128489090
Test: launch affected applications
Change-Id: Id53dedef4fa55a6b8cea8a60326a4b8acd3422f8
2019-03-13 12:33:29 -04:00
Torne (Richard Coles)
527fa8f4de Handle WebView assets correctly when multiple APKs are used.
Add all splits and shared libraries used by the WebView implementation
to the application's asset path, instead of just the base APK. Fix the
asset manipulation code path in WebViewFactory to reuse the modern
implementation in WebViewDelegate (using appendLibAssetForMainAssetPath)
instead of relying on addAssetPathAsSharedLibrary.

Add a new variant of appendLibAssetForMainAssetPath which accepts
multiple paths at once, to make it more efficient.

Bug: 124116212
Test: atest CtsWebkitTestCases
Change-Id: Ie55525d78089a4595c5b0b126e4ff1530303afe8
2019-03-12 11:41:09 -04:00
TreeHugger Robot
54626bf41f Merge "[webview] Rename force dark WebView settings." 2019-03-12 03:52:33 +00:00
TreeHugger Robot
f66f3ae921 Merge "[webview] rename unresponsive renderer APIs" 2019-03-12 02:37:30 +00:00
Shimi Zhang
b8e9c1c580 Merge "onPageFinished javadoc cleanup" into pi-dev am: dfd3a1b852
am: d4eed7352d

Change-Id: I0d405bad9ead8e1cd814c5634b5e0f69ead8956b
2019-03-11 17:45:09 -07:00
Shimi Zhang
d4eed7352d Merge "onPageFinished javadoc cleanup" into pi-dev
am: dfd3a1b852

Change-Id: Ib79006f63037bbbdc6a22c46ab790fc01a40c010
2019-03-11 17:36:38 -07:00
Tobias Sargeant
bbb043ae86 [webview] Rename force dark WebView settings.
Per API council request, remove setForceDarkMode -> setForceDark to
align with other framework naming.

Bug: 120599879
Test: None
Change-Id: I3f4ed00303d7e4b7d0651a384324a8b265663290
2019-03-11 23:54:27 +00:00
Shimi Zhang
ce222afda7 onPageFinished javadoc cleanup
PictureListener was deprecated, we need to replace its mentioning in
onPageFinished() javadoc with postVisualStateCallback().

Bug: 125939241
Test: make ds-docs
Change-Id: I7c1641c86632bb6c8214fd701e052096952deeec
2019-03-11 19:30:58 +00:00
Tobias Sargeant
39b68efcc3 [webview] rename unresponsive renderer APIs
Followup from API council review:

* Rename Renderer to RenderProcess for consistency with existing APIs.
* Make WebViewRenderProcess constructor public.
* Document 5 second minimum interval between successive callbacks.

Bug: 124767616
Bug: 123629980
Test: atest 'CtsWebkitTestCases'
Change-Id: I4416a97e8bb449c4a14a3617ef72a49c92aa3a83
2019-03-11 15:03:03 +00:00
Andrei-Valentin Onea
0c09cf5011 Merge "Add @UnsupportedAppUsage annotations" am: f304f4d2ea
am: 734611e34e

Change-Id: I14c15626440b2f1455110b6e504c4d18d2e5c5dc
2019-03-06 11:01:30 -08:00
Andrei-Valentin Onea
734611e34e Merge "Add @UnsupportedAppUsage annotations"
am: f304f4d2ea

Change-Id: Ic5e5148c473e64bc5d8ff506e7f4ac78c409734c
2019-03-06 10:30:15 -08:00
Andrei Onea
890db3d672 Add @UnsupportedAppUsage annotations
For packages:
  android.speech
  android.telephony.mbms.vendor
  android.view
  android.webkit

This is an automatically generated CL. See go/UnsupportedAppUsage
for more details.

Exempted-From-Owner-Approval: Mechanical changes to the codebase
which have been approved by Android API council and announced on
android-eng@

Bug: 110868826
Test: m
Merged-In: Iefe25091fa0fcc0adfe4ff85fe5e3ab3ac9c5f10
Change-Id: I04104cf3852a0a7440676ccc55dd96c1eec730c4
2019-03-06 15:43:49 +00:00
John Reck
e9aeadb1e7 Cleanup functor system-api surface
Fixes: 127282736
Test: none
Change-Id: I5982d3f4f0671a3c351c11d8baf04aff5640e0a6
2019-03-04 10:29:40 -08:00
Jeff Sharkey
9e8f83db6d All Parcelable CREATOR fields are @NonNull.
If they were null, then the Parcelable would fail to work.

Bug: 126726802
Test: manual
Change-Id: I7929ffa2f20e5de1c8e68e8263cca99496e9d014
Exempt-From-Owner-Approval: Trivial API annotations
2019-02-28 23:29:04 -07:00
Felipe Leme
50a8c75b49 Merge "Autofill, Content Capture, and Augmented Autofill API fixes:" 2019-03-01 02:04:30 +00:00
Felipe Leme
ce6877b0e4 Autofill, Content Capture, and Augmented Autofill API fixes:
- Added @Nullable / @NonNull on some returned values.
- Removed APIs that won't be implemented for Q.
- Made Builders final.

Test: m update-api

Bug: 123100695
Fixes: 126702168
Fixes: 126701052
Fixes: 126702191
Fixes: 126700602
Fixes: 126700135
Fixes: 126700413
Fixes: 126698817
Fixes: 126698792

Change-Id: I20710537c02051361da18370bc5cc642cc3c26e1
2019-02-28 09:25:12 -08:00
Andrei Onea
f4fb6fb754 Add @UnsupportedAppUsage annotations
For packages:
  android.speech
  android.telephony.mbms.vendor
  android.view
  android.webkit

This is an automatically generated CL. See go/UnsupportedAppUsage
for more details.

Exempted-From-Owner-Approval: Mechanical changes to the codebase
which have been approved by Android API council and announced on
android-eng@

Bug: 110868826
Test: m
Change-Id: Iefe25091fa0fcc0adfe4ff85fe5e3ab3ac9c5f10
2019-02-27 15:42:25 +00:00
Xin Li
b455c3a7f3 DO NOT MERGE - Merge pi-dev@5234907 into stage-aosp-master
Bug: 120848293
Change-Id: I2f9a524f2ba552de3f62e343075cf0abf400bbae
2019-02-21 16:02:06 -08:00