Commit Graph

103880 Commits

Author SHA1 Message Date
Todd Kennedy
aeb383ec87 Merge "Add documentation for OPSTR_LOADER_USAGE_STATS" into rvc-dev 2020-04-29 22:27:55 +00:00
TreeHugger Robot
265622e3c7 Merge "Update public documentation." into rvc-dev 2020-04-29 22:07:45 +00:00
Evan Rosky
650e162195 Merge "Shift Primary stack as well as secondary during ime adjustment" into rvc-dev 2020-04-29 20:55:18 +00:00
Alex Buynytskyy
78c3d0b57f Merge "Unavailable DataLoader status." into rvc-dev 2020-04-29 19:43:40 +00:00
Todd Kennedy
ae3af93daa Update public documentation.
Looks like we haven't returned `null` in years.

Fixes: 149837263
Test: None. Documentation only.
Change-Id: I6900458d0b69152a54034e572a6b994e8e6585bd
2020-04-29 12:33:31 -07:00
Martijn Coenen
1ed01451ed Merge "Add buildExternalStorageAndroidObbDirs()." into rvc-dev 2020-04-29 18:53:13 +00:00
TreeHugger Robot
2b49f81e7e Merge "Use POWER_MENU_LOCKED_SHOW_CONTENT in wallet" into rvc-dev 2020-04-29 18:08:23 +00:00
TreeHugger Robot
5630dc86ed Merge "Use TextClassicationSession to call smart selection APIs." into rvc-dev 2020-04-29 17:34:09 +00:00
Todd Kennedy
0f00675d74 Add documentation for OPSTR_LOADER_USAGE_STATS
Fixes: 150219240
Test: None. Doc only change
Change-Id: I6b156acd49acf95b34ecacff6d252b7ccab6303a
2020-04-29 09:37:10 -07:00
Julia Reynolds
74b8acae26 Merge "Remove unused development setting" into rvc-dev 2020-04-29 15:25:24 +00:00
Jorim Jaggi
1db61c9a6e Merge "Decouple InsetsController from ViewRootImpl" into rvc-dev 2020-04-29 14:35:10 +00:00
Mady Mellor
cf8ab8447e Merge "Fix CTS" into rvc-dev 2020-04-29 14:33:36 +00:00
Julia Reynolds
ccd18a9d58 Remove unused development setting
Test: make, atest
Bug: 151821676
Change-Id: I74c2b7ac17d99f150c1c185f4b69b3b2e72d2575
2020-04-29 13:22:25 +00:00
Jorim Jaggi
bf87c15b33 Decouple InsetsController from ViewRootImpl
Such that all it's goodness can also be used in context when
ViewRootImpl isn't available, like the SystemUI controller used
for Car and Split

Test: InsetsControllerTest
Fixes: 154631128
Change-Id: I54a3f8a34810472d9273e4627a7811b7abd0863f
2020-04-29 14:00:09 +02:00
TreeHugger Robot
447914fcfe Merge "Add RoleControllerManagerTest." into rvc-dev 2020-04-29 05:56:34 +00:00
TreeHugger Robot
d3b000cafe Merge "Move ImeAwareTextEdit from Settings to android.widget" into rvc-dev 2020-04-29 05:17:30 +00:00
Alex Buynytskyy
7e0a1a8ec7 Unavailable DataLoader status.
This is a temporary failure, does not fail the session, but requires
caller to re-commit. E.g. there are connectivity issues which can be
fixed later.

Bug: b/153874006
Test: atest PackageManagerShellCommandTest PackageManagerShellCommandIncrementalTest IncrementalServiceTest
Change-Id: I02791a2963130dbecb510c4a7cafcf04f6245761
2020-04-29 04:23:49 +00:00
Rob Carr
6fcbf83d5e Merge "BLAST: Avoid JNI call on creation" into rvc-dev 2020-04-29 03:59:14 +00:00
Mady Mellor
a114b79392 Fix CTS
* fix BubbleExtractor tests to work with this & better
  test things now that the channel is a tristate

Test: atest NotificationManagerTest BubbleExtractorTest
Bug: 155025024
Change-Id: I8b75c1b0087ca79cea29741e32c7c524cb056d04
2020-04-28 20:06:03 -07:00
TreeHugger Robot
13d7838088 Merge "Address leftover TODOs from inline suggestions." into rvc-dev 2020-04-29 01:46:47 +00:00
TreeHugger Robot
8ba4e7599a Merge "Resolve IndexOOBException in SigningDetails#hasAncestor" into rvc-dev 2020-04-29 01:21:27 +00:00
TreeHugger Robot
007a73c551 Merge "Don't remove OnAlarmListener mappings in the client" into rvc-dev 2020-04-29 01:09:32 +00:00
Kevin Chyn
412bd81933 Move ImeAwareTextEdit from Settings to android.widget
Also use it for AuthCredentialPasswordView

Bug: 154161590

Test: BiometricPromptDemo, authenticate with password
Change-Id: I17601848dd9be3d0580988e3ff613c3793dfed51
2020-04-28 18:06:25 -07:00
Sean Pont
d3cfe6204e Use POWER_MENU_LOCKED_SHOW_CONTENT in wallet
Use POWER_MENU_LOCKED_SHOW_CONTENT to control lock screen behavior for
the Quick Access Wallet.
Do not provide Intents that will fail to start an Activity.
Update comments.

Bug:155232731
Bug:155186709
Test: manual
Test: atest CtsQuickAccessWalletTestCases

Change-Id: I78e5355a69d666aee6dd122389edabed170f07b2
2020-04-28 17:40:09 -07:00
Adam He
045c020636 Address leftover TODOs from inline suggestions.
Fixes: 146524826
Test: atest android.autofillservice.cts.inline
Change-Id: I50666e9fa012b18f74c20982068a452fdc9592f8
2020-04-28 17:17:47 -07:00
Yifan Hong
325bbcf799 Merge "Update cleanupAppliedPayload comment." into rvc-dev 2020-04-29 00:08:37 +00:00
Suprabh Shukla
7d40780e39 Don't remove OnAlarmListener mappings in the client
Removing the mapping is prone to races in keeping the state consistent
with the server. An inconsistent state can lead to multiple alarms on
the server for the same listener.

Test: atest CtsJobSchedulerTestCases doesn't fill the alarm queue with
more than one alarm.
atest CtsAlarmManagerTestCases

Bug: 154444435
Change-Id: Iaf11d5decb17fbf2366b49d9865231bf65dbdc41
2020-04-28 15:37:21 -07:00
Michael Groover
09c24c3c4f Resolve IndexOOBException in SigningDetails#hasAncestor
When a package that is part of a shareduid is installed / updated its
lineage is compared against the current signature / lineage for the
shareduid. If the new package has more than one signature in the lineage
an IndexOutOfBoundsException is thrown by SigningDetails#hasAncestor
crashing the system server. This commit ensures the ancestor check
is only performed against the current signer for the shareduid.

Fixes: 155134046
Test: atest SigningDetailsTest
Change-Id: Icef9f21c6901e255e5276085259d2f773f41e858
2020-04-28 15:08:20 -07:00
Yifan Hong
524d0f5c28 Update cleanupAppliedPayload comment.
ServiceSpecificException might be thrown, but it is not
actionable by the caller. Hence hide the comment.

Fixes: 151156841
Test: none
Change-Id: I07836fe2c5cc361fa81f6fc24851ad2b0721591b
(cherry picked from commit d3abb6d385)
Merged-In: I07836fe2c5cc361fa81f6fc24851ad2b0721591b
2020-04-28 14:41:50 -07:00
TreeHugger Robot
48f0527199 Merge "Close heap dump ParcelFileDescriptor." into rvc-dev 2020-04-28 20:52:29 +00:00
Hai Zhang
a39cf78c63 Add RoleControllerManagerTest.
Fixes: 155119713
Test: atest RoleControllerManagerTest
Change-Id: If90ba60cccbe1589365142a06d917a87b7a092ef
2020-04-28 12:14:01 -07:00
Evan Rosky
e067ddfc05 Shift Primary stack as well as secondary during ime adjustment
Previously, was only 'adjusting' the secondary split for
ime. So the secondary had functional insets and drag/drop.
However, the primary wasn't being adjusted (accorcding to
WM). This caused its insets to be calculated against its
originla position (which allowed ime insets to potentially
overlap it) and it meant that WM didn't use its visual
position when calculating drag/drop coordinates.

So, this does the same with the primary stack as what was
done with secondary.

However, doing this required some other fixes in WM. Basically,
if appbounds is explicitly overridden, just use them instead of
intersecting with parent. Also, WSA doesn't apply crop for
splits (maybe it shouldn't apply crop to anything anymore).

Additionally, insets calculation was applying top insets to the
bottom if the inset frame's top wasn't exactly equal to the
window's top -- because of a catch-all else condition. So this
adds checks for matching the bottoms as well.

Bug: 154056542
Bug: 151862790
Test: Open two apps in split screen and open IME in secondary. Drag
      from secondary to primary.
Change-Id: I2391783e726e4a1c8ed3150628af2f398218fe90
2020-04-28 11:59:22 -07:00
Julia Reynolds
49467eebac Update logging
Priority isn't used; shortcut is

Test: manual
Bug: 149651274
Change-Id: If6577c5588afe5e48787ae7e6bc528442fdb3423
2020-04-28 14:50:01 +00:00
Julia Reynolds
8582df5cc7 Add experience for shortcut-less convos
- no conversation specific controls
- no 'bubble this' button
- turn off interim placeholder channels
- fix msg tracking - only shortcut-less notifs matter

Test: atest
Bug: 154814754
Change-Id: Ia04ce496d4e7b2f353c71865f338b5229192c395
2020-04-28 12:11:47 +00:00
TreeHugger Robot
f6288ea881 Merge "Enforce permission check in getUidStats function" into rvc-dev 2020-04-28 09:13:32 +00:00
Alex Johnston
a077a8a0cc Merge "Update setOrganizationColor javadoc" into rvc-dev 2020-04-28 08:36:57 +00:00
Chris Li
9859a326c1 Merge "Cache isSystemOrSystemUI on ContextImpl creation" into rvc-dev 2020-04-28 04:02:05 +00:00
TreeHugger Robot
046df72d9a Merge "Revert "Q Upstream: Use ParcelFileDescriptor for storing large clip data."" into rvc-dev 2020-04-28 02:12:12 +00:00
TreeHugger Robot
5e9aed81d0 Merge "Support WRAP_CONTENT in InlineSuggestion#inflate" into rvc-dev 2020-04-27 23:52:59 +00:00
Diego Vela
7383ef7a6c Merge "Fix default constructor for DisplayAdjustments" into rvc-dev 2020-04-27 23:41:45 +00:00
Sally Yuen
f8331a8a91 Merge "Fix system action API issues in SystemActions" into rvc-dev 2020-04-27 23:06:10 +00:00
Feng Cao
bd26abbc5b Support WRAP_CONTENT in InlineSuggestion#inflate
Test: atest android.autofillservice.cts.inline
Bug: 154887895

Change-Id: Ie420bd40e8f0fb7d6e6b1e47ed0f41dc3f85b25e
2020-04-27 15:12:14 -07:00
Evan Rosky
db49a262de Merge "Connect systemwindow root with accessibility" into rvc-dev 2020-04-27 21:52:07 +00:00
Philip P. Moltmann
fa658e0206 Merge "Fix typos in permissions.md" into rvc-dev 2020-04-27 21:18:40 +00:00
sallyyuen
93edd11724 Fix system action API issues in SystemActions
1) Actions are only registered when the service starts. If the locale
changes, the labels need to be translated, so re-register the actions
when this happens.

2) When its shortcut isn't visible the a11y menu action is a no-op. The
list should be an accurate representation of what actions are available.
Pass SystemActions into NavigationBarFragment, which keeps track of the
shortcut availability,  to unregister/register the action.

To do this, SystemActions exposes register/unregister to the fragment
and makes SYSTEM_ACTION_ID_ACCESSIBILITY_MENU public.

3) Remove Toggle Split Screen from SystemActions. The trigger isn't
system-level but is rather buried in the Recents UI in a button for each
app, and the a11y user can access this like everyone else.
SystemActionPerformer will still handle the legacy action call in
performSystemAction.

4) Rename "Accessibility Menu" to "On-screen Accessibility Shortcut"

Bug: 152636060, 152635646, 154833492
Test: Manual TalkBack test
Change-Id: I9b037f91c8d3b6f193fc9aee95ef73b7f3fbf315
2020-04-27 13:05:57 -07:00
Robert Carr
ae8e0aea36 BLAST: Avoid JNI call on creation
JNI calls aren't free and we don't need to burn one
to call update with the values we just passed in.

Bug: 152501005
Test: Existing tests pass
Change-Id: Iaf272edb03d4ec195b75e9ef7e6c122604025dcb
2020-04-27 12:54:11 -07:00
Mehdi Alizadeh
082d0c47b7 Merge "Adds unit tests for ShortcutChangeCallback APIs" into rvc-dev 2020-04-27 19:34:25 +00:00
Chavi Weingarten
5d2781b772 Merge "Added takeScreenshot API to WindowOrganizer" into rvc-dev 2020-04-27 18:59:49 +00:00
Kweku Adams
f1ddecc60e Close heap dump ParcelFileDescriptor.
The file descriptor is only closed in certain situations. Explicitly
closing it to ensure we don't have any leaks.

Bug: 154277871
Test: take a system heap dump via developer options & and watch for StrictMode violation
Test: adb shell am dumpheap <system|another app> & and watch for StrictMode violation
Change-Id: I3ae3e270bcec18ba531055becfff32924c8f2a2d
2020-04-27 18:43:09 +00:00
Chris Li
e7f4f30698 Cache isSystemOrSystemUI on ContextImpl creation
When creating Context without a container Context, cache the value of #isSystemOrSystemUI().

Fix: 154161051
Test: atest FrameworksCoreTests:ContextTest
Change-Id: I1d16173c7da06a73d1338e3d6e75f5b56fcdbe23
2020-04-27 11:35:31 -07:00