In the generated javastream and cppsteam incident proto file,
it defines the start position for netstats at 3001 and it doesn't
actually use the NetworkStatsServiceDumpProto which is deinfed in
netstats.proto.
Thus, the framework-connectivity-proto can be removed from
framework-javastream-protos and framework-cppstream-protos.
The generated incident proto file defines netstats as the following,
// optional .android.service.NetworkStatsServiceDumpProto netstats = 3001;
public static final long NETSTATS = 0x0000010b00000bb9L;
Furthermore, on Android side, this is not strictly proto dependency,
and there's no one using this section, so it can be removed and mark
it as reserved.
Bug: 222625935
Test: FrameworksNetTests
atest CtsIncidentHostTestCases:IncidentdTest
adb shell dumpsys netstats
Change-Id: I3083a43a2f9c20768264ce2a531e0a0593f31697
The depfile concept in Soong and Ninja isn't applicable in Bazel because Bazel requires listing the deps explicitly.
This CL removes the uses of depfile property and explictly declare the implicit deps in tool_files. The motivation behind this change is to eventually deprecate depfile (aosp/2120835) in gensrcs to ensure all gensrcs modules are convertable to Bazel.
Test: CI
Test: m framework-cppstream-protos && m framework-javastream-protos
Bug: 179452413
Change-Id: Iec6b61b4194d3f1e728449ee63b879818d9c958a
While dumpProtoLocked is called, InvalidProtocolBufferException
occurred because types are mismatched between platform side and
module side.
netstats.proto was moved into connectivity module, both the
platform(incident.proto) and the module uses protoc-gen-javastream
to generate the Java classes from it. It should be fine since
platform includes the source of the proto, and jarjar the generated
classess in the module to avoid conflict with platform.
Bug: 218566849
Test: adb shell incident 3001
adb shell dumpsys netstats --proto
atest CtsIncidentHostTestCases:IncidentdTest#testIncidentReportDumpAuto
Change-Id: I4654350a59dc1ca1a925785ad37f34aa7b481235
Merged-In: I4654350a59dc1ca1a925785ad37f34aa7b481235
While dumpProtoLocked is called, InvalidProtocolBufferException
occurred because types are mismatched between platform side and
module side.
netstats.proto was moved into connectivity module, both the
platform(incident.proto) and the module uses protoc-gen-javastream
to generate the Java classes from it. It should be fine since
platform includes the source of the proto, and jarjar the generated
classess in the module to avoid conflict with platform.
Bug: 218566849
Test: adb shell incident 3001
adb shell dumpsys netstats --proto
atest CtsIncidentHostTestCases:IncidentdTest#testIncidentReportDumpAuto
Change-Id: I4654350a59dc1ca1a925785ad37f34aa7b481235
Merged-In: I4654350a59dc1ca1a925785ad37f34aa7b481235
Enabled: false is more performant than -XepDisableAllChecks,
as normally the module is built twice, once with and once
without errorprone. Enabled: false will entirely remove
the second build.
Bug: 190944875
Bug: 72714520
Change-Id: Ie393f41a33e59dc4fd36b98ca2fd87f53c0f9785
Test: Presumbits
Move proto messages out of enum/ directory.
Test: make
Bug: b/184754707
Change-Id: Ia240c2608227c34d8caa0fa89d62a00bf2bb6908
Merged-In: Ia240c2608227c34d8caa0fa89d62a00bf2bb6908
The proto build rules are quite large and makes the top-level Android.bp
file difficult to navigate. Move them to a separate file.
Bug: 185128417
Test: m
Change-Id: I5719ba0fa8e03dcfca0cc32dc30db3f87ea4e3cd
