Commit Graph

12472 Commits

Author SHA1 Message Date
TreeHugger Robot
9a5663c787 Merge "Migrate to DeviceConfig in TextClassifier" 2019-03-06 19:51:53 +00:00
Ashley Rose
0be2720c5b Merge "Add @InspectableProperty annotations to LayoutParams" 2019-03-06 18:38:18 +00:00
Adam He
682ea3ccfd Merge changes from topic "aa_whitelist"
* changes:
  Check for empty arguments in setWhitelist().
  Implemented a WhitelistHelper for whitelisting packages/activities for Augmented Autofill and Content Capture.
2019-03-06 18:31:59 +00:00
Peiyong Lin
95378b2cae Merge "[WindowManager] Add PRIVATE_FLAG_COLOR_SPACE_AGNOSTIC." 2019-03-06 01:31:49 +00:00
TreeHugger Robot
380edb9e1e Merge "Resource ID support for view inspector" 2019-03-06 00:57:38 +00:00
Ashley Rose
e8914812c9 Resource ID support for view inspector
This allows for inspectors to do special handling on values known to be
resource IDs, such as converting them to a string format.

+ Add PropertyMapper#mapResourceId(String, int) and
  PropertyReader#readResourceId(int, int)
+ Add RESOURCE_ID to @InspectableProperty.ValueType
+ Add code generation support in the annotation processor, and value
  type inference for accessors annotated with a resource ID annotation
  like @AnyRes.

Bug: 127348933
Test: atest --host view-inspector-annotation-processor-test
Change-Id: I132aea319dcddf51c553057c036ce5609e3c381a
2019-03-05 17:16:14 -05:00
Peiyong Lin
88eb6a20b5 Merge "Add setColorSpaceAgnostic API to SurfaceControl." 2019-03-05 20:18:10 +00:00
Peiyong Lin
7504538985 [WindowManager] Add PRIVATE_FLAG_COLOR_SPACE_AGNOSTIC.
Normally on a phone, there are a bunch of layers that can be considered color
space agnostic, for example NavigationBar and ScreenDecorOverlay*. Previously
we added a SurfaceControl API setColorSpaceAgnostic to allow a surface to tell
SurfaceFlinger it's color space agnostic, this patch adds a private flag in
window manager to allow views to set it via WindowManager.LayoutParams, window
manager will process this private flag and call setColorSpaceAgnostic when it's
changed.

BUG: 126616348
Test: Build, flash and boot. Use UIBench to check WCG behaviour
Change-Id: Iecee6528c86c390c70379bbc05b114c53d0cca48
2019-03-05 09:30:59 -08:00
TreeHugger Robot
b21765f2f3 Merge "WindowInsets: Add system gesture insets" 2019-03-05 15:27:34 +00:00
Tony Mak
fc374578b7 Migrate to DeviceConfig in TextClassifier
ConfigParser is introduced to read the flags from DeviceConfig.
If the flag is missing, fallback to Settings.

Also, adds a new setting key: TEXT_CLASSIFIER_ACTION_MODEL_PARAMS

Test: atest frameworks/base/core/tests/coretests/src/android/view/textclassifier/
Test: adb shell cmd device_config put textclassifier system_textclassifier_enabled  false
      adb shell dumpsys textclassification, observed that the flag is updated.

BUG: 123389900
Change-Id: Icbd26ec7ed223e40b60696d12327cb123b96c4fd
2019-03-05 14:57:53 +00:00
TreeHugger Robot
5c73d2a82d Merge "Refactoring and some fixes around TextClassifierService" 2019-03-05 12:20:38 +00:00
TreeHugger Robot
f57f492b2c Merge "Add some test mappings" 2019-03-05 02:04:37 +00:00
Adam He
8059ab819c Merge "Minor changes on LocusId APIs." 2019-03-05 01:30:07 +00:00
Adam He
6240eab185 Implemented a WhitelistHelper for whitelisting packages/activities for Augmented Autofill and Content Capture.
Fixes: 125348180
Test: atest android.contentcaptureservice.cts.LoginActivityTest
Test: atest android.autofillservice.cts.augmented.AugmentedLoginActivityTest
Test: atest FrameworksCoreTests:com.android.internal.infra.WhitelistHelperTest
Change-Id: I59c32d5a05c9c1ee813395545507fc8eaee47745
2019-03-04 16:15:32 -08:00
John Reck
70ddefc673 Add some test mappings
Test: none
Change-Id: If8b5b51f28669416bcd15ee9df851a263f838802
2019-03-04 15:55:22 -08:00
Felipe Leme
7e7357515f Minor changes on LocusId APIs.
- Uses a String instead of URI for the main id.
- Uses FLAG_IS_PREFIX instead of isRecursive for UserDataRemovalRequest.

Test: m update-api
Test: atest CtsContentCaptureServiceTestCases CtsContentTestCases:LocusIdTest \
            FrameworksCoreTests:android.view.contentcapture.ContentCaptureEventTest
Bug: 126945732

Change-Id: I34ae42678aa4021ea53ed66279cad4049ac2dcb3
2019-03-04 14:02:37 -08:00
Ashley Rose
de3b4a78cd Add @InspectableProperty annotations to LayoutParams
Change-Id: I69eb71bec8bbf36564e178a3ddf4be9e00e2d531
Fix: 126913705
Test: m framework
2019-03-04 16:46:15 -05:00
Peiyong Lin
f4f0f6424b Add setColorSpaceAgnostic API to SurfaceControl.
Some layers, for example ScreenDecorOverlay*, only carry black, white or gray
with some transpanrency, these values are special as they are color space
agnostic. We don't need to do color conversion on them, instead we want to
intercept the color space before we send to hardware composer for validation.
This patch adds an API to allow this to happen, layers that can be considered
color space agnostic can call this API.

BUG: 126616348
Test: Build, flash and boot. Verify by calling in Letterbox.
Change-Id: I2e1384865bbae6c1bca5ab55962af6a4d529d81d
2019-03-04 12:30:46 -08:00
TreeHugger Robot
b5766bd50a Merge "Support for @InspectableProperty on public fields" 2019-03-04 18:49:35 +00:00
Adrian Roos
dd49eb7349 WindowInsets: Add system gesture insets
Bug: 126511573
Test: atest android.view.cts.WindowInsetsTest
Change-Id: I085a20cb49f37d272b882535a97aacd40168281f
2019-03-04 16:01:35 +00:00
lumark
ec75b42179 Add the check for UID presence to Display#hasAccess()
It would be nice if there is a common & reliable method for both outer
& internal modules to check the UID presense of the display.

Add more check in Display#hasAccess() to ask system if calling UID can
precense on the specific display, to consolidate only few special UIDs
& display flag checking.

Bug: 117347985
Test: atest ActivityManagerMultiDisplayTests
Change-Id: I2f8989598c99c0962e925c5aa65500972b4fc62b
2019-03-04 14:59:41 +08:00
Ashley Rose
89d6bce3af Support for @InspectableProperty on public fields
+ Add a field target to @InspectableProperty
+ Refactor PlatformInspectableProcessor to process annotated fields and
  generate InspectionCompanions that read fields.
+ Require that all inspectable getters and fields be public.
+ Make some hidden getters added to View for inspection public.

Test: atest --host view-inspector-annotation-processor-tests
Bug: 126913705
Change-Id: I0c012f42794885f17a397a2e3dd541b3aa4c2634
2019-03-01 19:31:01 -05:00
John Reck
1e2455e13f Merge "More targetted drawFinished fix" 2019-03-01 22:54:25 +00:00
Andrii Kulian
ddecd74c63 Merge changes from topic "wm_decor_status"
* changes:
  Notify the WMS when the display content is ready.
  Read system decor support status from WM
2019-03-01 22:50:28 +00:00
Qasid Sadiq
77f18a962e Merge "Make mIdsToViews thread safe." 2019-03-01 21:52:03 +00:00
John Reck
8cc1f69193 More targetted drawFinished fix
Prior to fe5dfca the frameCompleteCallback
was posted to the native Looper, which is
effectively a postAtFrontOfQueue. Since it
was switched to the Java-side looper, do
an explicit postAtFrontOfQueue

Fixes: 124801988
Test: speculative
Change-Id: I287c9f3917983503402dcfe3ee7d494eefae8d1f
2019-03-01 09:09:34 -08:00
Jeff Sharkey
a09312df67 Merge "All Parcelable CREATOR fields are @NonNull." 2019-03-01 14:58:28 +00:00
Issei Suzuki
ea5e754c37 Merge "Add comment to clarify use case of the new constructors." 2019-03-01 11:02:05 +00:00
TreeHugger Robot
023183101c Merge "Add null checks for attribute getters in View." 2019-03-01 06:35:17 +00:00
Jeff Sharkey
9e8f83db6d All Parcelable CREATOR fields are @NonNull.
If they were null, then the Parcelable would fail to work.

Bug: 126726802
Test: manual
Change-Id: I7929ffa2f20e5de1c8e68e8263cca99496e9d014
Exempt-From-Owner-Approval: Trivial API annotations
2019-02-28 23:29:04 -07:00
Qasid Sadiq
3d8f117bfc Merge "Revert "Revert "Fix a11y cache correctness bug""" 2019-03-01 02:25:26 +00:00
Felipe Leme
50a8c75b49 Merge "Autofill, Content Capture, and Augmented Autofill API fixes:" 2019-03-01 02:04:30 +00:00
Aurimas Liutikas
1196c0d376 Add null checks for attribute getters in View.
If the getter calls are made View#saveAttributeDataForStyleable
this might lead to null pointer exception. Add checks to prevent
that.

Test: None
Bug: 126780975
Change-Id: I3e27d6073b65367010bc9d5b002cf9791d434a72
2019-02-28 17:22:36 -08:00
Qasid Ahmad Sadiq
b2499c55a9 Revert "Revert "Fix a11y cache correctness bug""
This reverts commit 4d70022b88.
This is so certain tests start passing again. The revert was a low risk
measure for the security update.
We still need to address the crash that this introduces

Test: It builds
2019-02-28 14:35:45 -08:00
Adam Powell
b10113347d Merge "System gesture exclusion rects for Views" 2019-02-28 21:11:59 +00:00
Lucas Dupin
f2b2f3fc9d Merge "Add rounded corners attribute to window animations" 2019-02-28 20:46:06 +00:00
Aurimas Liutikas
21e8a2ff6a Merge "Remove unused method and constant in View" 2019-02-28 20:41:07 +00:00
Felipe Leme
ce6877b0e4 Autofill, Content Capture, and Augmented Autofill API fixes:
- Added @Nullable / @NonNull on some returned values.
- Removed APIs that won't be implemented for Q.
- Made Builders final.

Test: m update-api

Bug: 123100695
Fixes: 126702168
Fixes: 126701052
Fixes: 126702191
Fixes: 126700602
Fixes: 126700135
Fixes: 126700413
Fixes: 126698817
Fixes: 126698792

Change-Id: I20710537c02051361da18370bc5cc642cc3c26e1
2019-02-28 09:25:12 -08:00
Andrei-Valentin Onea
37b7e5846f Merge "Add @UnsupportedAppUsage annotations" 2019-02-28 13:07:02 +00:00
Lucas Dupin
3e1dc20ff9 Add rounded corners attribute to window animations
Windows now can have rounded corners that match the display shape,
this CL introduces a new xml attribute called hasRoundedCorners that
enables this feature when declared on an animation xml.

Bug: 111514493
Test: winscope
Test: atest WindowAnimationSpecTest
Change-Id: Ie7651bab00c6e9e0ab7ab50cdb14142c8b2b954b
2019-02-27 19:02:26 -08:00
Qasid Ahmad Sadiq
1aa9da4250 Make mIdsToViews thread safe.
View calls like "attachedToWindow" and "detachedToWindow" can be called
off of the main thread, on "android.anim" this happens in the system
process for application splash screens.
Let's wrap it with a synchronized block.

Fix: 124110476
Test: The crash is a race condition, so the best I can do is make sure
it generally doesn't crash anything by trying out both normal and
virtual hierarchies in Talkback.

Change-Id: I19f972a97b5ac80917f8dd77ac79bf7e3d5e826c
2019-02-27 18:26:34 -08:00
Andrii Kulian
dd98961be6 Read system decor support status from WM
There is no way to add FLAG_SHOULD_SHOW_SYSTEM_DECORATIONS to
hardware or simulated displays, so wallpaper, IME and nav bar were
not showing up even when desktop mode developer option was enabled.

Bug: 123199549
Bug: 125007644
Bug: 124073468
Bug: 124073384
Test: Enable force desktop mode, reboot, create simulated display
Change-Id: Id6f2f3746407467f20c1f26e735b84653e34625d
2019-02-27 17:58:58 -08:00
Aurimas Liutikas
67a8daf09f Remove unused method and constant in View
Turns out when you have IJ set up a lot of things become
more easy to spot.

sLayoutParamsAlwaysChanged was added in ag/818432, but then
not removed in ag/825933 when the feature was pulled.

transformRect was added in ag/173465 but never actually used.

Test: make -j
Change-Id: I69996a3b5e7526941a0e14158e892267075c29f3
2019-02-27 17:26:53 -08:00
Ady Abraham
42f9a2fbbd SurfaceControl: add getAllowedDisplayConfigs
expose ISurfaceComposer::getAllowedDisplayConfigs to SurfaceControl.

Test: manual test to call getAllowedDisplayConfigs() from SurfaceControl
observe config change.
Bug: 122905403

Change-Id: I0587ac5ed2eb29788c2ce941d9c54ebfd215ddf9
2019-02-27 21:49:24 +00:00
Andrei Onea
f4fb6fb754 Add @UnsupportedAppUsage annotations
For packages:
  android.speech
  android.telephony.mbms.vendor
  android.view
  android.webkit

This is an automatically generated CL. See go/UnsupportedAppUsage
for more details.

Exempted-From-Owner-Approval: Mechanical changes to the codebase
which have been approved by Android API council and announced on
android-eng@

Bug: 110868826
Test: m
Change-Id: Iefe25091fa0fcc0adfe4ff85fe5e3ab3ac9c5f10
2019-02-27 15:42:25 +00:00
Jorim Jaggi
8a4532cf8a Merge "Implement proper lifecycle for WindowInsetsAnimationController" 2019-02-27 13:02:35 +00:00
TreeHugger Robot
2d16430de5 Merge "WindowInsets: Add missing annotations and make Builder final" 2019-02-27 12:46:40 +00:00
Issei Suzuki
8b0e61710d Add comment to clarify use case of the new constructors.
Change-Id: Ide57dc749628c4ebaaf436171a3470c723958b64
Test: N/A (changed comment only)
Bug: 118675827
2019-02-27 13:34:56 +01:00
TreeHugger Robot
1f4f9f6e4b Merge "getScaledMinScalingSpan -> getScaledMinimum..." 2019-02-27 10:44:12 +00:00
TreeHugger Robot
1f24ccf2f6 Merge changes from topic "display_policy"
* changes:
  DisplayEventDispatcher: add DISPLAY_EVENT_CONFIG_CHANGED
  SurfaceControl: add setAllowedDisplayConfigs
2019-02-27 00:01:45 +00:00