Commit Graph

9239 Commits

Author SHA1 Message Date
SongFerngWang
121c969e22 [security] SubscriptionGroup is exposed to unprivileged callers
SubscriptionInfo.mGroupUUID is not cleared in
conditionallyRemoveIdentifiers if the caller only has READ_PHONE_STATE
(based on a check to checkReadPhoneState) and not READ_DEVICE_IDENTIFIERS.
Bug: 181053462
Test: atest SubscriptionManagerTest

Change-Id: Ic2b62523330dc6e2169ad851715c4ab3da3b29cf
Merged-In: Ic2b62523330dc6e2169ad851715c4ab3da3b29cf
2021-05-06 03:47:47 +00:00
Michael Groover
5e35376857 Fix unique identifiers best practices links in device ID API docs
Bug: 168447060
Test: m docs
Change-Id: I483e0cf4915862254461200deb5d3dc7302bafb4
Merged-In: I483e0cf4915862254461200deb5d3dc7302bafb4
(cherry picked from commit 1aef206a3a)
2020-11-21 00:11:46 +00:00
TreeHugger Robot
3fa2d86fd0 Merge "Add additional info to device ID docs in TelephonyManager and Build" into rvc-dev 2020-06-24 16:15:32 +00:00
Michael Groover
e0de018109 Add additional info to device ID docs in TelephonyManager and Build
Android 10 introduced additional restrictions to access persistent
device identifiers. This commit updates the javadocs for
TelephonyManager and Build to provide additional details regarding
the requirements and how to check if these requirements are met.

Fixes: 158471988
Test: m docs -j
Change-Id: I02932a22ecc5b761aa1a92d59d09d31863c34235
2020-06-23 19:52:51 -07:00
Michael Groover
e219b9196f Merge "Update SubInfo docs for ICC ID / num restrictions in API 30" into rvc-dev 2020-06-22 20:58:24 +00:00
Michael Groover
0643914d05 Update SubInfo docs for ICC ID / num restrictions in API 30
In Android 11 access to the ICC ID is guarded behind the same access
restrictions as the SIM serial number; the requirements to access the
device phone number have also changed. This commit updates the docs to
reflect that these changes are active starting from API level 30.

Fixes: 159568585
Test: m docs -j
Change-Id: I5ececac6f8dee5281d8bfc6c62408a18c8b3effa
2020-06-21 18:43:23 -07:00
TreeHugger Robot
6f000e189b Merge "Reset cell broadcast config before enabling all channels" into rvc-dev 2020-06-19 22:02:39 +00:00
Jack Yu
88fb45c1a9 Reset cell broadcast config before enabling all channels
Before cell broadcast config service enabling all channels, it
reset all channels that were previously enabled. This will make
sure the full channel config can be pushed down to modem. This
also solved the issue that channel config not sending to modem
when SIM is swapped. Note that a hidden API is added and will
be unhide in the next Android release.

Fix: 155027085
Test: Manual
Merged-In: Id571b990f4e45aea5bbab0dbadce48dda7b2bc56
Change-Id: Id571b990f4e45aea5bbab0dbadce48dda7b2bc56
2020-06-17 15:47:23 -07:00
SongFerngWang
d1b164401e Add a carrier config for WFC's carrier name override by ef_pnn
To override wifi calling's carrier name string using ef_pnn
from sim card.

Bug: 157108864
Test: UE with TMO sim card to test in Roaming and WFC on, and then
check operator name. (PASS)

Change-Id: Id72ce2a9a0fb8f45efa8a975e8052808f726a971
2020-06-17 14:40:52 +08:00
Sooraj Sasindran
06e61f7cd5 Merge "Add hidden API to support allowed networks reason" into rvc-dev 2020-06-13 03:14:37 +00:00
TreeHugger Robot
9ff2625493 Merge "Fixed unreadble debug messages" into rvc-dev 2020-06-13 02:23:16 +00:00
Sooraj Sasindran
7e4cd920e7 Add hidden API to support allowed networks reason
Add hidden API to support allowed networks type for
specific reason like power.

Bug: 156709797
Test: system test
Change-Id: If4424d7d94ac26ad31725a1658dad5751d0d2629
2020-06-12 18:31:37 -07:00
Jack Yu
e7580a7238 Fixed unreadble debug messages
Fix: 158875554
Test: Manual
Change-Id: I8aa45474521e4ef5e2368ab25c6c39445e9f779c
2020-06-12 16:06:47 -07:00
Shuo Qian
6775b77bd5 Change the threshold for RSSNR from 10*db to db
Test: SignalStrengthTest
Bug: 158539126
Change-Id: I9bc4b2f601d7d3f2a32ca34768ecb2a78d59d5bb
2020-06-12 17:39:37 +00:00
Jack Yu
29cb5d5028 Fix unreadable debug message in cell identity
Fix: 158785766
Test: Manual
Change-Id: Ie9e7fbb88da163fcac3a8e97310f5ce357acbdf5
2020-06-11 15:20:10 -07:00
TreeHugger Robot
a4d247cfbf Merge "Update UL values for NR" into rvc-dev 2020-06-05 19:55:07 +00:00
Sarah Chin
6963421dfe Update UL values for NR
Test: build
Bug: 158218596
Change-Id: I2d548711c5de9683b57dc7bbeea9379d23b18343
2020-06-04 11:29:21 -07:00
Jack Yu
059be24240 Store ETWS primary information in the database
ETWS primary/secondary flag needs to be saved in the
database in order to perform duplicate check later. Used the
hardcoded database column name because Android R API freezes.
Will remove the hardcode in the next Android release.

Fix: 157699377
Test: CtsTelephonyTestCases & CellBroadcastServiceTests
Change-Id: Iedec92a1f435f60ceb9f36637a1718adbbd7e2ae
2020-06-03 21:18:54 +00:00
Brad Ebinger
0093603809 Merge "Remove IllegalArgumentException for registration of capabilities" into rvc-dev 2020-05-27 18:10:51 +00:00
TreeHugger Robot
505380e42c Merge "Remove spammy log line." into rvc-dev 2020-05-27 03:01:09 +00:00
Amit Mahajan
5c5635ac7d Remove spammy log line.
Test: TH
Bug: 157172358
Change-Id: Ib76bd317bdd21ef6c1272d38f102f8e40b66d9b8
2020-05-26 14:51:21 -07:00
Allen Su
07fd727050 Merge "[KDDI] Define carrier config for call forwarding items" into rvc-dev 2020-05-25 02:54:22 +00:00
Brad Ebinger
ffb93e5dd6 Remove IllegalArgumentException for registration of capabilities
We threw an IllegalArgumentException for an invalid subscription,
however this is counter to what this exception should be used for.
Instead, use ImsException#CODE_ERROR_INVALID_SUBSCRIPTION.

Also fixed incorrect ImsException sent when telephony crashed.

Bug: 156402275
Test: atest FrameworksTelephonyTests; CtsTelephonyTestCases; manual
Change-Id: I3250419a2438afb58922ae653e3f2e4f9628e593
2020-05-21 16:41:01 -07:00
Brad Ebinger
0b35eb55a8 Merge "Fix MmTelFeatureConnection Memory Leak" into rvc-dev 2020-05-20 19:07:49 +00:00
allenwtsu
6206afc8c1 [KDDI] Define carrier config for call forwarding items
Test: build pass
Bug: 149274975
Change-Id: Ie49ca51497e8f0d9f16d14cc183311dcd02d8bbb
2020-05-19 23:06:33 +08:00
Brad Ebinger
64e101323b Fix MmTelFeatureConnection Memory Leak
In FeatureConnection, we never cleaned up the ImsFeatureStatusCallback
after it was destroyed, leaving zombie FeatureConnections around.

Bug: 156893040
Test: atest FrameworksTelephonyTests
Change-Id: Idcf8b558c3807a3f9f5094afee532e76ea6f02cb
2020-05-18 17:46:06 -07:00
TreeHugger Robot
b8ec05c9f0 Merge "Fix UCE docs" into rvc-dev 2020-05-18 23:04:41 +00:00
Hunter Knepshield
7eeed0981e Merge "Reapply aosp/970247 to fix SubInfo#toString." into rvc-dev 2020-05-18 22:30:16 +00:00
Hunter Knepshield
e23886b901 Reapply aosp/970247 to fix SubInfo#toString.
Looks like somewhere along the line this was partially overwritten by
another change. This makes the toString value consistent and stops the
MNC field from running into the country ISO code.

Test: compilation (trivial)
Change-Id: Ifdc00d340ae8ce31c224decebdd6c7aa4230bdb7
Bug: 8675309
2020-05-18 22:29:59 +00:00
Brad Ebinger
1735254a44 Fix UCE docs
Clarify some of the docs for UCE Intent.

Fixes: 156114453
test: docs only
Change-Id: I01617d0741055e347e05bdbd5eb5a6825f896e73
2020-05-18 21:22:26 +00:00
Sarah Chin
a718624635 Merge "Create carrier config for NR enabled setting" into rvc-dev 2020-05-15 18:47:12 +00:00
Sarah Chin
39c87c67d8 Create carrier config for NR enabled setting
Test: build
Bug: 155915216
Change-Id: Ib81bb6b1712fcf53723df04f162c50a89c96e04d
2020-05-13 23:44:12 -07:00
Calvin Pan
4bf8746b40 Merge "Update getSimCarrierId() document" into rvc-dev 2020-05-14 01:59:25 +00:00
calvinpan
18d70ab7b0 Update getSimCarrierId() document
Carrier_list.pb move to latest_carrierid/ folder, so update the
description.

Bug: 155254987
Test: Build pass
Change-Id: Iacf1bfe68fa86194e8b75cbfce9aa37c0abfbca3
2020-05-13 12:11:33 +08:00
Brad Ebinger
3e79d2dcf9 Merge "Do not throw RemoteException for notifyUserActivity" into rvc-dev 2020-05-11 20:35:00 +00:00
Shuo Qian
95ff60f2fd Merge "Modify the default values to avoid 2 DB hysteresis DB limitation" into rvc-dev 2020-05-11 20:22:13 +00:00
Brad Ebinger
c02f414712 Do not throw RemoteException for notifyUserActivity
PowerManager does not rely on TelephonyManager#notifyUserActivity
to complete successfully since it is a oneway notification. If it
fails, due to telephony not being alive, do not throw a
RemoteException.

Bug: 156203930
Test: manual
Change-Id: I4c788fef5a887c45dbc3a20b7c8af40beed8d00a
2020-05-11 11:12:36 -07:00
Rambo Wang
8a41bbf466 LTE+ indicator not shown when attached to CA network
NetworkTypeController (or DcTracker in aosp/master) will set lte
display type to LTE_CA when current ServiceState fulfills one of the
following conditions:
- getDataNetworkType return NETWORK_TYPE_LTE_CA
- isUsingCarrierAggregation return true

NetworkRegistrationInfo#getAccessNetworkTechnology() always returns LTE
when data rat is LTE CA. So the first condition will never get
fulfilled.

isUsingCarrierAggregation flag will only get updated when
ServiceStateTracker calls RatRatcheter.ratchet without location change.
This makes isUsingCarrierAggregation flag not always reliable to
determine if carrier aggregation is on.

The CL fix the issue by changing ServiceState#isUsingCarrierAggregation
to return true when ServiceState#getCellBandwidths return more than one.
The same condition is already used by RatRatcheter when set
isUsingCarrierAggregation flag in RatRatcheter#ratchet.

Bug: 154060784
Test: atest com.android.internal.telephony.ServiceStateTest
Test: atest android.telephony.cts.ServiceStateTest
Change-Id: Ie6c07cb58d2a40eeb10e8f0131c98212ba463517
2020-05-09 00:32:30 +00:00
Collin Fijalkovich
a131a0c64f Merge changes from topic "rvc-telephony-caching" into rvc-dev
* changes:
  Cache getPhoneId and getSlotIndex binder calls.
  Refactor SubscriptionManager caching code
  Cache getDefaultSmsSubscriptionId Binder calls
  Cache getActiveDataSubscriptionId Binder calls
2020-05-05 16:30:39 +00:00
Andrew Sapperstein
8fe35e5f21 Fix broken @see tags in public documentation.
These were previously being suppressed by doclava but with this change,
all failures are fixed and the suppression logic has been removed.

To fix the issues, there were a few possible changes made:
- broken reference to a public API (such as incorrect parameters): fixed
- unnecessary @link inside an @see tag: fixed
- @see referring to an @hide or @SystemApi: reference removed
- broken references to inner class constructors
 - worked around by fully qualifying the constructor

Bug: 6963924
Test: make doc-comment-check-docs
Exempt-From-Owner-Approval: cherry-picked from master
Change-Id: Ifbdce2de96cdffa560bd90f549fa7184d1f9af85
Merged-In: Ifbdce2de96cdffa560bd90f549fa7184d1f9af85
(cherry picked from commit e0624c7a40)
2020-05-01 18:25:32 +00:00
Shuo Qian
66c51cda97 Modify the default values to avoid 2 DB hysteresis DB limitation
Test: Treehugger
Bug: 155026280
Change-Id: Ic1af774b28629c7ab0e105f6ce198bfce8d160a8
2020-05-01 07:47:51 +00:00
Sarah Chin
6be7d4c5fb Merge "Add legacy state to 5g timer configs" into rvc-dev 2020-04-29 22:18:04 +00:00
Sarah Chin
4ab6a9e9e1 Add legacy state to 5g timer configs
Test: manual testing
Bug: 154186364
Change-Id: Iaf89f4ef9dfcea244033237f74818ab67e104b92
2020-04-29 11:23:05 -07:00
Collin Fijalkovich
41f94629c9 Cache getPhoneId and getSlotIndex binder calls.
Use PropertyInvalidatedCache to avoid redundant calls to
SubscriptionController getSlotIndex and getPhoneId.
Bug: 151953109
Test: Verified cache operated correctly when phone process is killed.
Test: atest SubscriptionControllerTest
Test: atest android.telephony.cts.SubscriptionManagerTest

Change-Id: I70552537af44f3e05b156cd190ebb28f0d940bf6
2020-04-28 16:30:40 -07:00
Hall Liu
29b1874ffc Refactor SubscriptionManager caching code
Create a genericized class to use for SubscriptionManager caching calls
in order to avoid duplicating logic that fetches values from ISub.

Bug: 151953109
Test: atest android.telephony.cts.SubscriptionManagerTest

Merged-In: I6682ded8aec8cb3e50521584c177df6d5dae8c49
Change-Id: I6682ded8aec8cb3e50521584c177df6d5dae8c49
2020-04-28 16:22:48 -07:00
Collin Fijalkovich
02e5c590c3 Cache getDefaultSmsSubscriptionId Binder calls
Use PropertyInvalidatedCache to avoid redundant
calls to SubscriptionController.getDefaultSmsSubscriptionId.
Bug: 151953109
Test: Verified cache operated correctly when phone process is killed.
Test: atest SubscriptionControllerTest
Test: atest android.telephony.cts.SubscriptionManagerTest

Merged-In: Iadb6a42b256013021903f75ed72bb5f046bfa2cc
Change-Id: Iadb6a42b256013021903f75ed72bb5f046bfa2cc
2020-04-28 16:22:28 -07:00
Malcolm Chen
9993fd6bff Add two ServiceState APIs back to @Unsupported list.
It was removed from boot-image-profile when we tried to expose them
for mainlining. Now it's @hide again, so we should add it back
into boot-image-profile otherwise it will break appss.

Bug: 153825725
Test: build
Change-Id: I7dcce69d3d2b3b2601f98817a4ee4467f7efb47a
2020-04-28 16:14:01 -07:00
Collin Fijalkovich
7d7ce5135c Cache getActiveDataSubscriptionId Binder calls
Use PropertyInvalidatedCache to avoid redundant
calls to SubscriptionController.getActiveDataSubscriptionId.
Bug: 151953109
Test: Verified cache operated correctly when phone process is killed.
Test: atest SubscriptionControllerTest
Test: atest android.telephony.cts.SubscriptionManagerTest

Merged-In: I45d1abf15e4b105c966d4a786a4dc33aa67b20aa
Change-Id: I45d1abf15e4b105c966d4a786a4dc33aa67b20aa
2020-04-28 16:03:59 -07:00
Brad Ebinger
3faad57604 Merge "Fix possible deadlock in incoming call" into rvc-dev 2020-04-28 18:05:08 +00:00
Sarah Chin
5227e8441d Merge changes from topics "displayinfocontroller", "remove_displayinfo" into rvc-dev
* changes:
  Remove constants for DisplayInfo logic from DcTracker
  Add carrier configs for 5G timer requirements
2020-04-28 16:48:19 +00:00