If newer smartspace content is not enabled, the title alignment and
burn-in placement of legacy smartspace is incorrect. Align to the
start.
Fixes: 210090859
Test: manual, play music and disable new smartspace
Change-Id: Id038290100b9bc254d6060cb163b0fe772518018
If smartspace, the large clock would overlap with UDFPS content. Make
sure the negative margin gets applied in all cases. Make slight
adjustments to the margin.
Bug: 209864593
Test: manual, oriole + all display sizes
Change-Id: Ibacdc777a8a1d6bcf9324cc12871fc6662a3d5c4
Adds animation that animates AOD content
from left to right when folding a foldable
device.
There are still a couple of issue that should be
addressed in the follow up CLs:
* Navigation bar handle sometimes displayed on AOD
* Showing keyguard when folding from unlocked state
sometimes takes too much time so the screen blocker
times out which leads to flickering
Bug: 202844967
Test: fold from lockscreen, fold from unlocked device,
aod enabled/disabled, gesture nav enabled/disabled
Test: screen off animation when unlocked
Test: screen off animation when locked
Test: screen off animation when timed out
Test: fingerprint unlock from aod
Change-Id: Ie44f82119ac770ce34faecc60402044d4109dddf
Big clock was not centered vertically properly in case we don't support smartspace on the device. When smartspace is not present big clock's height is wrap_content and that makes it (and all parent views) takes much less space. Then even though clock might be centered in parent, parent is not centered on the screen so it doesn't change much.
This change is making it always go match_parent, that is (more or less) full height of the screen.
Fixes: 209013448
Test: manual
Change-Id: I721b5750ae34d204c6eb0bdb7edca6aa12e3a88b
This setting allows users to always show a single-line format clock,
regardless of notification status.
Fixes: 194905512
Test: atest KeyguardClockSwitchControllerTest
Change-Id: I77269988447fc5732ff6b8774654ce4bf9c026de
This setting allows users to always show a single-line format clock,
regardless of notification status.
Fixes: 194905512
Test: atest KeyguardClockSwitchControllerTest
Change-Id: I77269988447fc5732ff6b8774654ce4bf9c026de
Also make sure they are removed properly when the view becomes
detached.
Fixes: 203257107
Test: atest KeyguardClockSwitchControllerTest
Change-Id: Ied4d4e7774d15af71648b188ac723c9c7635f506
Support a mode where icons are visible on AOD with the large
clock. This means shifting both smartspace and icons when switching
between large/small clocks.
Also: Continue to remove old keyguard flag
Also: Add a couple logs for smartspace, let
LockscreenSmartspaceController handle disconnect directly
Fixes: 201548040
Test: atest KeyguardClockSwitchControllerTest KeyguardSliceViewTest KeyguardUpdateMonitorTest KeyguardStatusViewControllerTest
Change-Id: I3697aea0c1a8083e87d446d082d95aab573af83a
Else, the clock may animate in at the wrong font weight.
Test: atest AnimatableClockControllerTest
Test: manually swipe away all notifications on LS,
see the large clock animate in at full font weight
Fixes: 201615075
Change-Id: I139e5a5c88551f23f99decff3e7ffc8bdaa5bba4
* update the UDFPS icon burn-in parameters to be in pixels
because we don't want display density to increase the
position movement
* when the clock is centered aligned, we want to make sure
it doesn't overlap with the udfps icon
Test: atest SystemUITests, manually update clock times with
with DozeUi.BURN_IN_TESTING_ENABLED enabled and see clock
doesn't interfere with the UDFPS icon.
Fixes: 192423460
Change-Id: I6f95fe3ad763971b804129b517f4c98192ab3674
Merged-In: I6f95fe3ad763971b804129b517f4c98192ab3674
* update the UDFPS icon burn-in parameters to be in pixels
because we don't want display density to increase the
position movement
* when the clock is centered aligned, we want to make sure
it doesn't overlap with the udfps icon
Test: atest SystemUITests, manually update clock times with
with DozeUi.BURN_IN_TESTING_ENABLED enabled and see clock
doesn't interfere with the UDFPS icon.
Fixes: 192423460
Change-Id: I6f95fe3ad763971b804129b517f4c98192ab3674
Previously, a singleton view was reused in multiple places. However,
this does not work when multiple displays are in use, such as when
casting the device display to another screen. Supports sets of views
that are activated when they are attached to windows, and removed when
they are detached.
Fixes: 196175396
Test: atest LockscreenSmartspaceControllerTest
Change-Id: Ied1ecff9103d8539f075785409d2951a1be21ab2
When casting or on other displays, the keyguard has always limited the
information shown when locked. Don't show the smartspace and icons on
these alternate displays
Fixes: 196175396
Test: manual (cast to nest display device)
Change-Id: Ied1ecff9103d8539f075785409d2951a1be21ab2
There is a new view managed by ConstraintLayout guidelines that serves as container for smartspace and is placed on the right.
It's visible only in split shade and then it contains Smartspace. Smartspace view is switching between the default (current) view container and the new split shade container.
Switching Smartspace view and visibility of its containers is managed by LockscreenSmartspaceController.
Bug: 193654214
Test: KeyguardClockSwitchControllerTest, LockscreenSmartspaceControllerTest, KeyguardClockPositionAlgorithmTest
Change-Id: I1afcdf7f3c750c36b995f1d6fd9d4393eee8cbef
Merged-In: I1afcdf7f3c750c36b995f1d6fd9d4393eee8cbef
Use old date format for the single line clock, so that we now
support (for single line clock) different clock representations.
For example, French Canadian uses an h instead of a colon
(13 h 01 instead of 13:01).
Test: manual
Bug: 186726401
Fixes: 191761465
Change-Id: If97a49780029f24dc99625a310729630b69e7a68
- Better position the large clock to support various display
sizes. Specs call for centering minus a slight adjustment vertically.
- Make sure notifications don't run into the indication area. The
prior padding was too small.
- Ensure a smooth transition between lockscreen and bouncer
- Fix the smartspace with large clock to not interfere with the dock
settings icon
Fixes: 190047134
Test: manual (all display sizes)
Change-Id: I89e35eef35dc1d3d609b381f768779226962585f
Reduce spacing between smartspace and notification area. Remove
concept of 'expanded clock position' from
KeyguardClockPositionAlgorithm, as it was only used when content was
vertically centered. Similarly, remove difference between
bypass/non-bypass height as the two layouts now match.
Fixes: 183008450
Fixes: 190831603
Test: atest KeyguardClockPositionAlgorithmTest
Change-Id: Ie274e34eb61a876166c11e4f4fa3b9d95ef49888
Big clock should be always visible on the left side of the lockscreen
in split shade mode, regardless of the number of notifications.
Bug: 190702873
Test: KeyguardClockSwitchTest and NotificationPanelViewTest
Change-Id: I7c4bb9684533f278f2014cf6fdf1b1b3f2e04515
Remove the concept of a 'preferred clock y'... not in use
anymore. Existing algo tests were designed around everything being
centered on the screen and isn't relevant. Update to reflect
everything being top-aligned.
Fixes: 190849712
Test: atest KeyguardClockPositionAlgorithmTest
Change-Id: I0a5fafb5ec36ffe6f98fdc6a44e46a65c821cc0c
When notified of a change in format or a change in user, issue a call
to update the time for both large/small clock.
Fixes: 189900109
Test: atest KeyguardStatusViewControllerTest
Change-Id: I5ccb55e74d26715fc5358bf9dcd95ff9257395bd
Smartspace shared element transitions are interferring with normal
clock operation. Remove the offending lines until a proper fix can be
put in
Fixes: 189534613
Test: manual
Change-Id: Ib4678c1405dff722e57048885d8c3c5fb878c954
Update spacing, specifically to match the end padding for the
smartspace container. Reduce padding for the icon shelf to match
incoming changes for smartspace
Bug: 189363380
Test: manual
Change-Id: I82030e21cd5b77424b30dc3c634d01c73beac148
To see this in action, enable the remote animation (adb shell setprop persist.wm.enable_remote_keyguard_animation 1) and enhanced SmartSpace (adb shell device_config put launcher ENABLE_SMARTSPACE_ENHANCED true). Also, set your lock mode to swipe or some sort of non-bypass biometrics, so you can swipe to unlock.
KIs:
- It looks pretty janky on a fast swipe - this is the same root cause as b/186847064 so will have the same fix
- Launcher animates in with window-level animations (Launcher team is looking into helping)
- Screen off animation is not yet implemented (this is for unlock only)
Bug: 187025480
Test: unlock with every possible permutation of lock settings
Change-Id: I8c186fe57132ebc9a0bc5e3d8785e753e72c3bf2
This is needed so that calendar and other time based updates are still received when in doze mode.
Bug: 187186900
Test: KeyguardClockSwitchControllerTest, manually on device
Change-Id: I2667b722fbde219063c719296de35946f536473b
Update AnimatableClockController's definition of attached to include
whether the keyguard is visible or not. This way, we won't animate
if the view isn't actually visible & we'll reset the clock state when
the keyguard is newly visible.
Only create a new AnimatableClockController onInit instead of
in the onAttach method for KeyguardClockSwitchController.
Fixes: 188203771
Test: manual
Change-Id: Id02132dba8b5392046cb46766aa64fd58e04a4ad
When the large clock appears, move smartspace up to take the place of
the small clock. Reverse that when notifications appear and the small
clock shows up. Animate the large clock weight on appear.
Fixes: 185301988
Test: manual (swipe away notifications)
Change-Id: Ic293cebad4e7a5311c024a4d9cdc7b206689fde7
Spins off the logic for manging the smartspace view into
LockscreenSmartspaceController. In addition to just cleaning things up,
this allows us to expose the current contents of the smartspace to any
listeners that might be interested (there's an interested listener in
the following CL).
Bug: 186481467
Test: atest
Change-Id: I117afdc984215128ec47dfd3190d1685757c0f69
The KeyguardClockSwitchController will already be recreated on a user
switch. This was adding a 2nd call, and then attempting reload
smartspace on a detached view.
Fixes: 187467770
Test: atest KeyguardClockSwitchControllerTest
Change-Id: I1f153c029481fe4915d42f7334cbb9534f89a42b
Add support for systemui to inform smartspace about do not disturb
settings. Address some minor spacing issues. Fix how smartspace loads
through dagger.
Fixes: 185970916
Test: atest KeyguardClockSwitchControllerTest
Change-Id: Id19244ceb45fb70a28d780fa5edefab35a5e42c4
For both the current user and any managed profiles, check to see if
sensitive smartspace content should be filtered out, based on the user
settings.
Bug: 183401939
Test: atest KeyguardClockSwitchControllerTest
Change-Id: I5de56b1e3229629864304853c26dc45c98ef0114
Also integrate the FalsingManager, which is important for determining
user intent while on the lockscreen.
Fixes: 186219857
Test: atest KeyguardClockSwitchControllerTest
Change-Id: I22108ec2335bd350fbcaf5d5b90dd3b351011767
Pass dozeAmount values to the smartspace library to allow the lib to
make decisions regarding content on both AOD and Lockscreen
Fixes: 185598979
Test: manual, multiple smartspace cards
Change-Id: Ic7bc2ba238b22794a33e6db18c1aae0fa7c96e0b
