Commit Graph

348 Commits

Author SHA1 Message Date
Grace Kloba
5a4fbd6c20 The starting progress for WebView should be 100 as it is
not in the loading state.
2009-09-17 14:20:28 -07:00
Leon Scroggins
d55de40481 Don't scroll the title bar off screen while loading.
Though the user can still manually scroll the title bar
off screen, we do not want it to happen automatically.
When we load a new page, its scroll position can be
set to (0,0).  Make sure that we simply set it to the
top without adding in the title bar's height.  Also,
prevent javascript which attempts to scroll the page
to (0,0) or (0,1) from removing the title bar.

Fixes http://b/issue?id=2113398 and http://b/issue?id=2123079

Change-Id: Ida64d8c94be6744c7b0b4d60af1c229b2cc83673
2009-09-17 15:48:37 -04:00
Grace Kloba
c0c03af15f Fix the zoom center. Now there is a titlebar, the zoom center
needs to be adjusted for it as the user really cares the spot
in the document. We need to pin zoom around that spot.

Fix http://b/issue?id=2126300
2009-09-17 11:56:28 -07:00
Grace Kloba
dfe095a045 Don't change the zoom filter during the zoom animation.
Call another invalidate() to draw with the final filters.
This fixed the problem where the end of the zoom animation
is slow and jagged.

Fix http://b/issue?id=2126523
2009-09-17 11:36:02 -07:00
Android (Google) Code Review
f7c98e8d18 Merge change 25493 into eclair
* changes:
  Wire the rest of MediaPlayer to our implementation of WebCore::MediaPlayerPrivate
2009-09-17 12:52:59 -04:00
Andrei Popescu
290c34ac3a Wire the rest of MediaPlayer to our implementation of WebCore::MediaPlayerPrivate 2009-09-17 17:27:51 +01:00
Android (Google) Code Review
ff22b182a2 Merge change 25401 into eclair
* changes:
  Add a null checking to avoid crash.
2009-09-17 11:23:48 -04:00
Andrei Popescu
64b86a1e8b Poster support on the Java side 2009-09-17 11:23:09 +01:00
Grace Kloba
b641abf677 Add a null checking to avoid crash.
Fix http://b/viewIssue?id=2125276
2009-09-16 17:28:24 -07:00
Leon Scroggins
241403fd19 Update the input method when the selection changes.
Fix http://b/issue?id=2074446

Add in code that is normally called by TextView.onDraw().  Since
drawing does not happen for WebTextView, we need to call it
ourselves.

Change-Id: Icb47f6a58fba6f8b11e2924befc704f26af68d43
2009-09-16 18:32:52 -04:00
Android (Google) Code Review
4295613a0e Merge change 25307 into eclair
* changes:
  Allow touches to change the selection in WebTextView.
2009-09-16 17:49:20 -04:00
Cary Clark
c9e2e661f0 slide the title if the site changes the scroll position
Slide the title away if the scroll is to zero or one, and the
title is partially or fully visible. Set the animation time
to at least SLIDE_TITLE_DURATION, currently set to 300 ms.
2009-09-16 15:22:24 -04:00
Leon Scroggins
7ae34197b0 Allow touches to change the selection in WebTextView.
Fix http://b/issue?id=2019857

If the user has not moved beyond the scaled touch slop, do not
turn it into a scroll, so the user can change the selection.

Change-Id: I1d88691a35ea2da4b03ad713b56331b5c268b757
2009-09-16 14:24:08 -04:00
Android (Google) Code Review
9f28d9008b Merge change 25280 into eclair
* changes:
  Don't scroll on load if titlebar is visible
2009-09-16 13:12:56 -04:00
Cary Clark
5b28c36644 Don't scroll on load if titlebar is visible
If the restore requests a scroll to zero and the titlebar is
partially or fully visible, skip the scroll altogether.

This fixes http://b/issue?id=2123079
2009-09-16 12:52:24 -04:00
Derek Sollenberger
468f067cf4 fixing documentation for PluginStub
Change-Id: I68fd9d0df3d8a5c39ad1de136a116f1b034323af
2009-09-15 21:22:06 -04:00
Derek Sollenberger
0b3a5d6524 First pass at replacing native plugin views with java.
Change-Id: I6d1f45f31210c2353fa348cc37be8d91bcd5e887
2009-09-15 19:33:54 -04:00
Cary Clark
674a844f6d synchronize access to pictureReady, copyContentPicture
Two methods in WebViewCore are called from WebView. The C
underpinnings were synchronized with a mutex, but the Java
shell was not, so under rare cirumstances, the Java side might
delete the native class. Add Java synchronization to
protect against this.

Fixes http://b/issue?id=2121684
2009-09-15 16:29:50 -04:00
Mike Reed
df4cf29715 redraw once more on a touch-up if we've been dragging, so we can redraw in high-quality mode
update dox on BlurMaskFilter
2009-09-15 16:16:05 -04:00
Grace Kloba
04b2868c74 WebView zoom clean up 2009-09-15 10:53:44 -07:00
Cary Clark
db6d939d2b if the cursor and focus don't match, match them on text view clicks
Call nativeMotionUp from touchUpOnTextField to move the
mouse cursor to the text field if necessary before moving
the text caret to the desired position.

Fixes http://b/issue?id=2075647
2009-09-15 13:24:33 -04:00
Cary Clark
df344375a9 compute Y scroll max by scaling only, ignoring title bar height
without this, the max scroll may be a single pixel
2009-09-15 13:24:32 -04:00
Mike Reed
e9e86b8908 special-case coordinate conversion when we are taking content coordinates to be invalidate. We need to
round "out" these, to account for the slop in antialiasing, rather than using the existing routines
that (correctly) round.
2009-09-15 13:14:20 -04:00
Leon Scroggins
74077c8f2e Clear the password field when reloading the current page.
Fixes http://b/issue?id=2119142

Change-Id: I14bfcc6873f295c4d24ef7ee10450fd444dbe82c
2009-09-14 19:06:04 -04:00
Leon Scroggins
d247aadfc4 Bring up the soft keyboard when touching a focused textfield.
Fix for http://b/issue?id=2118333

Change-Id: Ifa540de139b35548dde2b714b628ca1879a605c5
2009-09-14 17:01:28 -04:00
Grace Kloba
dd8174928c Remove trackball double click. Treat each click as a single click. 2009-09-14 13:34:39 -07:00
Cary Clark
298d32e193 Set the minimum fling to the title height.
Dragging and flinging have different minimums for the max Y
value. Allow the fling to have the title height instead of zero
for the minimum max Y so the title can always be removed via
fling.

This fixes http://b/issue?id=2109006
2009-09-14 15:21:14 -04:00
Grace Kloba
b6e164c779 Per suggestion in http://b/issue?id=2062340, update the UNIQUE in the
httpauth table.
2009-09-14 10:47:07 -07:00
Grace Kloba
e621d6ffb9 Use floor to calculate the range to avoid the rounding error triggered
scrollbar. The worst case is that you can never scroll down to the last
pixel. The old special case can cause problem when getViewWidth/Height
have changed which do not match mLastXXSent any more.

Remove FIND_HEIGHT from computeVerticalScrollRange per conversation with Leon.

Change computeMaxScrollY to use computeVerticalScrollRange which matches
how it computes X.

Change onMeasure to use contentToViewDimension() as it has the same logic.
2009-09-11 15:07:25 -07:00
Grace Kloba
d82bc5158c Avoid the rounding error, as Math.round(Math.round(viewWidth * mInvActualScale) * mActualScale) not necessary to be viewWidth, we special case when the content exactly fit in the view case.
Fix http://b/issue?id=2099889
2009-09-09 13:53:02 -07:00
Leon Scroggins
3a6c88c289 Adjust the WebTextView's text size according to density.
Fix for http://b/issue?id=2063143 .  Use TypedValue's
types to set the text size properly for the screen's
density.

Change-Id: I3772035157e2a9a8a2dba00ebddbf967c42bfa99
2009-09-09 15:00:38 -04:00
Andrei Popescu
cf7b5521fc Remove the call to nativeAddJavascriptInterface() from BrowserFrame::addJavascriptInterface() as it causes an intermitent crash. 2009-09-09 17:44:51 +01:00
Grace Kloba
273fecc22a Do not cache POST response as Cache is indexed with url.
mRequestHandle is only set from Network. So we can skip checking whether url is Network url if mRequestHandle is not null.

Fix http://b/issue?id=1980031
2009-09-08 19:24:44 -07:00
Android (Google) Code Review
c3a30a0033 Merge change 24153 into eclair
* changes:
  adding support for webkit plugins to use the java view system
2009-09-08 12:53:17 -07:00
Derek Sollenberger
2c3eb14d43 adding support for webkit plugins to use the java view system
Change-Id: I4fb328e5f30476fe4aa70565bacb969dc97b495d
2009-09-08 15:42:23 -04:00
Android (Google) Code Review
c18e9ed39c Merge change 24161 into eclair
* changes:
  don't fling if there's nowhere to go
2009-09-08 11:29:28 -07:00
Cary Clark
aa7caa6032 don't fling if there's nowhere to go
Add a test to doFling() to return quickly if the fling has
no effect. For simplicity, only test for horizontal or vertical
flings.

The man purpose is to avoid suspending webkit until the fling
animation is complete when the purpose of the touch drag is
to activate a touch event, like a swipe in superpudu.

fixes http://b/issue?id=2052852
2009-09-08 14:15:07 -04:00
Cary Clark
f8d4964e45 default overview mode to false in webkit
Browser defaults overview mode to true in BrowserSettings.java,
but a WebView should default overview mode to false. This permits
applications without zoom interfaces, such as HTMLViewer, to
have the same interface as before.
2009-09-08 13:23:24 -04:00
Derek Sollenberger
377c5c15f8 Revert "Adding classes to enable plugins to use the java view system."
This reverts commit b127dc29bb.
2009-09-08 09:30:47 -04:00
Android (Google) Code Review
67dffd93e0 Merge change 23485 into eclair
* changes:
  Adding classes to enable plugins to use the java view system.
2009-09-08 05:48:06 -07:00
Leon Scroggins
608f9f470f When zooming, do not draw the WebTextView. Resize it when done.
Fix for issue http://b/issue?id=2074429

Change-Id: Iae46df57310a360f07c9d6afef24ca3ff9d04bdc
2009-09-04 17:46:33 -04:00
Leon Scroggins
078c52c57a Clean up from earlier changes to place title bar at top of WebView
Rename addTitleBar to setEmbeddedTitleBar.  This requires a change
to packages/apps/Browser.  Also remove mTitleBar if there already
was one.

In ViewManager, call contentToViewDimension where appropriate.

Change-Id: If4d378fad192990253411924a9a80bee96e63ff2
2009-09-04 17:13:08 -04:00
Grace Kloba
3c72fff035 Some mobile sites, like m.www.yahoo.com, slashdot.org (iPhone version),
have a bigger minPrefWidth than the screen width. So we don't want to force
the minZoomScale to be same as defaultScale. Otherwise we won't be able to
zoom out in these sites.

Fix http://b/issue?id=2090718
2009-09-04 13:29:20 -07:00
Mike Reed
e8853fc570 also expose onDrawHorizontalScrollBar() in View
retool WebView's calculations to correctly compute scrollbar height and parameters
2009-09-04 15:05:27 -04:00
Grace Kloba
e5b6d02f34 Translate the content dimension to the view space before setting them to the view.
Fix http://b/issue?id=2027254
2009-09-04 10:34:14 -07:00
Andrei Popescu
4950b2b695 Fix appcache layout test that was timing out due to race condition in WebView::addJavascriptInterface. 2009-09-03 22:31:55 +01:00
Leon Scroggins
0236e673d8 Attach the title bar to the top of the page.
Remove the old notions of changing the viewing mode
resulting in changing the visibility of the title bar.
Instead, attach the title bar to the top of the page.
Change contentToView() to contentToViewY() (and an X
version; same change for viewToContent), to account
for the title bar's height.  Adjust the parameters
for drawing the scroll bar to account for the title bar.
Requires a change to packages/apps/Browser.

Change-Id: Ic0f7d6e0a1cce58ba2bca87337cf72a8194e9aa4
2009-09-03 14:08:53 -04:00
Steve Block
4afcd2e9d6 Handle security exception when Geolocation registers with system location service in DumpRenderTree. 2009-09-03 12:02:20 +01:00
Android (Google) Code Review
f6ca7fab50 Merge change 23690 into eclair
* changes:
  Prevent a crash when webkit changes the selection.
2009-09-02 16:45:33 -07:00
Leon Scroggins
ef92e7a606 Prevent a crash when webkit changes the selection.
Partial fix for http://b/issue?id=2081673
This prevents a crash.  However, if the user continues typing
into the textfield, the selection is incorrect.  The real solution
(forthcoming), will make sure that the WebTextView's text gets
updated when webkit updates.

Change-Id: Ic832ec48fd4236c8116c5cbda1467677ad731feb
2009-09-02 19:31:33 -04:00