Commit Graph

1423 Commits

Author SHA1 Message Date
Aurimas Liutikas
e701dc1799 Fix broken links in @see tags in framework docs.
doclava was accidentally suppressing all these broken links
in @see tags. This CL fixes issues so we can start enfocing
checks for broken @see links.

Test: make docs
Change-Id: If7830ece85f8d1f27c991eae282230814726e115
Exempt-From-Owner-Approval: Fixing @see javadoc link issues that are currently completely broken
2018-06-04 10:15:22 -07:00
Felipe Leme
21fb1a3385 Merged many autofill session metrics into AUTOFILL_REQUEST:
- AUTOFILL_UI_LATENCY
- AUTOFILL_AUTHENTICATED;
- AUTOFILL_DATASET_AUTHENTICATED
- AUTOFILL_INVALID_AUTHENTICATION
- AUTOFILL_INVALID_DATASET_AUTHENTICATION

At least one AUTOFILL_REQUEST is created on each session; additional ones are
created for each additional request made to the service (which is tracked by
FIELD_AUTOFILL_REQUEST_INDEX).

Also:
- Added TYPE_CLOSE to indicate a timeout waiting for the service response.
- Added FIELD_AUTOFILL_REQUEST_ORDINAL to indicate the order of the request in
  the session.
- Added FIELD_AUTOFILL_NUMBER_REQUESTS on AUTOFILL_SESSION_FINISHED.
- Created an AUTOFILL_FIELD_FLAGS to avoid conflict with FIELD_FLAGS.

Test: atest CtsAutoFillServiceTestCases # to make sure it didn't break anything
Test: manually run some test and watched the result of
      'adb shell logcat -b events | grep sysui', as described below.

1) LoginActivityTest#testAutoFillNoDatasets:

[757,907,758,10,806,android.autofillservice.cts,908,android.autofillservice.cts,909,-1,1454,1]
[757,919,758,4,806,android.autofillservice.cts,908,android.autofillservice.cts,1455,1]

Where 907=AUTOFILL_REQUEST, 919=AUTOFILL_SESSION_FINISHED,
1454=FIELD_AUTOFILL_REQUEST_ORDINAL, 1455=FIELD_AUTOFILL_NUMBER_REQUESTS,
758:10 = TYPE_SUCCESS, 909 = FIELD_AUTOFILL_NUM_DATASETS (-1 == null response)

2) LoginActivityTest#testAutoFillTwoDatasetsSameNumberOfFields:

[757,907,758,10,806,android.autofillservice.cts,908,android.autofillservice.cts,909,2,1145,60,1454,1]

Where 1145=FIELD_AUTOFILL_DURATION (60ms UI latency)

3) LoginActivityTest#testCancellationSignalCalledAfterTimeout:

[757,907,758,2,806,android.autofillservice.cts,908,android.autofillservice.cts,1454,1]

Where 758:2 = TYPE_CLOSE (timeout)

4) LoginActivityTest#testAutofillManuallyOneDataset:

[757,907,758,10,806,android.autofillservice.cts,908,android.autofillservice.cts,909,1,1145,67,1452,1,1454,1]

Where 1452=FIELD_AUTOFILL_FLAGS and 1=FLAG_MANUAL_REQUEST

5) FillEventHistoryTest#testNoEvents_whenServiceReturnsFailure:

[757,907,758,10,806,android.autofillservice.cts,908,android.autofillservice.cts,909,1,1145,48,1454,1]
[757,907,758,11,806,android.autofillservice.cts,908,android.autofillservice.cts,1454,2]
[757,919,758,4,806,android.autofillservice.cts,908,android.autofillservice.cts,1455,2]

Where 758:11 = TYPE_FAILURE

6) AuthenticationTest#testFillResponseAuthJustOneField

[757,907,758,10,806,android.autofillservice.cts,908,android.autofillservice.cts,909,0,1145,91,1453,912,1454,1]

Where 1453:912 is FIELD_AUTOFILL_AUTHENTICATION_STATUS = AUTOFILL_AUTHENTICATED

7) AuthenticationTest#testDatasetAuthTwoDatasets

[757,907,758,10,806,android.autofillservice.cts,908,android.autofillservice.cts,909,2,1145,64,1453,1126,1454,1]

Where 1453:1126 is FIELD_AUTOFILL_AUTHENTICATION_STATUS =
                   AUTOFILL_DATASET_AUTHENTICATED

8) AuthenticationTest#testFillResponseAuthServiceHasNoData
[757,907,758,10,806,android.autofillservice.cts,908,android.autofillservice.cts,909,0,1145,49,1453,1128,1454,1]

Where 1453:1128 is FIELD_AUTOFILL_AUTHENTICATION_STATUS =
                   AUTOFILL_INVALID_AUTHENTICATION

9) VirtualContainerActivityCompatModeTest#testAutofillSync

[757,907,758,10,806,android.autofillservice.cts,908,android.autofillservice.cts,909,1,1145,53,1414,1,1454,1]
[757,919,758,4,806,android.autofillservice.cts,908,android.autofillservice.cts,1414,1,1455,1]

Where 1414 is FIELD_AUTOFILL_COMPAT_MODE

10) FieldsClassificationTest#testHit_manyUserData_manyDetectableFields

[757,907,758,10,806,android.autofillservice.cts,908,android.autofillservice.cts,909,0,1271,2,1454,1]
Where 1271 is FIELD_AUTOFILL_NUM_FIELD_CLASSIFICATION_IDS

11)PartitionedActivityTest#testAutofill4PartitionsMixManualAndAuto

[757,907,758,10,806,android.autofillservice.cts,908,android.autofillservice.cts,909,1,1145,109,1454,1]
[757,907,758,10,806,android.autofillservice.cts,908,android.autofillservice.cts,909,1,1452,1,1454,2]
[757,907,758,10,806,android.autofillservice.cts,908,android.autofillservice.cts,909,1,1454,3]
[757,907,758,10,806,android.autofillservice.cts,908,android.autofillservice.cts,909,1,1452,1,1454,4]
[757,919,758,4,806,android.autofillservice.cts,908,android.autofillservice.cts,1455,4]

Bug: 80093094
Fixes: 80095814

Change-Id: I87424834fc925a3bcba410eec5aa32fcd6253367
(cherry picked from commit 01d82a51670065a683ec67b5c3a7268617a19c1f)
2018-05-24 18:21:31 -07:00
Rohan Shah
c30bf94134 Merge "Add knobs for tweaking blocking helper thresholds" into pi-dev am: 7af8fe3e29
am: 566a00935e

Change-Id: I39b306a0d56b4b9a27db4af098b0b30f75e535c7
2018-05-08 14:32:03 -07:00
Rohan Shah
7af8fe3e29 Merge "Add knobs for tweaking blocking helper thresholds" into pi-dev 2018-05-08 21:00:07 +00:00
android-build-team Robot
dd209c8c1c Merge changes I1539580e,I8452e799 into pi-dev am: 8ea760c815
am: f0013528bc

Change-Id: I662b167e13ed386290dc802988b3225a60a67fc0
2018-05-08 10:57:14 -07:00
Rohan Shah
0350dab5b6 Add knobs for tweaking blocking helper thresholds
Added both blocking helper parameters to Global Settings to allow for
tweaking stats/values. Added listeners for value updates (so that
channels are updated properly with new thresholds).

Bug: 77143005
Test: manually, test cases
Change-Id: Ia5cfb29ca40500a694261bd5e9e60fa1f34e742a
2018-05-08 09:34:38 -07:00
Beverly
4b7853ec5f Check if alarm and now times are in schedule
Bug: 77570224
Bug: 79230399
Test: ScheduleCalendarTest
Change-Id: I8452e799189dab0559b49f1e62b18b7106929cd3
2018-05-08 09:24:59 -04:00
android-build-team Robot
e145f4d7ff Merge "Update dnd defaults for new users" into pi-dev am: 8aec7be10e
am: e799bda2e0

Change-Id: Ia9dff7647091ebdd62738030b888d0d805b043b3
2018-05-04 07:15:02 -07:00
Julia Reynolds
10a7cc1275 Update dnd defaults for new users
Test: flash new device
Change-Id: I83ecf3394724a1efd952c01514272924cd289e34
Fixes: 78778706
2018-05-03 14:09:55 -04:00
Julia Reynolds
61dbd07e19 Change zen defaults for upgrade and new users am: 1f58057118
am: a70b6058ee

Change-Id: I854b3225787b5708e407eaa7ab0bd394178abcbe
2018-05-01 10:57:39 -07:00
Julia Reynolds
1f58057118 Change zen defaults for upgrade and new users
- Upgrade -> migrate suppressScreenOn and suppressScreenOff to
suppressVisualEffects
- New -> all visual effects are off, starred contacts are allowed
to call

Also fixed an NPE noticed while testing this CL

Test: runtest systemui-notification
Change-Id: I1efd6e3f9bc7519b2fb769bae62ffa1aaae59cb6
Fixes: 78778706
Fixes: 78768955
2018-05-01 09:04:38 -04:00
Dake Gu
cc24386a86 Merge "Autofill: new UX for TV and support themes" into pi-dev am: 9ea13ca0b6
am: 1c62e1ef27

Change-Id: Iefa843e82fdc4093b478b2a16ecf407d6a46a888
2018-04-26 10:10:58 -07:00
Dake Gu
36b86c28f8 Autofill: new UX for TV and support themes
1. Define default Themes for autofill window and save dialog.
   (http://go/theme_autofill). Phone uses light themes, TV uses
   dark themes.
2. Apply autofill theme to RemoteViews passed from autofill service.
   So this can make sure the textColor of RemoteViews matches
   the background of autofill theme uses.
   Updated public javadoc that autofill service should not
   hardcode color values.
3. A new TV ux that occupies half screen height (go/autofill-for-tv).
   TV autofill now passes unhandled physical keyevent to app window
   in the same way phone/tablet does.
4. Fixed ATV autofill window to be SYSTEM_DIALOG, so it wont be
   clipped by app activity window (DialogLauncherActivityTest).

Bug: 71720680
Bug: 74072921
Test: CtsAutofillTest

Change-Id: Ib570227b0958b1800e8f0600b8aec36478568d74
2018-04-25 10:49:14 -07:00
Julia Reynolds
4c6bb14007 Merge "GetActiveNotifications should never return null" into pi-dev am: 66dfd01292
am: a643f89ce1

Change-Id: I6ab090f262e819babc334a9c1a41bc1cb4920c2e
2018-04-20 13:54:52 -07:00
Julia Reynolds
94a38b35e9 GetActiveNotifications should never return null
Test: runtest systemui-notification
Change-Id: I53e7a4a2a9f05318dd97ffb096658a4f8bcebc8a
Fixes: 70396956
2018-04-20 14:46:43 -04:00
Felipe Leme
7ea5b41978 Merge changes from topic "revert_save_info" into pi-dev am: 4dddd61fa8
am: 76af91dddb

Change-Id: Ib7e1b48958a5a92dbf5bb10eb3fc58b9baa8f242
2018-04-19 17:17:46 -07:00
Felipe Leme
9c05605f52 Document compatibility mode limitations.
Test: mmm -j108 frameworks/base/:doc-comment-check-docs

Fixes: 77655074

Change-Id: I527d882850442c7e6e9379b1b423673885e07f2b
2018-04-19 15:26:48 -07:00
Felipe Leme
a7f3e9c7cb Revert "Always set FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE on SaveInfo when on compat mode."
Save has many limitations on compat mode, so we better not change the SaveInfo
behavior but rather document then.

This reverts commit 4f74a018c8.

Test: atest CtsAutoFillServiceTestCases:VirtualContainerActivityTest \
CtsAutoFillServiceTestCases:VirtualContainerActivityCompatModeTest

Bug: 77655074

Change-Id: I36bd28ca546dcedefe75de7815b76b8b5827aee3
2018-04-19 15:25:49 -07:00
Beverly Tai
2fe0e01fbf Merge "Don't mute ringer if apps can bypass dnd" into pi-dev am: 39997ea603
am: e4a5044b0f

Change-Id: I45a645c8650211d8cb5016e97762f5a9c48e3cc0
2018-04-19 10:02:33 -07:00
Beverly
86d076f9d3 Don't mute ringer if apps can bypass dnd
Test: atest RankingHelperTest
Change-Id: I587e5b8d4f6cfe3b384c5b4b9e72de12b6639b6f
Fixes: 77729075
2018-04-18 14:10:19 -04:00
Beverly
6b5d563e45 Merge "Don't show ringer status if dnd overrides it" into pi-dev am: a4e8196cf8
am: 3197513e32

Change-Id: Iad0d04f0557c384835595e503c239e1cd28ef2b9
2018-04-13 09:13:25 -07:00
Beverly
b9826dd191 Don't show ringer status if dnd overrides it
If DND is overriding the ringer then:
- Don't show silent/vibrate ringer in status bar
- Don't show silent/vibrate ringer status in QS

Change-Id: I0c921905c6b06e1379b497dd1ac9e3fce483d5fd
Fixes:77651394
Test: manual
2018-04-12 18:02:17 -04:00
Julia Reynolds
19cb0d1af8 Merge "Show onboarding screen from dnd tile" into pi-dev am: b2943a864e
am: fa40267709

Change-Id: Ic764bb701db0e534b0a9b44019cd262e016857f1
2018-04-11 13:19:51 -07:00
Julia Reynolds
b2943a864e Merge "Show onboarding screen from dnd tile" into pi-dev 2018-04-11 19:36:41 +00:00
Chavi Weingarten
2042446a96 Merge "Synchronize stack position and size update for split screen" into pi-dev am: 9553a11557
am: 5826a2a7ad

Change-Id: Ie8a24f3b8ae0c1fa1d9576118b1404e96dfe184c
2018-04-11 11:13:43 -07:00
Chavi Weingarten
9553a11557 Merge "Synchronize stack position and size update for split screen" into pi-dev 2018-04-11 16:53:42 +00:00
Julia Reynolds
c4e5ecf703 Show onboarding screen from dnd tile
Increase the DND version and reset the setting so those who
are upgrading P->P see the new flow.

Test: manual
Change-Id: I9286f022d1fa6520305ff03dbce54c4eec0e371a
Fixes: 77658931
2018-04-11 12:23:05 -04:00
chaviw
be43ac8686 Synchronize stack position and size update for split screen
When entering split screen, the secondary window changes position so
it's below the primary split screen when minimized. The WSA at the same
time is also changing size to fit the area. However, the size doesn't
change until the client requests a new size and a frame with the correct
size comes in. This causes the stack to update position before the
resize which causes content to get cut off and then a jump when the resize
completes.

This change updates the WSA position as soon as it recognizes that the
stack changed position due to entering split screen secondary. The WSA
sets its position as the negative of the stack position, making the
calculated window position at (0,0). When a relayout is requested, the
WSA's position is requested back to (0,0), deferring until the new frame.
This will put the WSA position at (0,0) when a frame with the correct size
is drawn. This places the window position at the stack's new position in
the same transaction that a WSA frame with the new size is drawn.

Change-Id: I8c88d7784f827d66926fb5c382af2346028dc48f
Fixes: 74354855
Test: Entering split screen with quick step is smooth
Test: Entering split screen with old launcher still works
2018-04-10 18:11:19 -07:00
Beverly Tai
1bbf283483 Merge "Update dnd settings summary" into pi-dev am: 8ecf40491b
am: 6fb1b0ba25

Change-Id: I0070ca70cc90c3177ea3b45c587f1c78d556537a
2018-04-09 13:18:04 -07:00
Beverly Tai
8ecf40491b Merge "Update dnd settings summary" into pi-dev 2018-04-09 19:54:24 +00:00
Beverly
ebcaeeb792 Update dnd settings summary
- Add null check for ZenModeConfig
- Add ability to include description for indefinite dnd

Test: manual, DndConditionTest, ZenModeSettingsTest
Bug: 76208187
Bug: 77704156
Change-Id: I88de555d2681e613dbcd7694087efef2504b4d51
2018-04-06 14:26:03 -04:00
Selim Cinek
108ebd0c4d Merge "Migrated the Person class to its own file" into pi-dev am: cecec7bf5b
am: b1226660f6

Change-Id: I1066f90cf4a5a415dcf35abd9e27fea02073faf4
2018-04-06 09:37:58 -07:00
Selim Cinek
9acd673c0d Migrated the Person class to its own file
Because we are expecting usage of Person across
other surfaces, we migrate the class out
of he Notification class which is already incredibly
huge.

Test: Migrated existing cts test
Change-Id: Ia487ae7965b5ca2b016245d21faa63e3b4628344
Fixes: 75980526
2018-04-05 17:21:11 -07:00
Jan Althaus
ac272dcc4c Merge "Makes TCS methods non-abstract" into pi-dev am: 37317e1668
am: d5cc6a8289

Change-Id: I954f9bd4c150027fbaec036fa9dc1892c9a0daba
2018-04-05 11:03:54 -07:00
Jan Althaus
37317e1668 Merge "Makes TCS methods non-abstract" into pi-dev 2018-04-05 16:53:17 +00:00
Jan Althaus
39ccc7e388 Makes TCS methods non-abstract
This only affects System API

Bug: 77563695
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Test: bit CtsViewTestCases:android.view.textclassifier.cts.TextClassificationManagerTest
Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest
Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationTest
Test: bit FrameworksCoreTests:android.view.textclassifier.TextSelectionTest
Test: bit FrameworksCoreTests:android.view.textclassifier.TextLinksTestBug:
Change-Id: Ie927ffe3a4678b7a622c139a5431b89e8f22c6e4
2018-04-05 17:26:03 +02:00
Abodunrinwa Toki
15b037367c Merge "Fix TCS crash due to API changes." into pi-dev am: d6997b05e0
am: b3f39bfd55

Change-Id: I3d365ffe5efed4b0d7133fe0e03fd326dbf25b64
2018-04-04 14:41:55 -07:00
Abodunrinwa Toki
ae82e7ad28 Fix TCS crash due to API changes.
- Brings by old deleted APIs and hides them
- Except parceling and hidden APIs that won't have been called anyway
- Option holds a reference to the Request object so we don't have to
  rebuild it

Bug: 77523413
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Test: bit CtsViewTestCases:android.view.textclassifier.cts.TextClassificationManagerTest
Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest
Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationTest
Test: bit FrameworksCoreTests:android.view.textclassifier.TextSelectionTest
Test: bit FrameworksCoreTests:android.view.textclassifier.TextLinksTest
Change-Id: I4277c48a950c3334439649373885ed7fe54f898e
2018-04-04 14:10:51 +02:00
Abodunrinwa Toki
dd5bc6f127 Merge "Merge "TextClassifier API updates." into pi-dev am: bf9dfb16be" into pi-dev-plus-aosp
am: 008a5d01af

Change-Id: I4efb43ab74ac98244c6f4145855a75480e2c85b0
2018-04-02 22:20:45 +00:00
TreeHugger Robot
bf9dfb16be Merge "TextClassifier API updates." into pi-dev 2018-04-02 09:08:52 +00:00
Abodunrinwa Toki
080c8542b6 TextClassifier API updates.
1. Wraps TC queries in Request objects
2. Adds create/destroyTextClassificationSession system APIs
3. Adds the session Ids to system API calls
4. Change setSignature() to setId() on result objects
5. Plumbing to make the API updates work as things currently work
6. Hide Linkify.addLinksAsync APIs

Bug: 74461129

Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Test: bit CtsViewTestCases:android.view.textclassifier.cts.TextClassificationManagerTest
Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest
Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationTest
Test: bit FrameworksCoreTests:android.view.textclassifier.TextSelectionTest
Test: bit FrameworksCoreTests:android.view.textclassifier.TextLinksTest

Change-Id: I933ada8b37ef9893331a265e3b4fc08e043f1029
2018-04-01 20:04:47 +01:00
Beverly
6bcab1a32a Merge "Don't exit dnd rule for old alarms" into pi-dev am: df3788dcd8
am: 77bd7d6657

Change-Id: I579d382e1eb17c6da750d2e26da0cbce7f1dc368
2018-03-30 18:17:00 +00:00
TreeHugger Robot
df3788dcd8 Merge "Don't exit dnd rule for old alarms" into pi-dev 2018-03-30 13:16:46 +00:00
Felipe Leme
c5f19bc0fd Merge "Minor javadoc fixes." into pi-dev am: 46e83ebf27
am: 74a95763db

Change-Id: I6b973b04046b6ad35a9bba35f69c82d6ef9c6951
2018-03-30 02:00:34 +00:00
Felipe Leme
12aef85270 Merge "Fixed annotation typo." into pi-dev am: 74896e21a7
am: e4c2d3c5ce

Change-Id: Ib098e9eb01551c303ccb9c4ddc3c2ab70c769010
2018-03-29 23:58:48 +00:00
TreeHugger Robot
46e83ebf27 Merge "Minor javadoc fixes." into pi-dev 2018-03-29 23:11:32 +00:00
Beverly
369dd4257c Don't exit dnd rule for old alarms
Bug: 77209521
Test: atest ScheduleCalendarTest
Change-Id: I394a6a74872f76f90b75238593197bb6c50531ef
2018-03-29 18:14:04 -04:00
TreeHugger Robot
74896e21a7 Merge "Fixed annotation typo." into pi-dev 2018-03-29 21:43:14 +00:00
Felipe Leme
8ce43a5e70 Minor javadoc fixes.
Test: echo 'In TH we trust!'
Bug: 74830976

Change-Id: Ib88fc0b0275e87ea31d22759507b4c29c7849c05
2018-03-29 13:02:09 -07:00
Felipe Leme
ea53501e72 Merge "Improved documentation of AutofillFieldClassificationService.onGetScores()" into pi-dev am: 7516514148
am: 523388559a

Change-Id: Iaeb0422f305956efa1843eaa18b0429ecbadc320
2018-03-29 19:42:09 +00:00