Commit Graph

1069 Commits

Author SHA1 Message Date
Felipe Leme
a5083c40d5 CharSequenceTransformation should not change anything when comparision fails.
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.CharSequenceTransformationTest#testMismatch
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 64482785

Change-Id: Ia6036e0a1c6f5f084e6b13c7bdd3a9e24be7ac1a
2017-08-09 15:30:06 -07:00
TreeHugger Robot
9d836b6312 Merge "Rate limit notifyColorsChanged()" into oc-mr1-dev 2017-08-09 20:07:48 +00:00
TreeHugger Robot
be3e4a6285 Merge "Minor Autofill changes after API council review." into oc-mr1-dev 2017-08-07 23:35:56 +00:00
Jeff Sharkey
67f9d5070a Fix broken javadocs.
Bug: 64337634
Test: make -j32 doc-comment-check-docs
Change-Id: I20fdd3dcddef09111d35946c41c596c7689effa6
2017-08-06 07:37:08 -06:00
Lucas Dupin
65b47650c8 Rate limit notifyColorsChanged()
Throttle onComputeColors to make sure that a wallpaper
won't affect general system health easily.

Test: runtest --path frameworks/base/services/tests/servicestests/src/com/android/server/wallpaper/WallpaperServiceTests.java
Fixes: 63585249
Change-Id: Ib4317c0b4d284d4cd4a640c24ec71b272b8493d0
2017-08-04 11:42:38 -07:00
Lucas Dupin
22b418448b Merge "Multi-user and WallpaperColors" into oc-mr1-dev 2017-08-03 16:23:41 +00:00
Lucas Dupin
50ba991655 Multi-user and WallpaperColors
Test: set different wallpapers for different users and switch between them.
Test: re-ran cts tests at cts/tests/app/src/android/app/cts/WallpaperManagerTest.java
Change-Id: Ic06d1dc6db26869a2948590863ca9b8ac81c630e
Fixes: 63513694
2017-08-02 18:34:00 -07:00
Tarandeep Singh
9c4115a562 Merge "Fix keyboard focus in VR" into oc-dr1-dev
am: 986995d481

Change-Id: I693c1256583dc1081c6402668401c6aab2337d16
2017-08-02 22:59:51 +00:00
Tarandeep Singh
986995d481 Merge "Fix keyboard focus in VR" into oc-dr1-dev 2017-08-02 20:33:02 +00:00
Tarandeep Singh
e1cfcf4c4d Fix keyboard focus in VR
Consider this VirtualDisplay (VD) scenario:
HostActivity creates a VD which holds SettingsActivity. When EditText
on SettingsActivity is tapped, it gains focus.
On eventual taps, it loses focus i.e. the Window in VD loses focus and
the host activity in primary display gets the focus instead. This
happens because WM's TaskTapPointerEventListener.onPointerEvent()
is called on the default display only.

Root cause:
1. Tap detector isn't registered for non-default display.
2. Tap detector has no info on which displayId touch was received.
3. InputFlinger doesn't deliver InputMonitor events for
non-default displays (fixed in a separate CL)

Fixing above results in onPointerEvent(MotionEvent) to deliver the
Touch events successfully to VD. We restrict these changes to physical
multi-displays and VR VirtualDisplays (which uses virtual touch device).
[VrManagerService calls WMInternal.setVr2dDisplayId(int)]

In future, displayId should be part of InputEvent. Bug: 64258305

Bug: 62033391
Test: bit FrameworksServicesTests:com.android.server.wm.DisplayContentTests
Change-Id: I3626f4de5aa9bcf905da9abd39f3ab1baefc4c48
2017-08-02 10:46:22 -07:00
Felipe Leme
c7cea5b79e Minor Autofill changes after API council review.
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 64262815
Fixes: 64262816
Fixes: 64263294

Change-Id: I18fa6f24c13233a54a5dae9061c07bcdadfaf4a7
2017-08-02 10:30:29 -07:00
Felipe Leme
d25050e2a4 Merge "Clarifies how the autofill service should check for signature hashes." into oc-dev am: c8f0fd7076
am: 32d4e30778

Change-Id: I8de50b81273e89298a6276d8b17100c90361380e
2017-08-02 16:09:13 +00:00
Felipe Leme
32d4e30778 Merge "Clarifies how the autofill service should check for signature hashes." into oc-dev
am: c8f0fd7076

Change-Id: Ida9652bb511ea0aa180e649992a9e5fa6409b2be
2017-08-02 16:00:41 +00:00
Felipe Leme
c8f0fd7076 Merge "Clarifies how the autofill service should check for signature hashes." into oc-dev 2017-08-02 15:52:05 +00:00
Felipe Leme
27eb322ed2 Merge "Cherry-picked some Autofill Javadoc improvements from master." into oc-dev
am: 6829a1dace

Change-Id: I41dec3cb31e6b523927717950f827f45dadabd8b
2017-08-02 00:26:37 +00:00
Felipe Leme
2fb64c0b28 Clarifies how the autofill service should check for signature hashes.
Test: m update-api

Bug: 64125551
Fixes: 63991811

Change-Id: I1ba66787ef91c0fc5fab20b5e9e9fd47aee46412
2017-08-01 12:51:58 -07:00
Felipe Leme
33681a94cf Cherry-picked some Autofill Javadoc improvements from master.
Test: m update-api

Bug: 64125551
Bug: 63669555
Bug: 63985284

Merged-in: Iba4817f682670e9fd6d891ae221e1fa415252e99
Change-Id: I82cbb54a522b2cf1dfb11aacc9735c932aa9af90
2017-07-31 10:18:03 -07:00
Felipe Leme
c0c6ab4ac1 Minor Autofill javadoc fix.
Test: no, thanks!

Bug: 64125551

Change-Id: Iba4817f682670e9fd6d891ae221e1fa415252e99
2017-07-31 10:12:08 -07:00
Felipe Leme
cb96f39155 Uses ParceledListSlice to allow larger number of datasets.
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.LoginActivityTest#testAutofillLargeNumberOfDatasets
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 63669555

Change-Id: If0847da3bafa1bfd80ee8925e17aace82010aec9
2017-07-27 09:44:11 -07:00
Felipe Leme
e802d18f49 Merge "Don't show Save UI when values filled by user belong to a dataset." into oc-mr1-dev 2017-07-27 15:11:22 +00:00
Felipe Leme
d0b18d665f Don't show Save UI when values filled by user belong to a dataset.
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 63068654

Change-Id: Ia9c42d57b0e7c316bfd3c0ee29816db18ac478c1
2017-07-26 15:59:38 -07:00
Julia Reynolds
7635ab0a1b Differentiate dnd countdowns/countdowns to an alarm
Test: runtest systemui, manual
Change-Id: I63b6c6b4128c7c3551efc64f54ce3e55ab2de54d
Fixes: 36569568
2017-07-26 16:07:12 -04:00
Julia Reynolds
04964fe069 Merge "Fix xml loading for managed services" into oc-mr1-dev 2017-07-21 19:52:50 +00:00
Albert Chaulk
95a3528866 Merge "Add modified API to send more information to VrCore" into oc-dr1-dev
am: c48e304bbf

Change-Id: I1c93664e2300cb9e234cfbc1c453da30a60e61af
2017-07-21 18:33:53 +00:00
Julia Reynolds
d1bf5f0108 Fix xml loading for managed services
Noticed while adding a shell cmd to toggle notification assistants,
which is also included

Bug: 62263757
Test: runtest systemui-notification
Change-Id: I9bc0ee857abb8b9f60ab18ad740ca0a3b7d754ff
(cherry picked from commit 88facd4d9a)
2017-07-21 13:07:48 -04:00
Lucas Dupin
98eabbd68a Unhide invalidateColors API
Live wallpapers should be able to report their colors
to have better integration with O-DR visual framework.

Test: make
Bug: 62490115
Change-Id: Id4a61245087a0c6530f56e474ce258ca9528becc
Fixes: 63585249
2017-07-20 21:39:15 +00:00
Albert Chaulk
16d2397e2d Add modified API to send more information to VrCore
Currently, null is sent when a 2D intent is running.
Sending the component name and a flag instead allows
VrCore to determine which intent is currently running
and which layers on the display correspond to this
application.

The process ID of the current intent is also sent,
to allow association of buffers to the VR app.

Bug: 63709047, 63115025
Test: manual with prints

Change-Id: I164b577f2c578867fb953d92074ef3d2d31221a1
2017-07-20 16:44:47 -04:00
Felipe Leme
22101ca5a9 Don't show a custom description if any transformation fail.
That could result in an inconsistent, confusing UI. For example, if the
successfully description for a credit card was "Exp. date: 04/20", one with a
failure could be "Exp. date: /20" - it's better to not show a custom description
in these cases.

Test: CtsAutoFillServiceTestCases pass
Test: CustomDescriptionTest.failFirstFailAll
Test: CustomDescriptionTest.failSecondFailAll

Bug: 62534917

Change-Id: I6554e3470ead2f84d7ef8715192d863c01ab1190
2017-07-18 17:40:45 -07:00
Felipe Leme
906b853717 Uses Pattern instead of String for new Autofill Save API.
Test: CtsAutoFillServiceTestCases pass
Bug: 62534917

Change-Id: Ic285838465c2aa55e4935cdd8f00c551faa6a972
2017-07-18 17:40:45 -07:00
Felipe Leme
7fc29dd931 Changed SaveInfo so it supports just optional ids.
Test: existing CtsAutoFillServiceTestCases pass
Test: new tests on LoginActivityTest pass
Test: new SaveInfoTest pass

Fixes: 38044993

Change-Id: Iefcf9610b27361585444157616325e9e9a89158f
2017-07-18 17:40:44 -07:00
Julia Reynolds
eb3dca71b5 Send less ranking reconsiderations and updates
- NotificationIntrusivenessExtractor does not need to reconsider
ranking for non intrusive notifications
- All adjustments (by group helper and the assistant) have been moved to
extractors so we can selectively send ranking updates instead of always
sending them.

Fixes: 62827235
Test: runtest systemui-notification
Change-Id: I2ea746c3883049abac0752788a3f4c2fa50c8064
2017-07-17 16:55:24 +00:00
TreeHugger Robot
d16aeddbd1 Merge "Make CustomDescription safe against crashes" 2017-07-12 22:29:10 +00:00
TreeHugger Robot
72c323964c Merge "Verify regex for SimpleRegexVerifier" 2017-07-12 22:24:18 +00:00
Philip P. Moltmann
3858aa6736 Make CustomDescription safe against crashes
... And allow users of the public APIs use Transformations.

Test: bit CtsAutoFillServiceTestCases:.CustomDescriptionTest
Bug: 62534917
Change-Id: I6b7b7d5e343e78f2f0381303451e08bb16c5c3e6
2017-07-12 09:38:08 -07:00
Philip P. Moltmann
f28764d900 Verify regex for SimpleRegexVerifier
Test: cts-tradefed run cts-dev -m CtsAutoFillServiceTestCases
          --test=android.autofillservice.cts.SimpleRegexValidatorTest
Bug: 62534917
Change-Id: I63a887643bff0f8d584069ee47f091b0edb8684c
2017-07-12 08:38:41 -07:00
Philip P. Moltmann
0e3e6f8274 Handle failures in validators
Test: cts-tradefed run cts-dev -m CtsAutoFillServiceTestCases
          --test=android.autofillservice.cts.ValidatorTest
Bug: 62534917

Change-Id: I3aad06cd2e8b6caf7238e420727aca0cb3703bc5
2017-07-12 08:05:01 -07:00
TreeHugger Robot
071072f33e Merge "Implement Luhn checksum algo" 2017-07-12 01:06:55 +00:00
Philip P. Moltmann
4e5ce39039 Implement Luhn checksum algo
Ignore all non-digits. If only digits should be allowed, the
developer can use a combination of SimpleRegexValidator and
RequiredValidators.

Bug: 62534917
Test: cts-tradefed run cts-dev -m CtsAutoFillServiceTestCases
          --test=android.autofillservice.cts.LuhnChecksumValidatorTest

Change-Id: I4a7c68a236c3d4cb967f1bc61115df89e584a86d
2017-07-11 09:19:31 -07:00
Philip P. Moltmann
2a9a771c65 Stabilize order of options in ImageTransformation
If two options match a the one added first is picked instead of a random
one.

Test: cts-tradefed run cts-dev -m CtsAutoFillServiceTestCases
           --test=android.autofillservice.cts.ImageTransformationTest

Change-Id: I17d6b93d406fe6aa70646dd0432091aab0ce55c0
2017-07-11 08:07:27 -07:00
TreeHugger Robot
99f0e0ef1e Merge "Verify regex on ImageTransformation" 2017-07-11 01:40:09 +00:00
Philip P. Moltmann
de78fabb74 Verify regex on ImageTransformation
Also change the constructor of the Builder of this class

Bug: 62534917
Test: cts-tradefed run cts-dev -m CtsAutoFillServiceTestCases
Change-Id: Ie54f3a1d4b3a0ecd25945d3deafb4858423f926e
2017-07-10 16:54:52 -07:00
Philip P. Moltmann
ebbe2d4899 Verify regex on CharSequenceTransformation
... Also
- change the constructor of the Builder of this class
- Do not crash if the subsitutions for the regexes are invalid

Change-Id: I965d5830f4932eb40ec22d7fa308815955920a99
Bug: 62534917
Test: cts-tradefed run cts-dev -m CtsAutoFillServiceTestCases
2017-07-10 15:15:48 -07:00
TreeHugger Robot
de295549d1 Merge "Hide some systemapi methods" 2017-07-10 17:59:36 +00:00
Julia Reynolds
7ca33079fd Hide some systemapi methods
Test: make
Change-Id: I0234ca06f68f0a25e1923e171cb6ef19d848aecd
Fixes: 62342239
Fixes: 62264035
2017-07-05 09:17:49 -04:00
Andrew Scull
0e5d5b1c8c PDBS: add package check for getMaximumDataBlockSize()
This method is only useful to the package that writes data to the block
so this applies the same security check as the write() method.

getDataBlockSize()'s security check was only relaxed to use a permission
as it is used by other system apps to determine whether the block
contains data and hence is in use (see ag/593371).

Fix: 62348164
Test: add a Google account to the device causing gmscore to call the
method
Change-Id: I7e71ea236899bf2e4df7cb26ae285b414e9e6565
2017-06-30 15:37:03 +01:00
TreeHugger Robot
ee39d54a8d Merge "Initial implementation of the new Save APIs." 2017-06-29 02:43:36 +00:00
Felipe Leme
979013d027 Initial implementation of the new Save APIs.
Test: manual verification with sample app (CTS tests coming later)

Bug: 62534917

Change-Id: I085a9c933bb5e8316d673976e059e13abd7098e5
2017-06-28 15:13:21 -07:00
Jeff Davidson
7b69a86b02 Add EuiccManager#retainSubscriptionsOnFactoryReset API.
By default, all subscriptions are wiped on first boot after a factory
reset. This ensures that if data is wiped outside of userspace (e.g.
in fastboot/recovery), the profiles are wiped, as there's no way to
offer this option to users in those modes - the radio isn't available
for us to access the eUICC.

This API provides a way to bypass this wipe if the user opts to retain
the policies for a wipe done from userspace (e.g. by unchecking the
"Wipe eUICC" checkbox in platform settings before wiping). We tell the
LPA to note this and skip the wipe on the ensuing factory reset.

Change-Id: I2fe472417497e28b043841a5aa2dc9efa45ebbff
Test: TreeHugger
Fixes: 62681577
2017-06-27 09:23:07 -07:00
TreeHugger Robot
776220d029 Merge "Pass calling package to resolution UI." into oc-dr1-dev 2017-06-27 00:48:39 +00:00
Felipe Leme
91d763f1b5 Improved documentation for AutofillService package:
am: 2ef19c1d73

Change-Id: I67d6649d4acb84ebb598c1ebceb3c3ed58cfd0c0
2017-06-23 00:36:35 +00:00