Commit Graph

1184 Commits

Author SHA1 Message Date
TreeHugger Robot
0e4308a36c Merge "Add log dumps for taskbar" 2022-01-21 15:05:32 +00:00
Wei Sheng Shih
e399817f9d Merge "Shift Recents task to top when opening Recents." 2022-01-21 10:11:57 +00:00
Wei Sheng Shih
d84239bd7a Merge "Let TransitionHandler to clear the transition-leash" 2022-01-21 09:34:02 +00:00
Schneider Victor-tulias
8ef85375cd Add log dumps for taskbar
Test: created bugreport and checked logs
Bug: -
Change-Id: I45f28aa27dfccab016ebbd96b5dc189af5444b09
2022-01-20 10:43:28 -08:00
Nicolò Mazzucato
e0e9d4ef49 Merge "Reformat unfold lib with ktfmt" 2022-01-20 13:18:30 +00:00
wilsonshih
028954b0b1 Let TransitionHandler to clear the transition-leash
Send the remove transition-leash transaction back to the transition
handler, so it can be applied with finishTransaction together, in
case the task surface suddenly disappears due to no parents.

Bug: 213867585
Bug: 214352241
Test: atest WMShellFlickerTests:QuickSwitchBetweenTwoAppsForwardTest
Test: atest WMShellFlickerTests:MovePipDownShelfHeightChangeTest
Change-Id: I5fca942c92d7175dc2f08c3f14f4da464405709c
2022-01-20 14:55:19 +08:00
wilsonshih
798075a566 Shift Recents task to top when opening Recents.
Unlike usual opening/closing app transition, the Recents task should
above Home task when opening recents, otherwise the home task would
above the recents task so it will seems like the home been add into
recents animation.

Bug: 207297486
Test: enable shell transition, setup 3rd-party launcher as default
home. Entering recents at home page and verify the home task won't
stay on top.

Change-Id: I9bac97cb79febf112ec9ac1bdbe3de205604b01d
2022-01-20 06:54:06 +00:00
Merissa Tan
f689c8dfef Merge "Create new DesktopNavbarButtonsViewController class." 2022-01-19 19:22:49 +00:00
Jerry Chang
1b7cf5a207 Merge "Consolidate recent animation in split screen with shell-transition" 2022-01-19 01:45:56 +00:00
Merissa Tan
2d6fce65c2 Create new DesktopNavbarButtonsViewController class.
This CL creates a new DesktopNavbarButtonsViewController class to allow
for taskbar buttons and status icons customization on desktop
environment.

Recall: http://recall/clips/1f3b88e2-9f4e-4291-a9fe-a17641d1fd0c

Bug: 213964564
Bug: 196757951
Test: Switch between different system navigation modes and verify the
desktop taskbar buttons/status icons stay on screen, and are functional.

Change-Id: I05846b61689213ded88b8f49460aced88e49fd65
2022-01-18 17:06:48 -08:00
Nicolo' Mazzucato
ff4060f5a5 Reformat unfold lib with ktfmt
This runs ktfmt on all unfold shared lib files. In this way there is always only one valid and consistent way to format our files.

+ Some documentation comment spacing refactored to look nicer.

Bug: 193798864
Test: m
Change-Id: I031a6e8c580ff763f9d2f4ee364807f1d405ba6d
2022-01-18 17:55:46 +01:00
Michael Groover
e10c4c21ac Merge "Add unaudited exported flag to exposed runtime receivers" 2022-01-17 17:53:29 +00:00
Jerry Chang
3c1ea525ed Consolidate recent animation in split screen with shell-transition
Make sure to delegate recent transition to launcher after split screen
activated.

Bug: 206487881
Test: manual check swipe split-pair to overview panel and swipe to home
      behavior
Change-Id: I1177b1efdd7a45e8f9ec162b2155dbea1660e1af
2022-01-17 03:13:31 +00:00
Michael Groover
de14599c42 Add unaudited exported flag to exposed runtime receivers
Android T allows apps to declare a runtime receiver as not exported
by invoking registerReceiver with a new RECEIVER_NOT_EXPORTED flag;
receivers registered with this flag will only receive broadcasts from
the platform and the app itself. However to ensure developers can
properly protect their receivers, all apps targeting T or later
registering a receiver for non-system broadcasts must specify either
the exported or not exported flag when invoking #registerReceiver;
if one of these flags is not provided, the platform will throw a
SecurityException. This commit updates all the exposed receivers
with a new RECEIVER_EXPORTED_UNAUDITED flag to maintain the existing
behavior of exporting the receiver while also flagging the receiver
for audit before the T release.

Bug: 161145287
Test: Build
Change-Id: I5faa64ae0d2b22b62390bf13cb2b87fd6926e0c7
2022-01-15 00:26:43 +00:00
Nicolò Mazzucato
5355b68962 Merge "Add Jank test for unfold transition" 2022-01-14 10:59:12 +00:00
Nicolò Mazzucato
15b6908100 Merge "Enhance dagger usage in UnfoldSharedModule" 2022-01-14 09:28:52 +00:00
TreeHugger Robot
2bb62ccaaa Merge "Removing SurfaceControlCompat" 2022-01-14 07:04:53 +00:00
TreeHugger Robot
24f7505d0b Merge "[Media TTT] Add DeviceInfo to the service callback." 2022-01-13 22:42:32 +00:00
TreeHugger Robot
71abd1233b Merge "[Media TTT] Add the aidl interface for the sender and a service that implements it." 2022-01-13 21:37:03 +00:00
Vadim Tryshev
28623e0269 Merge "Removing 2-button support from tests" 2022-01-13 17:59:57 +00:00
Nicolo' Mazzucato
6fb25a6665 Enhance dagger usage in UnfoldSharedModule
UnfoldTransitionProgressProvider is used in sysui and in other places that don't use dagger (e.g. Launcher).
However, we want to use dagger for all unfold transition related classes.
The solution in this cl is to create FoldSharedComponent. If an app that doesn't use dagger need UnfoldTransitionProgressProvider (or other shared classes), it can create the component with the factory, and get those object (now created by dagger, previously manually created).
If the app uses dagger, UnfoldSharedModule should be used instead.

The external interface is not changed in this cl: createUnfoldTransitionProgressProvider is left as it was before, therefore launcher doesn't require any change and continues to work as before.

Test: atest com.android.systemui.unfold
Test: Manually tested
Bug: 213908821
Change-Id: I22885ec15fed99254405e26ed2fe99a9567625b6
2022-01-13 18:10:01 +01:00
Caitlin Cassidy
0a93932437 [Media TTT] Add DeviceInfo to the service callback.
Bug: 203800643
Bug: 203800347
Test: manual (verify chip contains right name)
Test: media.taptotransfer tests
Change-Id: Iab3f8a7d793d0c824fad9041c52b5a7fe862d236
2022-01-13 15:59:32 +00:00
Caitlin Cassidy
38aa601aa2 [Media TTT] Add the aidl interface for the sender and a service that
implements it.

More callbacks will be added in future CLs.

Bug: 203800643
Bug: 203800347
Test: manual (verify `adb shell cmd statusbar media-ttt-chip-add-sender
Tablet MoveCloserToTransfer` still triggers chip)
Test: media.taptotransfer tests

Change-Id: Ic44b770e8c98f7c9a06a0846fd166e4c8d51ea7d
2022-01-13 15:49:59 +00:00
TreeHugger Robot
70125e4740 Merge "Remove CounterRotator surface in finishTransaction" 2022-01-13 06:25:24 +00:00
vadimt
ce0a16788e Removing 2-button support from tests
Bug: 187761685
Test: presubmit
Change-Id: Ia7ff4cca0ad5d28bbd0a86cf0a18792d2817583d
2022-01-12 10:34:25 -08:00
Lucas Dupin
6bfab8f7e7 Merge "Always destroy RegionSamplingHelper on same thread" 2022-01-12 16:29:15 +00:00
Nicolo' Mazzucato
caf468dce4 Add Jank test for unfold transition
A new TransitionProgressListener is added to start and stop the jank monitor during the transition. This is a no-op if the jank monitor is disabled.

The reason why it is added in StatusBarWindowController is that InteractionJankMonitor needs an attached to begin, and the status bar should always be present during the animation.

Bug: 213862831
Test: Running test suite in forrest with config in g3
Change-Id: I99dcd4e879b9c2c47611096b29b164881e8714c7
2022-01-12 16:40:00 +01:00
Chris Li
c00c3d93d8 Remove CounterRotator surface in finishTransaction
Before, the surface will be removed, and the children will be reparented
to root in a separate transaction when animation is done. That would
cause a flicker because the reparented children may be above the
rotation activity.

Bug: 206094140
Test: manually test expanding PIP
Change-Id: I0f16b7590d4bd0f4c377158d555cb94f28f134cd
2022-01-12 22:09:41 +08:00
Lucas Dupin
dafd01de26 Always destroy RegionSamplingHelper on same thread
stopAndDestroy() was being called from the main thread, while
registration was happening on the background. This would lead to
concurrency bugs because this class is not thread safe.

Test: atest RegionSamplingHelperTest
Fixes: 201962411
Change-Id: I01290f5931972ad3eb322e7dddc44e002324e405
2022-01-11 15:56:21 -08:00
Alex Chau
9a42318fcd Merge "Ensure SensorManager is destroyed on Launcher activity destruction" 2022-01-11 10:42:32 +00:00
Sunny Goyal
5e513c2109 Removing SurfaceControlCompat
Bug: 213421974
Test: Presubmit
Change-Id: I0193346bf5f17a3103279a6d40fa5b3a2fc89e02
2022-01-10 14:41:09 +00:00
Alex Chau
1a3c645186 Ensure SensorManager is destroyed on Launcher activity destruction
- Add back necessary destroy call chain

Fix: 210114103
Test: labtest
Change-Id: I96bf525fe3730e7bf6b4c1042c18ef96622248fd
2022-01-07 17:26:46 +00:00
Nicolo' Mazzucato
2e4d663ee0 Create FoldStateLoggingProvider
The aim of this class it to output fold state changes with the time between them.
Those will be logged in a follow up change to uptimize fold/unfold experience.

+ Changed files have been reformatted according to ktfmt. Those are minimal changes.
+ Making some return type explicit in dagger modules

Bug: 198305865
Test: atest FoldStateLoggingProviderTest
Change-Id: I3dcfa742f2cf3c712796b5c6f5481f319b680a12
2022-01-07 14:47:37 +01:00
TreeHugger Robot
5223943b0e Merge "Replace aborted with half_open in FoldStateProvider" 2022-01-06 18:27:27 +00:00
Nicolo' Mazzucato
b680365e1f Replace aborted with half_open in FoldStateProvider
All FOLD_UPDATE_ABORTED emissions were due to device stuck in half opened state.

This will allow us to log FULL_OPEN, HALF_OPEN and FULL_CLOSED states easily.

+ Removed some unused states.
+ DeviceFoldStateProviderTest.kt formatted with ktfmt

Bug: 198305865
Test: atest DeviceFoldStateProviderTest
Change-Id: Iadbe4bdc4cbdf2720efb46fbd69cfadf0b8357a8
2022-01-06 16:55:10 +01:00
TreeHugger Robot
5a6ec22676 Merge "Quick fix for NullPointerException 211713013" into sc-v2-dev am: b7f37cd797 am: 19516a0496
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/16569980

Change-Id: I4842f7c2e4e74a29f6b1868838dfb6d9d3b49158
2022-01-06 00:31:28 +00:00
TreeHugger Robot
19516a0496 Merge "Quick fix for NullPointerException 211713013" into sc-v2-dev am: b7f37cd797
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/16569980

Change-Id: I6c8bce01aa621ad8c09c5c2f1bed93e8de3c3b17
2022-01-06 00:27:03 +00:00
Sebastian Franco
76f9cda458 Quick fix for NullPointerException 211713013
Test: Manually tested
Fix: 211713013
Change-Id: Ie701bee61a69d88cc9fce12c9d001a52f30578c4
2022-01-05 19:54:40 +00:00
Nicolo' Mazzucato
f2b97883aa Trace fold/unfold animation with atrace
This cl adds an always present listener to UnfoldTransitionProgressProvider to log a trace when the animation is running, and it's progresses with a counter.

Bug: 203391751
Test: Traced with perfetto on top of this change and verified it is present as expected
Change-Id: I04062587b47a6238d969dc196ce06bb712ed0840
2022-01-04 18:10:17 +01:00
Jerry Chang
8959d0b139 Fix back to split pair from overview with shell-transition hang.
Prevent it throws index out of bounds exception when entering split pair
from overview panel. And make sure to update split screen state properly
when enter split transition got merged to other transition.

Fix: 210852531
Bug: 206487881
Test: Trigger split screen, swipe up to overview, verified it won't hang
      when select split pair from overview panel.
Change-Id: Ifc5c224b7185224b811e6e2e7fa5d798c99bc6b1
2021-12-22 04:58:37 +00:00
Vinit Nayak
255e26e865 Merge "Add API to get multiple running tasks for split" into sc-v2-dev am: 3a91691eb6 am: 4dde648761
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/16482617

Change-Id: I49acf0d87915ba02dfa3c2f2c4f17cc86161f89d
2021-12-16 00:54:45 +00:00
Vinit Nayak
4dde648761 Merge "Add API to get multiple running tasks for split" into sc-v2-dev am: 3a91691eb6
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/16482617

Change-Id: I368b4025726bda6b2315dd2a4d6205311eef4189
2021-12-16 00:36:17 +00:00
Vinit Nayak
e4dd959073 Add API to get multiple running tasks for split
Bug: 205675364
Change-Id: Ia350e443b6b80ca8af2d546cb35cad23b212d86e
2021-12-15 13:14:47 -08:00
Shuming Hao
e68f21997e Merge "Implement toggle notification panel for new buttons in taskbar" 2021-12-15 16:49:19 +00:00
TreeHugger Robot
9975e2c412 Merge "Add ACTION_SWITCH_DISPLAY_UNFOLD to LatencyTracker" 2021-12-15 14:34:40 +00:00
Tracy Zhou
741c3d7b7b Add haptic feedback to rotation button am: eab69869a0
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/16465449

Change-Id: Ic386ca454ddbeb2c53146c923aca10a20f8ce4db
2021-12-15 06:15:24 +00:00
Tracy Zhou
eab69869a0 Add haptic feedback to rotation button
Fixes: 205503732
Test: tap rotation button in vibration only mode
Change-Id: I8fe29afc03353943b56fea9e80618441f7bca174
(cherry picked from commit 8f30dd7aea)
2021-12-15 03:40:22 +00:00
Tracy Zhou
6cb7638137 Merge "Add haptic feedback to rotation button" 2021-12-15 03:39:55 +00:00
Nicolo' Mazzucato
ea41bd1c52 Add ACTION_SWITCH_DISPLAY_UNFOLD to LatencyTracker
Thanks to this, we will be able to create a dashboard of the time needed to turn on the screen after unfolding the device.

Test: atest DeviceFoldStateProviderTest
Test: atest KeyguardViewMediatorTest
Test: atest UnfoldLatencyTrackerTest
Bug: 209963184
Change-Id: I078be6431e1053bd9658b5756ab2d54f6f28c630
2021-12-14 21:57:48 +01:00
Tracy Zhou
8f30dd7aea Add haptic feedback to rotation button
Fixes: 205503732
Test: tap rotation button in vibration only mode
Change-Id: I8fe29afc03353943b56fea9e80618441f7bca174
2021-12-14 14:38:52 +08:00