Commit Graph

910 Commits

Author SHA1 Message Date
Treehugger Robot
c2b9af3ac8 Merge "Create owner test files for subpackages" am: 9e8cfbac2c am: 05bc30f21c am: a39bb54fdd am: 9e5539c793
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1952387

Change-Id: Idee1d783a52db16a7fb7aeadb11b69564e72aca5
2022-01-21 16:14:52 +00:00
Treehugger Robot
9e5539c793 Merge "Create owner test files for subpackages" am: 9e8cfbac2c am: 05bc30f21c am: a39bb54fdd
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1952387

Change-Id: I94c28df75a0af1ea24dcc388fee84c093268ffd0
2022-01-21 15:56:50 +00:00
Treehugger Robot
a39bb54fdd Merge "Create owner test files for subpackages" am: 9e8cfbac2c am: 05bc30f21c
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1952387

Change-Id: I5a4f26de3f474fe5794d94ca1f581b317ac1bb37
2022-01-21 15:46:05 +00:00
Vadim Caen
e0b59d46ce Merge changes Ifc2ed99b,Ibd7fc78e
* changes:
  Integration of back gesture animation on Sysui (BackNav 2/n)
  Server infrastructure for back nav animation (BackNav 1/n)
2022-01-21 13:36:58 +00:00
Vadim Caen
737bd6d0be Integration of back gesture animation on Sysui (BackNav 2/n)
This CL contains the BackAnimationController, on WMShell, which
controls the gesture based animation.

When the gesture is done, the animation is done. It will be handed over
to a TransisionHandler (in the next CL)

Test: atest WMShellUnitTests:BackAnimationControllerTest
Bug: 131727607
Change-Id: Ifc2ed99bfd51079f12a83468ca44e4aa19460e47
2022-01-20 12:38:04 +01:00
Nataniel Borges
4e4babec1a Create owner test files for subpackages
Now failures can be automatically directed to the correct buganizer components and forwarded directly to the correct assignees, instead of being all created into the Winscope for further triage

Test: check owners file
Change-Id: I6876a702b4f46443328aab027f7fee994b2bb819
2022-01-20 10:21:40 +00:00
Jerry Chang
1b7cf5a207 Merge "Consolidate recent animation in split screen with shell-transition" 2022-01-19 01:45:56 +00:00
Nataniel Borges
77a4620a02 Update enter pip focus change test
Previously focus didn't change when entering PIP. On the latest versions it should transition to launcher.

Bug: 198124027
Test: atest WMShellFlickerTests
Change-Id: I323a455f23e912afd9eb6e43b365a289c5159331
2022-01-17 16:24:07 +01:00
Chris Li
c812398169 Merge "Enable flicker test group3 with Shell transition" 2022-01-17 09:08:35 +00:00
Chris Li
7ade3e1ca4 Merge "Enable flicker test group2 with Shell transition" 2022-01-17 05:33:28 +00:00
Jerry Chang
3c1ea525ed Consolidate recent animation in split screen with shell-transition
Make sure to delegate recent transition to launcher after split screen
activated.

Bug: 206487881
Test: manual check swipe split-pair to overview panel and swipe to home
      behavior
Change-Id: I1177b1efdd7a45e8f9ec162b2155dbea1660e1af
2022-01-17 03:13:31 +00:00
Chris Li
70873fd601 Enable flicker test group3 with Shell transition
Bug: 214452854
Test: pass existing
Change-Id: Ia1a10ebaef3a058526be943194e15bf5b5a50ca6
2022-01-14 14:14:11 +00:00
Chris Li
47d7776959 Enable flicker test group2 with Shell transition
Bug: 214452854
Test: pass existing
Change-Id: I85f62b56433562abdbc34c103cddbceff1ac5341
2022-01-14 01:00:29 +00:00
Mariia Sandrikova
a274e1a7d4 DO NOT MERGE Revert "[2/n] Camera Compat UI: Add interfaces for client-server..." am: 7617679a61
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/16571392

Change-Id: I0adf2bf45c5f7d7349e9c0f180aea9d10f70645d
2022-01-13 22:55:51 +00:00
Mariia Sandrikova
7617679a61 DO NOT MERGE Revert "[2/n] Camera Compat UI: Add interfaces for client-server..."
Revert submission 16468379

Reason for revert: Feature development is moving to T.

Reverted Changes:
Id9b9a8930:[3/n] Camera Compat UI: Add a camera compat contro...
Id6be4a954:Enable a camera app compat control on Large screen...
I083aa6718:[2/n] Camera Compat UI: Add interfaces for client-...

Bug: 206602997

Change-Id: I9ad876043fd61f708a8f468fffd1ef371bfa0866
2022-01-13 15:21:38 +00:00
Aurimas Liutikas
aec26c4f68 DO NOT MERGE Revert "[3/n] Camera Compat UI: Add a camera compat control."
Revert submission 16468379

Reason for revert: Feature development is moving to T.

Reverted Changes:
Id9b9a8930:[3/n] Camera Compat UI: Add a camera compat contro...
Id6be4a954:Enable a camera app compat control on Large screen...
I083aa6718:[2/n] Camera Compat UI: Add interfaces for client-...

Bug: 206602997

Change-Id: I318b89b87cd3b05a3f3dcd428e3d80fe81465011
2022-01-13 15:16:51 +00:00
Jason Chang
fbb89d8c65 Merge changes from topic "new-ohm-bg-panel"
* changes:
  (2/n) Implement BackgroundWindowManager to manage tutorial background
  (1/n) Phase out FEATURE_ONE_HANDED_BACKGROUND_PANEL
2022-01-12 15:33:21 +00:00
Jason Chang
6d4fc4ca09 (2/n) Implement BackgroundWindowManager to manage tutorial background
Using WindowlessWindowManager for adding a surface wihtout depend on
Window Hierarchy, we just add leash with specific theme color at
bottom z-order while One-handed trigger, and remove it when exited.

Bug: 197165590

Test: manually test One-handed mode basic operations.
Test: atest WMShellUnitTests
Change-Id: Ie53684edd4511719516c00dd64c2dfad360a593b
2022-01-12 11:44:19 +08:00
Jason Chang
f25e1e90c2 (1/n) Phase out FEATURE_ONE_HANDED_BACKGROUND_PANEL
Remove DisplayArea feature FEATURE_ONE_HANDED_BACKGROUND_PANEL
We are going implement One handed panel throught
WindowlessWindow mechanism instead.

Bug: 197165590

Test: manually test One-handed mode basic operations.
Test: atest WMShellUnitTests
Change-Id: I3ba106a266e69bf61cdd43c0043852eed14dc365
2022-01-11 23:57:53 +08:00
Chris Li
b258c0fd58 Merge "Fix ExitPipWithDismissButtonTest with Shell transition" 2022-01-11 02:30:08 +00:00
Chris Li
9131c6a128 Merge "Fix WallpaperWindowToken visible update with Shell transition" 2022-01-11 02:29:29 +00:00
Chris Li
2490b439d0 Fix ExitPipWithDismissButtonTest with Shell transition
Fix: 210965692
Test: atest WMShellFlickerTests:ExitPipWithDismissButtonTest
Change-Id: I828095f55e7400b661513b853372a3bef5466663
2022-01-09 22:59:36 +08:00
Chris Li
c8a3d88def Fix WallpaperWindowToken visible update with Shell transition
With Shell transition, when mVisibleRequested is changed, it will wait
until the transition finish to update the isVisible(). As a result, if
there is a visible change before the previous transition is finished,
it will be skipped.

For example, when we first open a fullscreen app and then immediately
enter pip:
1. TRANSIT_OPEN will call to hide wallpaper and set mVisibleRequest to
false, but not commit visible until transition animation is finished.
2. TRANSIT_PIP will call to show wallpaper, but if it is started before
the OPEN transition is finsihed, it will not update the wallpaper
mVisibleRequested, which will leave the wallpaper hidden.

Fix: 210965575
Bug: 210965692
Test: atest WMShellFlickerTests:ExpandPipOnDoubleClickTest
Change-Id: I2578aafd024a3c9a6ec96079d4dc6cb740c890d2
2022-01-09 19:35:16 +08:00
Nataniel Borges
dd1d5b61b1 Set cutout mode to shortEdges on flicker
Use short edges on the flicker tests so that the test apps cover the full screen in both raven and in flame devices. With default cutout, some assertions will need to be updated to consider the letterbox layers, as well as app windows not covering the entire display

Bug: 209935473
Test: atest FlickerTests WMShellFlickerTests
Change-Id: Iaeabe2033adc2890605bbef7bce139569f402c4b
2022-01-07 16:22:46 +01:00
Chris Li
6ecdc3894b Merge "Fix SetRequestedOrientationWhilePinnedTest with Shell transition" 2022-01-07 02:06:10 +00:00
Chris Li
85e4cc2e6e Fix SetRequestedOrientationWhilePinnedTest with Shell transition
Fix: 210965919
Test: atest WMShellFlickerTests:SetRequestedOrientationWhilePinnedTest
Change-Id: Ib59300e1d3af8fbcc02a5a85964a1d2ffdaaaf4f
2022-01-06 19:53:06 +08:00
Bill Lin
40fa9bf6fb 2/ Instrument jank of One-handed mode trigger and exit transition
Add 2 CUJs for one handed mode transition
1. ONE_HANDED_ENTER_TRANSITION
2. ONE_HANDED_EXIT_TRANSITION

- [STATE_ENTERING] Detect swipe down gesture: Begin of enter CUJ
- [STATE_ENTERING] Tap shortcut to trigger: Begin of enter CUJ
- [STATE_ACTIVE] Transition end of enter: End of enter CUJ
- [STATE_EXITING] Detect swipe up gesture: Begin of exit CUJ
- [STATE_EXITING] Tap shortcut to exit: Begin of exit CUJ
- [STATE_NONE] Transition end of exit: End of exit CUJ

Test: see trace in comment
Bug: 201032904
Change-Id: I29258a1bbbe567c935d467621a85fbdfe2397d54
2022-01-05 13:31:02 +08:00
Bill Lin
a40be42069 Merge "Refresh display bounds when display layout updated" 2022-01-05 00:09:29 +00:00
Nataniel Borges
57d1c8b1aa Merge "Update tests to reflect region based assertion changes" 2022-01-04 09:25:31 +00:00
Bill Lin
630f3af989 Refresh display bounds when display layout updated
Previoulsy mDefaultDisplayBounds & mLastVisualDisplayBounds are
incorrect after device reboot without re-register DisplayAreaOrganizer.
Then the bounds does not set correctly for transition.
When AnimationController#getAnimator() get incorrect display bounds,
either surface bounds or rounded corner does not crop correctly.

Test: manual enable OHM, reboot device and trigger
     (Bounds/Rounded corner should works when trigger)
Test: atest WMShellUnitTests
Bug: 212651010
Change-Id: Ib30edf6ecc2244f7fec7e233b0fb048d5ee40f3c
2021-12-30 16:47:36 +08:00
Chris Li
67f1f5abe6 Merge "Set PIP corner radius after rotation" 2021-12-26 07:59:37 +00:00
Chris Li
76e0ddc048 Set PIP corner radius after rotation
When there is screen rotation, we need to set the corner radius and
window crop in both start and finish transaction to avoid janky
animation.

Fix: 210965679
Test: atest WMShellFlickerTests:PipRotationTest
Change-Id: I03d1c3c4e39ea55dd4cc3f43b1170cfd6fe88cfa
2021-12-24 12:15:26 +08:00
Pablo Gamito
793153795a Update tests to reflect region based assertion changes
Bug: 204894659
Test: atest FlickerTests WMShellFlickerTests FlickerLibTest
Change-Id: Ib82953da0f52953046cf2d5f717c9dc11f221a93
2021-12-23 18:48:07 +01:00
Nataniel Borges
43eb55e5d1 Merge "Add support to newer devices on flicker tests" 2021-12-23 13:49:44 +00:00
Nataniel Borges
b876fb200d Add support to newer devices on flicker tests
Some of the assertions used in flicker worked in older devices but not on newer ones.

Disable these assertions and make flicker tests compatible with notch to run on newer devices

Bug: 206753786
Test: atest FlickerTests WMShellFlickerTests
Change-Id: Idf889506d767c4743938ee6727cd228b29873e66
2021-12-22 12:04:44 +01:00
Chris Li
52e1f36763 Merge "Set PIP corner radius when enter" 2021-12-20 12:37:08 +00:00
Tony Huang
36b5dd8b5f Handle split rotation in rotation callback
By current split design, we always update bounds and apply WCT on
DA info changed callback. However, with shell transition, we should
avoid apply WCT while transition running.

Add display rotation callback we used in legacy split to new split
and apply bounds on such callback. This can ensure that WCT sync to
running rotation transition.

Bug: 206872147
Test: manual
Test: pass existing tests
Change-Id: I358a00ab6ecfb56ececcc93204a78366c48cabda
2021-12-20 17:33:45 +08:00
Chris Li
862c4118d4 Set PIP corner radius when enter
Before, it didn't set the corner radius on the finish transition, so the
corner radius is set to 0 when finished.

Bug: 210965679
Test: atest WMShellFlickerTests:PipRotationTest
Change-Id: I7a3c478ef36a4bb730f2153d6b2487a41a469545
2021-12-20 15:13:45 +08:00
Mariia Sandrikova
d77c92a3f1 Merge changes from topic "camera-compat" into sc-v2-dev am: 3486eacda3 am: 02a17e7b1f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/16468379

Change-Id: Ic9916a3883eef0148a86c86149aa2e883fc56d1b
2021-12-18 22:19:12 +00:00
Mariia Sandrikova
02a17e7b1f Merge changes from topic "camera-compat" into sc-v2-dev am: 3486eacda3
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/16468379

Change-Id: I1e56abcef9715a3dd6a00d70cb815c4d9260175a
2021-12-18 21:59:31 +00:00
Mariia Sandrikova
3486eacda3 Merge changes from topic "camera-compat" into sc-v2-dev
* changes:
  [3/n] Camera Compat UI: Add a camera compat control.
  [2/n] Camera Compat UI: Add interfaces for client-server communication.
2021-12-18 21:39:13 +00:00
Mariia Sandrikova
13e80fd997 [3/n] Camera Compat UI: Add a camera compat control.
Test: atest WMShellUnitTests
Bug: 206602997
Change-Id: Id9b9a89303387c4ac797fc1382967151a13d38ef
2021-12-17 00:20:19 +00:00
Mariia Sandrikova
24f4d8a952 [2/n] Camera Compat UI: Add interfaces for client-server communication.
Changes:
- Listens to changes from the client coming through IActivityClientController#requestCompatCameraControl to ActivityRecord#updateCameraCompatState
- ActivityRecord#updateCameraCompatState sends updated state via TaskInfo to WM Shell
- ITaskOrganizerController#updateCameraCompatControlState to dispatch the user interactions with the control from WM Shell triggers callback to ActivityRecord#updateCameraCompatStateFromUser
- ActivityRecord#updateCameraCompatStateFromUser remembers the user's choice and asks client to apply treatment through ICompatCameraControlCallback

Feature is guarded with config_isCameraCompatControlForStretchedIssuesEnabled

Test: atest WMShellUnitTests:ShellTaskOrganizerTests, atest WmTests:ActivityRecordTests
Bug: 206602997
Change-Id: I083aa6718bd67456bedd9444e9b78740c041f870
2021-12-17 00:18:57 +00:00
Jerry Chang
fdf92de82a Merge "Integrate RecetsTaskController with shell-transition" 2021-12-16 09:01:25 +00:00
Mady Mellor
b6d0f141fd Merge "Fix a potential NPE" into sc-v2-dev am: 4b3ea38f9b am: 6f120287c9
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/16470586

Change-Id: I27362b4a9b9698f2e1d4ba87ce941050b3e43dd9
2021-12-15 18:21:55 +00:00
Mady Mellor
6f120287c9 Merge "Fix a potential NPE" into sc-v2-dev am: 4b3ea38f9b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/16470586

Change-Id: Iac4afaa1caaf0969346e2c2ada0445a7dbc74be7
2021-12-15 18:21:15 +00:00
Mady Mellor
4b3ea38f9b Merge "Fix a potential NPE" into sc-v2-dev 2021-12-15 18:09:31 +00:00
Jerry Chang
7eccf61dcd Integrate RecetsTaskController with shell-transition
Hook up RecentsTaskController with split screen when enabled
shell-transition. Bundle exit reason and dismiss transition together in
order to log and determine whether the dismiss should break recorded
app-pair in recents or not.

When dismissing split screen with shell-transition, it'll reparent child
tasks out of split screen before they committed invisible, so rely on
fullscreen task opening signal to update app-pair information instead
of relying on visible task appeared or changed in
FullscreenTaskListener.

Bug: 206487881
Test: atest SplitTransitionTests
Test: dump and observe recorded split pair in RecentsTaskController
Change-Id: I109d7b3b2eab2b4f691e85a2afd052f56b1a9bca
2021-12-15 03:39:23 +00:00
Jerry Chang
1b560d8747 Integrate launch-to-side split transition to shell transition
Integrate launch-to-side split transition to shell transition.
Because there is no guarantee for launching activity to split
successfully before actually launching it, trigger enter split
transition after observed new task launching into split.

Bug: 206487881
Test: atest SplitTransitionTests
Test: drag to enter split with shell transition works
Change-Id: Idda7c3b02689753cea1a1fe80264145f1a449f73
2021-12-15 00:52:43 +00:00
Mady Mellor
447e4f16e2 Fix a potential NPE
I've never been able to reproduce this and the stack traces I have
of it don't match existing code, but looking at the code paths I think
this could still happen, there are a couple of places where the
mMagnetizedBubbleDraggingOut gets nulled out (e.g. on child removed)
I've tried to repro by:
 - canceling the bubbles in the middle of dragging to dismiss
 - trying to snap the bubble back and then drag it again to dismiss
   (snap back also nulls it)

I see a recent stack of it in pitot so I think it's worth adding the
null check.

Test: atest ExpandedAnimationControllerTest
Bug: 201866808
Change-Id: Ib9425a2b63410c95fddaaea59761dfd18557ed54
2021-12-14 15:21:41 -08:00