Commit Graph

13611 Commits

Author SHA1 Message Date
Matt Pietal
c3e572fc74 Merge "Sharesheet - Fix logic for a-z count" into rvc-dev 2020-06-10 20:10:15 +00:00
TreeHugger Robot
62a1b9d17e Merge "Conversations UX polish pass" into rvc-dev 2020-06-10 19:48:56 +00:00
TreeHugger Robot
dc9a555126 Merge "Sharesheet - Disable expansion" into rvc-dev 2020-06-10 19:07:05 +00:00
Steve Elliott
282498aaa5 Conversations UX polish pass
- adjust position of expanded group avatar to remain vertically
    centered with title

  - adjust top padding of guts to match that of conversation layout

  - vertically align app name and time in the conversation header

  - clean up some of our XML styles

Fixes: 157757386
Test: manual, visual
Change-Id: I5eb774b44ce641a97c5deb706711f3b252e6554e
2020-06-10 14:02:09 -04:00
Matt Pietal
185f715e77 Sharesheet - Disable expansion
Leave disabled until more apps are using sharing shortcuts

Fixes: 157065816
Test: atest ChooserActivityTest
Change-Id: I7f8811617fe2f3a77f86b8459c7f06b0929a40c9
2020-06-10 11:40:55 -04:00
Matt Pietal
1245b38b60 Sharesheet - Fix logic for a-z count
Prior logic only counted the number of grouped items. This could
result in the a-z list not being shown even though there were
additional targets. For instance, if 1 group had 9 targets, a-z
would've been hidden even though only 4 targets were present in the
ranked app row, resulting in 5 targets being inaccessible.

Fixes: 158017940
Test: atest ChooserActivityTest#fourOptionsStackedIntoOneTarget
Change-Id: I58e262e40f3064ce8a091e44d6b00163c8f4e4f3
2020-06-10 11:16:55 -04:00
TreeHugger Robot
f6793af032 Merge "Tweak Sharesheet DS icon rendering to ignore system shapes" into rvc-dev 2020-06-10 13:04:23 +00:00
Matt Pietal
a4614b0f1f Merge "Sharesheet - Disable delegate" into rvc-dev 2020-06-10 12:06:23 +00:00
Mike Digman
4141daa946 Tweak Sharesheet DS icon rendering to ignore system shapes
Directly renders AdaptiveIconDrawables to avoid normal masking
by the user applied icon shape. Shifts insetting to DS circle
masking to avoid clipping issues.

Test: manual
Fixes: 158318613
Change-Id: I2abc6f866500f2d8045af46278e9bac6a53458fc
2020-06-09 14:42:21 -07:00
Matt Pietal
9a178365c4 Sharesheet - Disable delegate
The original plan was to move sharesheet into systemui. The first
step was to route through a delegate living in systemui, which 
would just launch the activity. However, the full migration has not
occurred. And more notably, there are intermittent race conditions
caused by token expiration. This comes from the framework activity token
being removed just before the target intent is launched, due to the
requirement to call finish() on resolver/chooser when complete.

Fixes: 157272342
Test: atest ChooserActivityTest ResolverActivityTest
Change-Id: I75ca19589ba78abc1d1a05a917457c151420c949
2020-06-09 21:33:46 +00:00
Steve Elliott
666124b0c5 Adjust conversation layout paddings to match UX spec
Fixes: 157757386
Fixes: 157144647
Test: manual, visual
Change-Id: Ibeccc0fe2269aea69b882895fbb1a280cd6bf126
2020-06-09 15:59:58 -04:00
TreeHugger Robot
80d5c61da5 Merge "Add importance ring animation on convo priority change" into rvc-dev 2020-06-09 15:33:55 +00:00
TreeHugger Robot
b121512580 Merge "Report WINDOW_FOCUS_GAIN_REPORT_ONLY when the served connection remains" into rvc-dev 2020-06-09 13:41:30 +00:00
Ming-Shin Lu
6ecbf08772 Report WINDOW_FOCUS_GAIN_REPORT_ONLY when the served connection remains
When we tried CL[1] to fix Gboard Translation UI dialog dismissed that
keeping the served view when focused to the next window,
although we can skip starting new input when the window focused back as
the behavior of Q,

However, we overlooked in R, IME insets will rely on IMS#reportStartInput
to get the updated IME input target, which will out of sync for the above
case.

To fix this regression, we report the next window focus gain
to IMMS with WINDOW_FOCUS_GAIN_REPORT_ONLY when the next focused view is
same as current served view and the served input connection remains.

so that in IMMS side won't get StartInputFlags.INITIAL_CONNECTION flags
to set restarting as false when calling IInputMethod#startInput to IMS,
and in IMS side will still call reportStartInput to WMS for updating
IME input target without additional onFinishInputView callback to
client.

[1]: I8d4fff94ba9313b773bc27fcbd019cc88580d3e9

Fix: 152373385
Bug: 155781821
Test: atest CtsInputMethodTestCases
Test: manual, make sure Bug 155781821 comment #10 works:
    1) Launch video call in Hangouts.
    2) End call.
    3) Click on the text box.
    4) Expect Soft-Keyboard shown
Test: make sure not break Bug 148489857 and Bug 148788569, following
auto / manual test to verify:
 - Auto: atest FocusHandlingTest#testKeyboardStateAfterImeFocusableFlagChanged
 - Manual:
    1) Build / install EditTextVariations
    2) Select menu -> Direct-Reply, make sure Notification comes up.
    3) Tap EditText on Notification, verify soft-keyboard is visible.

Change-Id: I45a9814d812ad906f417c24200fd4219959e2423
2020-06-09 13:48:15 +08:00
Steve Elliott
8b4929dbbf Add importance ring animation on convo priority change
Bug: 157480039
Test: manual
Change-Id: I0c3b2a857c871fc344705f98aa8463e7de0c4b6b
2020-06-08 22:41:29 -04:00
Joanne Chung
9856804eb2 Merge "Handle SyncResultReceiver.TimeoutException" into rvc-dev 2020-06-09 00:21:44 +00:00
Daniel Sandler
bb2d9a52c1 Merge "Show the nearby chip for images and files too." into rvc-dev 2020-06-08 20:11:04 +00:00
Joanne Chung
c6adc68368 Handle SyncResultReceiver.TimeoutException
1.Change SyncResultReceiver.TimeoutException to checked exception
2.Handle the SyncResultReceiver.TimeoutException in AutofillManager,
ContentCaptureManager, ContentSuggestionsManager
3.Fix the bug we should throw e.rethrowFromSystemServer()

Bug: 156044027
Test: atest CtsAutoFillServiceTestCases
Test: atest ContentSuggestionsManagerTest
Test: atest CtsContentCaptureServiceTestCases
Change-Id: I959d2aca2b80866c076fae2520de66c123f5367d
2020-06-08 14:53:45 +08:00
Steve Elliott
05e10b59af Merge "Fix missing icon for one-to-one convos" into rvc-dev 2020-06-06 15:12:04 +00:00
Svetoslav Ganov
0ce4fba38f Merge "Correctly offset app op history on reboot" into rvc-dev 2020-06-06 14:50:03 +00:00
Jing Ji
d29532e699 Merge "Use the UID as the package name in procstat assoc proto dump" into rvc-dev 2020-06-05 23:16:36 +00:00
Mike Digman
5aa8394608 Merge "Make Sharesheet group and pin menu match material, redlines" into rvc-dev 2020-06-05 19:19:41 +00:00
Miranda Kephart
3a51a85aaf Merge "Only show error if screenshot process dies within timeout period" into rvc-dev 2020-06-05 18:55:08 +00:00
Mike Digman
ad2e9a0a57 Make Sharesheet group and pin menu match material, redlines
Requires wholesale creation of dialog layout. Using a fixed
width approach.

Test: manual
Bug: 152978014
Fixes: 158023059
Change-Id: Ifcff21b2f999839c3eba601a2ee96a08677e1267
2020-06-05 10:18:43 -07:00
Svet Ganov
185ddf644b Correctly offset app op history on reboot
The offset was computed based off the offset represented by
the most recent historical file while we have to use the time
this file was written.

Also now we persist the history on reboot and shutdown,
significantly minimizing the possibility of data loss.

Added test API to emulate reboot of the history to allow for
precise and tightly controlled test to prevent flakes due to
boot time deviations.

Test: atest android.app.appops.cts.HistoricalAppopsTest#testRebootHistory

Fixes:156853195

Change-Id: I4142371f8bc2b1d710cc8c300e7e79cb03764c04
2020-06-05 09:55:27 -07:00
Dan Sandler
b18b59fd58 Show the nearby chip for images and files too.
This revealed that we weren't initializing the nearby intent
from the original intent, so that's fixed too. This should
ensure that flags and extras from the original intent make
their way to the available and installed nearby component.

Test: Share (an image and a non-image) from DocumentsUI
Fixes: 155487375
Fixes: 155676993
Change-Id: If0c0b754a066b0ec439a866de3eae84caca7b793
2020-06-05 12:45:14 -04:00
TreeHugger Robot
6d410d8165 Merge "Cleanup outdated TODOs" into rvc-dev 2020-06-05 15:53:50 +00:00
arangelov
a2a821336f Cleanup outdated TODOs
Fixes: 158292009
Test: compiled
Change-Id: I7889c7ee818c154194bbe66eabbe04aa7ddb65a4
2020-06-05 15:27:43 +01:00
PETER LIANG
c9f8b52b26 Merge "Shouldn't turn on other accessibility features in SuW." into rvc-dev 2020-06-05 12:36:06 +00:00
TreeHugger Robot
8f27cd8e55 Merge "Add test for tapping Work share tab when work profile is off" into rvc-dev 2020-06-05 12:23:43 +00:00
Antoan Angelov
16fce9c63b Merge "Setup button bar padding before empty state handling" into rvc-dev 2020-06-05 10:04:52 +00:00
Felipe Leme
df98b27008 Merge "Added command / binder method to temporarily disable VoiceInteraction." into rvc-dev 2020-06-05 07:11:40 +00:00
felipeal
755578ac28 Added command / binder method to temporarily disable VoiceInteraction.
It will be used by Automotive when the display is off.

Test: adb shell cmd voiceinteraction disable true && \
      adb shell cmd voiceinteraction show
Test: atest CtsVoiceInteractionTestCases CtsAssistTestCases
Bug: 154011437

Change-Id: Ia87b0544b242c356c4f9180e250e2df54279803f
2020-06-04 23:05:14 +00:00
Jing Ji
1cd1f607e9 Use the UID as the package name in procstat assoc proto dump
And try to compress the process name if possible

Bug: 155980964
Test: Manual
Change-Id: I689724e7c271ba8d85608c3f484250e13c1a1c92
2020-06-04 15:44:26 -07:00
TreeHugger Robot
d1fee56540 Merge "Show 2nd row if we have 1 row in active profile and empty state in other" into rvc-dev 2020-06-04 21:37:39 +00:00
Miranda Kephart
700a093b0c Only show error if screenshot process dies within timeout period
Currently, we show a "Couldn't take screenshot" error any time the
screenshot process disconnects. However, if the screenshot process
remains up, this can result in strange superfluous notifications,
where hours later the screenshot process gets frozen/killed due to
memory pressure, and we show the notification despite the user not
trying to take a screenshot at that point.

This change adds a check so that we only show the error notification
if the screenshot process is disconnected within the timeout period
(10 seconds).

Bug: 156064134
Fix: 156064134
Test: manual -- killed the process with 'adb shell ps | grep screenshot'
and then 'adb shell kill <pid>' to verify that the error notification
appeared, then made sure it did not appear post-change.

Change-Id: I2419634ad888300abc8b50aadab5888ce653e363
2020-06-04 16:48:49 -04:00
arangelov
f32a43868b Add test for tapping Work share tab when work profile is off
Also fix some work tab-related tests.

Fixes: 158166545
Fixes: 148156663
Test: atest ChooserActivityTest
Test: atest ResolverActivityTest
Change-Id: I5850bbc7d72d563f6e58dd19fafc56c0703ce669
2020-06-04 19:09:35 +01:00
arangelov
5d9ca17ddc Setup button bar padding before empty state handling
Otherwise we don't add the padding if we show the empty state
on the current profile. This caused a slight height jump when
swiping to the other profile.

Fixes: 158174328
Test: manual
Test: atest ChooserActivityTest
Test: atest ResolverActivityTest
Change-Id: I08c3f30716a8fb9a15e30088be6d274dc0869cac
2020-06-04 18:18:59 +01:00
TreeHugger Robot
2c99d90744 Merge "Refocus conversation expand button in TalkBack" into rvc-dev 2020-06-04 16:33:45 +00:00
Steve Elliott
3d360da16d Fix missing icon for one-to-one convos
Fixes: 158089612
Test: manual
Change-Id: If588073ff1df557b755b844277e893e001822d79
2020-06-04 11:11:11 -04:00
arangelov
416a1b347c Show 2nd row if we have 1 row in active profile and empty state in other
Fixes: 157982025
Test: manual
Test: atest ChooserActivityTest
Test: atest ResolverActivityTest
Change-Id: Ifa525bad5d89d2ea6192044c6e2bb63310c57693
2020-06-04 14:36:00 +01:00
Peter_Liang
1eedde0d0f Shouldn't turn on other accessibility features in SuW.
Root Cause:
During the SuW, user could turn on other accessibility features except for Magnification, Select to Speak, and Talkback through edit shortcut menu list.

Solution:
Hide the edit shortcuts button if in the SuW period to avoid to turn on others.

Bug: 158046037
Test: manual test
Change-Id: I06e5fde2320c0736ecaf9feb912349c5965cb491
2020-06-04 18:10:28 +08:00
Jeff DeCew
4055c0861f Refocus conversation expand button in TalkBack
Test: manual
Fix: 156872754
Change-Id: I43e83c307adff4ce591a2650899b9356adf30e01
2020-06-03 19:47:15 -04:00
Zak Cohen
4cfb590a28 Screenshot - pass bitmap as bundled hardware buffer from Launcher
When passing a screenshot from Launcher to Sysui it should be passed
as a hardware buffer inside a bundle to avoid copying the underlying pixels.

Change also adds userid and component when a screenshot is passed.

Bug: 157380566
Bug: 156757117
Test: local
Change-Id: I531f1d1a41d179a257fe7202b68a6d1a78cc0f79
2020-06-03 16:09:57 -07:00
TreeHugger Robot
c235831ae5 Merge "Set calling user as intent extra to indicate intent resolver edge case" into rvc-dev 2020-06-03 19:33:26 +00:00
TreeHugger Robot
31a2e1ba46 Merge "Also call Intent#fixUris for the intent resolver case" into rvc-dev 2020-06-03 19:16:31 +00:00
Will Brockman
c66aeed213 Merge "Add RankingSelected to UiEventLogger." into rvc-dev 2020-06-03 17:55:47 +00:00
arangelov
738034ba6c Set calling user as intent extra to indicate intent resolver edge case
Instead of relying on the user hint in the intent, we now explicitly
set the calling user as an intent extra.

Fixes: 149741820
Test: atest ChooserActivityTest
Test: atest ResolverActivityTest
Test: manual
Change-Id: Iaa37fc1330abbb419035d899fad166afc53aaea8
2020-06-03 18:46:28 +01:00
arangelov
7c510c2227 Also call Intent#fixUris for the intent resolver case
Fixes: 158082179
Test: manual
Test: atest ChooserActivityTest
Test: atest ResolverActivityTest
Change-Id: I74c97f5d2f3bbbcd35df20151a455877562f34ad
2020-06-03 18:24:40 +01:00
arangelov
d85a74a473 Only allow scroll in one direction at a time
Fixes: 156605289
Test: manual
Test: atest ChooserActivityTest
Test: atest ResolverActivityTest
Change-Id: Ibf301f7aa4440e4483355829d0e24fc8e53350e7
2020-06-03 13:19:36 +01:00