Commit Graph

20905 Commits

Author SHA1 Message Date
Chris Tate
eb518cb4b2 Merge "Fix FGS enter/exit statslog semantics" into sc-dev am: d3a0befee4 am: 587acbbc2f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14823656

Change-Id: Ie3a0ec1e1fbfe09c45fe6770e81dd98083590283
2021-06-04 10:43:07 +00:00
Chris Tate
587acbbc2f Merge "Fix FGS enter/exit statslog semantics" into sc-dev am: d3a0befee4
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14823656

Change-Id: I0690cb6e354fa1a6dc8a58286bc717ef6ad77b6b
2021-06-03 22:31:10 +00:00
Chris Tate
d3a0befee4 Merge "Fix FGS enter/exit statslog semantics" into sc-dev 2021-06-03 22:19:23 +00:00
Jeff DeCew
e2f4c3aa14 Merge "Fix background color (again)" into sc-dev am: 7b96af705c am: b92267e793
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14805377

Change-Id: I243b09e973a231b6001a3a33bbb426b907e90a31
2021-06-03 19:41:22 +00:00
Jeff DeCew
b92267e793 Merge "Fix background color (again)" into sc-dev am: 7b96af705c
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14805377

Change-Id: I5397ca0f7d689c9a51af6e5be76ddfbaada7743f
2021-06-03 19:37:06 +00:00
Jeff DeCew
7b96af705c Merge "Fix background color (again)" into sc-dev 2021-06-03 19:32:50 +00:00
Jeff DeCew
eddec2cbc8 Merge "Notification layout fixes:" into sc-dev am: 10de71a380 am: f23b53f86f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14805134

Change-Id: Ida35be785b4045ddc42b869381bbc40f3c3a3d7a
2021-06-03 16:49:09 +00:00
Jeff DeCew
f23b53f86f Merge "Notification layout fixes:" into sc-dev am: 10de71a380
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14805134

Change-Id: Ieef984e702fc3e25514f6ce012b2217ca76c874d
2021-06-03 16:32:03 +00:00
Christopher Tate
29f1852efd Fix FGS enter/exit statslog semantics
Logging wasn't quite right in the case of deferred FGS notification in
various ordering scenarios.

Bug: 189926836
Test: atest CtsStatsdAtomHostTestCases:android.cts.statsdatom.statsd.UidAtomTests#testForegroundServiceState
Change-Id: I650730db9e01faa90a36a73b486464ab5b179fc6
2021-06-03 09:28:07 -07:00
Jeff DeCew
10de71a380 Merge "Notification layout fixes:" into sc-dev 2021-06-03 16:16:25 +00:00
Jeff DeCew
ea4b3a56b4 Fix background color (again)
* originally fixed in ag/14189045
* regressed in ag/14140988

Bug: 185920837
Test: post conversation notifications, and look at badge or face pile background; should match notification background
Change-Id: I8ef77901ed9d43eccf89dcc1f3905f0dbb38851f
2021-06-03 11:18:35 -04:00
Jeff DeCew
604c074dbe Notification layout fixes:
* "Headerless" notifications no longer capped at 88dp.  This allows DecoratedCustomViewStyle content to be sized larger than 48dp, but all that sizing is now controlled by the max heights for the entire notification, which is enforced by the ExpandableNotificationRow, rather than the layout.
* Reduce the max heads up height to 136dp (down by 7dp).  For standard headerless templates, this won't have any effect, because they would never get that tall.  For HUNs with decorated custom content this reduces the custom content area to 96dp without actions (to match RVC) and 56dp with actions (up slightly from 48dp in RVC).
* Fixed a bug where the snooze button would be bound when viewType=NORMAL, which only affected messaging style, and was hiding a layout bug if the snooze setting was enabled.
* Fixed a bug with the action margin on messaging notifications appearing in the collapsed state and causing oversized notifications.

Fixes: 189937886
Test: significant manual testing with notify and notify2, especially with HUNs
Change-Id: I775a0bb29944922581d01f237dbbc5580ced00c4
2021-06-02 20:23:59 -04:00
Svetoslav Ganov
ae1d49549a Merge "Switch media fw permissions checks to AttributionSource" into sc-dev am: 1028eb2f62 am: 94893b35e0
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14664152

Change-Id: I5dfa6199ec032779c732e916d6622427466c3f2f
2021-06-02 23:28:02 +00:00
Svetoslav Ganov
94893b35e0 Merge "Switch media fw permissions checks to AttributionSource" into sc-dev am: 1028eb2f62
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14664152

Change-Id: I1403b08f25c663715fd0a99a40f484a4e7ecf410
2021-06-02 23:19:16 +00:00
Svetoslav Ganov
1028eb2f62 Merge "Switch media fw permissions checks to AttributionSource" into sc-dev 2021-06-02 23:07:22 +00:00
Jon Spivack
a346ee51f2 Merge "Allow AssistDataRequester to fetch AssistContent without AssistStructure" into sc-dev am: dd934371ae am: 8dbc1f9bd6
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14738871

Change-Id: I2a590da835b7c3eb955912c086c5d065d33bfbfc
2021-06-02 18:01:57 +00:00
Jon Spivack
8dbc1f9bd6 Merge "Allow AssistDataRequester to fetch AssistContent without AssistStructure" into sc-dev am: dd934371ae
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14738871

Change-Id: Ia98ecaf808feff0bec2a502e6348d19f60982746
2021-06-02 17:36:45 +00:00
Mady Mellor
eb92c9a265 Merge "Remove doc saying setSuppressNotification requires being in foreground" into sc-dev am: 81cac3a9f1 am: 7f0dc6f537
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14791581

Change-Id: Icbcd8d2de2388b950a01d59feacf0829bc5c7f24
2021-06-02 17:17:22 +00:00
Jon Spivack
dd934371ae Merge "Allow AssistDataRequester to fetch AssistContent without AssistStructure" into sc-dev 2021-06-02 17:08:47 +00:00
Mady Mellor
7f0dc6f537 Merge "Remove doc saying setSuppressNotification requires being in foreground" into sc-dev am: 81cac3a9f1
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14791581

Change-Id: I6a498b1f289aff6fbfe80ecd1aadd30a73a1fb97
2021-06-02 16:52:42 +00:00
Mady Mellor
81cac3a9f1 Merge "Remove doc saying setSuppressNotification requires being in foreground" into sc-dev 2021-06-02 16:18:19 +00:00
Jay Sullivan
a6dd8a1338 Merge "Fix intermittent async noteOps" into sc-dev am: c2650e0440 am: 46b1e92c4f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14602086

Change-Id: I248db730e5927d68a58d8727d28c6ec4e1c5aac9
2021-06-02 01:33:57 +00:00
Jay Sullivan
46b1e92c4f Merge "Fix intermittent async noteOps" into sc-dev am: c2650e0440
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14602086

Change-Id: I111b7ed09ad9a91ac1bb0399f2fc041751612918
2021-06-02 01:10:11 +00:00
Jay Sullivan
c2650e0440 Merge "Fix intermittent async noteOps" into sc-dev 2021-06-02 00:42:31 +00:00
Mady Mellor
fe43118c50 Merge "Re-add checks for mutable intents on bubbles" into sc-dev am: f8218030bb am: c0a3fa5ffe
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14792011

Change-Id: I921d863959ea084198135c7af4def5fdee0803a5
2021-06-01 23:51:44 +00:00
Svet Ganov
2eebf92965 Switch media fw permissions checks to AttributionSource
Attribution source is the abstraction to capture the data
flows for private data across apps. Checking permissions
for an attribution source does this for all apps in the
chain that would receive the data as well as the relevant
app ops are checked/noted/started as needed.

Teach speech recognition service about attribution
chains. If an implementation does nothing the OS
would enforce permisisons and do blame as always.
This apporach leads to double blaming and doesn't
support attribition chains where app calls into
the default recognizer which calls into the on
device recognizer (this nests recursively). If the
implementer takes advantage of the attribution chain
mechanims the permissions for the entire chain are
checked at mic access time and all apps are blamed
only once.

Fixed a few bugs around finishing ops for attribution
chains. Also ensured that any app death in a started
attribution chain would lead to finishing the op for
this app

bug: 158792096

Test: (added tests for speech reco)
      atest CtsMediaTestCases
      atest CtsPermissionTestCases
      atest CtsPermission2TestCases
      atest CtsPermission3TestCases
      atest CtsPermission4TestCases
      atest CtsPermission5TestCases
      atest CtsAppOpsTestCases
      atest CtsAppOps2TestCases

Merged-In: Ic92c7adc14bd2d135ac13b96f17a1b393dd562e4

Change-Id: Ic92c7adc14bd2d135ac13b96f17a1b393dd562e4
2021-06-01 23:43:29 +00:00
Mady Mellor
c0a3fa5ffe Merge "Re-add checks for mutable intents on bubbles" into sc-dev am: f8218030bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14792011

Change-Id: Ibc1f94b5c03fe067befbdcce60832ab7d20ccdf3
2021-06-01 23:27:32 +00:00
Mady Mellor
f8218030bb Merge "Re-add checks for mutable intents on bubbles" into sc-dev 2021-06-01 22:59:54 +00:00
Mady Mellor
72c320aefc Remove doc saying setSuppressNotification requires being in foreground
ag/13330774  removed the requirement & added tests; this updates the
javadoc around it.

Bug: 189175840
Test: treehugger
Change-Id: I5c8fc35607c79a6e70e8245d8662d66d5e884fa1
2021-06-01 14:16:22 -07:00
Mady Mellor
4d9ab47b4b Re-add checks for mutable intents on bubbles
Also adds a note in the javadoc.

Bug: 177252626
Test: atest NotificationManagerServiceTest
Change-Id: I1e55b08d3de7b6be22090cc821794c78c6659620
2021-06-01 14:01:17 -07:00
Jeff DeCew
c293314bd3 Merge "Do not show the custom views of spoofing notitifactions." into sc-dev am: 3c3af99d00 am: 59c0a6b4cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14739250

Change-Id: I970996d424ff90cbab0b4ebe919a6ffa5f3e7bff
2021-06-01 20:40:35 +00:00
TreeHugger Robot
8df95fccd1 Merge "Fix various FGS notification deferral issues" into sc-dev am: 2ee596d203 am: 8358468870
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14736145

Change-Id: I1ec38feba3e9a4fca745b80ff3285ebe7b721abd
2021-06-01 20:05:29 +00:00
Jeff DeCew
59c0a6b4cc Merge "Do not show the custom views of spoofing notitifactions." into sc-dev am: 3c3af99d00
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14739250

Change-Id: I3c90492fe703d499421e776d28b8de0d592242b9
2021-06-01 19:40:29 +00:00
TreeHugger Robot
8358468870 Merge "Fix various FGS notification deferral issues" into sc-dev am: 2ee596d203
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14736145

Change-Id: If439610cf43da7ba0f18d901687a6319b58055c8
2021-06-01 19:34:05 +00:00
Jeff DeCew
3c3af99d00 Merge "Do not show the custom views of spoofing notitifactions." into sc-dev 2021-06-01 18:24:21 +00:00
TreeHugger Robot
2ee596d203 Merge "Fix various FGS notification deferral issues" into sc-dev 2021-06-01 17:32:02 +00:00
Jing Ji
6ad507bb7a Merge "Don't call onNullBinding when the service host is dead" into sc-dev am: e6436d95f8 am: ea4646691e
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14739098

Change-Id: Ic8f9f6e960add3f169c8d148ce92b921154b1b08
2021-05-28 03:16:10 +00:00
Ryan Mitchell
1e7576afd4 Merge changes from topic "inc-dis" into sc-dev am: 488522c9c5 am: a1cb15f54e
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14505818

Change-Id: I7078f4bf90100d9b8161d8a6460aeb6d981c416a
2021-05-28 03:05:19 +00:00
Jing Ji
ea4646691e Merge "Don't call onNullBinding when the service host is dead" into sc-dev am: e6436d95f8
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14739098

Change-Id: I4d9c7464005bdad716df41330bc76ecd7528e113
2021-05-28 03:03:04 +00:00
Bernardo Rufino
46de1f2e1a Merge "Fix background bypass via notifications" into sc-dev am: 365d013e43 am: e52ffd21cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14736230

Change-Id: Ic86cb427745de42f8e4cb85125adc3d8f8deb718
2021-05-28 02:54:04 +00:00
TreeHugger Robot
f5c87c3eda Merge "Create ActivityClientRecord early in preExecute" into sc-dev am: 018e114202 am: fab7d6a152
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14673572

Change-Id: Idcb3bfb581d459040e880d3b9c34edffe8670e9f
2021-05-28 02:53:08 +00:00
Ryan Mitchell
a1cb15f54e Merge changes from topic "inc-dis" into sc-dev am: 488522c9c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14505818

Change-Id: I5ae5007659172d8a247b8613646d72a68a7dd06a
2021-05-28 02:49:33 +00:00
Bernardo Rufino
e52ffd21cc Merge "Fix background bypass via notifications" into sc-dev am: 365d013e43
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14736230

Change-Id: I6872834f125417a2a31ee1d86435ac2c71958791
2021-05-28 02:25:29 +00:00
TreeHugger Robot
fab7d6a152 Merge "Create ActivityClientRecord early in preExecute" into sc-dev am: 018e114202
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14673572

Change-Id: I30b9949c8be0905202a2370fbfa57bad2f07096a
2021-05-28 02:24:32 +00:00
Jing Ji
e6436d95f8 Merge "Don't call onNullBinding when the service host is dead" into sc-dev 2021-05-28 01:35:24 +00:00
Ryan Mitchell
488522c9c5 Merge changes from topic "inc-dis" into sc-dev
* changes:
  Disable incremental hardening on own resources
  StringBlock incremental hardening default values
2021-05-27 21:31:04 +00:00
Christopher Tate
10a3ccad53 Fix various FGS notification deferral issues
A number of scenarios involving both FGS and non-FGS notification
operations were not yet working as intended.  This CL lands the
following behaviors:

* notify() to update the notification content during an FGS's
notification deferral period now respects the new Notification's
deferral policy rather than forcing immediate display.  An app can now
choose whether to force immediate display, or to have the new content be
what eventually appears at the end of the deferral period, by using the
same builder API as controls the deferral policy for startForeground().

* If an app posts a notification via notify() then adopts that
notification with new content (i.e. uses the same notification ID) in a
call to startForeground(), there is now no deferral: the existing
notification is always updated immediately, regardless of the
notification's or the service's configuration viz deferral policy.

* Fixed a latent bug when the app called notify() to update the
notification after startForeground(), then the service was killed for
memory and relaunched.  The notification might have been reposted with
stale content.

* Adjusted the metrics handling to more accurately express "was display
of the notification content for this transition to the FGS mode
deferred?"

Bug: 178406514
Bug: 185771298
Bug: 187860135
Test: atest CtsAppTestCases:android.app.cts.ServiceTest
Test: atest CtsAppTestCases:NotificationManagerTest
Change-Id: Ieb62f7195eb619c1769e3c1bd518cb6a7b6e4b7c
2021-05-27 12:57:11 -07:00
Ryan Mitchell
c0416698db Disable incremental hardening on own resources
When an application is incrementally installed, and a resources
operation fails due to the resources not being fully present,
the app should crash instead of swallowing the error and
returning default values to not alter the experience of
using the application.

Disable IncFsFileMap protections on ApkAssets that are a part of the
application that is running (base and splits).

Bug: 187220960
Test: atest ResourcesHardeningTest
Change-Id: Ibc67aca688720f983c7c656f404593285a54999b
2021-05-27 09:50:36 -07:00
Bernardo Rufino
365d013e43 Merge "Fix background bypass via notifications" into sc-dev 2021-05-27 10:48:45 +00:00
TreeHugger Robot
018e114202 Merge "Create ActivityClientRecord early in preExecute" into sc-dev 2021-05-27 03:50:20 +00:00